1. 09 May, 2019 1 commit
    • Michael Starzinger's avatar
      [wasm] Fix source positions for rethrown exceptions. · 89272565
      Michael Starzinger authored
      This fixes the source position printed in the stack trace for exceptions
      rethrown from within Wasm code. This only affects the message propagated
      to the console, not the trace stored as part of the exception object.
      
      Note that there still is a more fundamental issues with preserving the
      original message of a caught exception and funneling it through to each
      rethrow site, which is still missing. This change just makes sure that
      the interpreter and TurboFan are consistent.
      
      R=clemensh@chromium.org
      TEST=message/fail/wasm-exception-rethrow
      BUG=v8:8091
      
      Change-Id: Iac04149ded3c54f5b23faeb83b1228081bbd3dfa
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598754Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61374}
      89272565
  2. 06 May, 2019 1 commit
  3. 30 Jan, 2019 1 commit
  4. 25 Jan, 2019 1 commit
    • Michael Starzinger's avatar
      [wasm][arm] Fix {Word32Shr} instruction selection. · 8a3c4d9e
      Michael Starzinger authored
      This fixes a corner case with the matching for a {UBFX} instruction.
      According to the ISA reference "UBFX Rd, Rn, #lsb, #width" is only valid
      for "#width" in the [1;32-#lsb] range. Specifically a "#width" of 0 is
      invalid but was not checked against by the instruction selector.
      
      R=ahaas@chromium.org
      TEST=mjsunit/regress/wasm/regress-924905
      BUG=chromium:924905
      
      Change-Id: I470671282b215be62dfd147a619a0d317f7cc746
      Reviewed-on: https://chromium-review.googlesource.com/c/1435939Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59096}
      8a3c4d9e