1. 11 Aug, 2017 1 commit
    • Michael Starzinger's avatar
      [test] Rebaseline inspector test. · f984eb1b
      Michael Starzinger authored
      This changes the baseline of an inspector test setting breakpoints
      within an asm.js module while the module is being executed. With the
      validator it is not supported to switch from active WebAssembly code
      back to debuggable interpreter code. Hence some previously expected
      breakpoints no longer fire, the behavior is consistent across all
      configurations now though.
      
      R=yangguo@chromium.org
      TEST=inspector/debugger/asm-js-breakpoint-during-exec
      BUG=v8:6166
      
      Change-Id: Ie1bb62fa6df28b10336b4cb5d381d2141eec356c
      Reviewed-on: https://chromium-review.googlesource.com/608977Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47301}
      f984eb1b
  2. 28 Oct, 2016 1 commit
    • clemensh's avatar
      Fix detection of BUILTIN functions · 1cac34ed
      clemensh authored
      In the asm.js to wasm pipeline, we generate an entry function with
      BUILTIN code, but still attached to a TYPE_NORMAL script.
      This fix avoids trying to set a breakpoint there, resulting in a crash
      on DCHECK(shared->HasDebugInfo()).
      
      Also add two inspector tests to track regressions.
      
      BUG=v8:5568
      R=titzer@chromium.org,mstarzinger@chromium.org
      
      Review-Url: https://codereview.chromium.org/2457433002
      Cr-Commit-Position: refs/heads/master@{#40633}
      1cac34ed