- 21 Apr, 2015 1 commit
-
-
yangguo authored
R=dusan.milosavljevic@imgtec.com Review URL: https://codereview.chromium.org/1101503003 Cr-Commit-Position: refs/heads/master@{#27967}
-
- 20 Apr, 2015 1 commit
-
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1096763003 Cr-Commit-Position: refs/heads/master@{#27949}
-
- 16 Apr, 2015 1 commit
-
-
yangguo authored
Currently done with two templates, one used from native js, one from runtime. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1087633005 Cr-Commit-Position: refs/heads/master@{#27864}
-
- 09 Apr, 2015 2 commits
-
-
caitpotter88 authored
When ObjectToString is installed on Object.prototype twice (once in v8natives.js, and once in harmony-tostring.js), this pollutes old code spaces on some devices. To prevent this, the function is only installed once, preventing test failures when the --harmony-tostring flag is flipped on by default. BUG=v8:3502 LOG=N R=arv@chromium.org Review URL: https://codereview.chromium.org/1072083002 Cr-Commit-Position: refs/heads/master@{#27720}
-
caitpotter88 authored
BUG=v8:3018 R= LOG=N Review URL: https://codereview.chromium.org/938443002 Cr-Commit-Position: refs/heads/master@{#27714}
-
- 07 Apr, 2015 2 commits
-
-
svenpanne authored
Now every FOR_EACH_INTRINSIC_FOO sub-macro corresponds to a src/runtime/runtime-FOO.cc file, even the order of runtime functions within that file has been preserved in the corresponding macro, thanks to some eye-hurting for/clang/sed/grep madness. ;-) BUG=v8:3947 LOG=n Review URL: https://codereview.chromium.org/1056863002 Cr-Commit-Position: refs/heads/master@{#27609}
-
adamk authored
Previously, the only optimized code path for Maps and Sets was for String keys. This was achieved through an implementation of various complex operations in Hydrogen. This approach was neither scalable nor forward-compatible. This patch adds the necessary intrinsics to implement Maps and Sets almost entirely in JS. The added intrinsics are: %_FixedArrayGet %_FixedArraySet %_TheHole %_JSCollectionGetTable %_StringGetRawHashField With these additions, as well as a few changes to what's exposed as runtime functions, most of the C++ code backing Maps and Sets is gone (including both runtime code in objects.cc and Crankshaft in hydrogen.cc). Review URL: https://codereview.chromium.org/947683002 Cr-Commit-Position: refs/heads/master@{#27605}
-
- 01 Apr, 2015 1 commit
-
-
kozyatinskiy authored
Revert of Correctly compute line numbers in functions from the function constructor. (patchset #5 id:80001 of https://codereview.chromium.org/701093003/) Reason for revert: Locations from New Function are broken in DevTools. Original issue's description: > Correctly compute line numbers in functions from the function constructor. > > R=aandrey@chromium.org > BUG=chromium:109362 > LOG=Y > > Committed: https://code.google.com/p/v8/source/detail?r=25289 TBR=aandrey@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:109362 LOG=Y Review URL: https://codereview.chromium.org/1053563002 Cr-Commit-Position: refs/heads/master@{#27564}
-
- 31 Mar, 2015 1 commit
-
-
svenpanne authored
Currently this only sets branch hints, so we get unlikely code "out of the way", but in the long run the register allocator needs some love to treat the unlikely code as, well, unlikely. :-) Review URL: https://codereview.chromium.org/1048063002 Cr-Commit-Position: refs/heads/master@{#27540}
-
- 30 Mar, 2015 1 commit
-
-
svenpanne authored
No compiler support for now (BTW: %_NewString, doesn't have that, either), inline allocation will come later. Hopefully the last intrisic to add for a StringAddStub POC... Review URL: https://codereview.chromium.org/1041723002 Cr-Commit-Position: refs/heads/master@{#27508}
-
- 27 Mar, 2015 1 commit
-
-
svenpanne authored
Review URL: https://codereview.chromium.org/1031383002 Cr-Commit-Position: refs/heads/master@{#27497}
-
- 26 Mar, 2015 3 commits
-
-
yangguo authored
Revert of Revert of Debugger: deduplicate shared function info when setting script break points. (patchset #1 id:1 of https://codereview.chromium.org/999273003/) Reason for revert: Reland since the failure has been fixed in https://codereview.chromium.org/1035523005/ Original issue's description: > Revert of Debugger: deduplicate shared function info when setting script break points. (patchset #4 id:60001 of https://codereview.chromium.org/998253005/) > > Reason for revert: > Code caching failures. > > Original issue's description: > > Debugger: deduplicate shared function info when setting script break points. > > > > Also fix Debug.showBreakPoints for multiple break points at the same location. > > > > BUG=v8:3960 > > LOG=N > > > > Committed: https://crrev.com/73b17a71a22564c0b66d9aa7c00948c748f5b290 > > Cr-Commit-Position: refs/heads/master@{#27444} > > TBR=mstarzinger@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3960 > > Committed: https://crrev.com/9b29d008dfcc00bf56be8040add1d2c5e404673b > Cr-Commit-Position: refs/heads/master@{#27448} TBR=mstarzinger@chromium.org BUG=v8:3960 LOG=N Review URL: https://codereview.chromium.org/1037013002 Cr-Commit-Position: refs/heads/master@{#27472}
-
svenpanne authored
LOG=n Review URL: https://codereview.chromium.org/1013753016 Cr-Commit-Position: refs/heads/master@{#27465}
-
yangguo authored
R=ulan@chromium.org Review URL: https://codereview.chromium.org/1005053004 Cr-Commit-Position: refs/heads/master@{#27464}
-
- 25 Mar, 2015 3 commits
-
-
yangguo authored
Revert of Debugger: deduplicate shared function info when setting script break points. (patchset #4 id:60001 of https://codereview.chromium.org/998253005/) Reason for revert: Code caching failures. Original issue's description: > Debugger: deduplicate shared function info when setting script break points. > > Also fix Debug.showBreakPoints for multiple break points at the same location. > > BUG=v8:3960 > LOG=N > > Committed: https://crrev.com/73b17a71a22564c0b66d9aa7c00948c748f5b290 > Cr-Commit-Position: refs/heads/master@{#27444} TBR=mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3960 Review URL: https://codereview.chromium.org/999273003 Cr-Commit-Position: refs/heads/master@{#27448}
-
yangguo authored
Also fix Debug.showBreakPoints for multiple break points at the same location. BUG=v8:3960 LOG=N Review URL: https://codereview.chromium.org/998253005 Cr-Commit-Position: refs/heads/master@{#27444}
-
mstarzinger authored
This switches full-codegen to no longer push and pop StackHandler markers onto the operand stack, but relies on a range-based handler table instead. We only use StackHandlers in JSEntryStubs to mark the transition from C to JS code. Note that this makes deoptimization and OSR from within any try-block work out of the box, makes the non-exception paths faster and should overall be neutral on the memory footprint (pros). On the other hand it makes the exception paths slower and actually throwing and exception more expensive (cons). R=yangguo@chromium.org TEST=cctest/test-run-jsexceptions/DeoptTry Review URL: https://codereview.chromium.org/1010883002 Cr-Commit-Position: refs/heads/master@{#27440}
-
- 24 Mar, 2015 1 commit
-
-
svenpanne authored
These are needed (among other things) for a TurboFan-generated StringAddStub. Furthermore, they can be used to nuke the overly complex %_IsInstanceType intrisic, it's completely expressible in JavaScript now, but that will be done in a separate CL. Alpha-sorted things a bit on the way to ease navigation. Review URL: https://codereview.chromium.org/1010973010 Cr-Commit-Position: refs/heads/master@{#27415}
-
- 20 Mar, 2015 1 commit
-
-
Benedikt Meurer authored
R=dcarney@chromium.org, yangguo@chromium.org BUG=v8:3952 LOG=n Review URL: https://codereview.chromium.org/1021183002 Cr-Commit-Position: refs/heads/master@{#27329}
-
- 18 Mar, 2015 1 commit
-
-
svenpanne authored
Review URL: https://codereview.chromium.org/1010673004 Cr-Commit-Position: refs/heads/master@{#27268}
-
- 17 Mar, 2015 2 commits
-
-
titzer authored
In constructing the transfer between loop copies, we need to merge the backedges from all the previous copies of the given loop. The control reduction will work out which ones are really reachable. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1004993004 Cr-Commit-Position: refs/heads/master@{#27246}
-
mstarzinger authored
This ensures that there is only one stub that deals with unwinding the stack. Having more than one place containing that logic is brittle and error prone, especially when it is a corner case only for RangeErrors. R=titzer@chromium.org TEST=mjsunit/regress/regress-crbug-467047 BUG=chromium:467047 LOG=N Review URL: https://codereview.chromium.org/1012103002 Cr-Commit-Position: refs/heads/master@{#27243}
-
- 16 Mar, 2015 1 commit
-
-
svenpanne authored
Fix the resulting warnings by renaming things apart. BUG=v8:3947 LOG=n Review URL: https://codereview.chromium.org/1009373002 Cr-Commit-Position: refs/heads/master@{#27219}
-
- 13 Mar, 2015 2 commits
-
-
kozyatinskiy authored
Error.stack contains function.name if its type is string. Otherwise if function have inferred name then .stack contains it. For functions from eval .stack property contains "eval". LOG=N BUG=chromium:17356 R=yurys@chromium.org Review URL: https://codereview.chromium.org/919653002 Cr-Commit-Position: refs/heads/master@{#27186}
-
bmeurer authored
Reduces the amount of custom support code for Math functions in TurboFan and allows for more general inlining (i.e. independent of parameter types). BUG=v8:3952 LOG=n R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1004083002 Cr-Commit-Position: refs/heads/master@{#27172}
-
- 11 Mar, 2015 2 commits
-
-
svenpanne authored
Outside of runtime.h, only the distinction between intrinsics returning pairs and those returning pairs is really meaningful, not the internal traditional partitioning of them. BUG=v8:3947 LOG=n Review URL: https://codereview.chromium.org/997933003 Cr-Commit-Position: refs/heads/master@{#27137}
-
svenpanne authored
Combined the various lists, the only slightly ugly thing is now the distinction between intrinsics returning pairs and the rest, but that's no big deal. BUG=v8:3947 LOG=n Review URL: https://codereview.chromium.org/989273003 Cr-Commit-Position: refs/heads/master@{#27135}
-
- 10 Mar, 2015 2 commits
-
-
arv authored
The prototype of a class constructor function is read only. When we set computed property names we were ignoring this and we were overriding the property. Since the prototype is the only possible own read only property on the constructor function object we special case this so we do not have to check this for every property in the class literal. BUG=v8:3945 LOG=N R=mstarzinger@chromium.org, dslomov@chromium.org Review URL: https://codereview.chromium.org/985643003 Cr-Commit-Position: refs/heads/master@{#27106}
-
bmeurer authored
Provide an intrinsic %MathFloor / %_MathFloor that is used to optimize both Math.ceil and Math.floor, and use the JS inlining mechanism to inline Math.ceil into TurboFan code. Although we need to touch code outside of TurboFan to make this work, this does not affect the way we handle Math.ceil and/or Math.floor in CrankShaft, because for CrankShaft the old-style builtin function id based inlining still kicks in first. Once this solution is stabilized, we can use it for Math.floor as well. And once that is settled, we can establish it as the unified way to inline builtins, and get rid of the specialized builtin function id based inlining at some point. Note that "builtin" applies to basically every piece of internal JavaScript/intrinsics based code, so this also applies to the yet to be defined JavaScript based code stubs and handlers. BUG=v8:3953 LOG=n R=yangguo@chromium.org,svenpanne@chromium.org Review URL: https://codereview.chromium.org/990963003 Cr-Commit-Position: refs/heads/master@{#27086}
-
- 06 Mar, 2015 3 commits
-
-
svenpanne authored
Now the three intrinsic lists only differ in their compiler support. Unifying the lists and making the logic what is supported in which compiler local to the compilers themselves is handled in a follow-up CL. BUG=v8:3947 LOG=n Review URL: https://codereview.chromium.org/983183002 Cr-Commit-Position: refs/heads/master@{#27046}
-
svenpanne authored
This involved renaming apart a few more intrinsics. In the long run, we want to clean up redundant intrinsics which just delegate. BUG=v8:3947 LOG=n Review URL: https://codereview.chromium.org/984963002 Cr-Commit-Position: refs/heads/master@{#27043}
-
svenpanne authored
BUG=v8:3947 LOG=n Review URL: https://codereview.chromium.org/978123003 Cr-Commit-Position: refs/heads/master@{#27039}
-
- 05 Mar, 2015 1 commit
-
-
svenpanne authored
This way, every function in those lists has one C++ implementation called Runtime_##name. The previous distinction was confusing. Review URL: https://codereview.chromium.org/983623002 Cr-Commit-Position: refs/heads/master@{#27010}
-
- 04 Mar, 2015 1 commit
-
-
jarin authored
BUG= Review URL: https://codereview.chromium.org/961973002 Cr-Commit-Position: refs/heads/master@{#26993}
-
- 03 Mar, 2015 6 commits
-
-
dslomov authored
R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org BUG=v8:3930 LOG=Y Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 Cr-Commit-Position: refs/heads/master@{#26960} Committed: https://crrev.com/8d29cc11a56e77297792fe100986a80b65de0051 Cr-Commit-Position: refs/heads/master@{#26963} Committed: https://crrev.com/0705045b50a29cf1273e9e6b86fe6a627d8dcb43 Cr-Commit-Position: refs/heads/master@{#26966} Review URL: https://codereview.chromium.org/975463002 Cr-Commit-Position: refs/heads/master@{#26972}
-
dslomov authored
Revert of Implement subclassing Arrays. (patchset #8 id:130001 of https://codereview.chromium.org/975463002/) Reason for revert: Arm compilation again. Aaaarrrrrghhhhhh!!! Original issue's description: > Implement subclassing Arrays. > > R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org > BUG=v8:3930 > LOG=Y > > Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 > Cr-Commit-Position: refs/heads/master@{#26960} > > Committed: https://crrev.com/8d29cc11a56e77297792fe100986a80b65de0051 > Cr-Commit-Position: refs/heads/master@{#26963} > > Committed: https://crrev.com/0705045b50a29cf1273e9e6b86fe6a627d8dcb43 > Cr-Commit-Position: refs/heads/master@{#26966} TBR=arv@chromium.org,mvstanton@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Review URL: https://codereview.chromium.org/976693002 Cr-Commit-Position: refs/heads/master@{#26969}
-
dslomov authored
R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org BUG=v8:3930 LOG=Y Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 Cr-Commit-Position: refs/heads/master@{#26960} Committed: https://crrev.com/8d29cc11a56e77297792fe100986a80b65de0051 Cr-Commit-Position: refs/heads/master@{#26963} Review URL: https://codereview.chromium.org/975463002 Cr-Commit-Position: refs/heads/master@{#26966}
-
dslomov authored
Revert of Implement subclassing Arrays. (patchset #7 id:110001 of https://codereview.chromium.org/975463002/) Reason for revert: Arm buildre complains again (why v8_linux_arm_dbg does not complain?) Original issue's description: > Implement subclassing Arrays. > > R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org > BUG=v8:3930 > LOG=Y > > Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 > Cr-Commit-Position: refs/heads/master@{#26960} > > Committed: https://crrev.com/8d29cc11a56e77297792fe100986a80b65de0051 > Cr-Commit-Position: refs/heads/master@{#26963} TBR=arv@chromium.org,mvstanton@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Review URL: https://codereview.chromium.org/974963002 Cr-Commit-Position: refs/heads/master@{#26965}
-
dslomov authored
R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org BUG=v8:3930 LOG=Y Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 Cr-Commit-Position: refs/heads/master@{#26960} Review URL: https://codereview.chromium.org/975463002 Cr-Commit-Position: refs/heads/master@{#26963}
-
mvstanton authored
Revert of Implement subclassing Arrays. (patchset #6 id:90001 of https://codereview.chromium.org/975463002/) Reason for revert: ARM build failure... Original issue's description: > Implement subclassing Arrays. > > R=mvstanton@chromium.org,arv@chromium.org,rossberg@chromium.org > BUG=v8:3930 > LOG=Y > > Committed: https://crrev.com/6898da1a28d64d1fb2962804ba566f6d618ffc70 > Cr-Commit-Position: refs/heads/master@{#26960} TBR=arv@chromium.org,rossberg@chromium.org,dslomov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Review URL: https://codereview.chromium.org/975693002 Cr-Commit-Position: refs/heads/master@{#26961}
-