- 30 Nov, 2015 3 commits
-
-
hpayer authored
Revert of Tenure transition array. (patchset #1 id:1 of https://codereview.chromium.org/1472363007/ ) Reason for revert: Broken canary. Trying to find out root cause. Original issue's description: > Tenure transition array. > > BUG= > > Committed: https://crrev.com/c88d7cd1e09d921e8a9a2930cfe6f2dfbea3dc90 > Cr-Commit-Position: refs/heads/master@{#32378} TBR=ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:563378 Review URL: https://codereview.chromium.org/1485613003 Cr-Commit-Position: refs/heads/master@{#32405}
-
hpayer authored
Revert of Introduce instance type for transition arrays. (patchset #6 id:100001 of https://codereview.chromium.org/1480873003/ ) Reason for revert: Broken canary. Trying to find out root cause. Original issue's description: > Introduce instance type for transition arrays. > > The motivation is to allow specialized marking visitor for transition arrays and collect all transition array in a list for post-processing in ClearNonLiveReferences. > > BUG=chromium:554488 > LOG=NO > > Committed: https://crrev.com/026095a3c7932573e1810b8064ec3008ed696601 > Cr-Commit-Position: refs/heads/master@{#32396} TBR=mlippautz@chromium.org,jkummerow@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:554488 Review URL: https://codereview.chromium.org/1483003002 Cr-Commit-Position: refs/heads/master@{#32404}
-
ulan authored
The motivation is to allow specialized marking visitor for transition arrays and collect all transition array in a list for post-processing in ClearNonLiveReferences. BUG=chromium:554488 LOG=NO Review URL: https://codereview.chromium.org/1480873003 Cr-Commit-Position: refs/heads/master@{#32396}
-
- 27 Nov, 2015 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1472363007 Cr-Commit-Position: refs/heads/master@{#32378}
-
- 25 Nov, 2015 2 commits
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1472393002 Cr-Commit-Position: refs/heads/master@{#32297}
-
ulan authored
BUG=chromium:554488 LOG=NO Review URL: https://codereview.chromium.org/1470773003 Cr-Commit-Position: refs/heads/master@{#32272}
-
- 20 Aug, 2015 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1285183010 Cr-Commit-Position: refs/heads/master@{#30263}
-
- 05 Aug, 2015 1 commit
-
-
mstarzinger authored
R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1256283003 Cr-Commit-Position: refs/heads/master@{#30020}
-
- 08 Jul, 2015 1 commit
-
-
verwaest authored
BUG=chromium:507767 LOG=n Review URL: https://codereview.chromium.org/1224853003 Cr-Commit-Position: refs/heads/master@{#29528}
-
- 03 Jul, 2015 1 commit
-
-
verwaest authored
Additionally speed up instantiation of ObjectTemplates by preallocating enough space in the descriptor arrays BUG=v8:4184 LOG=n Review URL: https://codereview.chromium.org/1218403002 Cr-Commit-Position: refs/heads/master@{#29468}
-
- 23 Jun, 2015 1 commit
-
-
verwaest authored
BUG=chromium:499790 LOG=n Review URL: https://codereview.chromium.org/1203653003 Cr-Commit-Position: refs/heads/master@{#29233}
-
- 18 Jun, 2015 1 commit
-
-
ulan authored
Revert of Replace ad-hoc weakness in transition array with WeakCell. (patchset #5 id:80001 of https://codereview.chromium.org/1157943003/) Reason for revert: Breaks descriptor array clearing. Original issue's description: > Replace ad-hoc weakness in transition array with WeakCell. > > BUG= > > Committed: https://crrev.com/885455e99de817f86a0b5df2dc0d932cfc179749 > Cr-Commit-Position: refs/heads/master@{#29083} TBR=jkummerow@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1194673002 Cr-Commit-Position: refs/heads/master@{#29121}
-
- 17 Jun, 2015 1 commit
-
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/1157943003 Cr-Commit-Position: refs/heads/master@{#29083}
-
- 09 Jun, 2015 1 commit
-
-
ulan authored
Added missing slots recording. This reverts commit fd2e3344. BUG= Review URL: https://codereview.chromium.org/1169743002 Cr-Commit-Position: refs/heads/master@{#28857}
-
- 08 Jun, 2015 2 commits
-
-
ulan authored
Revert of Replace ad-hoc weakness in prototype transitions with WeakCell. (patchset #2 id:20001 of https://codereview.chromium.org/1163073002/) Reason for revert: GC stress failures. Original issue's description: > Replace ad-hoc weakness in prototype transitions with WeakCell. > > BUG= > > Committed: https://crrev.com/bfb81fbe0d38c88cc1b6ed6eb1a4b8cbe2c469c3 > Cr-Commit-Position: refs/heads/master@{#28830} TBR=jkummerow@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1169733002 Cr-Commit-Position: refs/heads/master@{#28832}
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/1163073002 Cr-Commit-Position: refs/heads/master@{#28830}
-
- 01 Jun, 2015 1 commit
-
-
erikcorry authored
When compiling on a laptop I like to concatenate the small test files. This makes a big difference to compile times. These changes make that easier. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1163803002 Cr-Commit-Position: refs/heads/master@{#28742}
-
- 07 Apr, 2015 1 commit
-
-
jkummerow authored
The motivation is that we prefer to avoid creating internal properties, and we have a usable field on maps ("transitions", which is not used for prototype maps). This CL also ensures the invariant that prototype maps are never shared, even if they are in dictionary mode. Review URL: https://codereview.chromium.org/1033653002 Cr-Commit-Position: refs/heads/master@{#27617}
-
- 17 Mar, 2015 1 commit
-
-
dcarney authored
additionally, remove unnecessary deopts when transitioning to global accessor properties from data properties R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/996133002 Cr-Commit-Position: refs/heads/master@{#27239}
-
- 06 Mar, 2015 1 commit
-
-
jkummerow authored
Original issue: https://codereview.chromium.org/980573002/ Simple transitions are now stored in a map's "transitions" field (as a WeakCell wrapping the target map); full TransitionArrays are used when that's not sufficient. To encapsulate these storage format implementation details, functions for manipulating and querying transitions have been refactored to be static functions on the TransitionArray class, and take maps as inputs. Review URL: https://codereview.chromium.org/988703002 Cr-Commit-Position: refs/heads/master@{#27044}
-
- 05 Mar, 2015 2 commits
-
-
jkummerow authored
Revert of Simplify and compact transitions storage (patchset #4 id:80001 of https://codereview.chromium.org/980573002/) Reason for revert: x64 test failures Original issue's description: > Simplify and compact transitions storage > > Simple transitions are now stored in a map's "transitions" field (as a WeakCell wrapping the target map); full TransitionArrays are used when that's not sufficient. > To encapsulate these storage format implementation details, functions for manipulating and querying transitions have been refactored to be static functions on the TransitionArray class, and take maps as inputs. > > Committed: https://crrev.com/45fbef7f2252fce10634931cb103ccc1fc95ae6a > Cr-Commit-Position: refs/heads/master@{#27029} TBR=verwaest@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/982143002 Cr-Commit-Position: refs/heads/master@{#27030}
-
jkummerow authored
Simple transitions are now stored in a map's "transitions" field (as a WeakCell wrapping the target map); full TransitionArrays are used when that's not sufficient. To encapsulate these storage format implementation details, functions for manipulating and querying transitions have been refactored to be static functions on the TransitionArray class, and take maps as inputs. Review URL: https://codereview.chromium.org/980573002 Cr-Commit-Position: refs/heads/master@{#27029}
-
- 19 Jan, 2015 1 commit
-
-
ishell authored
PropertyKind: DATA -> kData ACCESSOR -> kAccessor PropertyType: FIELD -> DATA CONSTANT -> DATA_CONSTANT ACCESSOR_FIELD -> ACCESSOR CALLBACKS -> ACCESSOR_CONSTANT PropertyLocation: IN_OBJECT -> kField IN_DESCRIPTOR -> kDescriptor StoreMode: FORCE_IN_OBJECT -> FORCE_FIELD FieldDescriptor -> DataDescriptor ConstantDescriptor -> DataConstantDescriptor CallbacksDescriptor -> AccessorConstantDescriptor Review URL: https://codereview.chromium.org/856503002 Cr-Commit-Position: refs/heads/master@{#26146}
-
- 12 Dec, 2014 1 commit
-
-
ishell authored
Review URL: https://codereview.chromium.org/801813002 Cr-Commit-Position: refs/heads/master@{#25802}
-
- 10 Dec, 2014 1 commit
-
-
ishell authored
Reland of "TransitionArray now uses <is_data_property, name, attributes> tuple as a key, which allows to have several entries for the same property name." Review URL: https://codereview.chromium.org/793453004 Cr-Commit-Position: refs/heads/master@{#25750}
-
- 24 Nov, 2014 1 commit
-
-
ishell authored
Review URL: https://codereview.chromium.org/739013004 Cr-Commit-Position: refs/heads/master@{#25482}
-
- 13 Nov, 2014 2 commits
-
-
ishell@chromium.org authored
This reverts the commit because it possibly causes renderer hangs. BUG=chromium:431807 LOG=N R=verwaest@chromium.org Review URL: https://codereview.chromium.org/725633002 Cr-Commit-Position: refs/heads/master@{#25338}
-
ishell@chromium.org authored
Revert "TransitionArray now uses <is_data_property, name, attributes> tuple as a key, which allows to have several entries for the same property name." Revert "Fix for an assertion failure in Map::FindTransitionToField(...). Appeared after r25136." This revert is made in order to revert r25099 which potentially causes renderer hangs. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/722873004 Cr-Commit-Position: refs/heads/master@{#25332}
-
- 05 Nov, 2014 1 commit
-
-
ishell@chromium.org authored
TransitionArray now uses <is_data_property, name, attributes> tuple as a key, which allows to have several entries for the same property name. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/661133002 Cr-Commit-Position: refs/heads/master@{#25136} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25136 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Nov, 2014 1 commit
-
-
ishell@chromium.org authored
This is a prerequisite for https://codereview.chromium.org/661133002/. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/698043003 Cr-Commit-Position: refs/heads/master@{#25099} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Nov, 2014 1 commit
-
-
ishell@chromium.org authored
BUG=chromium:427813 LOG=N R=verwaest@chromium.org Review URL: https://codereview.chromium.org/676393002 Cr-Commit-Position: refs/heads/master@{#25082} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25082 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Oct, 2014 1 commit
-
-
verwaest@chromium.org authored
Revert "Limit the number of transitions allowed per hidden class." Due to crashes in ClearMapTransitions BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/661583004 Cr-Commit-Position: refs/heads/master@{#24900} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24900 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Oct, 2014 1 commit
-
-
verwaest@chromium.org authored
Each time a transition is added to a hidden class, the whole transitions array must be copied, which causes poor performance in some circumstances. This change limits the maximum size of the transition array, avoiding this behavior in the pathological case. For example, this improves the performance of the EtchMark benchmark by nearly 60%. BUG=v8:3616 LOG= R=verwaest@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/635883003 Patch from Kevin M. McCormick <mckev@amazon.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24857 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Apr, 2014 1 commit
-
-
mvstanton@chromium.org authored
Tests for verifying that we deal correctly with shrinking transition arrays while allocating a copy of one. Also, we can rely on a transition array only shrinking and not disappearing during gc while copying one. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/232883003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20710 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Apr, 2014 2 commits
-
-
mvstanton@chromium.org authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/234873004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20694 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mvstanton@chromium.org authored
* And contain knowledge better in TransitionArray and DescriptorArray (for example WhitenessWitness is now private to DescriptorArray). * And remove some factory methods * And handlify some other things. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/234783002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20686 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Apr, 2014 1 commit
-
-
mvstanton@chromium.org authored
During handlification of TransitionArray code, an error was introduced in TransitionArray::CopyInsert because after creating a copy of a TransitionArray, it may be that the array disappears during GC because it is modified during the marking of the owning map. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/228483005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20654 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-