Skip to content

V
V8
Switch branch/tag
  1. 26 May, 2015 1 commit
    • erikcorry's avatar
      Move hash code from hidden string to a private symbol · eca5b5d7
      erikcorry authored 
      * Hash code is now just done with a private own symbol instead of the hidden string, which predates symbols.
* In the long run we should do all hidden properties this way and get rid of the
hidden magic 0-length string with the zero hash code.  The advantages include
less complexity and being able to do things from JS in a natural way.
* Initially, the performance of weak set regressed, because it's a little harder
to do the lookup in C++.  Instead of heroics in C++ to make things faster I
moved some functionality into JS and got the performance back. JS is supposed to be good at looking up named properties on objects.
* This also changes hash codes of Smis so that they are always Smis.

Performance figures are in the comments to the code review.  Summary: Most of js-perf-test/Collections is neutral.  Set and Map with object keys are 40-50% better.  WeakMap is -5% and WeakSet is +9%.  After the measurements, I fixed global proxies, which cost 1% on most tests and 5% on the weak ones :-(.

In the code review comments is a patch with an example of the heroics we could do in C++ to make lookup faster (I hope we don't have to do this.  Instead of checking for the property, then doing a new lookup to insert it, we could do one lookup and handle the addition immediately).  With the current benchmarks above this buys us nothing, but if we go back to doing more lookups in C++ instead of in stubs and JS then it's a win.

In a similar vein we could give the magic zero hash code to the hash code
symbol.  Then when we look up the hash code we would sometimes see the table
with all the hidden properties.  This dual use of the field for either the hash
code or the table with all hidden properties and the hash code is rather ugly,
and this CL gets rid of it.  I'd be loath to bring it back.  On the benchmarks quoted above it's slightly slower than moving the hash code lookup to JS like in this CL.

One worry is that the benchmark results above are more monomorphic than real
world code, so may be overstating the performance benefits of moving to JS.  I
think this is part of a general issue we have with handling polymorphic code in
JS and any solutions there will benefit this solution, which boils down to
regular property access. Any improvement there will lift all boats.

R=adamk@chromium.org, verwaest@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1149863005

Cr-Commit-Position: refs/heads/master@{#28622}
      eca5b5d7
  3. 16 Jan, 2015 1 commit
  5. 04 Sep, 2014 1 commit
  7. 04 Aug, 2014 1 commit
  9. 09 Jul, 2014 1 commit
  11. 03 Jun, 2014 1 commit
  13. 23 May, 2014 1 commit
  15. 17 Apr, 2014 1 commit
  17. 21 Mar, 2014 1 commit
  19. 19 Mar, 2014 1 commit
  21. 12 Feb, 2014 1 commit
  23. 19 Sep, 2013 2 commits
  25. 28 Jun, 2013 1 commit
  27. 28 May, 2013 1 commit
  29. 08 May, 2013 1 commit
  31. 07 May, 2013 2 commits
  33. 02 May, 2013 1 commit
  35. 09 Jan, 2013 2 commits
  37. 10 Jan, 2012 2 commits
  39. 06 Jan, 2012 1 commit
  41. 15 Dec, 2011 1 commit
  43. 10 Nov, 2011 2 commits