- 25 Aug, 2017 4 commits
-
-
Shiyu Zhang authored
The CPP builtins execute the same piece of code to prepare context before jumping into CEntryStub. By creating new ASM builtin to execute that common piece of code, ~7KB code size (tested on x64) of snapshot_blob.bin can be reduced without any negative performance impact. BUG= Change-Id: I744369e8723dcd902b61dc50645db66bea884441 Reviewed-on: https://chromium-review.googlesource.com/595119Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#47590}
-
Sathya Gunasekaran authored
Bug: v8:5717 Change-Id: I3775001a6148e25f15b11410449a6f8b7693f122 Reviewed-on: https://chromium-review.googlesource.com/625276 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#47589}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a35cf9a..a2b7113 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/92387bc..e37aa9d TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I5d7b8b212c66df540c930688c10606f112c5b7af Reviewed-on: https://chromium-review.googlesource.com/633137Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#47588}
-
Jaideep Bajwa authored
Disable test on big endian PPC for now, since it is missing load/store reverse byte instructions. R=machenbach@chromium.org, jkummerow@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com BUG= LOG=N Change-Id: Iaf12a14678bc9d113dc4d11998ea5bad158c20fd Reviewed-on: https://chromium-review.googlesource.com/634271Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#47587}
-
- 24 Aug, 2017 27 commits
-
-
Adam Klein authored
Change-Id: Id9f60cdafc486de2b04684de84174f9765637c12 Reviewed-on: https://chromium-review.googlesource.com/601328Reviewed-by:
-
Adam Klein authored
This also removes the IS_GLOBAL macro from macros.py, which did not work correctly for Remote objects/contexts. Bug: v8:6413 Change-Id: I90690bdd0d8e8fed581bc4c9f5c60168d785f096 Reviewed-on: https://chromium-review.googlesource.com/633872Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47585}
-
Kevin Gibbons authored
This flag allows invalid escape sequences in tagged templates, which is a stage-4 TC39 proposal shipping in other browsers. Bug: v8:5546 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I3e7c374c9b547f62d5976f76a7208d05fe9decf8 Reviewed-on: https://chromium-review.googlesource.com/581885 Commit-Queue: Kevin Gibbons <bakkot@gmail.com> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47584}
-
Marja Hölttä authored
U+feff is the UTF BOM but if it occurs inside the text, it's a "zero-width no-break space". However, the UTF-8 decoder in script streaming still thought it's a BOM and skipped it. The correct way to handle it would be to create a U+feff code point instead - the Scanner will then handle it as whitespace. This is a discrepancy between the Blink UTF-8 decoder and the V8 UTF-8 decoder, and caused the source positions be off by one. This bug went unnoticed, since normally off-by-one in this situation doesn't make the code to break. BUG=chromium:758508,chromium:758236 Change-Id: Ib92a3ee65c402e21b77e42537db2a021cff55379 Reviewed-on: https://chromium-review.googlesource.com/632096Reviewed-by:
-
Eric Holk (eholk) authored
This timer imposes a high overhead and does not give us the data we'd like. Disabling for now until we can develop a better solution. Bug: v8:6514 Change-Id: I73b15131a71d7b6750556f82907cb2a0e6edd321 Reviewed-on: https://chromium-review.googlesource.com/633703 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#47582}
-
Camillo Bruni authored
Bug: chromium:757199 Change-Id: I5936fab1784ebf8de6eddd3b2bec0e2cf1b73f82 Reviewed-on: https://chromium-review.googlesource.com/632317Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#47581}
-
Michael Lippautz authored
Bug: chromium:738368 Change-Id: I4867b90c639d8d5315e0caa22285e7ddbdab44f9 Reviewed-on: https://chromium-review.googlesource.com/632682 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47580}
-
Juliana Franco authored
of optimized JS functions. Bug: v8:6637 Change-Id: Ice94a4a2187f98adcbf25ac1832e13d4b7529f34 Reviewed-on: https://chromium-review.googlesource.com/628198 Commit-Queue: Juliana Patricia Vicente Franco <jupvfranco@google.com> Reviewed-by:
-
Camillo Bruni authored
Change-Id: Ic9dffa7f94b471824f18170c72df8568dd47cfcd Reviewed-on: https://chromium-review.googlesource.com/631959Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#47578}
-
Albert Mingkun Yang authored
This is useful for the RecordWrite stub that can now specify the set of allocatable registers in its call descriptor interface. During register allocation a custom register configuration is used to ensure that the register are allocated from the given set. This makes calling RecordWrite stub less expensive as we need to save/restore only the allocatable registers instead all registers. Bug: chromium:749486 Change-Id: If4d73f1fd525e480970ea92600fb811e63677eb5 Reviewed-on: https://chromium-review.googlesource.com/624734Reviewed-by:
-
Leszek Swirski authored
* Only pass -t to adb if running with stdout as a tty (prevents weird tty output processing, .e.g replacing '\n' with '\r\n') * Allow passing a device directory for d8 (useful for testing multiple builds against each other) * Allow specifying additional allowed paths (useful for e.g. running files from /tmp) Change-Id: I90b8bba6f3c248105927c800b8b5b601692adf6c Reviewed-on: https://chromium-review.googlesource.com/629079 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47576}
-
Camillo Bruni authored
Several stack traces from crash reports in https://crbug.com/754490 have wrong magic signatures. Even though we're supposed to be failing in a V8_Fatal the signature doesn't show up on the stack trace. Change-Id: I35c8f27e36fd2a0ec474095a6cf5557a76fe7d26 Reviewed-on: https://chromium-review.googlesource.com/631878Reviewed-by:
-
Camillo Bruni authored
We can avoid the ToString conversion before doing the HasProperty check. This avoid a costly Smi to String conversion which is unecessary for the following lookups. For very large dictionary elements this is a significant slow down as we will no longer hit the GetNumberStringCache. Change-Id: I5a0eb13470ab3d3d8a87ee36d28ce7be5cbc2b2e Reviewed-on: https://chromium-review.googlesource.com/626056Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
jgruber authored
The v8_enable_fast_mksnapshot gn flag reduces time spent in mksnapshot on x64 debug builds from 19s to 6s by disabling far jump rewrites and register allocation verification. This flag should only be used locally for development. Bug: v8:6688 Change-Id: I02e8546a6a329b9cb377b95ab586d5857a3c6731 Reviewed-on: https://chromium-review.googlesource.com/632258Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#47573}
-
Yuki Shiino authored
In case of LAP(lazy accessor pair), the function's creation context must be equal to the accessor holder's creation context, so this CL changes the current context to the accessor holder's creation context. Note that this is the second attempt after https://crrev.com/2770003002 The change from the previous attempt is to skip looking for the object's constructor if the object itself is a function. Also some of Blink's LAP-context-sensitive tests got updated at https://crrev.com/c/597990 and the rest of the tests will get temporarily disabled at https://crrev.com/c/605408 . TBR=verwaest@chromium.org Bug: v8:6156 Change-Id: I09709a90995d82a03996d0347e5a1d8425b5db9c Reviewed-on: https://chromium-review.googlesource.com/563152 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This further reduces the footprint of the deferred blocks used as part of our CSA-asserts by marking the {DebugAbort} calls as unreachable. This allows us to elide (un)spilling because re-entry into the normal instruction stream is removed. R=jgruber@chromium.org BUG=v8:6688 Change-Id: Ib00362fbe34427b3c8f8c8f5fcea0b83028f81b2 Reviewed-on: https://chromium-review.googlesource.com/632056Reviewed-by: -
Yang Guo authored
We no longer include hydrogen stubs in the snapshot. R=jgruber@chromium.org Change-Id: Id268b416ed839f55d297a1888444ef6323ec9dd9 Reviewed-on: https://chromium-review.googlesource.com/631956Reviewed-by:
-
Yang Guo authored
R=jgruber@chromium.org Change-Id: I07b748990f3e23cfedb0fd0cf8dce62f21a309bd Reviewed-on: https://chromium-review.googlesource.com/631722Reviewed-by:
-
Michael Starzinger authored
This introduces a {DebugAbort} machine-level operator as well as the corresponding {ArchDebugAbort} backend instruction. The goal of this is to speed up snapshot generation due to cheaper "CSA-asserts". R=jgruber@chromium.org BUG=v8:6688 Bug: v8:6688 Change-Id: If45f7da0652d4bb920c51ab7a7c41f9670434bbb Also-By: jgruber@chromium.org Reviewed-on: https://chromium-review.googlesource.com/628560Reviewed-by: -
Yang Guo authored
Bug: v8:6747 Change-Id: If4b9c1ccd23c3ef1ed5e173f0143d2cc85581154 Reviewed-on: https://chromium-review.googlesource.com/631678Reviewed-by:
-
Alexandre Talon authored
Since the AST graph builder is gone, no variable should be named osr_ast_id. This CL replaces it with osr_offset. It designates the offset of the bytecode where the OSRing was triggered. Bug: Change-Id: Ia53a83b09f917fcd0174da685a18edd3ee3aa01f Reviewed-on: https://chromium-review.googlesource.com/621008Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Lippautz authored
DEBUG builds pull in all sorts of instrumentation infrastructure that leads to larger heaps. The check for intial size is only useful for release builds. Bug: v8:6746 Change-Id: I5ab220d21167e69d7fb32c9db68045368c4ef178 R: ulan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/631876Reviewed-by:
-
Michael Hablich authored
This reverts commit 8bbc2242. Reason for revert: On Canary 3195. Original change's description: > [heap] Enable concurrent marking for x86 and x64. > > This is an experiment and will be reverted after getting canary > coverage. > > Bug: chromium:694255 > Change-Id: I40388d8c6db0e46e2ce64e88aba04c5ac8822e94 > Reviewed-on: https://chromium-review.googlesource.com/625959 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#47541} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: I642c1f778267a795bf1e1a6bba863552394ad1d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:694255 Reviewed-on: https://chromium-review.googlesource.com/631717Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#47564}
-
Clemens Hammacher authored
The {WireBytesRef} constructor checks that {offset + length} does not overflow. Hence we need to check for illegal sizes before constructing the {WireBytesRef}. The {consume_bytes} function already does that, so remove the redundant hand-written checking. R=titzer@chromium.org Bug: chromium:752781 Change-Id: If3a2946a62fa38cc668695ed7186b9751a1f356f Reviewed-on: https://chromium-review.googlesource.com/605894 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#47563}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/337452a..a35cf9a Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/810d9d2..92387bc TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: I55630210fe41f252dfaf6d1df91c8de98d4cd1df Reviewed-on: https://chromium-review.googlesource.com/630142Reviewed-by:
-
Alexey Kozyatinskiy authored
API resolves functions to its .prototype property to make possible queries like queryObjects(Object), queryObjects(HTMLElement), e.t.c. R=dgozman@chromium.org Bug: v8:6732 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie8dc2288fa7e59c69f9b2647a9d5e35f0ac9215f Reviewed-on: https://chromium-review.googlesource.com/630244 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#47561}
-
Mircea Trofin authored
Initialize the code table with a valid default (e.g. illegal builtin), otherwise we're invalidating assumptions when relocating. Bug: chromium:757217 Change-Id: I77890f1fe0e31534d9844d2e91694df1ec185110 Reviewed-on: https://chromium-review.googlesource.com/630097Reviewed-by:
-
- 23 Aug, 2017 9 commits
-
-
Alexey Kozyatinskiy authored
- simplify prototype traversal. - use V8InspectorClient::isInspectableHeapObject since some embedders on JavaScript heap contains not inspectable objects, e.g. wrapper boilerplates in blink. - Runtime.queryObjects takes prototype object as argument for more flexibility. R=alph@chromium.org Bug: v8:6732 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I06f0d5c987150c80c3e9b05e7f6ad195985fc539 Reviewed-on: https://chromium-review.googlesource.com/627577 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Anisha Rohra authored
Port 10f73fac R=bjaideep@ca.ibm.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ia5b50df98cb26bc332e3e2b114861740bae19d3d Reviewed-on: https://chromium-review.googlesource.com/629217Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#47558}
-
Brad Nelson authored
BUG= R=ahaas@chromium.org,mstarzinger@chromium.org Change-Id: Ida7ac441722d778946b7ac92e8f6c7fe5ea15cdc Reviewed-on: https://chromium-review.googlesource.com/628821 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by:
-
Jaideep Bajwa authored
The testcase was failing on BE, fix to use 32bit load before calling testbit. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com Log=N Bug: Change-Id: I075666b47dd90b6341ba7b4031cd4be96e8c1bf9 Reviewed-on: https://chromium-review.googlesource.com/628659Reviewed-by:
-
Georg Neis authored
With the removal of Crankshaft, kNumber has become obsolete as BinaryOperationFeedback. Turbofan uses kNumberOrOddball. Bug: Change-Id: If577f5efcc81d7c08f43908f2764ff0ec6f8747c Reviewed-on: https://chromium-review.googlesource.com/628376Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Adam Klein authored
BytecodeGenerator previously assumed that any UNALLOCATED variable must be a global object property, but that's incorrect for global lexical variables declared in a different script. This patch fixes the behavior by always falling back to the runtime to deal with deleting UNALLOCATED variables. This is sub-optimal, but should be correct, and it's unclear if speed is important for this case. Bug: v8:6733 Change-Id: I83c2a0b6e30e5e5f4c79bfe14ebf196529816c71 Reviewed-on: https://chromium-review.googlesource.com/627636Reviewed-by:
-
Adam Klein authored
V8 used to erroneously allow ForStatements to contain a function declaration, but that hasn't been true since we shipped the "--harmony-restrictive-declarations" flag 1.5 years ago. Bug: v8:4824 Change-Id: I893b45aed468017f89c0c5964df2091bea030327 Reviewed-on: https://chromium-review.googlesource.com/621871Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47553}
-
Ulan Degenbaev authored
Bug: chromium:694255 Change-Id: Ic21368f68e103ee1278b4e975255c6941f23a2d0 Reviewed-on: https://chromium-review.googlesource.com/629058Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47552}
-
Ulan Degenbaev authored
This enables concurrent marking for x86 and x64 on GYP builds. Bug: chromium:694255 Change-Id: I371b38e72ce0e8f7ad5b0eed4e29b223b9ed1cf4 Reviewed-on: https://chromium-review.googlesource.com/628836 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
