- 21 Nov, 2018 1 commit
-
-
Jakob Kummerow authored
In preparation for incrementally migrating subclasses to deriving from FixedArrayPtr/FixedArrayBasePtr. Once that is done for all subclasses, this duplication will be dropped again. Bug: v8:3770 Change-Id: I6d664997fdcb18f7c0f37183d9f920ae30f3b749 Reviewed-on: https://chromium-review.googlesource.com/c/1345325Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57702}
-
- 07 Nov, 2018 1 commit
-
-
Igor Sheludko authored
because otherwise cleared weak references require special treatment during decompression. Bug: v8:7703 Change-Id: I38761d656c606e7ba7fc3075dffbd855a9f72302 Reviewed-on: https://chromium-review.googlesource.com/c/1322909 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#57315}
-
- 05 Nov, 2018 1 commit
-
-
Jakob Kummerow authored
and split Smi out of objects.h into smi.h. Bug: v8:3770, v8:5402 Change-Id: I5ff7461495d29c785a76c79aca2616816a29ab1e Reviewed-on: https://chromium-review.googlesource.com/c/1313035Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57252}
-
- 26 Oct, 2018 1 commit
-
-
Jakob Kummerow authored
This CL applies the equivalent of the Object -> ObjectPtr transformation to MaybeObject and HeapObjectReference. We need no renaming in this case because we can just migrate them both in one go. Bug: v8:3770 Change-Id: Ie1259c3e8c556eff00f8bcf534d7270ca9fe00e1 Reviewed-on: https://chromium-review.googlesource.com/c/1298386 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57010}
-
- 24 Oct, 2018 1 commit
-
-
Jakob Kummerow authored
as part of the continuing quest to get rid of Object*/Object**. This is a fairly mechanical replacement of Object**/MaybeObject** with wrapper objects carrying the same data. No change in behavior is intended. Overloaded operators are provided to minimize code churn. Bug: v8:3770 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I76cee82b8bf2dd80a1b66f09dd2bb2b65038eeb7 Reviewed-on: https://chromium-review.googlesource.com/c/1287889 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#56920}
-
- 17 Sep, 2018 1 commit
-
-
Marja Hölttä authored
BodyDescriptorWeak is not needed for all classes. For the classes it's needed it's referred to explicitly (Foo::BodyDescriptorWeak::IterateBody()). BUG=v8:7308 Change-Id: If8591929cd588575e88f3d6f116ec2cac4941e8f Reviewed-on: https://chromium-review.googlesource.com/1226649Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#55941}
-
- 14 Sep, 2018 1 commit
-
-
Georg Neis authored
Change-Id: If90c13658713cbfdf06200e49773e67495dce85b Reviewed-on: https://chromium-review.googlesource.com/1225754Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55891}
-
- 11 Sep, 2018 1 commit
-
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: I564f340096e64b3d17f9367aea031148a40faf40 Reviewed-on: https://chromium-review.googlesource.com/1218742Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#55778}
-
- 17 Aug, 2018 1 commit
-
-
Marja Hölttä authored
This way the snapshot will contain only old space objects. BUG=v8:7308 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib19642795b1e8c7cbeda5162be86909c1a777767 Reviewed-on: https://chromium-review.googlesource.com/1177384Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#55186}
-
- 06 Aug, 2018 1 commit
-
-
Marja Hölttä authored
Now we can remove FixedArrayOfWeakCells (this was the last user). Previous try: https://chromium-review.googlesource.com/1150170 BUG=v8:7308 Change-Id: Ie924e379ea8bbd797430e3ca591019fe001e78ad Reviewed-on: https://chromium-review.googlesource.com/1154909Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54928}
-
- 03 Aug, 2018 1 commit
-
-
Peter Marshall authored
FixedArray max size is currently 1024 MB on 64 bit and 512 MB on 32 bit. Update the max size of FixedDoubleArray to match. This doubles the max size for arrays of doubles. Bug: chromium:814599 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I3ac1b4caaf5b6428fe8a8c848fffdf84af8a9ae9 Reviewed-on: https://chromium-review.googlesource.com/1160235Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#54892}
-
- 02 Aug, 2018 1 commit
-
-
Marja Hölttä authored
Previously, removing an element in the middle made it consume space forever. This fixes that, without changing the complexity of removal / addition. The trade-off is that RemoveOne will shuffle indices (which should be OK for the current users). BUG=v8:7308 Change-Id: I0373e30f2d9d1ffb93a78d383d41b500dbbf3429 Reviewed-on: https://chromium-review.googlesource.com/1159371 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54875}
-
- 31 Jul, 2018 1 commit
-
-
Georg Neis authored
Use sizeof of the C type instead. Also fix a few #undef's that got reported after my changes. R=jarin@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I30a43b3d93e6df04fb9fb33050b52988edd7fdb1 Reviewed-on: https://chromium-review.googlesource.com/1155108Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54817}
-
- 30 Jul, 2018 4 commits
-
-
Peter Marshall authored
Fixes: src/parsing/parse-info.h src/parsing/preparsed-scope-data.h src/profiler/heap-profiler.h src/profiler/heap-snapshot-generator.h src/profiler/heap-snapshot-generator-inl.h' src/property.h src/prototype.h src/prototype-inl.h Bug: v8:7754,v8:7490,v8:7965 Change-Id: Iba14292cdfbbaf29d5b989c16d579a1ee0edcc25 Reviewed-on: https://chromium-review.googlesource.com/1154967 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54787}
-
Jaroslav Sevcik authored
This CL introduces InstanceTypeChecker namespace with type checkers for types used by the optimizing compiler. The type checkers are global functions. Examples: bool InstanceTypeChecker::IsJSFunction(InstanceType); bool InstanceTypeChecker::IsAllocationSite(InstanceType); The CL also uses these type checkers in the HeapObject::IsXXXX() functions to ensure consistency. Bug: v8:7790 Change-Id: I7eb9e79ca28da02fd489201f532e566d0d13243a Reviewed-on: https://chromium-review.googlesource.com/1154529Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#54782}
-
Marja Hölttä authored
This reverts commit 13401d2b. Reason for revert: gc stress breakage Original change's description: > [in-place weak refs] Use WeakArrayList in wasm > > Now we can remove FixedArrayOfWeakCells (this was the last user). > > BUG=v8:7308 > > Change-Id: I7b74f7833288b20d8f4d098a4afce640ea6db823 > Reviewed-on: https://chromium-review.googlesource.com/1150170 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54776} TBR=marja@chromium.org,mlippautz@chromium.org,ahaas@chromium.org Change-Id: I1bc1ad7e27813aeaaf191efdf74b865d676475f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7308 Reviewed-on: https://chromium-review.googlesource.com/1154787Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54778}
-
Marja Hölttä authored
Now we can remove FixedArrayOfWeakCells (this was the last user). BUG=v8:7308 Change-Id: I7b74f7833288b20d8f4d098a4afce640ea6db823 Reviewed-on: https://chromium-review.googlesource.com/1150170 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#54776}
-
- 26 Jul, 2018 1 commit
-
-
Marja Hölttä authored
BUG=v8:7308 TBR=mlippautz@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic310ebcf0af2f3985cee9872f6e57a05652c4484 Reviewed-on: https://chromium-review.googlesource.com/1151197Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54722}
-
- 25 Jul, 2018 2 commits
-
-
Ross McIlroy authored
This reverts commit 6755b956. Reason for revert: Causing test failures on gc-stress bot: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8940015537308234128/+/steps/Mjsunit_-_slow_path/0/logs/array-multiple-receiv../0 Original change's description: > [in-place weak refs] Use WeakArrayList in Heap::noscript_list. > > BUG=v8:7308 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: Ia53233a3a0ba13b8019f2fda4bc4876ebf4feb76 > Reviewed-on: https://chromium-review.googlesource.com/1149367 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54700} TBR=marja@chromium.org,mlippautz@chromium.org Change-Id: I5e9b916a910b812c3cb50be18416c9e9e8ac7b24 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7308 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1150125Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#54701}
-
Marja Hölttä authored
BUG=v8:7308 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ia53233a3a0ba13b8019f2fda4bc4876ebf4feb76 Reviewed-on: https://chromium-review.googlesource.com/1149367 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54700}
-
- 24 Jul, 2018 5 commits
-
-
Marja Hölttä authored
Previous version: https://chromium-review.googlesource.com/c/v8/v8/+/1143467 BUG=v8:7308 TBR=jgruber@chromium.org Change-Id: I0c1fe73250b0aed270cdb9fa5e1bc55315ace3d2 Reviewed-on: https://chromium-review.googlesource.com/1148333 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54650}
-
Marja Hölttä authored
This reverts commit 1233e7c9. Reason for revert: There were more test failures, e.g. linux nosnap. Original change's description: > Reland "[in-place weak refs] Replace Heap::script_list with a WeakArrayList." > > This reverts commit cfccdf88. > > Reason for revert: Was a faulty test. > > Original change's description: > > Revert "[in-place weak refs] Replace Heap::script_list with a WeakArrayList." > > > > This reverts commit 06f556d8. > > > > Reason for revert: gc stress failures > > > > Original change's description: > > > [in-place weak refs] Replace Heap::script_list with a WeakArrayList. > > > > > > BUG=v8:7308 > > > > > > Change-Id: Idd527fc2a2f5bde635441a511e424a83558ab969 > > > Reviewed-on: https://chromium-review.googlesource.com/1143467 > > > Commit-Queue: Marja Hölttä <marja@chromium.org> > > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#54635} > > > > TBR=ulan@chromium.org,marja@chromium.org,jgruber@chromium.org > > > > Change-Id: I6908fa42fcf4a8916a1dc49b865526094f950c66 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: v8:7308 > > Reviewed-on: https://chromium-review.googlesource.com/1148280 > > Reviewed-by: Marja Hölttä <marja@chromium.org> > > Commit-Queue: Marja Hölttä <marja@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54636} > > TBR=ulan@chromium.org,marja@chromium.org,jgruber@chromium.org > > Change-Id: I2451ed0237b69bf17bbe13f4929568ebe2abfc67 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:7308 > Reviewed-on: https://chromium-review.googlesource.com/1148340 > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54639} TBR=ulan@chromium.org,marja@chromium.org,jgruber@chromium.org Change-Id: I60ebd9784416740c92b32aa92e330755d847b882 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7308 Reviewed-on: https://chromium-review.googlesource.com/1148341Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54642}
-
Marja Hölttä authored
This reverts commit cfccdf88. Reason for revert: Was a faulty test. Original change's description: > Revert "[in-place weak refs] Replace Heap::script_list with a WeakArrayList." > > This reverts commit 06f556d8. > > Reason for revert: gc stress failures > > Original change's description: > > [in-place weak refs] Replace Heap::script_list with a WeakArrayList. > > > > BUG=v8:7308 > > > > Change-Id: Idd527fc2a2f5bde635441a511e424a83558ab969 > > Reviewed-on: https://chromium-review.googlesource.com/1143467 > > Commit-Queue: Marja Hölttä <marja@chromium.org> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54635} > > TBR=ulan@chromium.org,marja@chromium.org,jgruber@chromium.org > > Change-Id: I6908fa42fcf4a8916a1dc49b865526094f950c66 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:7308 > Reviewed-on: https://chromium-review.googlesource.com/1148280 > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54636} TBR=ulan@chromium.org,marja@chromium.org,jgruber@chromium.org Change-Id: I2451ed0237b69bf17bbe13f4929568ebe2abfc67 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7308 Reviewed-on: https://chromium-review.googlesource.com/1148340Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54639}
-
Marja Hölttä authored
This reverts commit 06f556d8. Reason for revert: gc stress failures Original change's description: > [in-place weak refs] Replace Heap::script_list with a WeakArrayList. > > BUG=v8:7308 > > Change-Id: Idd527fc2a2f5bde635441a511e424a83558ab969 > Reviewed-on: https://chromium-review.googlesource.com/1143467 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54635} TBR=ulan@chromium.org,marja@chromium.org,jgruber@chromium.org Change-Id: I6908fa42fcf4a8916a1dc49b865526094f950c66 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7308 Reviewed-on: https://chromium-review.googlesource.com/1148280Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54636}
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: Idd527fc2a2f5bde635441a511e424a83558ab969 Reviewed-on: https://chromium-review.googlesource.com/1143467 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54635}
-
- 23 Jul, 2018 1 commit
-
-
Stephan Herhut authored
This moves the static handle() helper function to handles-inl.h as it ultimately depends on handles-inl.h anyway. To make this possible, also move some other code to -inl.h files and split up some header files into a -inl.h part. Bug: v8:7490 Change-Id: I0f68e0728ba082b87ffa911aaf205d9b1523d2c9 Reviewed-on: https://chromium-review.googlesource.com/1146723Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#54617}
-
- 18 Jul, 2018 1 commit
-
-
Dan Elphick authored
Strictly speaking there are some left in api.cc, but they are in deprecated functions with non-deprecated alternatives. Apart from changes made using tooling, this also modifies FieldType::AsClass to return Map* rather than Handle<Map> and converts its call sites to create the Handle when they need it - currently several sites immediately dereference the Handle. Also marks WasmDebugInfo as NeverReadOnlySpaceObject so GetIsolate and GetHeap remain usable. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I7ea5048f97f140c757f651712b8c33a5c7e0ebc1 Reviewed-on: https://chromium-review.googlesource.com/1140302Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54513}
-
- 17 Jul, 2018 1 commit
-
-
Marja Hölttä authored
It's a growing weak array which also has an API for marking slots empty (those will then be filled before growing the array again). This is a more efficient implementation than the corresponding feature in FixedArrayOfWeakCells, because we chain the empty slots together. BUG=v8:7308 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I335cd3f9cc7838c7f6ca350735b1503b2f5b8eed Reviewed-on: https://chromium-review.googlesource.com/1090922 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54481}
-
- 13 Jul, 2018 1 commit
-
-
Dan Elphick authored
All auto-generated with some fix-ups including marking the following classes as NeverReadOnlySpaceObject so their GetIsolate/GetHeap methods are safe to use: Code, CodeDataContainer, AbstractCode, DeoptimizationData, CompilationCacheTable, NormalizedMapCache, Script, SharedFunctionInfo TBR=yangguo@chromium.org Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I6cb5dcca88a0bc99b5afe80f553e06a661b5da3c Reviewed-on: https://chromium-review.googlesource.com/1135306 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54439}
-
- 12 Jul, 2018 1 commit
-
-
Leszek Swirski authored
With ReadOnlyRoots and GetIsolate on JSReceiver, we can remove almost every isolate parameter from <Object>::Print. The remaining ones, like Map, are special-caseable for read-only maps, and as a result we can remove isolate parameters from <Object>::Print entirely. This patch also opportunistically cleans up a few places where isolates were only needed for Object::Print, such as TransitionAccessors and DescriptorArrays. TBR=yangguo@chromium.org,mstarzinger@chromium.org Bug: v8:7786 Change-Id: Id44bd53b9893e679eea5f37b9548257595a1bfd9 Reviewed-on: https://chromium-review.googlesource.com/1133385Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54401}
-
- 11 Jul, 2018 1 commit
-
-
Dan Elphick authored
Removes GetHeap/GetIsolate from FixedArray::Shrink and FixedArray::SetAndGrow. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I8db2680f5ef69e901383e0b2cb60198c1b8dd316 Reviewed-on: https://chromium-review.googlesource.com/1131184Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54373}
-
- 05 Jul, 2018 1 commit
-
-
Leszek Swirski authored
Replace Is<oddball>(GetIsolate()) calls with a no-parameter version that goes through ReadOnlyRoots, and add a version that takes a ReadOnlyRoots if that is available in the parent (but Isolate isn't). Also opportunistically clean up a few places where ReadOnlyRoots are available but we still pass in an Isolate parameter. TBR=yangguo@chromium.org Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Icc0b8a7d8f9c6b84c0ec8fe771fcfb75c9dc5468 Reviewed-on: https://chromium-review.googlesource.com/1126302Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54245}
-
- 25 Jun, 2018 1 commit
-
-
Leszek Swirski authored
Roughly: GetIsolate(): -31 handle(HeapObject): -6 TBR=verwaest@chromium.org Bug: v8:7786 Change-Id: I3857f8c45f1f93c727d575d5f9244d9811949a7f Reviewed-on: https://chromium-review.googlesource.com/1111838Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#53997}
-
- 21 Jun, 2018 1 commit
-
-
Leszek Swirski authored
Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic00953a5375f60b61a093234c03ce0df41dbe228 Reviewed-on: https://chromium-review.googlesource.com/1110125Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#53944}
-
- 04 Jun, 2018 2 commits
-
-
Marja Hölttä authored
BUG=v8:7308 TBR=ishell@chromium.org, tebbi@chromium.org Change-Id: I0f7de13967d3e109b40d7158ee29775754c3d108 Reviewed-on: https://chromium-review.googlesource.com/1082475 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53483}
-
Marja Hölttä authored
(Pre-work for adding special-purpose data structures as subclasses.) BUG=v8:7308 Change-Id: I82a5a96e18c3321e9d5b783642516ff869b45f27 Reviewed-on: https://chromium-review.googlesource.com/1084474 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53482}
-
- 01 Jun, 2018 2 commits
-
-
Marja Hölttä authored
This reverts commit 0f23cedd. Reason for revert: buildbot failures Original change's description: > [in-place weak refs] Replace WeakCells in DescriptorArray. > > BUG=v8:7308 > > Change-Id: Ib0ad52916d6f5b65e7612981b467b491d832f505 > Reviewed-on: https://chromium-review.googlesource.com/1075053 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53473} TBR=ulan@chromium.org,marja@chromium.org,tebbi@chromium.org,ishell@chromium.org Change-Id: I713ab10650f933a8218a61521868d6cd16cb821e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7308 Reviewed-on: https://chromium-review.googlesource.com/1082218Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#53474}
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: Ib0ad52916d6f5b65e7612981b467b491d832f505 Reviewed-on: https://chromium-review.googlesource.com/1075053 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#53473}
-
- 29 May, 2018 1 commit
-
-
Marja Hölttä authored
WeakFixedArray::Shrink is fragile when not used properly (might invalidate GC bookeeping (location of weak slots)). BUG=v8:7308 Change-Id: Id84329e2a78907f5f0bfafae32fc2a71b77edbe7 Reviewed-on: https://chromium-review.googlesource.com/1076236Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#53410}
-
- 24 May, 2018 1 commit
-
-
Georg Neis authored
Instead use the canonical empty fixed array. Some code assumes that this is the only fixed array of length 0. Bug: chromium:843062 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: If780acf50147c061a81f2ff2b31779fbd1c78559 Reviewed-on: https://chromium-review.googlesource.com/1064052Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53320}
-