1. 24 Jul, 2020 1 commit
  2. 17 Jul, 2019 1 commit
  3. 23 May, 2019 1 commit
  4. 01 Feb, 2019 2 commits
  5. 28 Jan, 2019 1 commit
  6. 11 Jan, 2019 1 commit
  7. 10 Jan, 2019 1 commit
  8. 13 Dec, 2018 1 commit
  9. 02 Dec, 2017 1 commit
    • Mathias Bynens's avatar
      Normalize casing of hexadecimal digits · 822be9b2
      Mathias Bynens authored
      This patch normalizes the casing of hexadecimal digits in escape
      sequences of the form `\xNN` and integer literals of the form
      `0xNNNN`.
      
      Previously, the V8 code base used an inconsistent mixture of uppercase
      and lowercase.
      
      Google’s C++ style guide uses uppercase in its examples:
      https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters
      
      Moreover, uppercase letters more clearly stand out from the lowercase
      `x` (or `u`) characters at the start, as well as lowercase letters
      elsewhere in strings.
      
      BUG=v8:7109
      TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org
      NOPRESUBMIT=true
      
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6
      Reviewed-on: https://chromium-review.googlesource.com/804294
      Commit-Queue: Mathias Bynens <mathias@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49810}
      822be9b2
  10. 13 Oct, 2017 1 commit
  11. 23 Feb, 2017 1 commit
  12. 26 Jan, 2017 1 commit
    • ahaas's avatar
      [wasm] Fix constant folding with signalling NaN. · 55aed782
      ahaas authored
      According to the WebAssembly spec no arithmetic operation should ever
      return a signalling NaN. With the constant folding in V8, however, it
      was possible that some arithmetic operations were elided, and if the
      input of the arithmetic operation was a signalling NaN, then also the
      result was the same signalling NaN. This CL removes some constant
      folding optimizations and adjusts others so that even with constant
      folding the result of an arithmetic operation is never a signalling NaN.
      
      R=titzer@chromium.org, rossberg@chromium.org, bmeurer@chromium.org
      
      Review-Url: https://codereview.chromium.org/2647353007
      Cr-Commit-Position: refs/heads/master@{#42694}
      55aed782
  13. 29 Aug, 2016 1 commit
    • bmeurer's avatar
      [turbofan] Remove invalid typing rules. · 285e1e15
      bmeurer authored
      Drop the typing rules for the machine operators and replace them
      with UNREACHABLE. These typing rules were never correct and there's
      also no need to have those rules at all.
      
      Drive-by-fix: Remove the extremely annoying test-simplified-lowering.cc
      file, which is not very useful, but consumes a large amount of time to
      keep it compiling and passing. Instead we should introduce appropriate
      tests for the SimplifiedLowering that also test something meaningful
      w/o just cementing the implementation.
      
      R=jarin@chromium.org
      BUG=v8:5267
      
      Review-Url: https://codereview.chromium.org/2292463002
      Cr-Commit-Position: refs/heads/master@{#38970}
      285e1e15
  14. 08 Aug, 2016 1 commit
  15. 04 Aug, 2016 1 commit
  16. 22 Jun, 2016 1 commit
  17. 11 Dec, 2015 1 commit
  18. 10 Dec, 2015 1 commit
    • jarin's avatar
      [turbofan] Make MachineType a pair of enums. · bb2a830d
      jarin authored
      MachineType is now a class with two enum fields:
      - MachineRepresentation
      - MachineSemantic
      
      Both enums are usable on their own, and this change switches some places from using MachineType to use just MachineRepresentation. Most notably:
      - register allocator now uses just the representation.
      - Phi and Select nodes only refer to representations.
      
      Review URL: https://codereview.chromium.org/1513543003
      
      Cr-Commit-Position: refs/heads/master@{#32738}
      bb2a830d
  19. 09 Dec, 2015 1 commit
  20. 07 Dec, 2015 1 commit
  21. 30 Oct, 2015 1 commit
    • mstarzinger's avatar
      Move compiler cctests into v8::internal::compiler namespace. · 16f13300
      mstarzinger authored
      This moves all cctest files for the compiler to live in the same
      namespace as the components they are testing. Hence we can avoid the
      forbidden using directives pulling in entire namespaces.
      
      From the Google C++ style guide: "You may not use a using-directive to
      make all names from a namespace available". This would be covered by
      presubmit linter checks if build/namespaces were not blacklisted.
      
      R=bmeurer@chromium.org
      
      Review URL: https://codereview.chromium.org/1424943004
      
      Cr-Commit-Position: refs/heads/master@{#31671}
      16f13300
  22. 28 Oct, 2015 2 commits
  23. 16 Oct, 2015 1 commit
    • mstarzinger's avatar
      [turbofan] Move SimplifiedOperatorBuilder into JSGraph. · b7990793
      mstarzinger authored
      This fixes the lifetime of nodes created by JSGlobalSpecialization that
      contain a simplified operator. In the case where this reducer runs as
      part of the inliner, the SimplifiedOperatorBuilder was instantiated with
      the wrong zone. This led to use-after-free of simplified operators.
      
      To avoid such situations in the future, we decided to move this operator
      builder into the JSGraph and make the situation uniform with all other
      operator builders.
      
      R=bmeurer@chromium.org
      BUG=chromium:543528
      LOG=n
      
      Review URL: https://codereview.chromium.org/1409993002
      
      Cr-Commit-Position: refs/heads/master@{#31334}
      b7990793
  24. 25 Sep, 2015 1 commit
    • jarin's avatar
      [turbofan] Check node input/use consistency for changed operators and new nodes. · 1c2867c0
      jarin authored
      Verifies consistency of node inputs and uses:
      - node inputs should agree with the input count computed from the node's operator.
      - effect inputs should have effect outputs (or be a sentinel).
      - control inputs should have control outputs (or be a sentinel).
      - frame state inputs should be frame states (or be a sentinel).
      - if the node has control uses, it should produce control.
      - if the node has effect uses, it should produce effect.
      - if the node has frame state uses, it must be a frame state.
      
      I also removed some tests, either because they did not seem to be useful (scheduler) or they tested dead functionality (diamond effect phi).
      
      Review URL: https://codereview.chromium.org/1368913002
      
      Cr-Commit-Position: refs/heads/master@{#30927}
      1c2867c0
  25. 23 Sep, 2015 3 commits
  26. 30 Jun, 2015 1 commit
    • bmeurer's avatar
      [turbofan] Remove unused constructor function matching from typer. · 722e2e2b
      bmeurer authored
      This optimization never triggers currently, and is inherently native
      context dependent for no real reason (for example it will not properly
      detect those constructors in the case of cross native context inlining),
      plus it is slow and awkward.  In case we really need this functionality
      at some point, we should find a way to make it work with the builtin
      function id mechanism that is already in place to match other builtins.
      
      R=jarin@chromium.org,rossberg@chromium.org
      
      Review URL: https://codereview.chromium.org/1221683006
      
      Cr-Commit-Position: refs/heads/master@{#29365}
      722e2e2b
  27. 24 Jun, 2015 1 commit
    • danno's avatar
      Use big-boy Types to annotate interface descriptor parameters · c019d7f4
      danno authored
      - Thread Type::FunctionType through stubs and the TF pipeline.
      - Augment Typer to decorate parameter nodes with types from
        a Type::FunctionType associated with interface descriptors.
      - Factor interface descriptors into platform-specific and
        platform-independent components so that all descriptors share
        a common Type::FunctionType for all platforms.
      
      Review URL: https://codereview.chromium.org/1197703002
      
      Cr-Commit-Position: refs/heads/master@{#29248}
      c019d7f4
  28. 20 Feb, 2015 3 commits
  29. 30 Jan, 2015 3 commits
  30. 23 Jan, 2015 1 commit
    • danno's avatar
      Remove the dependency of Zone on Isolate · c7b09aac
      danno authored
      Along the way:
      - Thread isolate parameter explicitly through code that used to
        rely on getting it from the zone.
      - Canonicalize the parameter position of isolate and zone for
        affected code
      - Change Hydrogen New<> instruction templates to automatically
        pass isolate
      
      R=mstarzinger@chromium.org
      LOG=N
      
      Review URL: https://codereview.chromium.org/868883002
      
      Cr-Commit-Position: refs/heads/master@{#26252}
      c7b09aac
  31. 21 Jan, 2015 1 commit
  32. 23 Dec, 2014 1 commit