- 09 Mar, 2018 1 commit
-
-
Erik Luo authored
- Label as "bigint" in DevTools heap snapshot viewer - Treat as new primitive in injected-script-source - Show primitive value as property for BigIntObject - Adds the "n" suffix onto description, both with/without inspector being present Bug: v8:7486 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I47a02e32f9bdd9124a6c91056965574ecd443867 Reviewed-on: https://chromium-review.googlesource.com/940804 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#51855}
-
- 20 Feb, 2018 1 commit
-
-
Mostyn Bramley-Moore authored
Followup after https://chromium-review.googlesource.com/c/v8/v8/+/919063 Bug: chromium:811842 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8e8a4a6d9192d39502514c5a19539965b74b1681 Reviewed-on: https://chromium-review.googlesource.com/925603Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#51383}
-
- 19 Feb, 2018 1 commit
-
-
Ulan Degenbaev authored
Bug: chromium:811842 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I72163abf0b20b123fb541fe0a1b168e036ef044e Reviewed-on: https://chromium-review.googlesource.com/919063 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#51360}
-
- 01 Dec, 2017 1 commit
-
-
Erik Luo authored
Similar to Firefox and Safari, calling console.time() repeatedly with the same label will now produce a console warning indicating that the label already exists. Similarly for console.timeEnd() as well. Bug: chromium:727514 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id644ee107b09e7f4686fff44c5f32d31c88371ad Reviewed-on: https://chromium-review.googlesource.com/794345 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49803}
-
- 23 Nov, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
If async stack is longer then max depth, we add externalParent as id, client can fetch next max depth async stacks by Debugger.getStackTrace. R=dgozman@chromium.org Bug: chromium:778796 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I89d461e672251f03fb239f4f16ae3b0374fce766 Reviewed-on: https://chromium-review.googlesource.com/776242 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#49595}
-
- 25 Sep, 2017 1 commit
-
-
Clemens Hammacher authored
Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an embedded comparison. This gives better error messages and also does the right comparison for signed/unsigned mismatches. This will allow us to reenable the readability/check cpplint check. R=yangguo@chromium.org Bug: v8:6837 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I88e5afea1ad0fdf23a81b380e64ff356bbc20112 Reviewed-on: https://chromium-review.googlesource.com/681374Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48138}
-
- 12 Jun, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
console.context(name:string) method returns console instance, this console instance fully implements console interface (including fact that any method can be called without console as receiver). Protocol.Runtime.consoleAPICalled notification contains additional context:string field: - "anonymous#unique-id" for any method call on unnamed console context, - "name#unique-id" for any method call on named console context. console.count and console.timeEnd have context as a scope. console.clear clear all messages regardless on what context instance it was called. console calls is ~10% slower with this CL since we need to store and then fetch console_context_id and console_context_name from function object. We recently (in April) made console calls twice faster so 10% doesn't sound critical and existing of console.log call in hot code is problem by itself. R=pfeldman@chromium.org Bug: chromium:728767 Change-Id: I5fc73216fb8b28bfe1e8c2c1b393ebfbe43cd02e Reviewed-on: https://chromium-review.googlesource.com/522128Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#45864}
-
- 01 Jun, 2017 1 commit
-
-
dgozman authored
This patch adds ability to connect multiple sessions to a single context group. This is an experimental feature, which is already supported in test harness. So far covered runtime domain with tests (and found a bug thanks to the test). More tests to follow in next patches, probably with code adjustments as well. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2906153002 Cr-Commit-Position: refs/heads/master@{#45667}
-
- 29 Mar, 2017 5 commits
-
-
kozyatinskiy authored
With this CL we don't need to store reference to InspectedContext inside of JavaScript console object and able to get all required information from callback data. It allows us to implement console methods without taking in account how and where we create and store these methods: - later we can move console object implementation to builtins.. - ..and install command line API methods smarter. BUG=chromium:588893 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2784713002 Cr-Original-Original-Commit-Position: refs/heads/master@{#44212} Committed: https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca915f4c Review-Url: https://codereview.chromium.org/2784713002 Cr-Original-Commit-Position: refs/heads/master@{#44238} Committed: https://chromium.googlesource.com/v8/v8/+/88f71126a5c067f98c75044bc26778f2e8ea2e79 Review-Url: https://codereview.chromium.org/2784713002 Cr-Commit-Position: refs/heads/master@{#44251}
-
kozyatinskiy authored
Revert of [inspector] console get all information from inspector when needed (patchset #5 id:80001 of https://codereview.chromium.org/2784713002/ ) Reason for revert: One more failed layout test. Original issue's description: > [inspector] console get all information from inspector when needed > > With this CL we don't need to store reference to InspectedContext inside of JavaScript console object and able to get all required information from callback data. > It allows us to implement console methods without taking in account how and where we create and store these methods: > - later we can move console object implementation to builtins.. > - ..and install command line API methods smarter. > > BUG=chromium:588893 > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2784713002 > Cr-Original-Commit-Position: refs/heads/master@{#44212} > Committed: https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca915f4c > Review-Url: https://codereview.chromium.org/2784713002 > Cr-Commit-Position: refs/heads/master@{#44238} > Committed: https://chromium.googlesource.com/v8/v8/+/88f71126a5c067f98c75044bc26778f2e8ea2e79 TBR=dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:588893 Review-Url: https://codereview.chromium.org/2778743007 Cr-Commit-Position: refs/heads/master@{#44246}
-
kozyatinskiy authored
With this CL we don't need to store reference to InspectedContext inside of JavaScript console object and able to get all required information from callback data. It allows us to implement console methods without taking in account how and where we create and store these methods: - later we can move console object implementation to builtins.. - ..and install command line API methods smarter. BUG=chromium:588893 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2784713002 Cr-Original-Commit-Position: refs/heads/master@{#44212} Committed: https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca915f4c Review-Url: https://codereview.chromium.org/2784713002 Cr-Commit-Position: refs/heads/master@{#44238}
-
machenbach authored
Revert of [inspector] console get all information from inspector when needed (patchset #4 id:60001 of https://codereview.chromium.org/2784713002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/14569 Original issue's description: > [inspector] console get all information from inspector when needed > > With this CL we don't need to store reference to InspectedContext inside of JavaScript console object and able to get all required information from callback data. > It allows us to implement console methods without taking in account how and where we create and store these methods: > - later we can move console object implementation to builtins.. > - ..and install command line API methods smarter. > > BUG=chromium:588893 > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2784713002 > Cr-Commit-Position: refs/heads/master@{#44212} > Committed: https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca915f4c TBR=dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:588893 Review-Url: https://codereview.chromium.org/2784603003 Cr-Commit-Position: refs/heads/master@{#44217}
-
kozyatinskiy authored
With this CL we don't need to store reference to InspectedContext inside of JavaScript console object and able to get all required information from callback data. It allows us to implement console methods without taking in account how and where we create and store these methods: - later we can move console object implementation to builtins.. - ..and install command line API methods smarter. BUG=chromium:588893 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2784713002 Cr-Commit-Position: refs/heads/master@{#44212}
-
- 30 Jan, 2017 1 commit
-
-
kozyatinskiy authored
Without this CL we have only limit for amount of console messages and if user are dumping a huge messages we pretty soon run out of memory. So let's introduce limit for memory consumption it would help chromium and Node.js as well. BUG=chromium:671489 R=dgozman@chomium.org,alph@chromium.org, hpayer@chromium.org, ulan@chromium.org Review-Url: https://codereview.chromium.org/2653293003 Cr-Commit-Position: refs/heads/master@{#42780}
-
- 27 Jan, 2017 1 commit
-
-
pfeldman authored
BUG=chromium:682521 Review-Url: https://codereview.chromium.org/2659913002 Cr-Commit-Position: refs/heads/master@{#42747}
-
- 25 Jan, 2017 1 commit
-
-
pfeldman authored
BUG=chromium:682521 Review-Url: https://codereview.chromium.org/2656613004 Cr-Commit-Position: refs/heads/master@{#42666}
-
- 22 Nov, 2016 1 commit
-
-
kozyatinskiy authored
This roll includes: - Support config.protocol.options which defines which part of protocol definition should be generated. [1] - [inspector_protocol] Allow custom json parser. [2] - [inspector_protocol] Allow overriding specific config values. [3] - [inspector_protocol] Fix NoneType error when parsing config_values. [4] - [inspector_protocol] Support chromium code style. [5] - [inspector_protocol] Support features for content/ generator. [6] - [inspector_protocol] Fixed domain_json["has_exports"] flag for exported domains [7] [1] https://codereview.chromium.org/2482993002 [2] https://codereview.chromium.org/2490733002 [3] https://codereview.chromium.org/2482093004 [4] https://codereview.chromium.org/2490823002 [5] https://codereview.chromium.org/2495353004 [6] https://codereview.chromium.org/2509573006 [7] https://codereview.chromium.org/2515343005 BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2523743003 Cr-Commit-Position: refs/heads/master@{#41195}
-
- 20 Oct, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:656823 R=dgozman@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2436783003 Cr-Commit-Position: refs/heads/master@{#40484}
-
- 13 Oct, 2016 1 commit
-
-
kozyatinskiy authored
If current locale has "," as decimal separator then message for consoleAPICalled will be corrupted. BUG=chromium:653424 R=dgozman@chromium.org Committed: https://crrev.com/dde5ef75cbac1eb7e2dae59b246e4a0d0ba6a0f4 Review-Url: https://codereview.chromium.org/2410933002 Cr-Original-Commit-Position: refs/heads/master@{#40190} Cr-Commit-Position: refs/heads/master@{#40288}
-
- 12 Oct, 2016 1 commit
-
-
machenbach authored
Revert of [inspector] fix timestamp formatting with non C locales (patchset #7 id:120001 of https://codereview.chromium.org/2410933002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10548 See also: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [inspector] fix timestamp formatting with non C locales > > If current locale has "," as decimal separator then message for consoleAPICalled will be corrupted. > > BUG=chromium:653424 > R=dgozman@chromium.org > > Committed: https://crrev.com/dde5ef75cbac1eb7e2dae59b246e4a0d0ba6a0f4 > Cr-Commit-Position: refs/heads/master@{#40190} TBR=dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:653424 Review-Url: https://codereview.chromium.org/2419453002 Cr-Commit-Position: refs/heads/master@{#40200}
-
- 11 Oct, 2016 1 commit
-
-
kozyatinskiy authored
If current locale has "," as decimal separator then message for consoleAPICalled will be corrupted. BUG=chromium:653424 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2410933002 Cr-Commit-Position: refs/heads/master@{#40190}
-
- 26 Sep, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2343733002 Cr-Commit-Position: refs/heads/master@{#39727}
-
- 21 Sep, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org TBR=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2338413003 Cr-Commit-Position: refs/heads/master@{#39608}
-
- 19 Sep, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2332243002 Cr-Commit-Position: refs/heads/master@{#39506}
-
- 10 Sep, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:642496 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2323173004 Cr-Commit-Position: refs/heads/master@{#39322}
-
- 06 Sep, 2016 1 commit
-
-
dgozman authored
- inspector becomes a dependency of v8_base; - generated public protocol files are placed to gen/v8/include/inspector/<Domain.h>; - added v8_enable_inspector_override to be used in embedders (gn only); - combined public headers into v8-inspector.h and v8-inspector-protocol.h. BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2292053003 Cr-Commit-Position: refs/heads/master@{#39226}
-
- 01 Sep, 2016 1 commit
-
-
dgozman authored
Attempt #2, formatted and disabled lint for src/inspector. BUG=chromium:635948 NOPRESUBMIT=true (for grammar check in license code) Review-Url: https://codereview.chromium.org/2292573002 Cr-Commit-Position: refs/heads/master@{#39107}
-
- 31 Aug, 2016 2 commits
-
-
machenbach authored
Revert of [inspector] Initial import of v8_inspector. (patchset #3 id:40001 of https://codereview.chromium.org/2292573002/ ) Reason for revert: Presubmit Original issue's description: > [inspector] Initial import of v8_inspector. > > BUG=chromium:635948 > NOPRESUBMIT=true (for code style) > > Committed: https://crrev.com/e29594ea3c5c41de0844e71f7a82c990a8da71ee > Cr-Commit-Position: refs/heads/master@{#39057} TBR=jochen@chromium.org,pfeldman@chromium.org,dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2300823002 Cr-Commit-Position: refs/heads/master@{#39058}
-
dgozman authored
BUG=chromium:635948 NOPRESUBMIT=true (for code style) Review-Url: https://codereview.chromium.org/2292573002 Cr-Commit-Position: refs/heads/master@{#39057}
-