- 03 Nov, 2016 1 commit
-
-
ulan authored
Revert of [heap] Add a guard for restarting the memory reducer after mark-compact. (patchset #1 id:1 of https://chromiumcodereview.appspot.com/2433933005/ ) Reason for revert: Speculative revert to see impact on crbug.com/659531 Original issue's description: > [heap] Add a guard for restarting the memory reducer after mark-compact. > > Currently it is possible to get into a cycle of > mark-compact -> memory reducer -> mark-compact -> memory reducer ... > where the memory reducer does not free memory. > > This patch ensures that the memory reducer restarts only if the > committed memory increased by sufficient amount after the last run. > > BUG= TBR=hpayer@chromium.org,davidroutier17@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2472053003 Cr-Commit-Position: refs/heads/master@{#40737}
-
- 21 Oct, 2016 1 commit
-
-
hpayer authored
Additionally, remove all code related to the old-style slots filtering and black area end markers. BUG=chromium:648568 Review-Url: https://chromiumcodereview.appspot.com/2440683002 Cr-Commit-Position: refs/heads/master@{#40494}
-
- 20 Oct, 2016 1 commit
-
-
ulan authored
Currently it is possible to get into a cycle of mark-compact -> memory reducer -> mark-compact -> memory reducer ... where the memory reducer does not free memory. This patch ensures that the memory reducer restarts only if the committed memory increased by sufficient amount after the last run. BUG= Review-Url: https://chromiumcodereview.appspot.com/2433933005 Cr-Commit-Position: refs/heads/master@{#40457}
-
- 18 Oct, 2016 1 commit
-
-
hpayer authored
BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2428493003 Cr-Commit-Position: refs/heads/master@{#40393}
-
- 14 Oct, 2016 2 commits
-
-
jochen authored
R=ulan@chromium.org,cbruni@chromium.org,rmcilroy@chromium.org BUG=v8:5215 Review-Url: https://codereview.chromium.org/2413243002 Cr-Commit-Position: refs/heads/master@{#40295}
-
machenbach authored
Revert of [heap] Move slot filtering logic into sweeper. (patchset #4 id:60001 of https://codereview.chromium.org/2418773002/ ) Reason for revert: [Sheriff] Speculative revert for heap corruption on all platforms, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/12377 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/12379 https://build.chromium.org/p/client.v8/builders/V8%20Win32/builds/4819 https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/16783 https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20-%20debug/builds/10007 Original issue's description: > [heap] Move slot filtering logic into sweeper. > > BUG=chromium:648568 > > Committed: https://crrev.com/18db69c38c93450c1ae957999fc48c465f111f00 > Cr-Commit-Position: refs/heads/master@{#40267} TBR=ulan@chromium.org,mlippautz@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2418053002 Cr-Commit-Position: refs/heads/master@{#40292}
-
- 13 Oct, 2016 1 commit
-
-
hpayer authored
BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2418773002 Cr-Commit-Position: refs/heads/master@{#40267}
-
- 07 Oct, 2016 1 commit
-
-
hpayer authored
BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2397373002 Cr-Commit-Position: refs/heads/master@{#40075}
-
- 05 Oct, 2016 1 commit
-
-
hpayer authored
BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2390743005 Cr-Commit-Position: refs/heads/master@{#39982}
-
- 28 Sep, 2016 1 commit
-
-
ulan authored
This patch replaces cumulative counters with the counters for the current GC cycle. It also replaces the ring buffer of record incremental marking speeds with a single variable. Review-Url: https://codereview.chromium.org/2361563004 Cr-Commit-Position: refs/heads/master@{#39826}
-
- 26 Sep, 2016 1 commit
-
-
hpayer authored
BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2366393002 Cr-Commit-Position: refs/heads/master@{#39735}
-
- 22 Sep, 2016 2 commits
-
-
machenbach authored
Revert of [heap] Reland Concurrently free empty typed slot set chunks. (patchset #2 id:20001 of https://codereview.chromium.org/2365603002/ ) Reason for revert: Leaks and TSAN: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/15441 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11867 Original issue's description: > [heap] Reland Concurrently free empty typed slot set chunks. > > BUG=chromium:648568 > > Committed: https://crrev.com/ec3835751d678c0b4a3fda47d11ffa107cd27e23 > Cr-Commit-Position: refs/heads/master@{#39630} TBR=ulan@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2364603002 Cr-Commit-Position: refs/heads/master@{#39632}
-
hpayer authored
BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2365603002 Cr-Commit-Position: refs/heads/master@{#39630}
-
- 21 Sep, 2016 3 commits
-
-
adamk authored
Revert of [heap] Concurrently free empty typed slot set chunks. (patchset #3 id:40001 of https://codereview.chromium.org/2352423002/ ) Reason for revert: TSAN failures on Linux64: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11850 Also saw various threading-related flakiness on multiple bots. Original issue's description: > [heap] Concurrently free empty typed slot set chunks. > > BUG=chromium:648568 > > Committed: https://crrev.com/ff8101d8e8d5e14dfa89de1252c510e6a0775539 > Cr-Commit-Position: refs/heads/master@{#39605} TBR=ulan@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2358333002 Cr-Commit-Position: refs/heads/master@{#39607}
-
hpayer authored
BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2352423002 Cr-Commit-Position: refs/heads/master@{#39605}
-
hpayer authored
BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2360513002 Cr-Commit-Position: refs/heads/master@{#39596}
-
- 07 Sep, 2016 1 commit
-
-
ulan authored
Now callers of Heap::CollectGarbage* functions need to specify the reason as an enum value instead of a string. Subsequent CL will add stats counter for GC reason. BUG= Review-Url: https://codereview.chromium.org/2310143002 Cr-Commit-Position: refs/heads/master@{#39239}
-
- 25 Aug, 2016 1 commit
-
-
mlippautz authored
Record details, such as cumulative duration, number of steps, and longest steps in IncrementalMarkingDetails which get populated at a single callsite (AddScopeSample). Remove member fields that thus become obsolete (unfortunately not all of them). Additional remove some dead code and refactor printing. Printing in a single statement allows for using logcat on Android. This should also address the regression in chromium:640524. BUG=chromium:639818,chromium:640524 R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2269093002 Cr-Commit-Position: refs/heads/master@{#38912}
-
- 23 Aug, 2016 3 commits
-
-
mlippautz authored
Before this patch all tracing scopes in incremental marking would be reset during a gc tracer start/stop cycle. This patch handles scopes the same way it does other incremental marking metrics. Also: - Align finalization metric with regular marking metric. - Smaller cleanups BUG=chromium:639818 Review-Url: https://codereview.chromium.org/2273673002 Cr-Commit-Position: refs/heads/master@{#38834}
-
mlippautz authored
Revert of [heap] Tracer: Handle incremental marking scopes (patchset #4 id:100001 of https://codereview.chromium.org/2264033002/ ) Reason for revert: Unittest fails on win32 debug: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/4188/steps/Check/logs/GCTracerTest.Incremen.. Original issue's description: > [heap] Tracer: Handle incremental marking scopes > > Before this patch all tracing scopes in incremental marking would be reset > during a gc tracer start/stop cycle. This patch handles scopes the same way it > does other incremental marking metrics. > > Also: > - Align finalization metric with regular marking metric. > - Smaller cleanups > > BUG=chromium:639818 > R=jochen@chromium.org > > Committed: https://crrev.com/300a8f97472b88ff2f94eb977c36b4bf1bedabf1 > Cr-Commit-Position: refs/heads/master@{#38822} TBR=jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:639818 Review-Url: https://codereview.chromium.org/2275583002 Cr-Commit-Position: refs/heads/master@{#38827}
-
mlippautz authored
Before this patch all tracing scopes in incremental marking would be reset during a gc tracer start/stop cycle. This patch handles scopes the same way it does other incremental marking metrics. Also: - Align finalization metric with regular marking metric. - Smaller cleanups BUG=chromium:639818 R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2264033002 Cr-Commit-Position: refs/heads/master@{#38822}
-
- 01 Aug, 2016 1 commit
-
-
hpayer authored
BUG=chromium:630969,chromium:630386 Review-Url: https://codereview.chromium.org/2186863005 Cr-Commit-Position: refs/heads/master@{#38195}
-
- 28 Jul, 2016 1 commit
-
-
hpayer authored
Revert of [heap] Reland "Remove black pages and use black areas instead." (patchset #4 id:60001 of https://codereview.chromium.org/2185613002/ ) Reason for revert: Still crashing. Original issue's description: > [heap] Reland "Remove black pages and use black areas instead." > > BUG=chromium:630969,chromium:630386 > LOG=n > > Committed: https://crrev.com/9e37a07c8de0a20ef2681e26824ff4d329102603 > Cr-Commit-Position: refs/heads/master@{#38057} TBR=ulan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:630969,chromium:630386 Review-Url: https://codereview.chromium.org/2183383004 Cr-Commit-Position: refs/heads/master@{#38129}
-
- 26 Jul, 2016 1 commit
-
-
hpayer authored
BUG=630969,630386 LOG=n Review-Url: https://codereview.chromium.org/2185613002 Cr-Commit-Position: refs/heads/master@{#38057}
-
- 25 Jul, 2016 1 commit
-
-
yangguo authored
Revert of [heap] Remove black pages and use black areas instead. (patchset #6 id:100001 of https://codereview.chromium.org/2160613002/ ) Reason for revert: Suspected to cause crbug.com/630969 Original issue's description: > [heap] Remove black pages and use black areas instead. > > BUG=630386 > LOG=n > > Committed: https://crrev.com/b008a0d5a3db80a854cb93d9c94d67bf2d780f2c > Cr-Commit-Position: refs/heads/master@{#37967} TBR=ulan@chromium.org,hpayer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=630386 Review-Url: https://codereview.chromium.org/2176133002 Cr-Commit-Position: refs/heads/master@{#38006}
-
- 22 Jul, 2016 1 commit
-
-
hpayer authored
BUG=630386 LOG=n Review-Url: https://codereview.chromium.org/2160613002 Cr-Commit-Position: refs/heads/master@{#37967}
-
- 12 Jul, 2016 1 commit
-
-
hpayer authored
BUG= Review-Url: https://codereview.chromium.org/2139133003 Cr-Commit-Position: refs/heads/master@{#37685}
-
- 03 Jun, 2016 1 commit
-
-
ahaas authored
We need the host address in another CL to clear invalid slots. R=ulan@chromium.org Review-Url: https://codereview.chromium.org/2025833002 Cr-Commit-Position: refs/heads/master@{#36696}
-
- 29 Mar, 2016 2 commits
-
-
ulan authored
This avoids redundant casts, loss of precision, and potential overflows. BUG=chromium:597310 LOG=NO Review URL: https://codereview.chromium.org/1841043002 Cr-Commit-Position: refs/heads/master@{#35113}
-
ulan authored
Now instead of saving all event details in the ring buffer, we save only the bytes and duration. This reduces the GCTracer size from 20K to 3K and simplifies code. BUG=chromium:597310 LOG=NO Review URL: https://codereview.chromium.org/1830723004 Cr-Commit-Position: refs/heads/master@{#35104}
-
- 21 Mar, 2016 1 commit
-
-
mlippautz authored
Now that we have page-local remembered sets (due to refilling in page granularity) we can perform all updates on the sets during compaction in parallel without caching slots locally. BUG=chromium:524425 LOG=N NOTRY=true Review URL: https://codereview.chromium.org/1811573002 Cr-Commit-Position: refs/heads/master@{#34952}
-
- 25 Feb, 2016 1 commit
-
-
ulan authored
Reland "Replace slots buffer with remembered set. (patchset #14 id:250001 of https://codereview.chromium.org/1703823002/ )" This reverts commit 9146bc5e. This contains a fix for the following crash: 1. We record slots for a fixed array. 2. We trim the fixed array, so that some recorded slots are now in free space. 3. During mark-compact we sweep the page with the fixed array. Now free list items contain memory with recorded slots. 4. We evacuate a byte array using the new free list items. 5. We iterate slots that are now inside the byte array and crash. BUG=chromium:589413,chromium:578883 LOG=NO Review URL: https://codereview.chromium.org/1735523002 Cr-Commit-Position: refs/heads/master@{#34302}
-
- 24 Feb, 2016 1 commit
-
-
ulan authored
Revert of Replace slots buffer with remembered set. (patchset #14 id:250001 of https://codereview.chromium.org/1703823002/ ) Reason for revert: Revert because of canary crashes: crbug.com/589413 Original issue's description: > Replace slots buffer with remembered set. > > Slots pointing to evacuation candidates are now recorded in the new RememberedSet<OLD_TO_OLD>. > > The remembered set is extended to support typed slots. > > During parallel evacuation all migration slots are recorded in local slots buffers. > After evacuation all local slots are added to the remembered set. > > BUG=chromium:578883 > LOG=NO > > Committed: https://crrev.com/2285a99ef6f7d52f4f0c4d88a7db4224443ee152 > Cr-Commit-Position: refs/heads/master@{#34212} TBR=jochen@chromium.org,hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:578883 Review URL: https://codereview.chromium.org/1725073003 Cr-Commit-Position: refs/heads/master@{#34238}
-
- 23 Feb, 2016 1 commit
-
-
ulan authored
Slots pointing to evacuation candidates are now recorded in the new RememberedSet<OLD_TO_OLD>. The remembered set is extended to support typed slots. During parallel evacuation all migration slots are recorded in local slots buffers. After evacuation all local slots are added to the remembered set. BUG=chromium:578883 LOG=NO Review URL: https://codereview.chromium.org/1703823002 Cr-Commit-Position: refs/heads/master@{#34212}
-
- 22 Feb, 2016 1 commit
-
-
ulan authored
BUG=chromium:587574 LOG=NO Review URL: https://codereview.chromium.org/1705183003 Cr-Commit-Position: refs/heads/master@{#34188}
-
- 17 Feb, 2016 1 commit
-
-
ulan authored
If sweeping is in progress then we need to filter out slots in free space after array trimming, because the sweeper will add the free space into free list. This CL also fixes a bug in SlotSet::RemoveRange. BUG=chromium:587004 LOG=NO TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/1701963003 Cr-Commit-Position: refs/heads/master@{#34071}
-
- 08 Feb, 2016 1 commit
-
-
ulan authored
This replaces the global remembered set with per-page remembered sets. Each page in the old space, map space, and large object space keeps track of the set of slots in the page pointing to the new space. The data structure for storing slot sets is a two-level bitmap, which allows us to remove the store buffer overflow and SCAN_ON_SCAVENGE logic. Design doc: https://goo.gl/sMKCf7 BUG=chromium:578883 LOG=NO Review URL: https://codereview.chromium.org/1608583002 Cr-Commit-Position: refs/heads/master@{#33806}
-
- 27 Oct, 2015 1 commit
-
-
ulan authored
BUG=chromium:490559 LOG=NO Review URL: https://codereview.chromium.org/1420363004 Cr-Commit-Position: refs/heads/master@{#31600}
-
- 08 Oct, 2015 1 commit
-
-
mlippautz authored
See bug report. R=ulan@chromium.org BUG=chromium:538567 LOG=N Review URL: https://codereview.chromium.org/1393293002 Cr-Commit-Position: refs/heads/master@{#31179}
-
- 02 Oct, 2015 1 commit
-
-
ulan authored
This restores size_of_objects and removed unused fields. BUG=chromium:538539 LOG=NO Review URL: https://codereview.chromium.org/1380953003 Cr-Commit-Position: refs/heads/master@{#31072}
-