1. 11 Oct, 2019 1 commit
  2. 23 May, 2019 3 commits
  3. 20 May, 2019 1 commit
  4. 18 Jan, 2019 1 commit
  5. 29 Nov, 2018 1 commit
  6. 24 Nov, 2018 1 commit
  7. 13 Nov, 2018 1 commit
  8. 24 Aug, 2018 1 commit
  9. 17 Jul, 2018 1 commit
  10. 05 Jun, 2018 1 commit
  11. 08 Nov, 2017 1 commit
  12. 06 Nov, 2017 1 commit
    • Clemens Hammacher's avatar
      Reland "[bits] Consolidate Count{Leading,Trailing}Zeros" · 27ffc624
      Clemens Hammacher authored
      This is a reland of 7d231e57, fixed to
      avoid instantiating CountLeadingZeros for bits==0.
      
      Original change's description:
      > [bits] Consolidate Count{Leading,Trailing}Zeros
      > 
      > Instead of having one method for 32 bit integers and one for 64 bit,
      > plus a templatized version to choose from those two, just implement one
      > version which handles unsigned integers of any size. Also, make them
      > constexpr.
      > The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
      > order to keep the amount of code changes small. Also, sometimes it
      > improves readability by stating exactly the size of the argument,
      > especially for leading zeros (where zero-extending would add more
      > leading zeros).
      > 
      > CountLeadingZeros now uses a binary search inspired implementation
      > as proposed in Hacker's Delight. It's more than 20% faster on x64 if
      > the builtins are disabled.
      > CountTrailingZeros falls back to CountPopulation instead of counting in
      > a naive loop. This is ~50% faster.
      > 
      > R=mstarzinger@chromium.org
      > 
      > Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
      > Reviewed-on: https://chromium-review.googlesource.com/741231
      > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#49106}
      
      Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee
      Reviewed-on: https://chromium-review.googlesource.com/753903Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49138}
      27ffc624
  13. 04 Nov, 2017 1 commit
    • Michael Achenbach's avatar
      Revert "[bits] Consolidate Count{Leading,Trailing}Zeros" · 1a1968fe
      Michael Achenbach authored
      This reverts commit 7d231e57.
      
      Reason for revert: Breaks revert for win-clang:
      https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/342755
      
      Original change's description:
      > [bits] Consolidate Count{Leading,Trailing}Zeros
      > 
      > Instead of having one method for 32 bit integers and one for 64 bit,
      > plus a templatized version to choose from those two, just implement one
      > version which handles unsigned integers of any size. Also, make them
      > constexpr.
      > The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
      > order to keep the amount of code changes small. Also, sometimes it
      > improves readability by stating exactly the size of the argument,
      > especially for leading zeros (where zero-extending would add more
      > leading zeros).
      > 
      > CountLeadingZeros now uses a binary search inspired implementation
      > as proposed in Hacker's Delight. It's more than 20% faster on x64 if
      > the builtins are disabled.
      > CountTrailingZeros falls back to CountPopulation instead of counting in
      > a naive loop. This is ~50% faster.
      > 
      > R=​mstarzinger@chromium.org
      > 
      > Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
      > Reviewed-on: https://chromium-review.googlesource.com/741231
      > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#49106}
      
      TBR=mstarzinger@chromium.org,clemensh@chromium.org
      
      Change-Id: Iceeb35bf9c7539a1013c9bdbc47118008611bef2
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/753463Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49123}
      1a1968fe
  14. 03 Nov, 2017 1 commit
    • Clemens Hammacher's avatar
      [bits] Consolidate Count{Leading,Trailing}Zeros · 7d231e57
      Clemens Hammacher authored
      Instead of having one method for 32 bit integers and one for 64 bit,
      plus a templatized version to choose from those two, just implement one
      version which handles unsigned integers of any size. Also, make them
      constexpr.
      The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in
      order to keep the amount of code changes small. Also, sometimes it
      improves readability by stating exactly the size of the argument,
      especially for leading zeros (where zero-extending would add more
      leading zeros).
      
      CountLeadingZeros now uses a binary search inspired implementation
      as proposed in Hacker's Delight. It's more than 20% faster on x64 if
      the builtins are disabled.
      CountTrailingZeros falls back to CountPopulation instead of counting in
      a naive loop. This is ~50% faster.
      
      R=mstarzinger@chromium.org
      
      Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e
      Reviewed-on: https://chromium-review.googlesource.com/741231Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49106}
      7d231e57
  15. 18 Oct, 2017 1 commit
  16. 10 Jul, 2017 1 commit
  17. 31 May, 2017 1 commit
  18. 09 Jan, 2017 1 commit
  19. 18 Nov, 2016 1 commit
  20. 20 Aug, 2015 1 commit
  21. 11 Aug, 2015 1 commit
    • bmeurer's avatar
      [runtime] Store constructor function index on primitive maps. · 6c743b2b
      bmeurer authored
      This way we can greatly simplify the different variants of ToObject in
      our codebase and make them more uniform and robust.  Adding a new
      primitive doesn't require finding and changing all those places again,
      but it is sufficient to setup the constructor function index when
      allocating the map.
      
      We use the inobject properties field of Map, which is invalid primitive
      maps anyway.
      
      R=jkummerow@chromium.org
      
      Review URL: https://codereview.chromium.org/1276533003
      
      Cr-Commit-Position: refs/heads/master@{#30119}
      6c743b2b
  22. 01 Jun, 2015 1 commit
  23. 21 Apr, 2015 4 commits
    • jochen's avatar
      Revert of Reland "LayoutDescriptor should inherit from JSTypedArray" (patchset... · 1692380f
      jochen authored
      Revert of Reland "LayoutDescriptor should inherit from JSTypedArray" (patchset #3 id:40001 of https://codereview.chromium.org/1094333002/)
      
      Reason for revert:
      Breaks gbemu
      
      Original issue's description:
      > Reland "LayoutDescriptor should inherit from JSTypedArray"
      >
      > Original issue's description:
      > > LayoutDescriptor should inherit from JSTypedArray
      > >
      > > It can't just inherit from a FixedTypedArray-like type, as we soon
      > > assume that a FixedTypedArray-like type is always held by an
      > > ArrayBufferView-like type
      > >
      > > BUG=v8:3996
      > > R=ishell@chromium.org,verwaest@chromium.org
      > > LOG=n
      >
      > BUG=v8:3996
      > R=ishell@chromium.org,verwaest@chromium.org
      > LOG=n
      
      TBR=ishell@chromium.org,verwaest@chromium.org
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:3996
      
      Review URL: https://codereview.chromium.org/1080403004
      
      Cr-Commit-Position: refs/heads/master@{#27975}
      1692380f
    • jochen's avatar
      Reland "LayoutDescriptor should inherit from JSTypedArray" · d20660e0
      jochen authored
      Original issue's description:
      > LayoutDescriptor should inherit from JSTypedArray
      >
      > It can't just inherit from a FixedTypedArray-like type, as we soon
      > assume that a FixedTypedArray-like type is always held by an
      > ArrayBufferView-like type
      >
      > BUG=v8:3996
      > R=ishell@chromium.org,verwaest@chromium.org
      > LOG=n
      
      BUG=v8:3996
      R=ishell@chromium.org,verwaest@chromium.org
      LOG=n
      
      Review URL: https://codereview.chromium.org/1094333002
      
      Cr-Commit-Position: refs/heads/master@{#27973}
      d20660e0
    • jochen's avatar
      Revert of LayoutDescriptor should inherit from JSTypedArray (patchset #1 id:1... · 8a309a1e
      jochen authored
      Revert of LayoutDescriptor should inherit from JSTypedArray (patchset #1 id:1 of https://codereview.chromium.org/1084793004/)
      
      Reason for revert:
      breaks mjsunit on debug bots
      
      Original issue's description:
      > LayoutDescriptor should inherit from JSTypedArray
      >
      > It can't just inherit from a FixedTypedArray-like type, as we soon
      > assume that a FixedTypedArray-like type is always held by an
      > ArrayBufferView-like type
      >
      > BUG=v8:3996
      > R=ishell@chromium.org,verwaest@chromium.org
      > LOG=n
      
      TBR=ishell@chromium.org,verwaest@chromium.org
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:3996
      
      Review URL: https://codereview.chromium.org/1073053006
      
      Cr-Commit-Position: refs/heads/master@{#27968}
      8a309a1e
    • jochen's avatar
      LayoutDescriptor should inherit from JSTypedArray · 6d79ceb2
      jochen authored
      It can't just inherit from a FixedTypedArray-like type, as we soon
      assume that a FixedTypedArray-like type is always held by an
      ArrayBufferView-like type
      
      BUG=v8:3996
      R=ishell@chromium.org,verwaest@chromium.org
      LOG=n
      
      Review URL: https://codereview.chromium.org/1084793004
      
      Cr-Commit-Position: refs/heads/master@{#27964}
      6d79ceb2
  24. 16 Apr, 2015 1 commit
  25. 30 Mar, 2015 1 commit
  26. 16 Feb, 2015 1 commit
  27. 12 Feb, 2015 1 commit
  28. 30 Jan, 2015 1 commit
  29. 15 Dec, 2014 1 commit
  30. 11 Nov, 2014 1 commit
  31. 10 Nov, 2014 2 commits