- 10 Jun, 2020 1 commit
-
-
Ng Zhi An authored
unsigned is (uint32_t) in both branches, so the cast can be removed. See https://clang.llvm.org/extra/clang-tidy/checks/google-readability-casting.html and https://google.github.io/styleguide/cppguide.html#Casting. Bug: v8:10488 Change-Id: I6d669e36509049fde449d8455c34d140f95b9b8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2233989 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68303}
-
- 30 Mar, 2020 1 commit
-
-
Clemens Backes authored
If the type check fails, we should return. Otherwise we hit an error in ToLocalChecked below. R=yangguo@chromium.org Bug: chromium:1061673 Change-Id: I39e5b90b3574d0d2b77f5d704023aabb1c8130cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116035Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66901}
-
- 09 Mar, 2020 1 commit
-
-
Dan Elphick authored
String::NewFromLiteral is a templated function that takes a char[N] argument that can be used as an alternative to String::NewFromUtf8 and returns a Local<String> rather than a MaybeLocal<String> reducing the number of ToLocalChecked() or other checks. Since the string length is known at compile time, it can statically assert that the length is less than String::kMaxLength, which means that it can never fail at runtime. This also converts all found uses of NewFromUtf8 taking a string literal or a variable initialized from a string literal to use the new API. In some cases the types of stored string literals are changed from const char* to const char[] to ensure the size is retained. This API does introduce a small difference compared to NewFromUtf8. For a case like "abc\0def", NewFromUtf8 (using length -1 to infer length) would treat this as a 3 character string, whereas the new API will treat it as a 7 character string. As a drive-by fix, this also fixes all redundant uses of v8::NewStringType::kNormal when passed to any of the String::New* functions. Change-Id: Id96a44bc068d9c4eaa634aea688e024675a0e5b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2089935 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#66622}
-
- 24 Jul, 2019 1 commit
-
-
Tianyou Li authored
In windows, even use clang build, the V8_LIBC_MSVCRT was set to indicate use MSVC runtime libraries. Change to use __clang__ to determine enable cpuid magic inline assembly or not. Change-Id: I7372a27b311b695f019c5ff2d42b691d749eb607 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1715332Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Tianyou Li <tianyou.li@intel.com> Cr-Commit-Position: refs/heads/master@{#62884}
-
- 16 Jul, 2019 1 commit
-
-
Tianyou Li authored
Add CPU trace mark extension for adding a magic instruction like 'cpuid' to the code stream when perform trace collection. This feature can be enabled by --expose-cputracemark-as=THE_NAME_YOU_SPECIFIED option. Change-Id: I33e94793cddf4956dbb3ddddf2f599420aa4a945 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1699749 Commit-Queue: Tianyou Li <tianyou.li@intel.com> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#62749}
-