- 19 Apr, 2013 1 commit
-
-
danno@chromium.org authored
This will make it easier to use other STL headers in the future Review URL: https://codereview.chromium.org/14362023 Patch from Jochen Eisinger <jochen@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14352 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Apr, 2013 3 commits
-
-
jkummerow@chromium.org authored
Review URL: https://codereview.chromium.org/13760003 Patch from Haitao Feng <haitao.feng@intel.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14282 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
Review URL: https://codereview.chromium.org/13932006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14280 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yurys@chromium.org authored
Also OS::Sleep(interval_) is used to pause sampling thread on all platforms. It makes no sense to send signal once 900mks to compensate 100mks delay on signal delivery as the signals would be delivered once 900mks. BUG=None Review URL: https://codereview.chromium.org/14238007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14278 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Apr, 2013 1 commit
-
-
yurys@chromium.org authored
This is a first step to having profiler sampler implementation in one file with platform capabilities guarded with #ifdef. Otherwise we have very similar implementations scattered over platform-*.cc files which makes it hard to see differences and make changes. The next steps will be to merge win32, Mac OS X and Cygwin implementations into sampler.cc They suspend profiled thread instead of sending a signal but apart from that the logic is pretty much the same. Then I'm going to move sampler-related code from log.* into sampler.* BUG=None Review URL: https://codereview.chromium.org/13852005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14265 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Apr, 2013 1 commit
-
-
yurys@chromium.org authored
Assuming that the value on top of stack is return address for a frameless invocation is error-prone. Corresponding logic was removed from profile-generator.cc in r14205 (see https://code.google.com/p/v8/source/diff?spec=svn14205&r=14205&format=side&path=/branches/bleeding_edge/src/profile-generator.cc) and now it is time to remove it from the tick processor. Since the tos is not used anymore by profiler it is also removed from TickSample. BUG=None Review URL: https://codereview.chromium.org/13873009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14252 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Apr, 2013 1 commit
-
-
yurys@chromium.org authored
The new test checks full CPU profiling cycle: using public V8 API it starts profiling, executes a script, stops profiling and analyzes collected profile to check that its top-down tree has expected strutcture. The script that is being profiled is guaranteed to run > 200ms to make sure enough samples are collected. To avoid possible flakiness due to non-deterministic time required to start new thread on varios OSs when Sampler and ProfilerEventsProcessor threads are being started the main thread is blocked until the threads are running. Also I removed the heuristic in profile-generator.cc where we try to figure out if the value on top of the sampled stack is return address of some frameless stub invocation. The code periodically gives false positive with the new test ending up in an extra node in the collected cpu profile. After discussion with jkummerow@ we concluded that the logic is too fragile and that we can address frameless stub invocations in a more reliable way later should they have a noticeable effect on cpu profiling. BUG=None Review URL: https://codereview.chromium.org/13627002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14205 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Mar, 2013 1 commit
-
-
mstarzinger@chromium.org authored
R=jkummerow@chromium.org BUG=chromium:196330 Review URL: https://codereview.chromium.org/12790012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14025 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Mar, 2013 1 commit
-
-
yurys@chromium.org authored
This reverts commit r13735 as CPU profiler data is inaccurate after that change. BUG=v8:2571 Review URL: https://codereview.chromium.org/12592002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13851 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Feb, 2013 1 commit
-
-
yurys@chromium.org authored
The patch is based on the previous one that was rolled out: https://code.google.com/p/v8/source/detail?r=12985 On Linux sampling for CPU profiler is initiated on the profiler event processor thread, other platforms to follow. CPU profiler continues to use SamplingCircularQueue, we will replave it with a single sample buffer when Mac and Win ports support profiling on the event processing thread. When --prof option is specified profiling is initiated either on the profiler event processor thread if CPU profiler is on or on the SignalSender thread as it used to if no CPU profiles are being collected. ProfilerEventsProcessor::ProcessEventsAndDoSample now waits in a tight loop, processing collected samples until sampling interval expires. To save CPU resources I'm planning to change that to use nanosleep as only one sample is expected in the queue at any point. BUG=v8:2364 Review URL: https://codereview.chromium.org/12321046 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13735 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Feb, 2013 1 commit
-
-
hpayer@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/12089107 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13676 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Dec, 2012 1 commit
-
-
rossberg@chromium.org authored
Currently only supported on Linux. When compiled with GCC, also demangles C++ identifier names. Should make debugging those flaky crashes on buildbots easier... :) R=mstarzinger@chromium.org,ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/11577019 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Nov, 2012 1 commit
-
-
jkummerow@chromium.org authored
This reverts r12985. Review URL: https://codereview.chromium.org/11428103 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13104 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Nov, 2012 1 commit
-
-
jkummerow@chromium.org authored
Review URL: https://codereview.chromium.org/11418149 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13054 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Nov, 2012 1 commit
-
-
jkummerow@chromium.org authored
- perform CPU profiler sampling in the sampler thread as we used to; - skip sampling in the sampling thread if processing thread is running; - only install SIGPROF handler when CPU profiling is enabled. BUG=v8:2364 Review URL: https://codereview.chromium.org/11231002 Patch from Sergey Rogulenko <rogulenko@google.com> and Andrey Kosyakov <caseq@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12985 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Oct, 2012 1 commit
-
-
mstarzinger@chromium.org authored
The patch introduces CommittedPhysicalMemory function to the Heap class that reports committed *physical* memory acquired for the heap from the OS. It is important because some OSes may defer actual committment on e.g. first access to the region. So reporting just plain committed size led to various weird artifacts like showing V8 allocated memory higher than the whole process private size. BUG=v8:2191 Review URL: https://codereview.chromium.org/11066118 Patch from Alexei Filippov <alph@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12793 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Oct, 2012 1 commit
-
-
danno@chromium.org authored
Some ARM architectures load 32-bit immediate constants more efficiently using movw/movt pairs rather than constant pool loads. This patch allows the assembler to generate one or the other load form at runtime depending on what is faster. R=ulan@chromium.org Review URL: https://codereview.chromium.org/11037023 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12755 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Oct, 2012 1 commit
-
-
jkummerow@chromium.org authored
This reverts r12649 and r12650. BUG=v8:2364 Review URL: https://codereview.chromium.org/11193020 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12745 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Oct, 2012 1 commit
-
-
jkummerow@chromium.org authored
BUG=None Review URL: https://codereview.chromium.org/10857035 Patch from Sergey Rogulenko <rogulenko@google.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12649 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Oct, 2012 1 commit
-
-
mstarzinger@chromium.org authored
Original message: Implement committed physical memory stats for Linux. This had to be reverted because it crashes when compiled into Chromium due to the sandbox not allowing the mincore call. R=verwaest@chromium.org BUG=v8:2191 Review URL: https://codereview.chromium.org/11023010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12640 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Sep, 2012 1 commit
-
-
mstarzinger@chromium.org authored
The patch introduces CommittedPhysicalMemory function to the Heap class that reports committed *physical* memory acquired from the OS. It is important because some OSes may postpone actual commitment on e.g. first access to the previously committed region. So reporting just plain committed size led to various weird artifacts like DevTools showing V8 allocated memory higher than the whole process private size. BUG=v8:2191 Review URL: https://codereview.chromium.org/10961042 Patch from Alexei Filippov <alph@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Sep, 2012 1 commit
-
-
yangguo@chromium.org authored
BUG=v8:1445 Review URL: https://chromiumcodereview.appspot.com/10919314 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12522 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Aug, 2012 2 commits
-
-
ulan@chromium.org authored
R=yangguo@chromium.org Review URL: https://chromiumcodereview.appspot.com/10880004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12365 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ulan@chromium.org authored
According to Web IDL spec, we should round to the nearest integer, choosing the even integer if it lies halfway between two. R=yangguo@chromium.org,kbr@chromium.org BUG=v8:2294 Review URL: https://chromiumcodereview.appspot.com/10831409 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12364 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Jul, 2012 1 commit
-
-
mstarzinger@chromium.org authored
BUG=none TEST=manual Review URL: https://chromiumcodereview.appspot.com/9817002 Patch from Jochen Eisinger <jochen@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12032 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 May, 2012 1 commit
-
-
yangguo@chromium.org authored
R=jkummerow@chromium.org BUG=15719 TEST= Review URL: https://chromiumcodereview.appspot.com/10412021 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11601 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Apr, 2012 1 commit
-
-
svenpanne@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/10084003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11320 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Mar, 2012 1 commit
-
-
danno@chromium.org authored
This CL: - Adds a new trait parameter to LazyInstance to let it initialize the instance without paying the cost of atomic operations (which are expensive on Mac). This only works for users who don't care about thread-safety and this is now the default initialization trait used by LazyInstance in v8. - Reverts the changes that were made in r11010 in isolate.{cc,h}. That lets Isolate's accessors be as cheap as they were before (but adds one static initializer). - Adds OS::PostSetup() used to initialize the math functions which depend on CPU features. That lets the math functions get rid of CallOnce(). BUG=118686 Review URL: https://chromiumcodereview.appspot.com/9873023 Patch from Philippe Liard <pliard@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Mar, 2012 2 commits
-
-
yangguo@chromium.org authored
BUG= TEST=regress-sqrt.js Review URL: https://chromiumcodereview.appspot.com/9690010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11012 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
fschneider@chromium.org authored
This change includes two CLs by pliard@chromium.org: 1. http://codereview.chromium.org/9447052/ (Add CallOnce() and simple LazyInstance implementation): Note that this implementation of LazyInstance does not handle global destructors (i.e. the lazy instances are never deleted). This CL was initially reviewed on codereview.appspot.com: http://codereview.appspot.com/5687064/ 2. http://codereview.chromium.org/9455088/ (Remove static initializers in v8): This CL depends on CL 9447052 (adding CallOnce and LazyInstance). It is based on a patch sent by Digit. With this patch applied, we have only one static initializer left (in atomicops_internals_x86_gcc.cc). This static initializer populates a structure used by x86 atomic operations. It seems that we can hardly remove it. If possible, it will be removed in a next CL. This CL also modifies the presubmit script to check the number of static initializers. BUG=v8:1859 Review URL: https://chromiumcodereview.appspot.com/9666052 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11010 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Mar, 2012 1 commit
-
-
yangguo@chromium.org authored
BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/9583037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10915 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Mar, 2012 2 commits
-
-
yangguo@chromium.org authored
BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/9580007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10909 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
BUG= TEST=regress-transcendental.js Review URL: https://chromiumcodereview.appspot.com/9572009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10908 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Feb, 2012 1 commit
-
-
vegorov@chromium.org authored
Split executable memory chunks into two pieces: header with all metadata (protection: RW) and body (protection: RWX). Separate header from metadata with a guard page and add a guard page after the page body. R=erik.corry@gmail.com BUG=http://crbug.com/115151 Review URL: https://chromiumcodereview.appspot.com/9452002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10809 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Jan, 2012 1 commit
-
-
erik.corry@gmail.com authored
Review URL: https://chromiumcodereview.appspot.com/9117032 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10490 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Jan, 2012 2 commits
-
-
erik.corry@gmail.com authored
test failures. Review URL: http://codereview.chromium.org/9178014 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10417 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
erik.corry@gmail.com authored
Reduce signal sender thread stack size to 32k. Commit partial old-space pages to reduce minimum memory use. This is a rebase of http://codereview.chromium.org/9017009/ Review URL: http://codereview.chromium.org/9179012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10413 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Jan, 2012 1 commit
-
-
erik.corry@gmail.com authored
Review URL: http://codereview.chromium.org/9123031 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10403 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Jan, 2012 1 commit
-
-
erik.corry@gmail.com authored
Review URL: http://codereview.chromium.org/9139051 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10399 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Dec, 2011 1 commit
-
-
erik.corry@gmail.com authored
memory use (2Mbyte on x64). Review URL: http://codereview.chromium.org/8776032 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10143 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-