Skip to content

V
V8
Switch branch/tag
  1. 07 Jul, 2022 1 commit
  3. 23 May, 2019 3 commits
  5. 21 May, 2019 1 commit
  7. 23 Jul, 2018 1 commit
  9. 01 Jun, 2016 1 commit
  11. 27 May, 2016 1 commit
    • franzih's avatar
      [builtins] Rewrite uri.js as builtin functions. · 8c31bd81
      franzih authored 
      Rewrite decodeURI and decodeURIComponent as builtin functions
and install them in the bootstrapper.

Delete unused runtime functions:
 - TruncateString
 - NewString
 - OneByteSeqStringGetChar
 - OneByteSeqStringSetChar
 - TwoByteSeqStringGetChar
 - TwoByteSeqStringSetChar

Add regression test for decoding large strings. Clusterfuzz detected
a problem with %TruncateString, see
https://bugs.chromium.org/p/chromium/issues/detail?id=612109#c6
This is automatically fixed by this rewrite because %TruncateString
is deleted anyways.

Crude benchmark on 585 decodeURI and decodeURIComponent tests
averaged over five runs:

* builtin functions
real	0m9.69s
user	2m39.8816s
sys    	0m12.6398s

* JS functions calling into the runtime e.g., for %TruncateString
real	0m11.0598s
user	3m6.7026s
sys	0m13.5756s

By running:
$  time tools/run-tests.py   --arch=x64  --mode=Release --buildbot
  test262/built-ins/decodeURI* mjsunit/uri
>>> Running tests for x64.Release

BUG=v8:4912, chromium:612109
R=yangguo@chromium.org, bmeurer@chromium.org

Review-Url: https://codereview.chromium.org/1994733003
Cr-Commit-Position: refs/heads/master@{#36543}
      8c31bd81
  13. 24 May, 2016 1 commit
  15. 17 May, 2016 1 commit
    • franzih's avatar
      [builtins] Move EncodeURI from runtime to builtins. · c60cb90c
      franzih authored 
      Repackage encodeURI and encodeURIComponent as builtin functions
and install them in the bootstrapper.

Crude benchmark on 351 encodeURI and encodeURIComponent tests averaged
over five runs:

* builtin functions
real	0m8.01s
user	0m18.00s
sys	0m7.37s

* JS functions calling into the runtime e.g., for %NewString
real	0m8.44s
user	0m19.52s
sys	0m7.49s

By running:
$ time tools/run-tests.py   --arch=x64 --mode=Release --buildbot
mjsunit/uri test262/built-ins/encodeURI*
>>> Running tests for x64.Release

BUG=v8:4912
R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/1983593002
Cr-Commit-Position: refs/heads/master@{#36273}
      c60cb90c
  17. 29 Sep, 2014 1 commit
  19. 10 Sep, 2014 1 commit
  21. 04 Aug, 2014 1 commit
  23. 03 Jun, 2014 1 commit
  25. 29 Apr, 2014 1 commit
  27. 28 Apr, 2014 1 commit
  29. 25 Apr, 2014 3 commits
  31. 04 Apr, 2014 1 commit
  33. 03 Apr, 2014 4 commits
  35. 25 Mar, 2014 1 commit
  37. 24 Mar, 2014 2 commits
  39. 20 Mar, 2014 3 commits
  41. 03 Jun, 2013 1 commit
  43. 21 Feb, 2013 1 commit