1. 12 Jun, 2019 1 commit
  2. 28 May, 2019 1 commit
  3. 08 May, 2019 1 commit
    • Pierre Langlois's avatar
      [ic] Do not decode instructions to detect deoptimized code. · 0d8ec36b
      Pierre Langlois authored
      This fixes a crash when using --trace-ic on Arm64 debug. For a given return
      address, the assembler's `target_address_from_return_address()` method will
      displace it to give you the call-site address. However, this is fragile because
      it needs to decode the instruction stream to distinguish between different call
      sequences. So it triggered an assertion on Arm64 because we now use BL for
      builtin to buitin calls.
      
      We only use this when tracing IC states to detect if the caller is a deoptimized
      function. But to do this it doesn't matter if the address we have is the return
      or the call-site address. So we can just remove the need for the fragile
      Assembler method.
      
      As a drive-by, also remove `return_address_from_call_start()` which was doing
      the opposite and was unused.
      
      Change-Id: I5988d17eadd1652ed85d662e62bc4c579665dd31
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594566
      Commit-Queue: Pierre Langlois <pierre.langlois@arm.com>
      Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61337}
      0d8ec36b
  4. 21 Mar, 2019 1 commit
    • Pierre Langlois's avatar
      [mjsunit] Do not generate compiler traces for the entire snapshot. · 2970249a
      Pierre Langlois authored
      The `compiler-trace-flags.js` test just makes sure the various --trace-turbo*
      flags do not cause V8 to crash. However, on builds with no snapshot, they would
      generate a *lot* of output as they were tracing the compiler while generating
      the snapshot.
      
      Let's set the `--trace-turbo-filter` flag to make sure we only trace the test
      functions. Sadly, WASM functions do not have a name, just an index, so we have
      to split this test into two.
      
      Bug: chromium:943064
      Cq-Include-Trybots: luci.v8.try:v8_win_nosnap_shared_rel_ng
      Change-Id: I30b3935f63d412ab8c96cc5156d342c428229865
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532078Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
      Commit-Queue: Pierre Langlois <pierre.langlois@arm.com>
      Cr-Commit-Position: refs/heads/master@{#60383}
      2970249a
  5. 30 Jan, 2019 1 commit
  6. 10 Aug, 2018 4 commits
    • Michael Achenbach's avatar
      Reland "[test] Add logic to run tests on Android" · b2537f21
      Michael Achenbach authored
      This is a reland of 4c094342
      
      Original change's description:
      > [test] Add logic to run tests on Android
      > 
      > This adds a new command abstraction for running commands on Android
      > using dockered devices on swarming.
      > 
      > The new abstraction handles pushing all required files to the device.
      > The logic used for pushing and running is reused from the perf runner.
      > 
      > This adds only the mjsunit test suite. Others will be handled in
      > follow up CLs. The suite logic is enhanced with auto-detection of files
      > to be pushed to devices, for e.g. load or import statements.
      > 
      > Some test cases need an extra resource section for specifying required
      > files.
      > 
      > Remaining failing tests are marked in the status files for later
      > triage.
      > 
      > Bug: chromium:866862
      > Change-Id: I2b957559f07fdcd8c1bd2f7034f5ba7754a31fb7
      > Reviewed-on: https://chromium-review.googlesource.com/1150153
      > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
      > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#55041}
      
      Bug: chromium:866862
      Change-Id: Icf7e04c75d4abeab7254d10ba21240e46b0022ae
      Reviewed-on: https://chromium-review.googlesource.com/1170643Reviewed-by: 's avatarSergiy Byelozyorov <sergiyb@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55059}
      b2537f21
    • Sergiy Byelozyorov's avatar
      Revert "[test] Add logic to run tests on Android" · 2071051e
      Sergiy Byelozyorov authored
      This reverts commit 4c094342.
      
      Reason for revert: Unfortunately this broke all perf builders.
      
      Original change's description:
      > [test] Add logic to run tests on Android
      > 
      > This adds a new command abstraction for running commands on Android
      > using dockered devices on swarming.
      > 
      > The new abstraction handles pushing all required files to the device.
      > The logic used for pushing and running is reused from the perf runner.
      > 
      > This adds only the mjsunit test suite. Others will be handled in
      > follow up CLs. The suite logic is enhanced with auto-detection of files
      > to be pushed to devices, for e.g. load or import statements.
      > 
      > Some test cases need an extra resource section for specifying required
      > files.
      > 
      > Remaining failing tests are marked in the status files for later
      > triage.
      > 
      > Bug: chromium:866862
      > Change-Id: I2b957559f07fdcd8c1bd2f7034f5ba7754a31fb7
      > Reviewed-on: https://chromium-review.googlesource.com/1150153
      > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
      > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#55041}
      
      TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org
      
      Change-Id: If80129810586b709dab762c9b5724888e15daec2
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:866862
      Reviewed-on: https://chromium-review.googlesource.com/1170962Reviewed-by: 's avatarSergiy Byelozyorov <sergiyb@chromium.org>
      Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55058}
      2071051e
    • Michael Achenbach's avatar
      [test] Add logic to run tests on Android · 4c094342
      Michael Achenbach authored
      This adds a new command abstraction for running commands on Android
      using dockered devices on swarming.
      
      The new abstraction handles pushing all required files to the device.
      The logic used for pushing and running is reused from the perf runner.
      
      This adds only the mjsunit test suite. Others will be handled in
      follow up CLs. The suite logic is enhanced with auto-detection of files
      to be pushed to devices, for e.g. load or import statements.
      
      Some test cases need an extra resource section for specifying required
      files.
      
      Remaining failing tests are marked in the status files for later
      triage.
      
      Bug: chromium:866862
      Change-Id: I2b957559f07fdcd8c1bd2f7034f5ba7754a31fb7
      Reviewed-on: https://chromium-review.googlesource.com/1150153Reviewed-by: 's avatarSergiy Byelozyorov <sergiyb@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55041}
      4c094342
    • Bret Sepulveda's avatar
      Escape backslashes when logging. · f642de00
      Bret Sepulveda authored
      Log::MessageBuilder was already escaping most unsafe characters when
      they were being logged, but plain backslashes were not. Merely updating
      the existing escaping path was not sufficient, as recursion would cause
      escape codes to be doubly escaped. This patches refactors the API to
      ensure incoming text is escaped exactly once.
      
      Bug: v8:8039
      Change-Id: Id48aabf29fb6153189ae4a1ad7dfaaf4b41b62ad
      Reviewed-on: https://chromium-review.googlesource.com/1169049Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Commit-Queue: Bret Sepulveda <bsep@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55038}
      f642de00
  7. 07 Jun, 2018 1 commit
    • Simon Zünd's avatar
      Reland "[array] Use random middle element to determine pivot during sorting" · 3896cdc2
      Simon Zünd authored
      This is a reland of 91bab558
      
      This CL contains two major changes w.r.t to the original CL:
      
      The random state is removed from the Smi root list and we pre-seed the RNG
      on each sort with the length of the array.
      
      To cut down on the length of the arguments list and to keep track of the
      random state across recursive calls, we move most of the sort arguments into
      a FixedArray and reload from the array for each recursion.
      
      Original change's description:
      > [array] Use random middle element to determine pivot during sorting
      >
      > This CL adds a "random state" to the Smi Root list and implements a
      > basic Linear congruential pseudo random number generator in Torque.
      >
      > The RNG is used to determine the pivot element for sorting. This will
      > prevent the worst cases for certain data layouts.
      >
      > Drive-by-fix: Make sorting of ranges and execution pauses for profviz
      > deterministic by adding a secondary sorting criteria.
      >
      > Bug: v8:7382
      > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      > Change-Id: Ieb871e98e74bdb803f821b0cd35d2f67ee0f2868
      > Reviewed-on: https://chromium-review.googlesource.com/1082193
      > Reviewed-by: Hannes Payer <hpayer@chromium.org>
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
      > Commit-Queue: Simon Zünd <szuend@google.com>
      > Cr-Commit-Position: refs/heads/master@{#53524}
      
      Bug: v8:7382
      Change-Id: Ia7bef7ed1c0e904ffe43bc428e702f64f9c6a60b
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/1087888Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Simon Zünd <szuend@google.com>
      Cr-Commit-Position: refs/heads/master@{#53583}
      3896cdc2
  8. 06 Jun, 2018 1 commit
  9. 05 Jun, 2018 1 commit
  10. 14 May, 2018 1 commit
    • Pierre Langlois's avatar
      [turbofan][wasm] Fix --trace-turbo with compiling a WASM function. · 7927d646
      Pierre Langlois authored
      The --trace-turbo flag would cause a crash when compiling a WASM_FUNCTION. It
      was caused by assuming the OptimizedCompilationInfo had a SharedFunctionInfo
      attached if the code isn't a stub and wasm functions are not considered as such.
      
      In order to test this, we've added a new flag to specify were to dump JSON
      files: --trace-turbo-path. This is used to make sure we do not leave lots of
      files behind in the top-level directory. It should be useful as standalone
      feature too.
      
      
      Change-Id: Ia9442638d28100bea45a8683fb233803cc5393f2
      Reviewed-on: https://chromium-review.googlesource.com/1030555
      Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
      Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53153}
      7927d646
  11. 24 Oct, 2017 1 commit
  12. 20 Oct, 2017 1 commit
    • Camillo Bruni's avatar
      [log] Consistently escape log entries · d06cb586
      Camillo Bruni authored
      Implicitly escape all output that is passed to Log::MessageBuilder.
      We escape non-printable characters and the log field separator ','
      using the \x00 and \u0000 escape sequences.
      
      Example:
      Before: event-foo,"space: ","comma: ,","double quotes: """
      After:  event-foo,space: ,comma: \x2C,double quotes: "
      
      This might slightly impact human readability of the log files in
      extreme cases. However, most strings do not contain any escaped
      characters.
      
      Bug: 
      Change-Id: Ic78f6d9932367d02f9f3c3f70b41b5c283bdf880
      Reviewed-on: https://chromium-review.googlesource.com/728332
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48805}
      d06cb586
  13. 11 Apr, 2017 1 commit
  14. 22 Mar, 2017 1 commit
  15. 10 Mar, 2017 1 commit
  16. 04 Mar, 2017 1 commit
  17. 01 Feb, 2017 1 commit
  18. 10 Nov, 2016 1 commit
  19. 30 May, 2016 1 commit
  20. 02 May, 2016 1 commit
  21. 05 Apr, 2016 1 commit
  22. 11 Mar, 2016 1 commit
  23. 03 Sep, 2015 1 commit
  24. 20 Jan, 2015 1 commit
    • jkummerow's avatar
      Profiler improvements · feffccca
      jkummerow authored
      (1) --prof-cpp: Collects ticks like --prof, but ignores code creation events to reduce distortion (so all JS ticks will be "unaccounted"). Useful for profiling C++ code.
      (2) --timed-range flag for tick processor: Ignores ticks before the first and after the last call to Date.now(). Useful for focusing on the timed section of a test.
      
      Review URL: https://codereview.chromium.org/802333002
      
      Cr-Commit-Position: refs/heads/master@{#26168}
      feffccca
  25. 17 Oct, 2014 1 commit
  26. 04 Aug, 2014 1 commit
  27. 10 Jun, 2014 2 commits
  28. 22 May, 2014 1 commit
  29. 22 Nov, 2013 1 commit
  30. 22 Aug, 2013 1 commit
  31. 10 Jul, 2013 1 commit
  32. 03 Jul, 2013 1 commit
  33. 18 Jun, 2013 1 commit
  34. 19 Apr, 2013 1 commit
  35. 12 Apr, 2013 1 commit
  36. 29 Jan, 2013 1 commit