- 28 Aug, 2018 27 commits
-
-
Peter Marshall authored
Very large allocations can cause timeouts or crashes on TSAN bots. This test checks the handling of arrays with length > MaxSmi, so allocates a very large array. It's unlikely that TSAN will find anything interesting here that other bots won't catch, so disabling the test. Bug: v8:8103 Change-Id: I8ea01d418ff088a2b9bd1b1ef938d4f69be1155d Reviewed-on: https://chromium-review.googlesource.com/1193423Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#55464}
-
Ujjwal Sharma authored
This increases the size of a V8BreakIterator instance by a word to store the next function. The instance to be bound is stored on the context of this builtin function. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ibdfabe53c7d0790c1ba44d5de8d1c8fc8de517c9 Reviewed-on: https://chromium-review.googlesource.com/1193502Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55463}
-
Toon Verwaest authored
Change-Id: I6fe237d4aec3745e993a65ddf31f5fafc3ce175d Reviewed-on: https://chromium-review.googlesource.com/1193368Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#55462}
-
jgruber authored
In preparation for kRootRegister support on ia32. Updated: CallWithSpread, CallWithArrayLike, ConstructWithSpread. Bug: v8:6666 Change-Id: I41c166aebee99356efa5c175739b2124d5557d58 Reviewed-on: https://chromium-review.googlesource.com/1188563Reviewed-by:
-
Ross McIlroy authored
With FLAG_preparser_scope_analysis enabled we now always track unresolved variables in the preparser. Fix the logic for deciding on the correct RCS tracing category to be based on what the preparser does. Change-Id: If691d51e6a2c09e554e4d96c10c37060cc7cca96 Reviewed-on: https://chromium-review.googlesource.com/1193303Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55460}
-
Ujjwal Sharma authored
This increases the size of a V8BreakIterator instance by a word to store the first function. The instance to be bound is stored on the context of this builtin function. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ib1e8cb8353d0885e0d9bcfdc5fe558c1de0a0738 Reviewed-on: https://chromium-review.googlesource.com/1192823 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
jgruber authored
These two builtins are a special case in that their calling convention must be kept in-sync since they are both generated from Generate_CallOrConstructVarargs. ConstructVarargs in particular used all available registers. In order to free ebx, the calling convention is changed to pass the last argument on the stack. As part of this change, the order of the last two arguments is swapped since the stack parameter must be tagged. Bug: v8:6666 Change-Id: If1ad14fc09693c36dd63ffebb6f34fcd3f012896 Reviewed-on: https://chromium-review.googlesource.com/1193444Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55458}
-
Michael Starzinger authored
This fixes a crash with a predicate used during stack unwinding of WebAssembly frames during exception handling. The predicate caused an observable side-effect in JavaScript during unwinding, code that is inherently unhandlified and is not allowed to be observable. The fix actually just removes the entire predicate. This is because the updated proposal causes all JavaScript exceptions to participate in WebAssembly exception handling, allowing modelling of "finally" language constructs to perform cleanup independent of the embedders exception details. R=ahaas@chromium.org TEST=mjsunit/regress/wasm/regress-8095 BUG=v8:8095 Change-Id: Ic03bc45e7b7f4562a431ccf910ee9ddcf558aa48 Reviewed-on: https://chromium-review.googlesource.com/1193445Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55457}
-
Ross McIlroy authored
This is a reland of 1e5b6d99 Original change's description: > [RCS] Create thread local runtime call stats tables for worker threads > > Creating a runtime call stats table for each worker thread task is expensive. > Instead we create a single table per thread, and use TLS to get the correct one > when starting a worker thread task. > > In order to correctly initialize the parser, scanner and parse-info's runtime > call stats fields, we move creation of the scanner and parser onto the > background tasks for BackgroundCompileTask and UnoptimizedCompilationJob. > > Change-Id: I36064c7fb43290968620b1985cc02637b16f4232 > Reviewed-on: https://chromium-review.googlesource.com/1187522 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55448} TBR=verwaest@chromium.org Change-Id: I7c2f48280651d7632d99ee22d86260c72bc16185 Reviewed-on: https://chromium-review.googlesource.com/1193463 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55456}
-
Creddy authored
There was preformance regression with one-shot optimizations ( https://bugs.chromium.org/p/chromium/issues/detail?id=876839#c4). Disable the one shot optimizations by default until the regrssion is fixed. Change-Id: I031ac2e0151e06fb2116f417ad3d9a3d04da16ac Reviewed-on: https://chromium-review.googlesource.com/1189823Reviewed-by:
-
Rodrigo Bruno authored
Reland "[heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery." This is a reland of ba735dde Original change's description: > [heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery. > > Bug: chromium:845409 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: Ic62a4339110e3dd2a6b1961a246e2bee0c07c03b > Reviewed-on: https://chromium-review.googlesource.com/1160162 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55128} Bug: chromium:845409 Change-Id: Iaff177f7bebbc073460fab0ae4e5cd9e632e1921 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1177301Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#55454}
-
Michael Starzinger authored
R=ahaas@chromium.org TEST=mjsunit/wasm/exceptions Change-Id: I6301cf9bcb94e972f4e7eb3d096c650a5afc55ca Reviewed-on: https://chromium-review.googlesource.com/1190343 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Hai Dang authored
The SharedFeedbackSlot helper class allow bytecodes to share one feedback slot. The helper will only create the slot on-demand, at the first-use. This does not encapsulate the use-case of FeedbackSlotCache. Change-Id: I22aec19d59e52e7395898fa2a59c5c1ec95abbe8 Reviewed-on: https://chromium-review.googlesource.com/1189904 Commit-Queue: Hai Dang <dhai@google.com> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55452}
-
Simon Zünd authored
This CL re-implements Array.p.lastIndexOf in Torque. The implementation consists of a generic baseline path and a fast-path for JSArrays with fast ElementsKinds. Sparse support for JSArrays was removed. Bug: v8:7624 Change-Id: I6ae877aaf99fa97a91763b3d60a0ee05623ab085 Reviewed-on: https://chromium-review.googlesource.com/1190345 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55451}
-
Toon Verwaest authored
Instead of using explicit current_, next_, and next_next_ pointers we now use a range from token_start_ to token_end_. Upon scan we "precrement" token_end_ to update the scan_target(). This will allow us to increase the buffer size later. Change-Id: I816d208eafc33c29a9888e7040696b56b1409fb8 Reviewed-on: https://chromium-review.googlesource.com/1189984Reviewed-by:
-
Maya Lekova authored
This reverts commit 1e5b6d99. Reason for revert: Breaks an arm64 MSAN bot - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/22601 Original change's description: > [RCS] Create thread local runtime call stats tables for worker threads > > Creating a runtime call stats table for each worker thread task is expensive. > Instead we create a single table per thread, and use TLS to get the correct one > when starting a worker thread task. > > In order to correctly initialize the parser, scanner and parse-info's runtime > call stats fields, we move creation of the scanner and parser onto the > background tasks for BackgroundCompileTask and UnoptimizedCompilationJob. > > Change-Id: I36064c7fb43290968620b1985cc02637b16f4232 > Reviewed-on: https://chromium-review.googlesource.com/1187522 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55448} TBR=rmcilroy@chromium.org,verwaest@chromium.org Change-Id: If3f28e65667816b7ae05c5efcb2f463379bc582b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1193224Reviewed-by:
-
Ross McIlroy authored
Creating a runtime call stats table for each worker thread task is expensive. Instead we create a single table per thread, and use TLS to get the correct one when starting a worker thread task. In order to correctly initialize the parser, scanner and parse-info's runtime call stats fields, we move creation of the scanner and parser onto the background tasks for BackgroundCompileTask and UnoptimizedCompilationJob. Change-Id: I36064c7fb43290968620b1985cc02637b16f4232 Reviewed-on: https://chromium-review.googlesource.com/1187522Reviewed-by:
-
Hai Dang authored
This fixes the wrong JSON data that was not updated by CL 1188572. Change-Id: I8cf1a040fa7faa95b967f8dc995b8222304f5514 Reviewed-on: https://chromium-review.googlesource.com/1193244Reviewed-by:
-
Michael Achenbach authored
TBR=delphick@chromium.org NOTRY=true Bug: v8:8058 Change-Id: I7ae59067672a295fb61195ac65226c8cd138d7b9 Reviewed-on: https://chromium-review.googlesource.com/1193284Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55446}
-
Toon Verwaest authored
Change-Id: I331ff09ee06db39e2ca051db0a91823f5b8fb402 Reviewed-on: https://chromium-review.googlesource.com/1193262Reviewed-by:
-
Ross McIlroy authored
Currently chunked and streaming character streams don't have cloning support as this requires additional changes on the Blink side. BUG=v8:8041 Change-Id: I167b3b1cd5ae1ac4038f3715b6a679d3e65d9a85 Reviewed-on: https://chromium-review.googlesource.com/1183429Reviewed-by:
-
Georg Neis authored
Change-Id: Ib967337b140594e70307348e6989b1324a62d71e Reviewed-on: https://chromium-review.googlesource.com/1186641Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=ahaas@chromium.org TEST=mjsunit/wasm/exceptions BUG=v8:8091 Change-Id: If811fdffe31df3ca94c70ff910603fab8d7e1ad4 Reviewed-on: https://chromium-review.googlesource.com/1190303 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I9642f37f3dae3f9c07661ddca1a981e223148e49 Reviewed-on: https://chromium-review.googlesource.com/1192842Reviewed-by:
-
Maya Lekova authored
This change allows passing no context to NewConsString, since it's not used anyway. Change-Id: I125e1dca90ff1b8d1c8695d5b688e8ff4e075044 Reviewed-on: https://chromium-review.googlesource.com/1190602 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Lei Zhang authored
In the logic to run tests on Android, the path is currently relative. This only works when V8 is standalone. When V8 is checkout in another project, the path is wrong. The build_with_chromium check only helps with Chromium, but there are other V8 embedders. Change-Id: I52640a664deb39e5959ed3cc9dc79fd7b6d68758 Reviewed-on: https://chromium-review.googlesource.com/1189096Reviewed-by:
-
Junliang Yan authored
Change-Id: I14a3a1d1da983528601fcd595d7e9ea820ae9d12 Reviewed-on: https://chromium-review.googlesource.com/1191822Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#55438}
-
- 27 Aug, 2018 13 commits
-
-
Sathya Gunasekaran authored
The spec specifies that search and standard can not be valid values for the collation extension keyword. Instead users are expected to use the options bag to set the correct usage options. But, ICU expects the usage option to be set through the collation extension value. In this patch, we set the usage option using the collation extension value in ICU. For resolvedOptions, we filter out this extension value using ICU to be spec compatible. Previously, we stored the usage option on the JSCollator instance. But this patch changes the logic to just look it up from the icu::Collator when required. This saves one word of memory. This fails a test262 that was incorrectly fixed. A follow on patch will fix the test262 test. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I8c66c6286287e686f4cd152fa1301f9d51c38654 Reviewed-on: https://chromium-review.googlesource.com/1180488Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55437}
-
Frank Tang authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I67e15208bc2954957275e3283eb746c1c12f10f0 Reviewed-on: https://chromium-review.googlesource.com/1191362Reviewed-by:
-
Junliang Yan authored
This reverts commit b8705eb6. Reason for revert: bf1e47e6 is reverted. Original change's description: > PPC64/s390x: move smi to lower 32-bit > > Change-Id: Id203bb297547002a41e18d621b59ce4237f88e5a > Reviewed-on: https://chromium-review.googlesource.com/1183976 > Reviewed-by: Muntasir Mallick <mmallick@ca.ibm.com> > Commit-Queue: Junliang Yan <jyan@ca.ibm.com> > Cr-Commit-Position: refs/heads/master@{#55320} TBR=jyan@ca.ibm.com,joransiu@ca.ibm.com,mmallick@ca.ibm.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ied4e7b0cd0659b5429906d1d90c91397fa268416 Reviewed-on: https://chromium-review.googlesource.com/1191162Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#55435}
-
Brian Stell authored
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I5f6adec8857398f82598295e86d2559c96363647 Bug: v8:7955, v8:7869, v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I5f6adec8857398f82598295e86d2559c96363647 Reviewed-on: https://chromium-review.googlesource.com/1184046 Commit-Queue: Brian Stell <bstell@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#55434}
-
Toon Verwaest authored
Change-Id: I1551da2cbd5cbd6e0cdf86837a01c84217a648b6 Reviewed-on: https://chromium-review.googlesource.com/1190783Reviewed-by:
-
Benoît Lizé authored
"short" external strings are not short, they mean that the external data pointer is not cached. Rename the various classes and objects to align with the actual meaning. Bug: chromium:877044 Change-Id: Ie3d5baa9ad352ac6ca89f5ba1d066760825e4beb Reviewed-on: https://chromium-review.googlesource.com/1185192Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55432}
-
Toon Verwaest authored
Change-Id: I254c2d911af5f389a68dd0f349d5a27a4a8cca54 Reviewed-on: https://chromium-review.googlesource.com/1190742Reviewed-by:
-
Michael Achenbach authored
TBR=mslekova@chromium.org NOTRY=true Bug: chromium:877964 Change-Id: Ia7ea1094ea339f6e956cb7241f7d35913b7821b2 Reviewed-on: https://chromium-review.googlesource.com/1190502Reviewed-by:
-
Andreas Haas authored
{Isolate::Deinit} waits for all created {OptimizingCompiler::CompileTask}s to finish. However, these CompileTasks run in the background and can be blocked by other tasks which run in the background, e.g. WebAssembly compilation tasks. With this CL we stop WebAssembly compilation tasks before we wait for the {optimizingCompiler:::CompileTask}s. R=mstarzinger@chromium.org CC=jarin@chromium.org Change-Id: I1549c1babdebc2e951aef5e48d0aa8130884fb7d Reviewed-on: https://chromium-review.googlesource.com/1190302Reviewed-by: -
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org Bug: v8:5918 Change-Id: I6fc16e3c6415246072b7626bdfd13ea0b7ce2dc2 Reviewed-on: https://chromium-review.googlesource.com/1189983Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55428}
-
Peter Marshall authored
This reverts commit 133a6815. Reason for revert: Regresses parsing time Original change's description: > [cleanup] Replace ZoneList with ZoneVector for parser reported_errors_ > > We use a ZoneVector because we do a fair amount of random access e.g. > in ExpressionClassifier::Accumulate() so the vector is better suited > than ZoneChunkList as it has constant time random access. > > Bug: v8:6333 > Change-Id: I83e1de60ee8fe319cfa5ce77fc5f5f86beb5307d > Reviewed-on: https://chromium-review.googlesource.com/1054672 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55315} TBR=neis@chromium.org,petermarshall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:6333 Change-Id: Ib89f0aa1f27b7d6dbbf21af60ed7d1bcd2c0b7d3 Reviewed-on: https://chromium-review.googlesource.com/1189803Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#55427}
-
Bret Sepulveda authored
This patch disables the conditions that cause the test to flake, but as a band-aid that doesn't fix the underlying issue. Bug: v8:8084 Change-Id: I46380d0ce4f450c176583330ed760bc3b57b9edc Reviewed-on: https://chromium-review.googlesource.com/1189822Reviewed-by:
-
Michael Achenbach authored
This is for temporarily testing if those bots work as expected on V8 CQ. They'll be afterwards added only on demand on presubmit for API changes. NOTRY=true TBR=delphick@chromium.org Bug: v8:8058 Change-Id: I841539a899f2987914588b2f84d402e3403bb41e Reviewed-on: https://chromium-review.googlesource.com/1189942 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
