Commits · c616ec7bf3fabbb0aab989f42236d9c34a1da137 · Linshizhi / V8

21 Mar, 2014 12 commits

Mark test-assembler-arm64/fmadd_fmsub_float_nans on arm64 as flaky · c616ec7b

jochen@chromium.org authored Mar 21, 2014

BUG=v8:3226
LOG=n
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/205863004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20151 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c616ec7b

Move ParseLeftHandSideExpression to ParserBase. · 7708d4a2

marja@chromium.org authored Mar 21, 2014

Includes cleanups:
- Reorganized functions in PreParserFactory to be in the logical order.
- De-hackified things PreParser doesn't need to track, such as IsCall & IsCallNew.

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/206433003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20150 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7708d4a2

Move ParsePostfixExpression into ParserBase. · 84520308

marja@chromium.org authored Mar 21, 2014

+ enable a test which checks that Parser and PreParser produce the "invalid left
hand side" errors consistently.

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/202333004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20149 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

84520308

Rename A64 port to ARM64 port · 2ce0bebb

jochen@chromium.org authored Mar 21, 2014

BUG=354405
R=ulan@chromium.org, rodolph.perfetta@arm.com
LOG=y

Review URL: https://codereview.chromium.org/207823003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2ce0bebb

Prepare switch from a64 to arm64 · 9fccfc37

jochen@chromium.org authored Mar 21, 2014

BUG=354405
R=machenbach@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/207793002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20147 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9fccfc37

JSObject::NormalizeElements() handlified. · bd2f8139

ishell@chromium.org authored Mar 21, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/206343002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20146 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bd2f8139

JSArray::SetContent() handlified. · e9a315c9

ishell@chromium.org authored Mar 21, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/206223003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20145 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e9a315c9

Remove unused color declarations in the a64 simulator · ca871bf0

jochen@chromium.org authored Mar 21, 2014

They're now all defined globally

BUG=none
R=svenpanne@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/207723003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20144 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ca871bf0

ArrayUnshift builtin handlified. · 863b5d30

ishell@chromium.org authored Mar 21, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/206463002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20143 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

863b5d30

Revert "Use constant length for memcpy on A64 simulator." · 586f64e1

svenpanne@chromium.org authored Mar 21, 2014

This reverts commit r20141 which broke the build with some GCC versions. The
reason behind that is GCC emits a warning about code which can never be reached,
but GCC can't figure that out.

The right approach would be using template specialization instead of these
runtime if/then/else cascades, which would be nicer from a SW engineering
perspective, too.

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/207703003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20142 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

586f64e1

Use constant length for memcpy on A64 simulator. · bfb35322

svenpanne@chromium.org authored Mar 21, 2014

Compiler can't optimize away variable length memcpy.
About a 18% boost.

Before - 5:40

Richards: 75.2
DeltaBlue: 105
Crypto: 64.0
RayTrace: 188
EarleyBoyer: 146
RegExp: 23.8
Splay: 96.2
NavierStokes: 91.9
----
Score (version 7): 85.7

After - 4:39

Richards: 90.8
DeltaBlue: 134
Crypto: 81.7
RayTrace: 227
EarleyBoyer: 177
RegExp: 29.7
Splay: 126
NavierStokes: 108
----
Score (version 7): 106

R=rodolph.perfetta@gmail.com, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/203263017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20141 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bfb35322

Introduce addp, idivp, imulp and subp for x64 port · c867df51

haitao.feng@intel.com authored Mar 21, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/196893003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20140 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c867df51

20 Mar, 2014 28 commits

MIPS: Fix register usage of r20076. · 03b435ee

plind44@gmail.com authored Mar 20, 2014

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/206763002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20139 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

03b435ee

Fix missing access check in Runtime_SetPrototype. · c27758bc

mstarzinger@chromium.org authored Mar 20, 2014

R=rossberg@chromium.org
BUG=chromium:354123
TEST=cctest/test-api/Regress354123
LOG=y

Review URL: https://codereview.chromium.org/205033011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20138 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c27758bc

Fix polymorphic hydrogen handling of SLOPPY_ARGUMENTS_ELEMENTS · 2b722b66

jkummerow@chromium.org authored Mar 20, 2014

BUG=chromium:354391
LOG=y
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/206073008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20137 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2b722b66

Reland "Implement ES6 symbol registry and predefined symbols" · b3b6987b

rossberg@chromium.org authored Mar 20, 2014

Only change relative to original CL is the updated assertion condition at objects-inl.h:2119

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/204913006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20136 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b3b6987b

MIPS: Implement flooring division by a constant via truncating division by a constant. · 2aadbc8f

plind44@gmail.com authored Mar 20, 2014

Port r20123 (31ab416)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/206373004

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20135 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2aadbc8f

Allow to push arbitrary revisions when pushing to trunk. · b12ff513

machenbach@chromium.org authored Mar 20, 2014

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/206133004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20132 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b12ff513

A64: Restore the stack limit protection to 1KB. · bd69f653

alexandre.rames@arm.com authored Mar 20, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/206393002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20131 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bd69f653

Fix assertions wrt concurrent OSR. · c9d391d8

yangguo@chromium.org authored Mar 20, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/206473002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20130 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c9d391d8

Remove outdated OOM tests. · 8f48dbb7

yangguo@chromium.org authored Mar 20, 2014

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/206373003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8f48dbb7

Callers of JSArray::SetContent() handlified. · 9f6be9c5

ishell@chromium.org authored Mar 20, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/206383003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20128 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9f6be9c5

Fix for performance issue 353661 - 23% regression in dromaeo. · c92de5d1

mvstanton@chromium.org authored Mar 20, 2014

The issue was that a previous fix to avoid a logic error was not
targeted enough: it allowed non-transitioning stores to fall
into a code path meant to preserve monomorphic state in the
case of a transitioning store.

BUG=353661
LOG=N
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/206353002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20127 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c92de5d1

Increase the "local variables in a function" limit. · e9358fa9

marja@chromium.org authored Mar 20, 2014

The limit was originally added to avoid having large user-controlled constants
(variable indexes) in the code generated by full-codegen.

History behind this change:

The original CL for adding the limit was https://codereview.chromium.org/7003030
and at that time, the limit was 32767.

Reason for adding the limit (in CL comments): "The motivation behind this change
is to avoid large user controlled constants in the code. The slot_operand used
in the IA32 full code generator uses a relative load where the local index is an
(negative) immediate."

The limit was then bumped to 65535 by https://codereview.chromium.org/10965063
and to 131071 by https://codereview.chromium.org/11099063.

R=dcarney@chromium.org, svenpanne@chromium.org, jkummerow@chromium.org, rossberg@chromium.org
BUG=v8:3205
LOG=Y

Review URL: https://codereview.chromium.org/206143004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20126 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e9358fa9

Make PreParser track valid left hand sides. · d017e6ce

marja@chromium.org authored Mar 20, 2014

Notes:
- This makes PreParser produce invalid_lhs_in_assignment and
invalid_lhs_in_prefix_op. Other errors will follow as the corresponding funcs
move to ParserBase.
- PreParserExpression::IsStrictFunction and StrictFunction() are not needed any
more -> removed them.

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/196343033

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20125 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d017e6ce

ArrayShift builtin handlified. · 68c91ea3

ishell@chromium.org authored Mar 20, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/206423002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20124 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

68c91ea3

Implement flooring division by a constant via truncating division by a constant. · 68237f65

svenpanne@chromium.org authored Mar 20, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/204583002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20123 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

68237f65

ArrayPush builtin handlified. · 8e10eea9

ishell@chromium.org authored Mar 20, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/206183006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20122 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8e10eea9

Revert "Implement ES6 symbol registry and predefined symbols" · 1088fbd1

rossberg@chromium.org authored Mar 20, 2014

TBR=yangguo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/204353004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20121 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1088fbd1

Use HBoundsCheck to check string length. · 00170e43

yangguo@chromium.org authored Mar 20, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/206183003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20120 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

00170e43

Reland "Throw exception on invalid string length instead of OOM." · 000be4d0

yangguo@chromium.org authored Mar 20, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/199583007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20119 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

000be4d0

Implement ES6 symbol registry and predefined symbols · 0f71f617

rossberg@chromium.org authored Mar 20, 2014

R=mstarzinger@chromium.org, arv@chromium.org
BUG=
LOG=Y

Review URL: https://codereview.chromium.org/203243004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20118 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0f71f617

Handlify callers to GetElementNoException. · 77a28b73

yangguo@chromium.org authored Mar 20, 2014

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/204693002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20117 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

77a28b73

A64: Minor cleaning in StoreStubCompiler::GenerateStoreField. · 50360315

alexandre.rames@arm.com authored Mar 20, 2014

Abstract a register to simplify code generation.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/206183005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20116 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

50360315

Revert "Throw exception on invalid string length instead of OOM." · a5a82ef1

yangguo@chromium.org authored Mar 20, 2014

This reverts r20112.

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/206383002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20114 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a5a82ef1

ElementsAccessor::Delete() handlified. · 107ea152

ishell@chromium.org authored Mar 20, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/200923006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20113 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

107ea152

Throw exception on invalid string length instead of OOM. · 9ba80269

yangguo@chromium.org authored Mar 20, 2014

R=bmeurer@chromium.org
BUG=349329
LOG=Y

Review URL: https://codereview.chromium.org/199853004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20112 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9ba80269

A64: Remove Operand constructors where an implicit constructor can be used. · bfcc117f

alexandre.rames@arm.com authored Mar 20, 2014

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/204293004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20111 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bfcc117f

A64: Improve the deoptimization exit code for LMathRound. · 0768479e

alexandre.rames@arm.com authored Mar 20, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/203253004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20109 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0768479e

A64: In the Simulator, corrupt caller-saved registers after runtime printf call. · c8a6fd01

alexandre.rames@arm.com authored Mar 20, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/203603002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20108 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c8a6fd01