- 02 Aug, 2018 4 commits
-
-
Michael Starzinger authored
R=titzer@chromium.org BUG=v8:7424 Change-Id: I3bb3be92b6c1bf855904cf0bf334ad98dce74dd4 Reviewed-on: https://chromium-review.googlesource.com/1156310Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54855}
-
Rodrigo Bruno authored
This CL introduces a new MemoryController that will be used to control the size of external memory (array buffers and external string for now). Bug: chromium:845409 Change-Id: I119506ce0243ac33cec2b783b888b53ee11225a9 Reviewed-on: https://chromium-review.googlesource.com/1156393 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54854}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e9eade2..cc35cac Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5c2d9e7..2acd8e0 Rolling v8/third_party/proguard: https://chromium.googlesource.com/chromium/src/third_party/proguard/+log/63f6c0b..d901b76 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/af36d66..bb4cc1a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib6fa819faf6a542c60bd4ef51d362abe133ef9ad Reviewed-on: https://chromium-review.googlesource.com/1159847Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54853}
-
Deepti Gandluri authored
Bug: v8:6532 Change-Id: Ib486a1c0d80a14b778dde5ef6655e11d326b4c73 Reviewed-on: https://chromium-review.googlesource.com/1157068Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#54852}
-
- 01 Aug, 2018 22 commits
-
-
Sergiy Byelozyorov authored
All status messages will be printed into STDERR and only the results will continue to be written to STDOUT as documentation suggests. Additionally the following changes are made: - on Buildbot each log entry will have a timestamp to make it easy to measure time between status messages printed by test runner, users will continue to see just the message itself - when devil (or any other module) logs error, they will not be interleaved with our own output since logging module is thread-safe - critical logs replaced with warning since they do not immediately stop the test runner - logging.exception is used for all exceptions to get formatted stack trace TBR=machenbach@chromium.org No-Try: true Bug: chromium:838864 Change-Id: I197fcc3bc5890130ce8b35c3e21237f9614fc468 Reviewed-on: https://chromium-review.googlesource.com/1159361 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#54851}
-
Wez authored
This is a temporary rename of zx_task_suspend(), to allow the API signature to be updated. It will be followed by a rename back to the old name, with the new signature. Change-Id: I896d714e556dad2e0740891ff99cb0b51c6c1943 Reviewed-on: https://chromium-review.googlesource.com/1158998Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#54850}
-
Clemens Hammacher authored
Very minor cleanup to reduce code complexity. R=mstarzinger@chromium.org Bug: chromium:869420 Change-Id: I53d1776792b3918d489fe002e2cb17b7a3e0ff73 Reviewed-on: https://chromium-review.googlesource.com/1158686Reviewed-by:
-
Toon Verwaest authored
This templatizes CharacterStream by char type, and makes them subclass ScannerStream. Methods that are widely used by tests are marked virtual on ScannerStream and final on CharacterStream<T> so the specialized scanner will know what to call. ParseInfo passes around ScannerStream, but the scanner requires the explicit CharacterStream<T>. Since AdvanceUntil is templatized by FunctionType, I couldn't mark that virtual; so instead I adjusted those tests to operate directly on ucs2 (not utf8 since we'll drop that in the future). In the end no functionality was changed. Some calls became virtual in tests. This is mainly just preparation. Change-Id: I0b4def65d3eb8fa5c806027c7e9123a590ebbdb5 Reviewed-on: https://chromium-review.googlesource.com/1156690 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54848}
-
Clemens Hammacher authored
The background compilation logic moved to the {CompilationState}, so the {NumberOfBackgroundTasks} is now always 1. R=mstarzinger@chromium.org Bug: chromium:869420 Change-Id: I5860f46db953778890c842af4507e8d989e34784 Reviewed-on: https://chromium-review.googlesource.com/1158581 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
We have complicated logic in place to ensure that an {AsyncCompileJob} is not removed as long as a foreground task is still pending. This CL changes that to just cancel the pending foreground task and remove the {AsyncCompileJob} immediately. R=mstarzinger@chromium.org Bug: chromium:869420 Change-Id: Ia064dae4a0e31416675e5d77c46879254fc817c4 Reviewed-on: https://chromium-review.googlesource.com/1158578Reviewed-by: -
Sigurd Schneider authored
uses of the function where that was assumed to not be the case. RelocInfo: :NONE satisfies IsShareableRelocMode; this cleans up some Change-Id: Iafd7262496edc389131966f07f4e5b4fa8b5c1e6 Reviewed-on: https://chromium-review.googlesource.com/1158574Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54845}
-
Michael Starzinger authored
This changes the predicate in question to only check for async compile jobs belonging to a given Isolate, having an engine-wide predicate is not desirable for draining message queues. R=clemensh@chromium.org BUG=v8:7424 Change-Id: If990378400cc4484d413c4d7771ec6deb6bfd244 Reviewed-on: https://chromium-review.googlesource.com/1158565 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54844}
-
Clemens Hammacher authored
This reverts commit baa055c7. Reason for revert: mips compile failure: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mips%20-%20builder/18458 Original change's description: > Applied noexcept to all mctors and massigns > > Refactoring the code base to use noexcept for their move constructors and move > assignment operators. > > Bug: v8:7999 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I13d24eddba3bfa601cff26fd680a040cf4e71426 > Reviewed-on: https://chromium-review.googlesource.com/1152817 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Florian Sattler <sattlerf@google.com> > Cr-Commit-Position: refs/heads/master@{#54841} TBR=marja@chromium.org,yangguo@chromium.org,ahaas@chromium.org,jgruber@chromium.org,sattlerf@google.com Change-Id: I49757025daac368a647887a63164e927f0106803 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7999 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1158644Reviewed-by:
-
Ben L. Titzer authored
This removes the need to pass Counters into the function body decoder by making timing happen in the callers. R=mstarzinger@chromium.org Change-Id: I05c8d2c85b1c315150cbf9e9b3f68efa03114b75 Reviewed-on: https://chromium-review.googlesource.com/1156700 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Florian Sattler authored
Refactoring the code base to use noexcept for their move constructors and move assignment operators. Bug: v8:7999 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I13d24eddba3bfa601cff26fd680a040cf4e71426 Reviewed-on: https://chromium-review.googlesource.com/1152817Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#54841}
-
Clemens Hammacher authored
All compile tasks are already canceled when the {CompilationState} dies. This happens when the {NativeModule} dies, and all {NativeModule}s die before the {WasmEngine} dies. Thus, the WasmEngine does not need to cancel any compile jobs, because there are none anyway. R=mstarzinger@chromium.org Bug: chromium:869420 Change-Id: I7e006392a1f9126333733c81c4c19985f626a470 Reviewed-on: https://chromium-review.googlesource.com/1158411Reviewed-by: -
Clemens Hammacher authored
We currently don't execute the tests on android, because the error message is redirected to the android log. What we can still to though is ensuring that the call aborts the process, but just ignore the error message. R=mstarzinger@chromium.org Bug: chromium:863799 Change-Id: I54b503849358133ffe647be83eae7a964c2ac49e Reviewed-on: https://chromium-review.googlesource.com/1148444 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This changes the WebAssembly serializer to take a full snapshot of the code table before measuring and serializing the module. It allows other threads (or other Isolates) to mutate the native module while the main thread is serializing the module. R=clemensh@chromium.org BUG=v8:7424 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I64bc27600452880f37f4fbb2f40c77c79975358f Reviewed-on: https://chromium-review.googlesource.com/1156596 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This moves the {ReadUnalignedValue} and {WriteUnalignedValue} methods from utils.h to v8memory.h. R=titzer@chromium.org Bug: v8:7754, v8:7490 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8becfc3ac169427968c11e24b035a90856f51e8e Reviewed-on: https://chromium-review.googlesource.com/1158405Reviewed-by: -
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754, v8:7965 Change-Id: I9389bc60eab8283d9b70a49a9a71c6d092146de0 Reviewed-on: https://chromium-review.googlesource.com/1158071Reviewed-by:
-
Georg Neis authored
R=jarin@chromium.org Change-Id: I9b54049852696680fb7fde26813638aae727b5d3 Reviewed-on: https://chromium-review.googlesource.com/1158231Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54835}
-
Andreas Haas authored
This is the second V8 CL to refactor WebAssembly.instantiateStreaming to make it spec compliant again. The design doc where the whole change is discussed is available in the tracking bug. The tracking bug also references prototype implementations of the whole change, which includes the changes in this CL. R=mstarzinger@chromium.org Bug: chromium:860637 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I776c0f24959ab5663727d3dfee0248a9b0642a42 Reviewed-on: https://chromium-review.googlesource.com/1143187 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Andreas Haas authored
The original implementation of 'testAsync' in mjsunit.js required to put the call to '%AbortJS' into an 'eval' statement. The reason is that this call requires the flag --allow-natives-syntax to be set, but the flag is not set in all mjsunit tests. With the use of 'eval' compilation errors can be avoided. The problem with this approach was that the fuzzer started to produce test cases which include the line 'eval("%AbortJS(message)");', and this line crashes intentionally. Different to the line '%Abort(message)', however, the 'eval' statement cannot be filtered so easily in the fuzzer. Therefore I pulled the implementation of 'testAsync' into a separate file to avoid the 'eval'. Additional changes: I use '===' now instead of 'deepEquals' in AsyncAssertion.equals because 'deepEquals' is not available outside mjsunit.js. Using '===' seems more appropriate anyways because for all tests but one it is sufficient, and it is more precise than deepEquals. R=gsathya@chromium.org Bug: chromium:774841 Change-Id: I47270aa63ff5a1d6aa76a771f9276eaaf579c5ac Reviewed-on: https://chromium-review.googlesource.com/1156598Reviewed-by:Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#54833}
-
Sathya Gunasekaran authored
Similar to existings helpers like SetProperty, WriteToReadOnlyProperty, etc, this create an helper for CreateDataProperty that abstracts away the LookupIterator. Bug: v8:5751 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I5ca02a2bad982adf233f3ea9de799e5706cd248a Reviewed-on: https://chromium-review.googlesource.com/1156400Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54832}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3e09e23..e9eade2 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/65f883b..5c2d9e7 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b0e855a..6f812e1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/24c4916..af36d66 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I80e0c172cd95e10c9d445ebe8ae563c9c799c047 Reviewed-on: https://chromium-review.googlesource.com/1157881Reviewed-by:
-
Caitlin Potter authored
An object with a deprecated Map which has already been cached in CloneObjectIC feedback is still a valid Map for fast cloning --- but to be consistent with other ICs, deprecated maps are ignored, and are expected to be transitioned away from. If the source object has a deprecated map, the instance is migrated. BUG=v8:7611, chromium:867958, chromium:868586, chromium:869342, chromium:869347, chromium:869293 R=jkummerow@chromium.org, mvstanton@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1154143 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#54799} Change-Id: I6e2f7b28c41bb9bd6255441da0f209a97bce5e8f Reviewed-on: https://chromium-review.googlesource.com/1157142 Cr-Commit-Position: refs/heads/master@{#54830}
-
- 31 Jul, 2018 14 commits
-
-
Jungshik Shin authored
ICU maps a few grandfathered tags to made-up values even when there is no preferred value entry in the IANA language tag registry. [1] 1. Check for grandfathered tags without preferred value upfront and return them as they're. 2. Lowercase the input before structural validity check to simplify check for grandfathered tag without preferred value as well as regexps used in the structural validity check. intl/general/grandfathered_tags_without_preferred_value is added and intl/general/language_tags_with_preferred_values is changed to check for case-insensitive matching of grandfathered tags. [1] https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry Bug: v8:7669 Test: test262/intl402/Intl/getCanonicalLocales/preferred-grandfathered Test: intl/general/grandfathered_tags_without_preferred_value Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ie0520de8712928300fd71fe152909789483ec256 Reviewed-on: https://chromium-review.googlesource.com/1156529 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
-
Junliang Yan authored
Port 19953355 Original Commit Message: The {CommentOperator}, used for implementing the --code-comments flag, is not UBSan-safe. This CL fixes this and adds a test which uses code comments. R=clemensh@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ia7976ec9a726fdeb7d8bfbb99c8a16d473aa0da4 Reviewed-on: https://chromium-review.googlesource.com/1157230Reviewed-by:
Muntasir Mallick <mmallick@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#54828}
-
Tobias Tebbi authored
Change-Id: I4710d317cf9f5686551a3df6e98619bab79387fa Reviewed-on: https://chromium-review.googlesource.com/1156698 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#54827}
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I99c0a72c40133532acfa09cd809b695052b91ea1 Reviewed-on: https://chromium-review.googlesource.com/1156547 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54826}
-
Georg Neis authored
The test uses an incomplete native context, so the broker fails during serialization. Bug: v8:7790 Change-Id: I33e9e37df4e4acce62829123a8d16087d4fdc76d Reviewed-on: https://chromium-review.googlesource.com/1156693Reviewed-by:
-
Georg Neis authored
For the sake of incremental development it makes sense to still allow serialization to happen even when the broker is in mode 'kSerialized'. To locally obtain the stricter behavior, I'm adding the temporary flag --strict-heap-broker. Bug: v8:7790 Change-Id: Ie92f4f13d76bac9ce1f98bdd245829984d436d77 Reviewed-on: https://chromium-review.googlesource.com/1156603 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
The heap broker expects that handles get canonicalized. R=jarin@chromium.org Bug: v8:7790 Change-Id: If6162316bb2a256e783a8175ac7d4172d040b28b Reviewed-on: https://chromium-review.googlesource.com/1155123 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georgia Kouveli authored
MakeAssemblerBufferExecutable now flushes the i-cache, so we do not need to do that again. Change-Id: I46f5619167114cdb84064ef363106bee64282d1f Reviewed-on: https://chromium-review.googlesource.com/1152813Reviewed-by:
-
Camillo Bruni authored
Bug: v8:7942 Change-Id: I7b3740b04cbcaa56dc809150900ab8d821b054ce Reviewed-on: https://chromium-review.googlesource.com/1156544Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#54821}
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754, v8:7965 Change-Id: I5cb76b4e989fbe6d4d08bafb60dbbb26c3d58e2d Reviewed-on: https://chromium-review.googlesource.com/1156515Reviewed-by:
-
Sathya Gunasekaran authored
... So that this can be re-used in the intl code. Also, add a helper method that loads the iterator if it's not provided. Bug: v8:5751 Change-Id: Ifc1142a486b2cdf1c33a813c5446b206ad9f81ef Reviewed-on: https://chromium-review.googlesource.com/1156390 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
As discussed offline, this header is not really useful without its inline definitions. So instead of trying to split it (unnaturally), declare defeat and make it an inline header file. Also remove two unnecessary uses of it, move the JSON stringifier class into its .cc file (because it needs IncrementalStringBuilder inline) and forward declare in prettyprinter.h. R=petermarshall@chromium.org, mstarzinger@chromium.org BUG=v8:7965 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I7ba032ca718a195e156ec3e59f8e858a25423450 Reviewed-on: https://chromium-review.googlesource.com/1156401Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54818}
-
Georg Neis authored
Use sizeof of the C type instead. Also fix a few #undef's that got reported after my changes. R=jarin@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I30a43b3d93e6df04fb9fb33050b52988edd7fdb1 Reviewed-on: https://chromium-review.googlesource.com/1155108Reviewed-by:
-
Michael Starzinger authored
This changes recording of compilation stats (i.e. code and reloc info size) for each code object individually after it is finished, instead of for the entire module. It avoids needed to iterate the code table which would race with background tasks performing tier-up. R=clemensh@chromium.org Change-Id: Ic196fccb38b069a07e79fed4633d01dfc2639cd7 Reviewed-on: https://chromium-review.googlesource.com/1156396 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
