- 05 Feb, 2020 1 commit
-
-
Michael Lippautz authored
Delay completing marking (and thus the atomic GC pause) during JS executions, increasing the chance to finalize the garbage collection from a task. This is beneficial as it avoids stack scanning which is expensive and can keep alive outdated objects in case of unified heap. Completing will be delayed at most by some overshoot factor (10%). In addition, the GC keeps the weighted average of previously recorded time to incremental marking task invocations and bails out if the task is expected to arrive too late. Reland: Do not schedule a delayed task when marking has already been finalized. This reverts commit 1775684e. Bug: chromium:1044630, v8:10178 Change-Id: Ic46e9504ce7c200bd1d37ee8d0190fb8727a3f96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2037436Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#66137}
-
- 04 Feb, 2020 2 commits
-
-
Michael Achenbach authored
This reverts commit 02e57873. Reason for revert: High flakiness and broken GPU builders. See: https://crbug.com/v8/10178 (speculative revert) Original change's description: > heap: Delay completing marking > > Delay completing marking (and thus the atomic GC pause) during JS > executions, increasing the chance to finalize the garbage collection > from a task. This is beneficial as it avoids stack scanning which is > expensive and can keep alive outdated objects in case of unified heap. > > Completing will be delayed at most by some overshoot factor (10%). > > In addition, the GC keeps the weighted average of previously recorded > time to incremental marking task invocations and bails out if the > task is expected to arrive too late. > > Bug: chromium:1044630 > Change-Id: I10e63e6aaa88d8488d4415f311016dce2b4e62a2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2030906 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66107} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: I0cd3f1189d0f83754350d5bdaaf82cb3c4d402c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1044630, v8:10178 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2037434Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66120}
-
Michael Lippautz authored
Delay completing marking (and thus the atomic GC pause) during JS executions, increasing the chance to finalize the garbage collection from a task. This is beneficial as it avoids stack scanning which is expensive and can keep alive outdated objects in case of unified heap. Completing will be delayed at most by some overshoot factor (10%). In addition, the GC keeps the weighted average of previously recorded time to incremental marking task invocations and bails out if the task is expected to arrive too late. Bug: chromium:1044630 Change-Id: I10e63e6aaa88d8488d4415f311016dce2b4e62a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2030906 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#66107}
-
- 24 May, 2019 1 commit
-
-
Yang Guo authored
TBR=mvstanton@chromium.org,neis@chromium.org,ahaas@chromium.org Bug: v8:9247 Change-Id: I5433c863a54f3412d73df0d38aba3fdbcfac7ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627973 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61830}
-
- 07 Feb, 2019 1 commit
-
-
Ulan Degenbaev authored
The new scheduling reduces the main thread marking performed in tasks and on allocation. It is based on two counters: - bytes_marked, - scheduled_bytes_to_mark. The bytes_marked accounts marking done both the main thread and the concurrent threads. The scheduled_bytes_to_mark increases based on allocated bytes and also based on time passed since the start of marking. The main thread steps are allowed to mark the minimal amount if bytes_marked is greater than scheduled_bytes_to_mark. This also changes tasks posted for marking. Before only normal tasks were posted. Now delayed tasks are posted if the marker is ahead of schedule. Bug: 926189 Change-Id: I5bc9c33a5ecfc9f8d09f78d08ae277d16a2779ca Reviewed-on: https://chromium-review.googlesource.com/c/1443056 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#59433}
-
- 10 Oct, 2018 1 commit
-
-
Michael Lippautz authored
Pass on information about the embedder state using the fact that tasks are run from top level Bug: chromium:893944 Change-Id: I01441778770c5acc784540e496eec5c3fdb87796 Reviewed-on: https://chromium-review.googlesource.com/c/1273048 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#56540}
-
- 11 Jul, 2017 1 commit
-
-
Ulan Degenbaev authored
BUG=chromium:694255 Change-Id: Iaaa7a493bfad8817fba288efd486a5a7e8b0a0fb Reviewed-on: https://chromium-review.googlesource.com/567005 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#46560}
-
- 26 May, 2017 1 commit
-
-
Andreas Haas authored
This CL removes the isolate_ property from the Cancelable class. The isolate is actually not used in the class itself, only in sub-classes which can store the isolate themselves. R=jochen@chromium.org, mlippautz@chromium.org Change-Id: If102fdea41b81fb3cb25782728f7fcbce9642815 Reviewed-on: https://chromium-review.googlesource.com/516704Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#45535}
-
- 05 Dec, 2016 1 commit
-
-
ulan authored
This reverts commit aea4f1a7. Reason: performance regression on benchmarks (crbug.com/671118). BUG=chromium:671118,chromium:613518 TBR=hpayer@chromium.org Review-Url: https://codereview.chromium.org/2549053002 Cr-Commit-Position: refs/heads/master@{#41479}
-
- 02 Dec, 2016 1 commit
-
-
ulan authored
BUG=chromium:613518 Review-Url: https://codereview.chromium.org/2407153002 Cr-Commit-Position: refs/heads/master@{#41459}
-
- 12 Sep, 2016 1 commit
-
-
ulan authored
This patch changes incremental marking work scheduling from combination of idle/delayed tasks to ordinary short-running tasks and moves more marking work from V8.Execute to tasks by accounting how much bytes were marked in tasks. BUG=chromium:616434 LOG=NO Review-Url: https://codereview.chromium.org/2321553002 Cr-Commit-Position: refs/heads/master@{#39348}
-
- 24 Mar, 2016 1 commit
-
-
ulan authored
Based on CL 1777883002. BUG=chromium:590975 LOG=NO Review URL: https://codereview.chromium.org/1813963002 Cr-Commit-Position: refs/heads/master@{#35053}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 08 Sep, 2015 1 commit
-
-
ulan authored
This moves incremental marking steps from gc-idle-time-handler and heap to the new incremental marking task. BUG=chromium:490559 LOG=NO Review URL: https://codereview.chromium.org/1265423002 Cr-Commit-Position: refs/heads/master@{#30641}
-