- 26 Sep, 2018 1 commit
-
-
Frank Tang authored
Bug: v8:8066 Change-Id: I931de0472941fca8f68739a05fa38dee308d59f4 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1212467Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#56227}
-
- 14 Sep, 2018 1 commit
-
-
PhistucK authored
Previously, DateTimeFormat.prototype.formatToParts returned an object with the property key 'dayperiod' which is incorrect as per the spec. This patch updates the property key to say 'dayPeriod', making this spec compliant. R=cira@chromium.org Bug: chromium:865351 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I37f50797387bc69d5e29d7c2911bc5cc0fad37ac Reviewed-on: https://chromium-review.googlesource.com/1145304Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: PhistucK <phistuck@gmail.com> Cr-Commit-Position: refs/heads/master@{#55922}
-
- 13 Sep, 2018 1 commit
-
-
Adam Klein authored
Also fix type-check to check receiver for JSReceiver, not JSObject, and add a test for DateTimeFormat verifying that it already has the proper behavior. Bug: chromium:881023 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I950c86094dfb9634e0b7e49bcbbb022fa81a71f7 Reviewed-on: https://chromium-review.googlesource.com/1225612 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55880}
-
- 04 Sep, 2018 1 commit
-
-
Frank Tang authored
Bug: v8:8066 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;luci.chromium.try:linux_chromium_rel_ng Change-Id: I74fe09bb6bb4428d57c66811b77f5f35144f717f Reviewed-on: https://chromium-review.googlesource.com/1186153 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#55625}
-
- 30 Aug, 2018 1 commit
-
-
Frank Tang authored
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I9adf2b15b76e26e6e59a7732da714da7d44daf69 Reviewed-on: https://chromium-review.googlesource.com/1195071Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#55510}
-
- 02 Aug, 2018 1 commit
-
-
Jungshik Shin authored
Etc/GMT* time zones are listed in the INAN time zone database and they should be accepted as valid. This CL will be followed by a CL for moving time zone name checks to C++ that will accept all the time zone names (e.g. EST5EDT, Hongkong, ROK, Zulu). Bug: chromium:364374 Test: intl/date-format/timezone.js Test: mjsunit/regress/regress-crbug-364374 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: If0e5327d7e980504a9cb3d2b641e907ebce61180 Reviewed-on: https://chromium-review.googlesource.com/1159546 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54879}
-
- 25 Apr, 2018 1 commit
-
-
Jungshik Shin authored
https://github.com/tc39/ecma402/pull/194 requires that TimeClip be called before formatting in Intl.DateTimeFormat. Bug: v8:7471 Test: test262/intl402/DateTimeFormat/prototype/format/time-clip* Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Iad80376ae7598aab3e4df84a6cbbcd8691e16e09 Reviewed-on: https://chromium-review.googlesource.com/1027442Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#52796}
-
- 21 Apr, 2018 1 commit
-
-
Timothy Gu authored
With certain ICU data bundles (such as the Node.js "small-icu"), %GetDefaultICULocale() may return a more specific language tag (e.g. "en-US") than what's available (e.g. "en"). In those cases, consider the more specific language tag supported. This CL also resolves the following Node.js issue: https://github.com/nodejs/node/issues/15223 Bug: v8:7024 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ifda0776b3418734d5caa8af4e50c17cda95add73 Reviewed-on: https://chromium-review.googlesource.com/668350 Commit-Queue: Daniel Ehrenberg <littledan@chromium.org> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#52716}
-
- 12 Apr, 2018 1 commit
-
-
Jungshik Shin authored
This is to fix an assertion failure in formatToParts when Chinese calendar is specified with 'u-ca-chinese'. See https://github.com/tc39/ecma402/issues/225 . This CL is a temporary work-around to get v8 match the spec in terms of the external behavior, but it's not taking the steps in the spec, yet. Moreover, the spec may have to be revised as to how to pick the best match pattern when the default calendar for a locale is different from the calendar specified via 'u-ca'. How to handle 'related year' part also needs to be specified. Bug: chromium:826549 Test: intl/date-format/format-with-extensions Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I1f9a2467e86e71e024bc9babe18f16e49746008e Reviewed-on: https://chromium-review.googlesource.com/1006915Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#52556}
-
- 27 Jan, 2018 1 commit
-
-
Jungshik Shin authored
Bug: chromium:801602 Test: intl/date-format/month-far-future.js Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie2279680e8879c943cbf0873a933d2633e759212 Reviewed-on: https://chromium-review.googlesource.com/868376Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#50914}
-
- 19 Oct, 2017 1 commit
-
-
Jungshik Shin authored
intl.js throws an exception when datetime-value to format is Infinity or NaN, but there was a way to thwart the check. Moreover, intl.js and runtime-intl.cc have unnecessary conversions of 'Number->Date->Number'. I removed the unnecessary conversion and made 'Number' be passed to %InternalDateFormat. With this streamlining, the work-around mentioned above does not work anymore. Add a check in runtime_intl.cc for Infinity/NaN and throw a RangeError. Add invalid-time test for invalid datetime-values passed to Intl.DateTimeFormat.format(). Bug: chromium:774833 Test: intl/date-format/invalid-time.js Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Idc575e532a86ee110dc4bb945ae023d6516650ee Reviewed-on: https://chromium-review.googlesource.com/724860 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48765}
-
- 12 Jul, 2017 1 commit
-
-
Daniel Ehrenberg authored
In certain timezones, being at noon UTC doesn't guarantee that you'll be the same day in local time. This patch fixes that false assumption. Thanks to Holmes He for reporting the issue. Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I7432c0eb1e13fdf11c665e59dabaebeb79bff8c8 Reviewed-on: https://chromium-review.googlesource.com/568021Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#46584}
-
- 17 Apr, 2017 1 commit
-
-
Adam Klein authored
This flag was shipped with V8 5.7 (Chrome 57). Bug: v8:5244 Change-Id: I044edb8d7e74ea3c84bf46ec5cf81b8ff1b7a3de Reviewed-on: https://chromium-review.googlesource.com/477975Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#44667}
-
- 19 Dec, 2016 1 commit
-
-
littledan authored
Previously, the Intl.DateTimeFormat constructor and other related paths had a bug where the options bag passed in would be modified in place. This patch makes V8's Intl implementation follow the specification's logic to avoid such a modification. BUG=v8:4219 Review-Url: https://codereview.chromium.org/2587703002 Cr-Commit-Position: refs/heads/master@{#41826}
-
- 15 Sep, 2016 1 commit
-
-
littledan authored
This flag has been flipped off since 52, so it is due for removal. R=adamk@chromium.org,caitp@igalia.com BUG=v8:3785 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng Review-Url: https://codereview.chromium.org/2268633002 Cr-Commit-Position: refs/heads/master@{#39435}
-
- 06 Sep, 2016 1 commit
-
-
jshin authored
Spec discussion: https://github.com/tc39/ecma402/issues/30 It's in stage 4 and Firefox has already implemented it. For now, it's added to HARMONY_IN_PROGRESS bucket behind '--datetime-format-to-parts' flag. BUG=v8:5244 TEST=intl/date-format/date-format-to-parts.js TEST=test262/intl402/DateTimeFormat/prototype/formatToParts/* Review-Url: https://codereview.chromium.org/2273953003 Cr-Commit-Position: refs/heads/master@{#39225}
-
- 17 Aug, 2016 1 commit
-
-
jshin authored
Language tags with Unicode extensions can have multiple subtags for a key (e.g. -ca-ismalic-civil has 'islamic-civi' for 'ca'). BUG=v8:4749 TEST=intl/date-format/calendar-with-multiple-type-subtags.js Review-Url: https://codereview.chromium.org/2248563003 Cr-Commit-Position: refs/heads/master@{#38692}
-
- 27 May, 2016 1 commit
-
-
jshin authored
intl/number-format/parse-percent.js intl/date-format/parse-mdyhms.js intl/number-format/parse-decimal.js intl/date-format/parse-MMMdy.js Also added a few more test cases. BUG=v8:3454 TEST=The tests listed above. Review-Url: https://codereview.chromium.org/1988073003 Cr-Commit-Position: refs/heads/master@{#36555}
-
- 12 May, 2016 1 commit
-
-
littledan authored
This patch removes the following properties, as their use count is very low, they are V8-only, and not on a standards track. - v8Parse - resolved - pattern v8BreakIterator is left in as it has significantly more usage. BUG=v8:3785 R=adamk,jshin@chromium.org Review-Url: https://codereview.chromium.org/1968893002 Cr-Commit-Position: refs/heads/master@{#36190}
-
- 12 Dec, 2015 1 commit
-
-
littledan authored
A couple of the Intl tests made calls to getDefaultTimeZone(), which doesn't exist in V8; however, these were not core to the test. Rather than marking the whole test as failing, just comment out that unimportant part of the test. R=adamk Review URL: https://codereview.chromium.org/1522533003 Cr-Commit-Position: refs/heads/master@{#32819}
-
- 08 Dec, 2015 1 commit
-
-
littledan authored
ECMAScript dates act as if the Gregorian changeover happened at the beginning of time. This patch fixes up internationalized date formatting to set that changeover properly, as opposed to the ICU default which is in the 16th century. BUG=chromium:537382 R=adamk,cira LOG=Y Review URL: https://codereview.chromium.org/1501113002 Cr-Commit-Position: refs/heads/master@{#32669}
-
- 23 Jul, 2014 2 commits
-
-
jochen@chromium.org authored
The intl tests still fail locally. BUG=v8:3454 LOG=N R=verwaest@chromium.org Review URL: https://codereview.chromium.org/410083004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22558 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
Update the following 4 intl tests after ICU 52 roll. date-format/parse-MMMdy.js date-format/parse-mdyhms.js number-format/parse-decimal.js number-format/parse-percent.js BUG=v8:3454 TEST=intl/* tests pass. LOG=Y R=jochen@chromium.org Review URL: https://codereview.chromium.org/410733003 Patch from Jungshik Shin <jshin@chromium.org>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22544 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Apr, 2014 3 commits
-
-
jochen@chromium.org authored
There were some tests that are supposed to protect against js messing with the meta data, however, they just didn't try hard enough. BUG=354967 R=dcarney@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=20375 Review URL: https://codereview.chromium.org/215293005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20388 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
Store i18n meta data in hidden symbols instead of js accessible properties BUG=354967 LOG=N TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/220673002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20377 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
There were some tests that are supposed to protect against js messing with the meta data, however, they just didn't try hard enough. BUG=354967 R=dcarney@chromium.org LOG=y Review URL: https://codereview.chromium.org/215293005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20375 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Oct, 2013 1 commit
-
-
https://codereview.chromium.org/25855005cira@chromium.org authored
Reverting reverted r17148 and fixing build (test) breakage by side stepping the Windows vs. Linux issue of different Date object for the same millisecond time stamp. We do that by using UTC Date methods (they eliminate DST problems). Windows: new Date(129193200000); Sun Feb 03 1974 23:00:00 GMT-0800 (Pacific Standard Time) Linux: new Date(129193200000); Mon Feb 04 1974 00:00:00 GMT-0700 (PST) BUG=2919 R=dslomov@chromium.org, mnita@google.com Review URL: https://codereview.chromium.org/26918002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17171 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Oct, 2013 2 commits
-
-
dslomov@chromium.org authored
This reverts commit r17148 for breaking tests on Windows. TBR=cira@google.com,titzer@chromium.org Review URL: https://codereview.chromium.org/26467005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17149 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
cira@chromium.org authored
BUG=2919 TEST=All tests passing when local timezone was set to EST. R=mnita@google.com, titzer@chromium.org Review URL: https://codereview.chromium.org/25855005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Aug, 2013 1 commit
-
-
jochen@chromium.org authored
It's now available via builtins. BUG=v8:2475 R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/21512002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16016 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Jul, 2013 1 commit
-
-
jochen@chromium.org authored
BUG=v8:2745 R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18687003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15584 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-