1. 09 Sep, 2020 1 commit
  2. 09 Mar, 2020 1 commit
    • Dan Elphick's avatar
      [api] Create v8::String::NewFromLiteral that returns Local<String> · b097a8e5
      Dan Elphick authored
      String::NewFromLiteral is a templated function that takes a char[N]
      argument that can be used as an alternative to String::NewFromUtf8 and
      returns a Local<String> rather than a MaybeLocal<String> reducing the
      number of ToLocalChecked() or other checks.
      
      Since the string length is known at compile time, it can statically
      assert that the length is less than String::kMaxLength, which means that
      it can never fail at runtime.
      
      This also converts all found uses of NewFromUtf8 taking a string literal
      or a variable initialized from a string literal to use the new API. In
      some cases the types of stored string literals are changed from const
      char* to const char[] to ensure the size is retained.
      
      This API does introduce a small difference compared to NewFromUtf8. For
      a case like "abc\0def", NewFromUtf8 (using length -1 to infer length)
      would treat this as a 3 character string, whereas the new API will treat
      it as a 7 character string.
      
      As a drive-by fix, this also fixes all redundant uses of
      v8::NewStringType::kNormal when passed to any of the String::New*
      functions.
      
      Change-Id: Id96a44bc068d9c4eaa634aea688e024675a0e5b3
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2089935
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Reviewed-by: 's avatarMathias Bynens <mathias@chromium.org>
      Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
      Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#66622}
      b097a8e5
  3. 26 Jun, 2019 1 commit
  4. 21 Feb, 2018 1 commit
  5. 14 Nov, 2017 1 commit
  6. 04 Sep, 2017 1 commit
  7. 28 Aug, 2017 1 commit
  8. 02 Aug, 2017 1 commit
  9. 29 Jun, 2016 1 commit
  10. 08 Jun, 2016 1 commit
  11. 14 Aug, 2015 1 commit
    • vogelheim's avatar
      Rework startup-data-util. · c69e2eae
      vogelheim authored
      - Make the API look like v8::V8::InitializeICU.
        (That is: A static method call, not an object to be created on the stack.)
      - Fix path separator on Windows, by calling base::OS::isPathSeparator.
      - Move into API, so that it can be called by hello-world & friends.
      - Actually call it from hello-world and friends.
      
      R=jochen@chromium.org
      BUG=
      
      Review URL: https://codereview.chromium.org/1292053002
      
      Cr-Commit-Position: refs/heads/master@{#30174}
      c69e2eae
  12. 15 Jul, 2015 1 commit
  13. 02 Jul, 2015 1 commit
  14. 28 May, 2015 1 commit
  15. 29 Apr, 2015 1 commit
  16. 28 Apr, 2015 3 commits
  17. 27 Nov, 2014 1 commit
  18. 21 Nov, 2014 1 commit
  19. 19 Sep, 2014 1 commit
  20. 18 Sep, 2014 2 commits
  21. 03 Jul, 2014 2 commits
  22. 20 Jun, 2014 1 commit
  23. 10 Jun, 2014 1 commit
  24. 08 May, 2014 1 commit
  25. 22 Apr, 2014 2 commits
  26. 08 Jan, 2014 1 commit
  27. 18 Dec, 2013 1 commit
  28. 04 Dec, 2013 1 commit
  29. 22 Nov, 2013 1 commit
  30. 12 Nov, 2013 1 commit
  31. 03 Sep, 2013 1 commit
  32. 11 Jul, 2013 1 commit
  33. 09 Jul, 2013 1 commit
  34. 05 Jul, 2013 1 commit
  35. 05 Jun, 2013 1 commit