- 11 Jul, 2017 1 commit
-
-
Alexandre Talon authored
Each reducer now has a virtual reducer_name function, returning its name (the name of the class containing this reducer). This gets displayed when using the --trace_turbo_reduction flag. Also when using this flags more messages are displayed. Actually when a node is replaced in-place (which is called an update of the node), other reducers can still update it right after the in-place replacement. When a node is really replaced (not in-place), then we stop trying to apply reducers to it before we propagate the reduction through the relevant nodes. Before a message got printed only for the last reduction it went through. So in case a node was reduced in-place several times in a row, only the last update was printed, or none at all if after being reduced in-place it got reduced by being replaced by another node: only the non-in-place replacement was showed. Now each time an in-place reduction is applied to a node, a message gets printed. Bug: Change-Id: Id0f816fecd44c01d0253966c6decc4861be0c2fa Reviewed-on: https://chromium-review.googlesource.com/563365Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Alexandre Talon <alexandret@google.com> Cr-Commit-Position: refs/heads/master@{#46552}
-
- 17 Oct, 2016 1 commit
-
-
jochen authored
R=machenbach@chromium.org,titzer@chromium.org,bmeurer@chromium.org,jgruber@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_win_dbg,v8_mac_dbg;master.tryserver.chromium.android:android_arm64_dbg_recipe Review-Url: https://codereview.chromium.org/2416243002 Cr-Commit-Position: refs/heads/master@{#40350}
-
- 18 Jul, 2016 1 commit
-
-
jarin authored
This makes sure that we preserve call's tailness even if we have introduced a loop exit between the call and the return. BUG=chromium:628773 Review-Url: https://codereview.chromium.org/2155123002 Cr-Commit-Position: refs/heads/master@{#37832}
-
- 29 Jun, 2016 3 commits
-
-
mstarzinger authored
Reland of [turbofan] Implicitly emit eager checkpoint at graph building. (patchset #1 id:1 of https://codereview.chromium.org/2104973004/ ) Reason for revert: Can be cleanly relanded without any changes after a fix to redundancy elimination. Kudos go to Benedikt. Depends on: https://codereview.chromium.org/2112463002/ Original issue's description: > Revert of [turbofan] Implicitly emit eager checkpoint at graph building. (patchset #13 id:260001 of https://codereview.chromium.org/2074703002/ ) > > Reason for revert: > Causers flaky failures on the waterfall on Mac with the following error in the builtin QuickSort method: > > # > # Fatal error in Zone > # Allocation failed - process out of memory > # > > Original issue's description: > > [turbofan] Implicitly emit eager checkpoint at graph building. > > > > This makes preparation of eager checkpoints within the graph builder > > implicit. Every sub-expression visitation is now guaranteed to emit > > valid checkpoints in AstContext. > > > > R=jarin@chromium.org > > BUG=v8:5021 > > > > Committed: https://crrev.com/74e328efee7995aeee6d568f9d14f9bbc1087100 > > Cr-Commit-Position: refs/heads/master@{#37368} > > TBR=jarin@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:5021 > > Committed: https://crrev.com/45190a4fbfa5199f6ddf5ed9a7e2f50be865e0db > Cr-Commit-Position: refs/heads/master@{#37372} TBR=jarin@chromium.org BUG=v8:5021 Review-Url: https://codereview.chromium.org/2107163002 Cr-Commit-Position: refs/heads/master@{#37395}
-
mstarzinger authored
Revert of [turbofan] Implicitly emit eager checkpoint at graph building. (patchset #13 id:260001 of https://codereview.chromium.org/2074703002/ ) Reason for revert: Causers flaky failures on the waterfall on Mac with the following error in the builtin QuickSort method: # # Fatal error in Zone # Allocation failed - process out of memory # Original issue's description: > [turbofan] Implicitly emit eager checkpoint at graph building. > > This makes preparation of eager checkpoints within the graph builder > implicit. Every sub-expression visitation is now guaranteed to emit > valid checkpoints in AstContext. > > R=jarin@chromium.org > BUG=v8:5021 > > Committed: https://crrev.com/74e328efee7995aeee6d568f9d14f9bbc1087100 > Cr-Commit-Position: refs/heads/master@{#37368} TBR=jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5021 Review-Url: https://codereview.chromium.org/2104973004 Cr-Commit-Position: refs/heads/master@{#37372}
-
mstarzinger authored
This makes preparation of eager checkpoints within the graph builder implicit. Every sub-expression visitation is now guaranteed to emit valid checkpoints in AstContext. R=jarin@chromium.org BUG=v8:5021 Review-Url: https://codereview.chromium.org/2074703002 Cr-Commit-Position: refs/heads/master@{#37368}
-
- 01 Jun, 2016 1 commit
-
-
mstarzinger authored
This adds a very simplistic reduction of {CheckPoint} nodes via the new {CheckpointElimination}, eliminating redundant check points that appear in an effect chain of operations that are all {kNoWrite}. Such a chain allows an arbitrary check point to be chosen. The current approach will end up choosing the first one for all deopts in the chain. R=bmeurer@chromium.org TEST=unittests/CheckpointEliminationTest.CheckPointChain BUG=v8:5021 Review-Url: https://codereview.chromium.org/2022913003 Cr-Commit-Position: refs/heads/master@{#36634}
-