- 19 May, 2017 1 commit
-
-
dgozman authored
This refactoring makes it easier to write advanced tests and gives full control over what's happening to the test code. It also forces description for every test. BUG=none Review-Url: https://codereview.chromium.org/2891213002 Cr-Commit-Position: refs/heads/master@{#45412}
-
- 18 May, 2017 1 commit
-
-
dgozman authored
- moved all extensions to inspector_test.cc; - properly supported multiple context groups and sessions; - better isolation between components; - better infrastructure in protocol-test. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2890463004 Cr-Commit-Position: refs/heads/master@{#45409}
-
- 21 Apr, 2017 1 commit
-
-
kozyatinskiy authored
.. replace all of them with prepared global object template. + bonus: wrap inspector related methods with inspector namespace. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2832723004 Cr-Commit-Position: refs/heads/master@{#44785}
-
- 29 Mar, 2017 3 commits
-
-
kozyatinskiy authored
With this CL we don't need to store reference to InspectedContext inside of JavaScript console object and able to get all required information from callback data. It allows us to implement console methods without taking in account how and where we create and store these methods: - later we can move console object implementation to builtins.. - ..and install command line API methods smarter. BUG=chromium:588893 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2784713002 Cr-Original-Original-Commit-Position: refs/heads/master@{#44212} Committed: https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca915f4c Review-Url: https://codereview.chromium.org/2784713002 Cr-Original-Commit-Position: refs/heads/master@{#44238} Committed: https://chromium.googlesource.com/v8/v8/+/88f71126a5c067f98c75044bc26778f2e8ea2e79 Review-Url: https://codereview.chromium.org/2784713002 Cr-Commit-Position: refs/heads/master@{#44251}
-
kozyatinskiy authored
Revert of [inspector] console get all information from inspector when needed (patchset #5 id:80001 of https://codereview.chromium.org/2784713002/ ) Reason for revert: One more failed layout test. Original issue's description: > [inspector] console get all information from inspector when needed > > With this CL we don't need to store reference to InspectedContext inside of JavaScript console object and able to get all required information from callback data. > It allows us to implement console methods without taking in account how and where we create and store these methods: > - later we can move console object implementation to builtins.. > - ..and install command line API methods smarter. > > BUG=chromium:588893 > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2784713002 > Cr-Original-Commit-Position: refs/heads/master@{#44212} > Committed: https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca915f4c > Review-Url: https://codereview.chromium.org/2784713002 > Cr-Commit-Position: refs/heads/master@{#44238} > Committed: https://chromium.googlesource.com/v8/v8/+/88f71126a5c067f98c75044bc26778f2e8ea2e79 TBR=dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:588893 Review-Url: https://codereview.chromium.org/2778743007 Cr-Commit-Position: refs/heads/master@{#44246}
-
kozyatinskiy authored
With this CL we don't need to store reference to InspectedContext inside of JavaScript console object and able to get all required information from callback data. It allows us to implement console methods without taking in account how and where we create and store these methods: - later we can move console object implementation to builtins.. - ..and install command line API methods smarter. BUG=chromium:588893 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2784713002 Cr-Original-Commit-Position: refs/heads/master@{#44212} Committed: https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca915f4c Review-Url: https://codereview.chromium.org/2784713002 Cr-Commit-Position: refs/heads/master@{#44238}
-
- 24 Mar, 2017 1 commit
-
-
kozyatinskiy authored
- added InspectorTest.setupInjectedScriptEnvironment method which mutates current context, - clear prototype of InjectedScript function and domAttributesWithObservableSideEffectOnGet. Second point increases chances that injected-script-source would be successfully compiled. BUG=chromium:693338 R=dgozman@chromium.org,luoe@chromium.org Review-Url: https://codereview.chromium.org/2770823003 Cr-Commit-Position: refs/heads/master@{#44081}
-
- 28 Feb, 2017 1 commit
-
-
kozyatinskiy authored
This method enables test of agent::restore methods. Bonus: forbid setCustomObjectFormatterEnabled on disabled agent. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2713023004 Cr-Commit-Position: refs/heads/master@{#43502}
-
- 26 Oct, 2016 1 commit
-
-
rob authored
BUG=657568 TEST=Manually, see bug report Review-Url: https://codereview.chromium.org/2432163004 Cr-Commit-Position: refs/heads/master@{#40605}
-
- 20 Oct, 2016 1 commit
-
-
hablich authored
Revert of [inspector] align console implementation with spec (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/2428473003/ ) Reason for revert: Breaks roll: https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/164610 See https://chromiumcodereview.appspot.com/2434733002/ for more context Original issue's description: > [inspector] align console implementation with spec > > console should be non enumerable. > > BUG=chromium:656826 > R=dgozman@chromium.org TBR=dgozman@chromium.org,kozyatinskiy@chromium.org NOTRY=true BUG=chromium:656826 Review-Url: https://chromiumcodereview.appspot.com/2435013002 Cr-Commit-Position: refs/heads/master@{#40464}
-
- 19 Oct, 2016 1 commit
-
-
kozyatinskiy authored
console should be non enumerable. BUG=chromium:656826 R=dgozman@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2428473003 Cr-Commit-Position: refs/heads/master@{#40414}
-
- 03 Oct, 2016 1 commit
-
-
kozyatinskiy authored
Introduce Protocol.Domain.method(args) and Protocol.Domain.onEventName() instead. Renamed InspectorTest.evaluateInPage -> InspectorTest.addScript. Improved InspectorTest.logMessage. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2390733002 Cr-Commit-Position: refs/heads/master@{#39942}
-
- 02 Oct, 2016 1 commit
-
-
kozyatinskiy authored
- added most part of inspector tests that depends only on JavaScript domains. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Committed: https://crrev.com/9ddbdab195923fc87fae3587ae06c5c1c5ca6d79 Review-Url: https://codereview.chromium.org/2369753004 Cr-Original-Commit-Position: refs/heads/master@{#39897} Cr-Commit-Position: refs/heads/master@{#39931}
-
- 30 Sep, 2016 2 commits
-
-
machenbach authored
Revert "[inspector] added inspector test runner [part 3]" This reverts commit f3f9f444. Revert "[inspector] added inspector test runner [part 4]" This reverts commit 4a5f5d09. Revert "[inspector] added inspector test runner [part 5]" This reverts commit 9ddbdab1. Reverting this in order to revert parts 1-2 which block the roll: https://codereview.chromium.org/2379053003/ BUG=chromium:635948 TBR=kozyatinskiy@chromium.org, NOTRY=true Review-Url: https://codereview.chromium.org/2379303002 Cr-Commit-Position: refs/heads/master@{#39908}
-
kozyatinskiy authored
- added most part of inspector tests that depends only on JavaScript domains. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2369753004 Cr-Commit-Position: refs/heads/master@{#39897}
-