1. 17 May, 2019 1 commit
  2. 16 May, 2019 1 commit
  3. 08 May, 2019 1 commit
    • Maciej Goszczycki's avatar
      Reland "[heap] Set read-only space's and its pages' heap_ to null." · b672d089
      Maciej Goszczycki authored
      Seems like the CodeBuilder CL actually caused this.
      
      This is a reland of 964edc25
      
      Original change's description:
      > [heap] Set read-only space's and its pages' heap_ to null.
      >
      > Various small changes are required to enable this.
      >
      > HeapObject::GetReadOnlyRoots no longer uses the Space's heap when
      > possible (see comment in ReadOnlyHeap::GetReadOnlyRoots definition).
      > This requires that ReadOnlyRoots be construct-able using a raw pointer
      > to the read-only space's roots array.
      >
      > Global read-only heap state is now cleared by tests where appropriate
      > and extra DCHECKs in ReadOnlyHeap::SetUp should make catching future
      > issues easier.
      >
      > String padding is now always cleared just before read-only space is
      > sealed when not deserializing.
      >
      > Change-Id: I7d1db1c11567be5df06ff7066f3a699125f8b372
      > Bug: v8:7464
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535830
      > Commit-Queue: Maciej Goszczycki <goszczycki@google.com>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Reviewed-by: Dan Elphick <delphick@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#61188}
      
      Bug: v8:7464
      Change-Id: If75bbd16c2e2af5b80cd60811dfd7866f8be8309
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599186
      Commit-Queue: Maciej Goszczycki <goszczycki@google.com>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61323}
      b672d089
  4. 03 May, 2019 1 commit
    • Maciej Goszczycki's avatar
      Revert "[heap] Set read-only space's and its pages' heap_ to null." · fa4b433f
      Maciej Goszczycki authored
      This reverts commit 964edc25.
      
      Reason for revert: chromium:959190
      
      Original change's description:
      > [heap] Set read-only space's and its pages' heap_ to null.
      >
      > Various small changes are required to enable this.
      >
      > HeapObject::GetReadOnlyRoots no longer uses the Space's heap when
      > possible (see comment in ReadOnlyHeap::GetReadOnlyRoots definition).
      > This requires that ReadOnlyRoots be construct-able using a raw pointer
      > to the read-only space's roots array.
      >
      > Global read-only heap state is now cleared by tests where appropriate
      > and extra DCHECKs in ReadOnlyHeap::SetUp should make catching future
      > issues easier.
      >
      > String padding is now always cleared just before read-only space is
      > sealed when not deserializing.
      >
      > Change-Id: I7d1db1c11567be5df06ff7066f3a699125f8b372
      > Bug: v8:7464
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535830
      > Commit-Queue: Maciej Goszczycki <goszczycki@google.com>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Reviewed-by: Dan Elphick <delphick@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#61188}
      
      TBR=ulan@chromium.org,hpayer@chromium.org,delphick@chromium.org,goszczycki@google.com
      
      Change-Id: I53cecf3976dfeabae309040313351385f651f010
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:7464, chromium:959190
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591608Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Commit-Queue: Adam Klein <adamk@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61217}
      fa4b433f
  5. 02 May, 2019 1 commit
    • Maciej Goszczycki's avatar
      [heap] Set read-only space's and its pages' heap_ to null. · 964edc25
      Maciej Goszczycki authored
      Various small changes are required to enable this.
      
      HeapObject::GetReadOnlyRoots no longer uses the Space's heap when
      possible (see comment in ReadOnlyHeap::GetReadOnlyRoots definition).
      This requires that ReadOnlyRoots be construct-able using a raw pointer
      to the read-only space's roots array.
      
      Global read-only heap state is now cleared by tests where appropriate
      and extra DCHECKs in ReadOnlyHeap::SetUp should make catching future
      issues easier.
      
      String padding is now always cleared just before read-only space is
      sealed when not deserializing.
      
      Change-Id: I7d1db1c11567be5df06ff7066f3a699125f8b372
      Bug: v8:7464
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535830
      Commit-Queue: Maciej Goszczycki <goszczycki@google.com>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61188}
      964edc25
  6. 30 Apr, 2019 1 commit
    • Mike Stanton's avatar
      Reland "[ptr-compr] New RelocInfo for compressed pointers." · ed319e84
      Mike Stanton authored
      Failure addressed by not exposing the new test to the jitless environment.
      (jgruber@ on TBR).
      
      New enum RelocInfo::COMPRESSED_EMBEDDED_OBJECT created to support
      compressed pointers in generated code. Enum name EMBEDDED_OBJECT
      changed to FULL_EMBEDDED_OBJECT.
      
      RelocInfo::[set_]target_object() abstract away the difference between
      FULL_EMBEDDED_OBJECT and COMPRESSED_EMBEDDED_OBJECT.
      
      Compressed embedded objects can only be created at this time on
      x64 with pointer compression turned on. Arm64 constant pools don't
      support compressed objects at this time.
      
      NOPRESUBMIT=true
      
      Bug: v8:7703
      TBR: jgruber@chromium.org
      Change-Id: Ifff53b041bab09b4b8c3e16085e5df4aa2b99f4f
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588461Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Michael Stanton <mvstanton@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61104}
      ed319e84
  7. 29 Apr, 2019 3 commits
  8. 29 Mar, 2019 1 commit
  9. 05 Mar, 2019 1 commit
  10. 25 Feb, 2019 1 commit
    • Pierre Langlois's avatar
      [heap] Relax accessing markbits in ranges. · b152bb75
      Pierre Langlois authored
      When calling the `bitmap(chunk)` method of the various *MarkingState accessors
      we would receive a raw `Bitmap` pointer which does not tell you if accesses to
      markbits should be made atomically or not. As a result, we would default to
      doing atomic operation when in fact it may not be necessary.
      
      Here we're introducing a templated `ConcurrentBitmap` class that wraps
      operations done on the markbits and allows them to be made non-atomic.
      
      Additionaly, some of the `Bitmap` methods were only used to verify the heap and
      in the tests so they do not need atomic implementations. Using them in a
      concurrent context should now fail to link to make sure they're not mis-used in
      the future.
      
      Change-Id: Ifb55f8522c8bf0c87d65da9227864ee428d21bbd
      Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel
      Reviewed-on: https://chromium-review.googlesource.com/c/1482916Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Pierre Langlois <pierre.langlois@arm.com>
      Cr-Commit-Position: refs/heads/master@{#59836}
      b152bb75
  11. 21 Feb, 2019 1 commit
  12. 19 Feb, 2019 1 commit
  13. 15 Feb, 2019 1 commit
  14. 29 Jan, 2019 1 commit
  15. 22 Jan, 2019 1 commit
  16. 10 Jan, 2019 1 commit
  17. 08 Jan, 2019 1 commit
  18. 20 Dec, 2018 1 commit
  19. 19 Dec, 2018 1 commit
  20. 10 Dec, 2018 1 commit
  21. 26 Nov, 2018 1 commit
  22. 24 Nov, 2018 1 commit
  23. 23 Nov, 2018 1 commit
  24. 22 Nov, 2018 1 commit
  25. 21 Nov, 2018 1 commit
    • Ulan Degenbaev's avatar
      [heap] Clean up TypedSlotSet. · 841c40b7
      Ulan Degenbaev authored
      This extracts the parts of the TypedSlotSet that are used only
      sequentially into a separate class called TypedSlots.
      
      The new class will be used in the concurrent marker to keep track of
      typed slots locally and then to merge them to the main remembered set
      during finalization of marking.
      
      The patch also cleans up atomics in the Iterate and ClearInvalidSlots
      methods that can run concurrently to each other.
      
      Bug:v8:8459
      
      Change-Id: Id7a63041f7b99218381e5e9e1999210cab9c4369
      Reviewed-on: https://chromium-review.googlesource.com/c/1340247
      Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
      Reviewed-by: 's avatarHannes Payer <hpayer@chromium.org>
      Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57673}
      841c40b7
  26. 07 Nov, 2018 1 commit
  27. 30 Oct, 2018 2 commits
  28. 26 Oct, 2018 1 commit
  29. 24 Oct, 2018 2 commits
  30. 23 Oct, 2018 2 commits
  31. 17 Oct, 2018 1 commit
  32. 12 Oct, 2018 1 commit
  33. 10 Oct, 2018 1 commit
  34. 28 Sep, 2018 1 commit
  35. 19 Sep, 2018 1 commit