- 18 Jul, 2018 1 commit
-
-
Dan Elphick authored
Move brackets enclosing declarator in a couple of V8_DEPRECATE_SOON cases so that the attribute is correctly placed. I.e. should come after the class keyword and after a function signature but before the body. Also adds suppressions for a case where a replacement method calls the deprecated method it replaces. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I490ff07a13552cf335186d64ca061f21ac4e8afc Reviewed-on: https://chromium-review.googlesource.com/1140593Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54527}
-
- 25 Apr, 2018 1 commit
-
-
Predrag Rudic authored
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I3fc1b53c43e53e12e041178912f372f33068d67c Reviewed-on: https://chromium-review.googlesource.com/1023418 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#52775}
-
- 06 Apr, 2018 1 commit
-
-
Clemens Hammacher authored
Replace all uses with V8_WARN_UNUSED_RESULT. WARN_UNUSED_RESULT was defined in src/base/compiler-specific.h, which includes include/v8config.h, which already defined V8_WARN_UNUSED_RESULT. R=mstarzinger@chromium.org Bug: v8:7570 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I662072294605036ca5aa0c8fdaa0218ac5d95f23 Reviewed-on: https://chromium-review.googlesource.com/998893Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52457}
-
- 26 Jun, 2017 1 commit
-
-
Clemens Hammacher authored
There were only two uses. Replace them by [[noreturn]] directly. R=jarin@chromium.org BUG=v8:6474 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I965f74f5b3493cfef9efd698f24bf00216442fd8 Reviewed-on: https://chromium-review.googlesource.com/544845Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#46205}
-
- 13 Jun, 2017 1 commit
-
-
Clemens Hammacher authored
Since we require C++11 support now, there is no need to use __attribute__ or __declspec, all compilers should support the [[noreturn]] attribute. R=jarin@chromium.org BUG=v8:6474 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I6c478c69658fd23c1c8ca468fbf3c6a36474ef66 Reviewed-on: https://chromium-review.googlesource.com/529072Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#45909}
-
- 11 Jun, 2017 1 commit
-
-
scottmg authored
Sufficient to compile //v8 in Chrome with target_os="fuchsia". Doesn't link yet, due to missing implementations (primarily VirtualMemory, as well as a few utility functions). BUG=chromium:731217 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng Review-Url: https://codereview.chromium.org/2931143002 Cr-Commit-Position: refs/heads/master@{#45831}
-
- 15 May, 2017 1 commit
-
-
Wiktor Garbacz authored
Change-Id: Ie141097c12ad578c752f51393bd5a5df176b3cad Reviewed-on: https://chromium-review.googlesource.com/504528 Commit-Queue: Wiktor Garbacz <wiktorg@google.com> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#45301}
-
- 27 Jul, 2016 1 commit
-
-
yangguo authored
Review-Url: https://codereview.chromium.org/2175193003 Cr-Commit-Position: refs/heads/master@{#38081}
-
- 22 Mar, 2016 1 commit
-
-
jfb authored
Cleanup, and matches Chromium's build. Review URL: https://codereview.chromium.org/1820583002 Cr-Commit-Position: refs/heads/master@{#34993}
-
- 25 Nov, 2015 1 commit
-
-
thakis authored
Also add a note that it should go away over time. BUG=none LOG=n Review URL: https://codereview.chromium.org/1475033003 Cr-Commit-Position: refs/heads/master@{#32290}
-
- 08 Oct, 2015 2 commits
-
-
karl authored
Without that, it has a few false positives about out-of-bounds array accesses. Also makes the clang static-analyzer happy. Original code review from Sven Panne: https://codereview.chromium.org/790723002/ CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg,v8_linux_gcc_rel Review URL: https://codereview.chromium.org/1393023003 Cr-Commit-Position: refs/heads/master@{#31185}
-
bmeurer authored
Revert of Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (patchset #3 id:40001 of https://codereview.chromium.org/1383053005/ ) Reason for revert: Breaks Arm debug. Original issue's description: > Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. > > Without that, it has a few false positives about out-of-bounds array accesses. > Also makes the clang static-analyzer happy. > > Original code review from Sven Panne: > https://codereview.chromium.org/790723002/ > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg > > Committed: https://crrev.com/93ae81101af68d81b7af84ea4046ea849e605116 > Cr-Commit-Position: refs/heads/master@{#31163} TBR=jochen@chromium.org,karl@skomski.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1398643002 Cr-Commit-Position: refs/heads/master@{#31167}
-
- 07 Oct, 2015 1 commit
-
-
karl authored
Without that, it has a few false positives about out-of-bounds array accesses. Also makes the clang static-analyzer happy. Original code review from Sven Panne: https://codereview.chromium.org/790723002/ CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg Review URL: https://codereview.chromium.org/1383053005 Cr-Commit-Position: refs/heads/master@{#31163}
-
- 05 Oct, 2015 2 commits
-
-
machenbach authored
Revert of Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (patchset #3 id:40001 of https://codereview.chromium.org/1384873002/ ) Reason for revert: [Sheriff] Breaks the gcc 4.8 bot: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/3274 Original issue's description: > Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. > > Without that, it has a few false positives about out-of-bounds array accesses. > Also makes the clang static-analyzer happy. > > Original code review from Sven Panne: > https://codereview.chromium.org/790723002/ > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg > > Committed: https://crrev.com/d068574e641e28f05dcde89ddc9a1d0ec6f6f308 > Cr-Commit-Position: refs/heads/master@{#31105} TBR=jochen@chromium.org,bmeurer@chromium.org,karl@skomski.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1376113005 Cr-Commit-Position: refs/heads/master@{#31112}
-
karl authored
Without that, it has a few false positives about out-of-bounds array accesses. Also makes the clang static-analyzer happy. Original code review from Sven Panne: https://codereview.chromium.org/790723002/ CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg Review URL: https://codereview.chromium.org/1384873002 Cr-Commit-Position: refs/heads/master@{#31105}
-
- 28 Sep, 2015 2 commits
-
-
ishell authored
Revert of Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (patchset #3 id:80001 of https://codereview.chromium.org/1361763004/ ) Reason for revert: This CL breaks cross-compiling to arm. Original issue's description: > Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. > > Without that, it has a few false positives about out-of-bounds array accesses. > Also makes the clang static-analyzer happy. > > Original code review from Sven Panne: > https://codereview.chromium.org/790723002/ > > Committed: https://crrev.com/0b48b2a8ebfc791a36f4ec1f299f46db76265a3a > Cr-Commit-Position: refs/heads/master@{#30977} TBR=jochen@chromium.org,bmeurer@chromium.org,jkummerow@chromium.org,karl@skomski.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1370203002 Cr-Commit-Position: refs/heads/master@{#30982}
-
karl authored
Without that, it has a few false positives about out-of-bounds array accesses. Also makes the clang static-analyzer happy. Original code review from Sven Panne: https://codereview.chromium.org/790723002/ Review URL: https://codereview.chromium.org/1361763004 Cr-Commit-Position: refs/heads/master@{#30977}
-
- 29 Jun, 2015 1 commit
-
-
bmeurer authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/1212163003 Cr-Commit-Position: refs/heads/master@{#29342}
-
- 12 Jun, 2015 1 commit
-
-
bmeurer authored
Up until now we used int32_t for NodeId, but that was not ideal because negative values are invalid for NodeId and we use it as an array index for example in the NodeMarker class, where C++ compilers on x64 have to generate code that does proper sign extension for the indices, which is completely unnecessary. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/1178403004 Cr-Commit-Position: refs/heads/master@{#28997}
-
- 21 May, 2015 2 commits
-
-
hans authored
This macro is used for defining static data members with STATIC_CONST_MEMBER_DEFINITION. Clang-cl mimics MSVC's behaviour here, so it also needs __declspec(selectany). This change was prompted by Clang r237787 which changed a bug where Clang would previously not emit symbols for some static data members. BUG=82385 LOG=N Review URL: https://codereview.chromium.org/1145213004 Cr-Commit-Position: refs/heads/master@{#28563}
-
jochen authored
This should help to keep syntax errors from creeping into v8.h Also, I'll remove usages of to-be-deprecated APIs and turn this flag on for standalone builds BUG=4134 R=vogelheim@chromium.org LOG=n Review URL: https://codereview.chromium.org/1149633003 Cr-Commit-Position: refs/heads/master@{#28538}
-
- 05 May, 2015 1 commit
-
-
bmeurer authored
These macros are not needed anymore, so there's no point in supporting them. Review URL: https://codereview.chromium.org/1123723003 Cr-Commit-Position: refs/heads/master@{#28214}
-
- 20 Apr, 2015 1 commit
-
-
Ross McIlroy authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/1088993003 Cr-Commit-Position: refs/heads/master@{#27937}
-
- 14 Apr, 2015 1 commit
-
-
smcgruer authored
As uClibc defines __GLIBC__ in an attempt to look like glibc, V8_LIBC_GLIBC was true for uClibc as well. Checking for uClibc before glibc fixes this and restores the correct behavior. BUG= Review URL: https://codereview.chromium.org/1066573005 Cr-Commit-Position: refs/heads/master@{#27806}
-
- 25 Mar, 2015 1 commit
-
-
alexandre.rames authored
BUG= Review URL: https://codereview.chromium.org/1003383004 Cr-Commit-Position: refs/heads/master@{#27442}
-
- 09 Mar, 2015 1 commit
-
-
Dan Carney authored
BUG= R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/990873002 Cr-Commit-Position: refs/heads/master@{#27061}
-
- 27 Feb, 2015 1 commit
-
-
dcarney authored
BUG=v8:3929 LOG=y Review URL: https://codereview.chromium.org/962983002 Cr-Commit-Position: refs/heads/master@{#26912}
-
- 30 Jan, 2015 2 commits
-
-
bmeurer authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/877753007 Cr-Commit-Position: refs/heads/master@{#26346}
-
michael_dawson authored
Contribution of PowerPC port (continuation of 422063005 and 817143002). This patch covers the key changes needed to the common files needed to support AIX. Subsequent patches will cover: - changes to update the ppc directories so they are current with the changes in the rest of the project. - remaining AIX changes not resolved by 4.8 compiler - individual optimizations for PPC This is based off of the GitHub repository https://github.com/andrewlow/v8ppc R=danno@chromium.org, svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/866843003 Cr-Commit-Position: refs/heads/master@{#26343}
-
- 02 Dec, 2014 1 commit
-
-
thakis authored
Also, remove V8_CC_CLANG since it's not read anywhere (and ideally shouldn't be). Clang tries to be compatible with gcc in clang mode, and with msvc in clang-cl mode. It wants to go down the same code paths that these compilers want to go down in most cases. For example, V8PRIxPTR was set incorrectly on Windows 64-bit before this change since macros.h assumed that checking for V8_CC_MSVC is enough to find LLP64 systems, but V8_CC_MSVC wasn't set for clang. Most other existing checks for V8_CC_MSVC should be taken for clang-cl too (and for the remaining ones, clang-cl is happy with either code path). Likewise, V8_IMMEDIATE_CRASH is currently set to a suboptimal value with clang since __builtin_trap() is only used if V8_CC_GNU is set. Including clang in the gcc and cl macros is also what chromium does. BUG=chromium:82385 LOG=y Review URL: https://codereview.chromium.org/757553004 Cr-Commit-Position: refs/heads/master@{#25592}
-
- 22 Oct, 2014 1 commit
-
-
bmeurer@chromium.org authored
This fixes the problem of not being able to detect ARM features on ChromeOS because sandbox cannot access /proc/self/auxv and /proc/cpuinfo there. Drive-by-cleanup to libc detection in two other places. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/672543002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Oct, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/656143004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24735 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Sep, 2014 1 commit
-
-
bmeurer@chromium.org authored
TEST=base-unittests,compiler-unittests,cctest R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/555833002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23809 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Sep, 2014 1 commit
-
-
bmeurer@chromium.org authored
Less useless creativity is best creativity! R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/526223002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23579 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
The bit counting functions provided by CompilerIntrinsics were undefined for zero, which was easily overlooked and unsafe in general. Also their implementation was kinda hacky and mostly untested. Fixed the implementation and moved the functions to base/bits.h. TEST=base-unittests,cctest,compiler-unittests,mjsunit R=hpayer@chromium.org Review URL: https://codereview.chromium.org/494633002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23229 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Jan, 2014 1 commit
-
-
bmeurer@chromium.org authored
Use this for detecting MSVCRT library features instead of V8_CC_MSVC. One use case for this is when compiling with Clang together with the MSVC library. In that case, V8_CC_MSVC will be false, but V8_LIBC_MSVCRT will be true. BUG=82385 LOG=n R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/145593003 Patch from Hans Wennborg <hans@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18888 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Jan, 2014 1 commit
-
-
bmeurer@chromium.org authored
This patch contains contributions from the following members of the BlackBerry Web Technologies team: Eli Fidler <efidler@blackberry.com> Konrad Piascik <kpiascik@blackberry.com> Jeff Rogers <jrogers@blackberry.com> Cosmin Truta <ctruta@blackberry.com> Peter Wang <peter.wang@torchmobile.com.cn> Xiaobo Wang <xiaobwang@blackberry.com> Ming Xie <mxie@blackberry.com> Leo Yang <leoyang@blackberry.com> R=bmeurer@chromium.org, jkummerow@chromium.org Review URL: https://codereview.chromium.org/61153009 Patch from Cosmin Truta <ctruta@blackberry.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18430 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Nov, 2013 1 commit
-
-
jkummerow@chromium.org authored
BUG=v8:2767,v8:2149 R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/69413002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17641 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Sep, 2013 1 commit
-
-
dcarney@chromium.org authored
also add a deprecation message for newer gcc versions R=danno@chromium.org BUG= Review URL: https://codereview.chromium.org/25226002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17006 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-