Commits · be0fcaa2bc5922717318758f6b299fdc8d7b6a27 · Linshizhi / V8

24 Nov, 2014 4 commits

Added test cases for truncating stores. · be0fcaa2

svenpanne authored Nov 24, 2014

Review URL: https://codereview.chromium.org/741643003

Cr-Commit-Position: refs/heads/master@{#25474}

be0fcaa2

don't use to-be-deprecated Value::To* without isolate parameter · b1667fca

dcarney authored Nov 24, 2014

R=svenpanne@chromium.org

BUG=

Review URL: https://codereview.chromium.org/725293003

Cr-Commit-Position: refs/heads/master@{#25473}

b1667fca

Fix alignment of Code::kConstantPoolOffset. · c1bfc348

andrew_low authored Nov 24, 2014

This is needed for 64bit alignment sensitive platforms (PowerPC)
Exposed bugs with new GC compare and swap changes updating the
field.

Example failing test:
out/ppc64.debug/cctest  test-decls/ExistsInPrototype

BUG=

Review URL: https://codereview.chromium.org/740443002

Cr-Commit-Position: refs/heads/master@{#25472}

c1bfc348

remove some isolate::currents from api.cc · 3bfc3ae7

dcarney authored Nov 24, 2014

R=svenpanne@chromium.org

BUG=

Review URL: https://codereview.chromium.org/691513005

Cr-Commit-Position: refs/heads/master@{#25471}

3bfc3ae7

22 Nov, 2014 2 commits

Revert of Enable inobject double fields unboxing for 64-bit archs. (patchset... · d6cd4eab

ishell authored Nov 22, 2014

Revert of Enable inobject double fields unboxing for 64-bit archs. (patchset #3 id:40001 of https://codereview.chromium.org/753503002/)

Reason for revert:
GCMole and gc-stress issues.

Original issue's description:
> Enable inobject double fields unboxing for 64-bit archs.

TBR=verwaest@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/751863002

Cr-Commit-Position: refs/heads/master@{#25470}

d6cd4eab

Enable inobject double fields unboxing for 64-bit archs. · 726eb9d5

ishell authored Nov 22, 2014

Review URL: https://codereview.chromium.org/753503002

Cr-Commit-Position: refs/heads/master@{#25469}

726eb9d5

21 Nov, 2014 18 commits

harmony-scoping: Disallow cross-script assignment to const · 4d4ed236

dslomov authored Nov 21, 2014

R=rossberg@chromium.org
BUG=v8:2198
LOG=N

Review URL: https://codereview.chromium.org/745963002

Cr-Commit-Position: refs/heads/master@{#25468}

4d4ed236

Revert "Remove deprecated ShouldSelfOptimize machinery." · 7aad1d2e

mstarzinger authored Nov 21, 2014

This reverts commit 9da92c1a because of performance regressions.

R=danno@chromium.org

Review URL: https://codereview.chromium.org/752613002

Cr-Commit-Position: refs/heads/master@{#25467}

7aad1d2e

[turbofan]: remove optimization of adds/subs to inc and dec · 4f1cc515

danno authored Nov 21, 2014

They generally cause regressions on most modern Intel chips. Replace them with
addl/subl.

Review URL: https://codereview.chromium.org/737153003

Cr-Commit-Position: refs/heads/master@{#25466}

4f1cc515

[turbofan] put late ssa deconstruction in register allocator behind a flag · ac3c4d40
dcarney authored Nov 21, 2014
```
BUG=

Review URL: https://codereview.chromium.org/751543002

Cr-Commit-Position: refs/heads/master@{#25465}
```
ac3c4d40

Rip out bzip compression for native sources. · 9b8d4059

yangguo authored Nov 21, 2014

R=vogelheim@chromium.org

Review URL: https://codereview.chromium.org/750543002

Cr-Commit-Position: refs/heads/master@{#25464}

9b8d4059

Slightly improve tests that rely on lazy compilation. · 5414c399

yangguo authored Nov 21, 2014

R=rossberg@chromium.org
BUG=v8:3712
LOG=N

Review URL: https://codereview.chromium.org/743843003

Cr-Commit-Position: refs/heads/master@{#25463}

5414c399

Introduce a flag to change the new space growth factor · 34363bf5

jochen authored Nov 21, 2014

A useful value would be 4, so we get 1, 4, 16MB (instead of the default
value 2 which leads to 1, 2, 4, 8, 16)

BUG=none
R=hpayer@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/753513002

Cr-Commit-Position: refs/heads/master@{#25462}

34363bf5

[turbofan] put spill slot reuse behind a flag · dad405a2

dcarney authored Nov 21, 2014

BUG=

Review URL: https://codereview.chromium.org/748773002

Cr-Commit-Position: refs/heads/master@{#25461}

dad405a2

ARM64: skip flaky mozilla/ecma/Date/15.9.5.26-1 until it is fixed. · 132871a6

ulan authored Nov 21, 2014

BUG=v8:3716
LOG=N

Review URL: https://codereview.chromium.org/746983002

Cr-Commit-Position: refs/heads/master@{#25460}

132871a6

Remove deprecated ShouldSelfOptimize machinery. · 9da92c1a

mstarzinger authored Nov 21, 2014

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/582683002

Cr-Commit-Position: refs/heads/master@{#25459}

9da92c1a

Fix mozilla expectations after regexp change. · 5d65e137

Yang Guo authored Nov 21, 2014

TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/749963002

Cr-Commit-Position: refs/heads/master@{#25458}

5d65e137

Correctly escape RegExp source. · 61bee5c8

yangguo authored Nov 21, 2014

R=ulan@chromium.org
BUG=v8:3229
LOG=N

Review URL: https://codereview.chromium.org/736003002

Cr-Commit-Position: refs/heads/master@{#25457}

61bee5c8

Assert to protect against polymorphic string loads fires on valid stores. · cf572694

Michael Stanton authored Nov 21, 2014

BUG=435477
LOG=N
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/751513002

Cr-Commit-Position: refs/heads/master@{#25456}

cf572694

Fix for 435073: CHECK failure in CHECK(p->IsSmi()) failed. · 3d58b82a

Michael Stanton authored Nov 21, 2014

The bug was an error when copying arrays in crankshaft. If it's a holey smi
array, the copy must be done as FAST_HOLEY_ELEMENTS to prevent representation
changes from being inserted that deopt on encountering the hole.

Also, prevent inlining array pop() and shift() if the length is read-only.

BUG=435073
LOG=N
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/737383002

Cr-Commit-Position: refs/heads/master@{#25455}

3d58b82a

[turbofan] Avoid useless zero-extension on arm64. · fada2a08

Baptiste Afsa authored Nov 21, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/737733002

Cr-Commit-Position: refs/heads/master@{#25454}

fada2a08

dump compiler stats from d8 on direct exit from js · 0ed433ce

dcarney authored Nov 21, 2014

BUG=

Review URL: https://codereview.chromium.org/753483002

Cr-Commit-Position: refs/heads/master@{#25453}

0ed433ce

Fix the compilation issue for turbofan unsupported backend which · 4c11d75d

chunyang.dai authored Nov 21, 2014

is introduced by https://chromium.googlesource.com/v8/v8/+/aed26c05a50b2a1257ef8accc67143825f2e1f60.
( [turbofan] Clean up and factor out branch generation logic.)

BUG=

Review URL: https://codereview.chromium.org/748673002

Cr-Commit-Position: refs/heads/master@{#25452}

4c11d75d

MIPS: [turbofan] Clean up and factor out branch generation logic. · 9182813f

Akos Palfi authored Nov 21, 2014

Port aed26c05a50b2a1257ef8accc67143825f2e1f60

BUG=
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/742243003

Cr-Commit-Position: refs/heads/master@{#25451}

9182813f

20 Nov, 2014 16 commits

Cache template literal callSiteObj · ad86a1a2

caitpotter88 authored Nov 20, 2014

BUG=v8:3230
LOG=y

Review URL: https://codereview.chromium.org/742643003

Cr-Commit-Position: refs/heads/master@{#25450}

ad86a1a2

Do not put D8 and TEST natives into the external snapshot. · 4d48e1b7

baixo authored Nov 20, 2014

D8 natives, in particular, will cause Windows static builds to not link due to another definition in the generated file d8-js.cc.

BUG=421063

Review URL: https://codereview.chromium.org/738153003

Cr-Commit-Position: refs/heads/master@{#25449}

4d48e1b7

Rename String.prototype.contains to 'includes'. · 5aed61cc

dslomov authored Nov 20, 2014

Per TC39 Nov 2014 decison.

R=arv@chromium.org,yangguo@chromium.org
LOG=Y

Committed: https://chromium.googlesource.com/v8/v8/+/b5379216e23ff0ec734e70361dd07057c2421c96

Review URL: https://codereview.chromium.org/742963002

Cr-Commit-Position: refs/heads/master@{#25448}

5aed61cc

Do not bailout from optimizing functions that use f(x, arguments) · dc889623

ulan authored Nov 20, 2014

if there is not enough type-feedback to detect that f is Function.prototype.apply.

BUG=v8:3709
LOG=N
TEST=mjsunit/regress/regress-3709

Review URL: https://codereview.chromium.org/736043002

Cr-Commit-Position: refs/heads/master@{#25447}

dc889623

[turbofan] Clean up and factor out branch generation logic. · 87e9d839

titzer authored Nov 20, 2014

R=dcarney@chromium.org
BUG=

Review URL: https://codereview.chromium.org/745633002

Cr-Commit-Position: refs/heads/master@{#25446}

87e9d839

Remove superflous SharedFunctionInfo::uses_super call. · bf11bf47

mstarzinger authored Nov 20, 2014

R=danno@chromium.org

Review URL: https://codereview.chromium.org/736383002

Cr-Commit-Position: refs/heads/master@{#25445}

bf11bf47

When optimizing deserialized code, make sure IC state is preserved. · c64b47f5

yangguo authored Nov 20, 2014

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/737373003

Cr-Commit-Position: refs/heads/master@{#25444}

c64b47f5

[turbofan] use double temp registers for stack-stack swap on arm64 · be782ea7

Dan Carney authored Nov 20, 2014

TBR=vogelheim@chromium.org

BUG=

Review URL: https://codereview.chromium.org/744743002

Cr-Commit-Position: refs/heads/master@{#25443}

be782ea7

Fix Regress3540 after r25441. · 29704b50

Ulan Degenbaev authored Nov 20, 2014

BUG=
TBR=hpayer@chromium.org

Review URL: https://codereview.chromium.org/746443002

Cr-Commit-Position: refs/heads/master@{#25442}

29704b50

Reserve code range block for evacuation. · d703e875

ulan authored Nov 20, 2014

If we run out of code range, then GC wouldn't be able to compact code space,
because it wouldn't be able to allocate a new page. This can cause code space
fragmentation and OOM crashes.

BUG=chromium:430118
LOG=Y

Review URL: https://codereview.chromium.org/742733002

Cr-Commit-Position: refs/heads/master@{#25441}

d703e875

[turbofan] More aggressive reuse of spill slots in the register allocator. · b11825fe
dcarney authored Nov 20, 2014
```
BUG=

Review URL: https://codereview.chromium.org/725083004

Cr-Commit-Position: refs/heads/master@{#25440}
```
b11825fe

[turbofan]: More optimizations to add and subtract operations on x64 · 5a494cf0

Daniel Clifford authored Nov 20, 2014

- Use "leal" for subtraction of integer constant when non-constant input to
  subtract is used more than once.
- Use "incl", "decl", and "addl" when they are smaller/cheaper than their
  leal/addl/subl equivalant.

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/738073002

Cr-Commit-Position: refs/heads/master@{#25439}

5a494cf0

[turbofan] remove redundant '& 0x1F' for shifts. · 481772ac

Rodolph Perfetta authored Nov 20, 2014

JavaScript shifts perform an implicit '& 0x1F' on their right operand, this
patch removes it when the underlying architecture already does it.

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/732103002

Cr-Commit-Position: refs/heads/master@{#25438}

481772ac

Enable TurboFan for Win64 targets. · 6d41045b

mstarzinger authored Nov 20, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/743963002

Cr-Commit-Position: refs/heads/master@{#25437}

6d41045b

Fix lower bound violation · 4f635647

Andreas Rossberg authored Nov 20, 2014

R=jarin@chromium.org
BUG=433332
LOG=N

Review URL: https://codereview.chromium.org/739563002

Cr-Commit-Position: refs/heads/master@{#25436}

4f635647

Disable classes in sloppy mode unless --harmony-sloppy is set · 1808badc

Andreas Rossberg authored Nov 20, 2014

Also clean up flag names a little.

Baseline: https://codereview.chromium.org/713413003/

R=arv@chromium.org, dslomov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/722203006

Cr-Commit-Position: refs/heads/master@{#25435}

1808badc