- 17 Jan, 2022 1 commit
-
-
Simon Zünd authored
This CL introduces a dedicated API to retrieve the current (w.r.t. the JS stack) script name or sourceURL. Currently, API clients will collect multiple stack traces in increasing sizes to accomplish the same goal. The new method walks the JS stack in the same way as the stack trace collection mechanic but doesn't create/allocate stack info or callsite objects along the way. R=bmeurer@chromium.org, yangguo@chromium.org Doc: https://bit.ly/v8-current-script-name Bug: chromium:1286677 Change-Id: Id53e4f04bf17349d34f3d581bc712b1f4aa055db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3382818Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#78645}
-
- 30 Dec, 2021 1 commit
-
-
Benedikt Meurer authored
This introduces a new `GetLocation()` method for `v8::StackFrame`s, which returns both line and column number at the same time (using the existing `v8::Location` class). Since `v8::StackFrame` instances store only the source position (per https://bit.ly/v8-stack-frame), we currently need to look up the source position in the Script's line table twice, once when we request the line number, and another time when we request the column number. With `GetLocation()` we perform only a single lookup in the Script's line table and return both line and column number at the same time. This cuts roughly 8% of the average execution time from the `standalone.js` benchmark mentioned in crbug.com/1280519. Bug: chromium:1280519, chromium:1278650, chromium:1069425 Bug: chromium:1077657, chromium:1283162 Doc: https://bit.ly/v8-cheaper-inspector-stack-traces Change-Id: Ia3a0502990b6230363112a358b59875283399404 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3359628Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#78452}
-
- 24 Aug, 2021 1 commit
-
-
Dan Elphick authored
This is a reland of d1b27019 Fixes include: Adding missing file to bazel build Forward-declaring classing before friend-classing them to fix win/gcc Add missing v8-isolate.h include for vtune builds Original change's description: > [include] Split out v8.h > > This moves every single class/function out of include/v8.h into a > separate header in include/, which v8.h then includes so that > externally nothing appears to have changed. > > Every include of v8.h from inside v8 has been changed to a more > fine-grained include. > > Previously inline functions defined at the bottom of v8.h would call > private non-inline functions in the V8 class. Since that class is now > in v8-initialization.h and is rarely included (as that would create > dependency cycles), this is not possible and so those methods have been > moved out of the V8 class into the namespace v8::api_internal. > > None of the previous files in include/ now #include v8.h, which means > if embedders were relying on this transitive dependency then it will > give compile failures. > > v8-inspector.h does depend on v8-scripts.h for the time being to ensure > that Chrome continue to compile but that change will be reverted once > those transitive #includes in chrome are changed to include it directly. > > Full design: > https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing > > Bug: v8:11965 > Change-Id: I53b84b29581632710edc80eb11f819c2097a2877 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76424} Cq-Include-Trybots: luci.v8.try:v8_linux_vtunejit Bug: v8:11965 Change-Id: I99f5d3a73bf8fe25b650adfaf9567dc4e44a09e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113629Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/main@{#76460}
-
- 23 Aug, 2021 2 commits
-
-
Dan Elphick authored
This reverts commit d1b27019. Reason for revert: Broke vtune build, tsan build and possibly others Original change's description: > [include] Split out v8.h > > This moves every single class/function out of include/v8.h into a > separate header in include/, which v8.h then includes so that > externally nothing appears to have changed. > > Every include of v8.h from inside v8 has been changed to a more > fine-grained include. > > Previously inline functions defined at the bottom of v8.h would call > private non-inline functions in the V8 class. Since that class is now > in v8-initialization.h and is rarely included (as that would create > dependency cycles), this is not possible and so those methods have been > moved out of the V8 class into the namespace v8::api_internal. > > None of the previous files in include/ now #include v8.h, which means > if embedders were relying on this transitive dependency then it will > give compile failures. > > v8-inspector.h does depend on v8-scripts.h for the time being to ensure > that Chrome continue to compile but that change will be reverted once > those transitive #includes in chrome are changed to include it directly. > > Full design: > https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing > > Bug: v8:11965 > Change-Id: I53b84b29581632710edc80eb11f819c2097a2877 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76424} Bug: v8:11965 Change-Id: Id57313ae992e720c8b19abc975cd69729e1344aa No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3113627 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#76428}
-
Dan Elphick authored
This moves every single class/function out of include/v8.h into a separate header in include/, which v8.h then includes so that externally nothing appears to have changed. Every include of v8.h from inside v8 has been changed to a more fine-grained include. Previously inline functions defined at the bottom of v8.h would call private non-inline functions in the V8 class. Since that class is now in v8-initialization.h and is rarely included (as that would create dependency cycles), this is not possible and so those methods have been moved out of the V8 class into the namespace v8::api_internal. None of the previous files in include/ now #include v8.h, which means if embedders were relying on this transitive dependency then it will give compile failures. v8-inspector.h does depend on v8-scripts.h for the time being to ensure that Chrome continue to compile but that change will be reverted once those transitive #includes in chrome are changed to include it directly. Full design: https://docs.google.com/document/d/1rTD--I8hCAr-Rho1WTumZzFKaDpEp0IJ8ejZtk4nJdA/edit?usp=sharing Bug: v8:11965 Change-Id: I53b84b29581632710edc80eb11f819c2097a2877 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097448Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/main@{#76424}
-
- 12 Feb, 2018 1 commit
-
-
Yang Guo authored
R=jgruber@chromium.org Bug: v8:5510 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ic0ba012ed7ff66f034c5a54554b2ab36d1d70d2c Reviewed-on: https://chromium-review.googlesource.com/911110Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: ปอ คับ <misspor061853@gmail.com> Cr-Commit-Position: refs/heads/master@{#51245}
-
- 10 Mar, 2017 1 commit
-
-
yangguo authored
R=clemensh@chromium.org, jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2727393003 Cr-Commit-Position: refs/heads/master@{#43714}
-
- 02 Feb, 2017 1 commit
-
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2670823002 Cr-Commit-Position: refs/heads/master@{#42893}
-
- 23 Jan, 2017 1 commit
-
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2642253005 Cr-Original-Commit-Position: refs/heads/master@{#42543} Committed: https://chromium.googlesource.com/v8/v8/+/e26a58e43c51a680a0a6363e0066886f4971a41f Review-Url: https://codereview.chromium.org/2642253005 Cr-Commit-Position: refs/heads/master@{#42595}
-
- 20 Jan, 2017 2 commits
-
-
yangguo authored
Revert of [debugger api] remove legacy JSON debug protocol. (patchset #2 id:20001 of https://codereview.chromium.org/2642253005/ ) Reason for revert: Node.js relies on this Original issue's description: > [debugger api] remove legacy JSON debug protocol. > > R=jgruber@chromium.org > BUG=v8:5530 > > Review-Url: https://codereview.chromium.org/2642253005 > Cr-Commit-Position: refs/heads/master@{#42543} > Committed: https://chromium.googlesource.com/v8/v8/+/e26a58e43c51a680a0a6363e0066886f4971a41f TBR=jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5530 Review-Url: https://codereview.chromium.org/2644233003 Cr-Commit-Position: refs/heads/master@{#42549}
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2642253005 Cr-Commit-Position: refs/heads/master@{#42543}
-
- 11 Jan, 2017 1 commit
-
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2589203002 Cr-Original-Commit-Position: refs/heads/master@{#41911} Committed: https://chromium.googlesource.com/v8/v8/+/381082168d37d4f2794360ae31dc078f2a350113 Review-Url: https://codereview.chromium.org/2589203002 Cr-Commit-Position: refs/heads/master@{#42220}
-
- 23 Dec, 2016 1 commit
-
-
yangguo authored
Revert of [debugger] deprecate v8::Debug:GetDebugContext. (patchset #2 id:20001 of https://codereview.chromium.org/2589203002/ ) Reason for revert: crbug/676749 Original issue's description: > [debugger] deprecate v8::Debug:GetDebugContext. > > R=jgruber@chromium.org > BUG=v8:5530 > > Review-Url: https://codereview.chromium.org/2589203002 > Cr-Commit-Position: refs/heads/master@{#41911} > Committed: https://chromium.googlesource.com/v8/v8/+/381082168d37d4f2794360ae31dc078f2a350113 TBR=jgruber@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5530, chromium:676749 Review-Url: https://codereview.chromium.org/2595413003 Cr-Commit-Position: refs/heads/master@{#41935}
-
- 22 Dec, 2016 1 commit
-
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5530 Review-Url: https://codereview.chromium.org/2589203002 Cr-Commit-Position: refs/heads/master@{#41911}
-
- 02 Dec, 2016 1 commit
-
-
jgruber authored
This relands API deprecation (without removing the implementation), removal of NewFunction and BeforeCompile events, and removal of DebugCommandProcessor tests. The remaining portion of the original CLs can be relanded after the 4.7 branch point. Original CLs: https://codereview.chromium.org/2524323002 https://codereview.chromium.org/2531543002 BUG=v8:5510 Review-Url: https://codereview.chromium.org/2546473008 Cr-Commit-Position: refs/heads/master@{#41446}
-
- 01 Dec, 2016 1 commit
-
-
jgruber authored
Debugging API is still in use by Node. Revert "[debug] remove deprecated debug command message queue." This reverts commit abdbfc95. Revert "[debug] mark more unused debug API as deprecated." This reverts commit d5ada19c. BUG=v8:5530 Review-Url: https://codereview.chromium.org/2537313005 Cr-Commit-Position: refs/heads/master@{#41427}
-
- 25 Nov, 2016 1 commit
-
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5510 Review-Url: https://codereview.chromium.org/2531543002 Cr-Commit-Position: refs/heads/master@{#41283}
-
- 24 Nov, 2016 2 commits
-
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5510 Review-Url: https://codereview.chromium.org/2524323002 Cr-Commit-Position: refs/heads/master@{#41259}
-
yangguo authored
In most cases we can use the debug event listener as alternative. Multithreaded tests are obsolete. R=jgruber@chromium.org BUG=v8:5510 Review-Url: https://codereview.chromium.org/2529883002 Cr-Commit-Position: refs/heads/master@{#41256}
-
- 20 Jul, 2016 1 commit
-
-
yangguo authored
Review-Url: https://codereview.chromium.org/2162503002 Cr-Commit-Position: refs/heads/master@{#37892}
-
- 06 Jun, 2016 1 commit
-
-
jochen authored
Since the generic GetCallingContext is deprecated, but there's still the use case for the debugger to get the currently debugged context while in the debug context, add a convenience API for it. Note that EventDetails already exposes this context, but the embedder might not necessarily have the EventDetails around. R=verwaest@chromium.org BUG= Review-Url: https://codereview.chromium.org/2040853003 Cr-Commit-Position: refs/heads/master@{#36751}
-
- 05 Apr, 2016 1 commit
-
-
kozyatinskiy authored
We decided to remove related devtools experiment. BUG=chromium:526811 LOG=Y R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1833563002 Cr-Commit-Position: refs/heads/master@{#35275}
-
- 30 Mar, 2016 1 commit
-
-
ishell authored
BUG=v8:4698 LOG=N TBR=rossberg@chromium.org Review URL: https://codereview.chromium.org/1842763002 Cr-Commit-Position: refs/heads/master@{#35132}
-
- 04 Dec, 2015 1 commit
-
-
jochen authored
We should consider deprecating the message based API as well in the future. BUG=none R=yangguo@chromium.org LOG=y Review URL: https://codereview.chromium.org/1485333007 Cr-Commit-Position: refs/heads/master@{#32621}
-
- 02 Dec, 2015 1 commit
-
-
jochen authored
BUG=v8:2487 LOG=n R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/1496493002 Cr-Commit-Position: refs/heads/master@{#32509}
-
- 03 Sep, 2015 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1318863004 Cr-Commit-Position: refs/heads/master@{#30554}
-
- 06 Jul, 2015 1 commit
-
-
jochen authored
BUG=v8:4131 R=bmeurer@chromium.org LOG=n Review URL: https://codereview.chromium.org/1224623004 Cr-Commit-Position: refs/heads/master@{#29473}
-
- 12 May, 2015 4 commits
-
-
yurys authored
Some of the DevTools' clients need to inspect JS objects without enabling debugger. This CL allows to inspect object's internal properties without enabling debugger and instantiating debug context. Note that now debug context can be created lazily if v8::Debug::GetDebugContext is called when there is no debug listener. This is fragile and has already resulted in some subtle error. I'm going to fix that in a separate CL. BUG=chromium:481845 LOG=Y Review URL: https://codereview.chromium.org/1134193002 Cr-Commit-Position: refs/heads/master@{#28371}
-
yangguo authored
Revert of Provide accessor for object internal properties that doesn't require debugger to be active (patchset #3 id:40001 of https://codereview.chromium.org/1126103006/) Reason for revert: GC mole issues: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gcmole/builds/1950/steps/GCMole%20ia32/logs/stdio Original issue's description: > Provide accessor for object internal properties that doesn't require debugger to be active > > Some of the DevTools' clients need to inspect JS objects without enabling debugger. This CL allows to inspect object's internal properties without enabling debugger and instantiating debug context. > > Note that now debug context can be created lazily if v8::Debug::GetDebugContext is called when there is no debug listener. This is fragile and has already resulted in some subtle error. I'm going to fix that in a separate CL. > > BUG=chromium:481845 > LOG=Y > > Committed: https://crrev.com/bdeb0de88c8cf5f2c78f261b45314138f525110d > Cr-Commit-Position: refs/heads/master@{#28362} TBR=pfeldman@chromium.org,kozyatinskiy@chromium.org,yurys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:481845 Review URL: https://codereview.chromium.org/1133243002 Cr-Commit-Position: refs/heads/master@{#28365}
-
yurys authored
Some of the DevTools' clients need to inspect JS objects without enabling debugger. This CL allows to inspect object's internal properties without enabling debugger and instantiating debug context. Note that now debug context can be created lazily if v8::Debug::GetDebugContext is called when there is no debug listener. This is fragile and has already resulted in some subtle error. I'm going to fix that in a separate CL. BUG=chromium:481845 LOG=Y Review URL: https://codereview.chromium.org/1126103006 Cr-Commit-Position: refs/heads/master@{#28362}
-
yurys authored
If there had been no debug listener v8::Debug::GetDebugContext would have created new context and wouln't have kept reference to it. This way we may well end up with several debug contexts and disabled debugger. As a side effect this change allows to efficiently distinguish debug context from blink contexts by simply comparing handles. BUG=chromium:482290 LOG=Y Review URL: https://codereview.chromium.org/1136733002 Cr-Commit-Position: refs/heads/master@{#28356}
-
- 27 Apr, 2015 1 commit
-
-
yangguo authored
The debug event BreakForCommand is now deprecated, as it cannot happen any longer. R=ulan@chromium.org Review URL: https://codereview.chromium.org/1089893002 Cr-Commit-Position: refs/heads/master@{#28071}
-
- 07 Apr, 2015 1 commit
-
-
yangguo authored
Instead, please use v8::Isolate::RequestInterrupt to synchronize to the main thread. R=yurys@chromium.org API=Removed v8::Debug::DebugBreakForCommand LOG=Y Review URL: https://codereview.chromium.org/1036863002 Cr-Commit-Position: refs/heads/master@{#27625}
-
- 11 Mar, 2015 1 commit
-
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/993223003 Cr-Commit-Position: refs/heads/master@{#27126}
-
- 20 Aug, 2014 1 commit
-
-
yangguo@chromium.org authored
API=v8::Debug::CheckDebugBreak LOG=Y R=aandrey@chromium.org, vsevik@chromium.org, yurys@chromium.org Review URL: https://codereview.chromium.org/473913002 Patch from Sergei Vasilinetc <sergeyv@chromium.org>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23227 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jul, 2014 1 commit
-
-
aandrey@chromium.org authored
R=yangguo@chromium.org, adamk@chromium.org, rafaelw@chromium.org, rossberg@chromium.org BUG=chromium:272416 LOG=Y Review URL: https://codereview.chromium.org/362783002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jun, 2014 1 commit
-
-
yangguo@chromium.org authored
R=aandrey@chromium.org, rossberg@chromium.org BUG=v8:3093 LOG=Y Review URL: https://codereview.chromium.org/357603005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22086 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Jun, 2014 1 commit
-
-
yangguo@chromium.org authored
R=yurys@chromium.org Review URL: https://codereview.chromium.org/358873005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22063 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Jun, 2014 1 commit
-
-
yurys@chromium.org authored
This event is generated when the parser can not generate code. R=vsevik@chromium.org, yangguo@chromium.org, yurys@chromium.org Review URL: https://codereview.chromium.org/264333007 Patch from Alexey Kozyatinskiy <kozyatinskiy@google.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22043 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Jun, 2014 1 commit
-
-
svenpanne@chromium.org authored
R=ulan@chromium.org Review URL: https://codereview.chromium.org/322293003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21763 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-