1. 03 Jul, 2018 1 commit
  2. 19 Mar, 2018 1 commit
    • jgruber's avatar
      Reland "[builtins] Remove off-heap builtins from the snapshot" · fd70917d
      jgruber authored
      This is a reland of f1b1ec70
      
      Original change's description:
      > [builtins] Remove off-heap builtins from the snapshot
      >
      > This CL is the final major step towards shipping off-heap-safe builtins
      > embedded into the binary.
      >
      > Prior to snapshot serialization, we now:
      > * create the embedded blob containing off-heap instruction streams,
      > * use that to generate embedded.cc (containing embedded binary data),
      > * replace off-heap-safe builtins with trampolines,
      > * and serialize those into the final snapshot.
      >
      > The new RelocInfo::OFF_HEAP_TARGET kind is used to fix up trampoline
      > targets on deserialization.
      >
      > Bug: v8:6666
      > Change-Id: Ib07aea9e3bd7ecdec42291c1388b3a7453ea96ce
      > Reviewed-on: https://chromium-review.googlesource.com/950775
      > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#51960}
      
      TBR=yangguo@chromium.org,mstarzinger@chromium.org
      
      Cq-Include-Trybots: luci.v8.try:v8_mac64_dbg,v8_mac64_rel
      Bug: v8:6666
      Change-Id: Id9954af3c8195754ff3658c4603858904fcf88c4
      Reviewed-on: https://chromium-review.googlesource.com/964481
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52006}
      fd70917d
  3. 15 Mar, 2018 2 commits
  4. 09 Mar, 2018 2 commits
    • jgruber's avatar
      [builtins] Remove unneeded code · 391fb8fe
      jgruber authored
      It turns out that with the help of Code::Instruction{Start,End,Size}
      helpers, we don't need custom profiler methods.
      
      InstructionStream is now all-static.
      
      Bug: v8:6666
      Change-Id: I59e1d2d2cb72c128725a1ed03f11506d40e76224
      Reviewed-on: https://chromium-review.googlesource.com/947973
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#51837}
      391fb8fe
    • jgruber's avatar
      Reland "[builtins] Execute binary-embedded builtin code" · 5025e415
      jgruber authored
      This is a reland of 6afd25ff
      
      Original change's description:
      > [builtins] Execute binary-embedded builtin code
      >
      > This CL creates trampolines into binary-embedded builtins on
      > isolate-creation, if --stress-off-heap-code is passed.
      >
      > Note that this still overwrites existing code objects with the
      > off-heap trampoline, and that off-heap builtins still exist both in
      > the snapshot and the binary. Addressing these points are the next
      > steps.
      >
      > Drive-by-change: More efficient off-heap code lookups now that the
      > off-heap memory area has a contiguous and static layout.
      >
      > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng
      > Bug: v8:6666
      > Change-Id: I7e7ef0aa2cd7b8184ae3a13fa02bdcbb4f2c9f86
      > Reviewed-on: https://chromium-review.googlesource.com/947969
      > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#51809}
      
      TBR=mstarzinger@chromium.org
      
      Bug: v8:6666
      Change-Id: I4e0684de90733e5f18f6f0ea4832e327d03dfbf7
      Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/955595Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#51835}
      5025e415
  5. 08 Mar, 2018 2 commits
    • Jakob Gruber's avatar
      Revert "[builtins] Execute binary-embedded builtin code" · d4c4345e
      Jakob Gruber authored
      This reverts commit 6afd25ff.
      
      Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug%20-%20fyi/builds/1437
      
      Original change's description:
      > [builtins] Execute binary-embedded builtin code
      > 
      > This CL creates trampolines into binary-embedded builtins on
      > isolate-creation, if --stress-off-heap-code is passed.
      > 
      > Note that this still overwrites existing code objects with the
      > off-heap trampoline, and that off-heap builtins still exist both in
      > the snapshot and the binary. Addressing these points are the next
      > steps.
      > 
      > Drive-by-change: More efficient off-heap code lookups now that the
      > off-heap memory area has a contiguous and static layout.
      > 
      > Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng
      > Bug: v8:6666
      > Change-Id: I7e7ef0aa2cd7b8184ae3a13fa02bdcbb4f2c9f86
      > Reviewed-on: https://chromium-review.googlesource.com/947969
      > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#51809}
      
      TBR=mstarzinger@chromium.org,jgruber@chromium.org
      
      Change-Id: I18276541b468b9d2b2a1366ccd287822e96b6df7
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:6666
      Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/956042Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#51816}
      d4c4345e
    • jgruber's avatar
      [builtins] Execute binary-embedded builtin code · 6afd25ff
      jgruber authored
      This CL creates trampolines into binary-embedded builtins on
      isolate-creation, if --stress-off-heap-code is passed.
      
      Note that this still overwrites existing code objects with the
      off-heap trampoline, and that off-heap builtins still exist both in
      the snapshot and the binary. Addressing these points are the next
      steps.
      
      Drive-by-change: More efficient off-heap code lookups now that the
      off-heap memory area has a contiguous and static layout.
      
      Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng
      Bug: v8:6666
      Change-Id: I7e7ef0aa2cd7b8184ae3a13fa02bdcbb4f2c9f86
      Reviewed-on: https://chromium-review.googlesource.com/947969
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#51809}
      6afd25ff
  6. 23 Feb, 2018 1 commit
  7. 01 Feb, 2018 1 commit