Commits · bc21f42563e5a2b3bc76ec1ec07c67eb8ab958bc · Linshizhi / V8

04 Mar, 2014 14 commits

Refactoring: Make script dependencies more object-oriented in push and merge scripts. · bc21f425

machenbach@chromium.org authored Mar 04, 2014

- Connect the top-level scripts via inheritance and remove top-level functions
- Options and option processing can be extended from base to subclass script

This CL is split off from https://codereview.chromium.org/173983002/

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/185263003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19664 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bc21f425

MIPS: Remove all uses of field-tracking flags that do not make decisions but... · 66d1246f

plind44@gmail.com authored Mar 04, 2014

MIPS: Remove all uses of field-tracking flags that do not make decisions but are subject to existing information.

Port r19650 (a51b043)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/180803010

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19663 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

66d1246f

MIPS: Push safepoint registers in deferred number-to-i/u only on-demand. · 66b794cb

plind44@gmail.com authored Mar 04, 2014

Port r19649 (49f8c2d)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/186673004

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19662 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

66b794cb

A64: Move veneer emission checking in the Assembler. · 83c7b602

alexandre.rames@arm.com authored Mar 04, 2014

The previous heuristic would break as a significant amount of code could be
generated without checking for veneer emission.
The veneer emission is now done in the Assembler, in a very similar way to
constant pool emission.

BUG=v8:3177
LOG=N
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/181873002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19661 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

83c7b602

Print properly signed displacement in IA32 disassembler. · 827adfe4

mstarzinger@chromium.org authored Mar 04, 2014

R=jkummerow@chromium.org
BUG=

Review URL: https://codereview.chromium.org/176993004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19652 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

827adfe4

Refactoring to clean up duplicate code in Heap::Allocate methods. · 45ebabfb

mvstanton@chromium.org authored Mar 04, 2014

R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/170703002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19651 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

45ebabfb

Remove all uses of field-tracking flags that do not make decisions but are... · 9b8021ad

verwaest@chromium.org authored Mar 04, 2014

Remove all uses of field-tracking flags that do not make decisions but are subject to existing information.

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/173963002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19650 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9b8021ad

Push safepoint registers in deferred number-to-i/u only on-demand. · e16cc0ac

bmeurer@chromium.org authored Mar 04, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/181053005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19649 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e16cc0ac

Allow objects with "" properties to stay fast. · 1aeaeb2b

verwaest@chromium.org authored Mar 04, 2014

R=danno@chromium.org

Review URL: https://codereview.chromium.org/184453003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19648 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1aeaeb2b

Don't disable hash randomization option in predictable mode. · 1d3f32ea

ishell@chromium.org authored Mar 04, 2014

We don't need it because
1) hash randomization uses random generator whose results depend on --random-seed option which is set in predictable mode.
2) disabling hash randomization triggers assert in snapshot mode.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/171813015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19647 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1d3f32ea

Fix HStringAdd::PrintDataTo(). · 766af5c2

bmeurer@chromium.org authored Mar 04, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/185403005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19646 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

766af5c2

Prepare push to trunk. Now working on version 3.25.4. · f447e4c3

titzer@chromium.org authored Mar 04, 2014

R=hpayer@chromium.org
TBR=hpayer@chromium.org

Review URL: https://codereview.chromium.org/185533011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19643 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f447e4c3

Fix HCheckValue::Canonicalize wrt uninitialized HConstant unique. · b1a271a0

yangguo@chromium.org authored Mar 04, 2014

R=titzer@chromium.org
BUG=348280
LOG=N

Review URL: https://codereview.chromium.org/183383006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19642 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b1a271a0

Add try server configuration for 'git cl try'. · bebe5209

machenbach@chromium.org authored Mar 04, 2014

BUG=
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/177533029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19641 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bebe5209

03 Mar, 2014 6 commits

Add coverage analysis to push and merge script tests. · 73bb6c6b

machenbach@chromium.org authored Mar 03, 2014

The coverage analysis must live in an extra file in order to analyze the scripts when being imported.

TEST=tools/push-to-trunk/script_test.py
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/183923013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19640 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

73bb6c6b

Consolidate RecordWriteFromCode and RecordWriteForEvacuationFromCode. · b3ecfa32

hpayer@chromium.org authored Mar 03, 2014

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/185233008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19639 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b3ecfa32

Make EvictFromOptimizedCodeMap more robust. · 81f1b0bd

ulan@chromium.org authored Mar 03, 2014

This removes all occurences of the specified optimized code from the optimized
code map.

R=titzer@chromium.org, yangguo@chromium.org

Review URL: https://codereview.chromium.org/181493004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19638 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

81f1b0bd

Fix A64 after 19635. · c3347e4e

ulan@chromium.org authored Mar 03, 2014

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/184103013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19637 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c3347e4e

Fix symbol printing in migration / generalization tracing · ec54d9a9

verwaest@chromium.org authored Mar 03, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/176713006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ec54d9a9

Clear optimized code cache in shared function info when code gets deoptimized. · b9e0b87a

ulan@chromium.org authored Mar 03, 2014

This adds a pointer to the shared function info into deoptimization data of an optimized code. Whenever the code is deoptimized, it clears the cache in the shared function info.

This fixes the problem when the optimized function dies in new space GC before the code is deoptimized due to code dependency and before the optimized code cache is cleared in old space GC (see mjsunit/regress/regress-343609.js).

This partially reverts r19603 because we need to be able to evict specific code from the optimized code cache.

BUG=343609
LOG=Y
TEST=mjsunit/regress/regress-343609.js
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/184923002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19635 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b9e0b87a

28 Feb, 2014 20 commits

Refactoring: Long option names in push and merge scripts. · 5acdc942

machenbach@chromium.org authored Feb 28, 2014

This CL is split off from https://codereview.chromium.org/173983002/

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/180873010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19632 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5acdc942

Fix ChangeLog entries. · bc2e7a60

commit-bot@chromium.org authored Feb 28, 2014

NOTREECHECKS=true
BUG=

Review URL: https://codereview.chromium.org/179873021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19629 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bc2e7a60

Fix line distance in push and merge scripts. · 56060812

commit-bot@chromium.org authored Feb 28, 2014


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19628 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

56060812

Move all Harmony-only tests to harmony/ · 5543263c

rossberg@chromium.org authored Feb 28, 2014

R=jkummerow@chromium.org
BUG=

Review URL: https://codereview.chromium.org/178583005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19622 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5543263c

Update README about where the test262 files are downloaded from. · 227cac3b

jochen@chromium.org authored Feb 28, 2014

BUG=none
TBR=jkummerow@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/184573003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19620 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

227cac3b

Check elimination did not mark some dead blocks. · c2601aea

ishell@chromium.org authored Feb 28, 2014

R=danno@chromium.org

Review URL: https://codereview.chromium.org/180483003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19619 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c2601aea

Revert "Remove Script::SetData and the script_data parameter from Script::(Compile|New)." · 40ffba58

marja@chromium.org authored Feb 28, 2014

This reverts revision 19616.

BUG=
TBR=marja@chromium.org,svenpanne@chromium.org

Review URL: https://codereview.chromium.org/181113008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19618 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

40ffba58

Fix ARM/MIPS versions of r19607 · 8b4c59fc

jkummerow@chromium.org authored Feb 28, 2014

kNoCodeAgeSequenceLength is in bytes on ia32/x64, but in instructions on arm/mips.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/183893006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19617 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8b4c59fc

Remove Script::SetData and the script_data parameter from Script::(Compile|New). · 55750b1c

marja@chromium.org authored Feb 28, 2014

This feature makes it possible to associate data with a script and get it back
when the script is compiled or when an event is handled. It was historically
used by Chromium Dev Tools, but not any more. It is not used by node.js.

Note: this has nothing to do with the preparse data, despite the confusing name.
The preparse data is passed as ScriptData*.

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/184403002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19616 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

55750b1c

Remove bogus assertion regarding code marked for deopt. · 99c6ba13

yangguo@chromium.org authored Feb 28, 2014

TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/178583003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19610 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

99c6ba13

Fixed constant folding for Math.clz32. · e9273332

svenpanne@chromium.org authored Feb 28, 2014

LOG=y
BUG=347906
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/184353002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19609 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e9273332

Make a64.release a quickcheck target · ba981e58

jochen@chromium.org authored Feb 28, 2014

I marked all tests as slow that take more than a minute on my machine.
With this, a64.release.quickcheck takes two minutes which is about as
fast as arm.optdebug.quickcheck.

BUG=none
R=ulan@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/183763008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19608 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ba981e58

Fail early when re-entering code that has been patched for lazy deopt · 85367a7d

jkummerow@chromium.org authored Feb 28, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/184373004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19607 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

85367a7d

Update test262 to get test data from github · 6b23cd07

jochen@chromium.org authored Feb 28, 2014

BUG=none
R=jkummerow@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/184223002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19606 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6b23cd07

When upgrading the test data twice, don't bail out because of an existing backup · 9d515242

jochen@chromium.org authored Feb 28, 2014

BUG=none
R=jkummerow@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/183853004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19605 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9d515242

A JSArray may have a filler map in the elements pointer. · b1ffc790

mvstanton@chromium.org authored Feb 28, 2014

We already have code that expects this, but incorrectly asserted that the
filler map case would never happen when allocation folding is turned on.
However, even folding has it's limits, bailing out of continued folding
when the object size grows too large. Therefore, it's a general problem
when verifying JSArray objects, that we might encounter a filler map
in elements().

Discovered by ClusterFuzz crbug 347903.

R=hpayer@chromium.org
LOG=N
BUG=347903

Review URL: https://codereview.chromium.org/184493002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19604 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b1ffc790

Evict from optimized code map in sync with removing from optimized functions list. · 5c186bb1

yangguo@chromium.org authored Feb 28, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/184443002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19603 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5c186bb1

parser: fix build on solaris · f524f51e

marja@chromium.org authored Feb 28, 2014

`FS` is defined in `regset.h` on solaris and smartos.

BUG=
R=ulan@chromium.org, danno@chromium.org

Review URL: https://codereview.chromium.org/176403004

Patch from Fedor Indutny <fedor.indutny@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19602 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f524f51e

Fix JSObject::PrintTransitions. · 70242fe3

bmeurer@chromium.org authored Feb 28, 2014

BUG=347912
LOG=y
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/183683005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19601 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

70242fe3

Fix representation generalization for doubles. · 38ca2629

hpayer@chromium.org authored Feb 28, 2014

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/184393002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19599 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

38ca2629