- 15 Feb, 2019 1 commit
-
-
Sigurd Schneider authored
Change-Id: I43efddcbd381be3d61deb94515842e582069ffb9 Bug: v8:8834 Reviewed-on: https://chromium-review.googlesource.com/c/1475465Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59640}
-
- 14 Nov, 2018 1 commit
-
-
Leszek Swirski authored
Moves the unicode predicate cache tables out of the unicode cache, and turns them into generic predicates in char-predicates.h which use static constexpr tables. This drops the per-isolate cost of unicode caches, and removes the need for accessing the unicode cache from most files. It does remove the mutability of the cache, which means that there may be regressions when parsing non-ASCII identifiers. Most likely the benefits to ASCII identifiers/keywords will outweigh any non-ASCII costs. Change-Id: I9a7a8b7c9b22d3e9ede824ab4e27f133ce20a399 Reviewed-on: https://chromium-review.googlesource.com/c/1335564Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57506}
-
- 02 Aug, 2018 1 commit
-
-
Florian Sattler authored
This is a reland of baa055c7 Original change's description: > Applied noexcept to all mctors and massigns > > Refactoring the code base to use noexcept for their move constructors and move > assignment operators. > > Bug: v8:7999 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I13d24eddba3bfa601cff26fd680a040cf4e71426 > Reviewed-on: https://chromium-review.googlesource.com/1152817 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Florian Sattler <sattlerf@google.com> > Cr-Commit-Position: refs/heads/master@{#54841} Bug: v8:7999 Change-Id: I72394e326a4f8da462ee6285511d721440ceb21d Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1158646Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#54863}
-
- 01 Aug, 2018 3 commits
-
-
Clemens Hammacher authored
This reverts commit baa055c7. Reason for revert: mips compile failure: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mips%20-%20builder/18458 Original change's description: > Applied noexcept to all mctors and massigns > > Refactoring the code base to use noexcept for their move constructors and move > assignment operators. > > Bug: v8:7999 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I13d24eddba3bfa601cff26fd680a040cf4e71426 > Reviewed-on: https://chromium-review.googlesource.com/1152817 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Florian Sattler <sattlerf@google.com> > Cr-Commit-Position: refs/heads/master@{#54841} TBR=marja@chromium.org,yangguo@chromium.org,ahaas@chromium.org,jgruber@chromium.org,sattlerf@google.com Change-Id: I49757025daac368a647887a63164e927f0106803 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7999 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1158644Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54843}
-
Florian Sattler authored
Refactoring the code base to use noexcept for their move constructors and move assignment operators. Bug: v8:7999 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I13d24eddba3bfa601cff26fd680a040cf4e71426 Reviewed-on: https://chromium-review.googlesource.com/1152817Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#54841}
-
Clemens Hammacher authored
This moves the {ReadUnalignedValue} and {WriteUnalignedValue} methods from utils.h to v8memory.h. R=titzer@chromium.org Bug: v8:7754, v8:7490 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8becfc3ac169427968c11e24b035a90856f51e8e Reviewed-on: https://chromium-review.googlesource.com/1158405Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54837}
-
- 26 Apr, 2018 2 commits
-
-
Alexey Kozyatinskiy authored
This is a reland of 436faae0 Original change's description: > [inspector] added timeout for Debugger.evaluateOnCallFrame method > > R=dgozman@chromium.org,yangguo@chromium.org > > Bug: none > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I569899f245190ca2fa720bdb837db1263e8058d5 > Reviewed-on: https://chromium-review.googlesource.com/1023035 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52798} Bug: none Change-Id: I91219382b5dc45b54dd8e5c64d9f0d11c849b9c8 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1030510 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52818}
-
Michael Achenbach authored
This reverts commit 436faae0. Reason for revert: Introduces flakes: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/24482 https://build.chromium.org/p/client.v8/builders/V8%20Win32/builds/13557 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/25210 Original change's description: > [inspector] added timeout for Debugger.evaluateOnCallFrame method > > R=dgozman@chromium.org,yangguo@chromium.org > > Bug: none > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I569899f245190ca2fa720bdb837db1263e8058d5 > Reviewed-on: https://chromium-review.googlesource.com/1023035 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52798} TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org Change-Id: I63ee0d19642856a7c0c2128bfa4c4620974d1919 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1029910Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52800}
-
- 25 Apr, 2018 1 commit
-
-
Alexey Kozyatinskiy authored
R=dgozman@chromium.org,yangguo@chromium.org Bug: none Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I569899f245190ca2fa720bdb837db1263e8058d5 Reviewed-on: https://chromium-review.googlesource.com/1023035 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#52798}
-
- 20 Feb, 2018 1 commit
-
-
Ivica Bogosavljevic authored
During hash calculation, an array type was reinterpreted from uint16_[] to uint32_t[]. Uint32 arrays have stricter alignment requirements and these causes failures of several tests from the debugger suite. TEST=debugger/debug/debug-eval-scope Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I463c7aeb56a1010ddfb0c34f8404f05b75e6c466 Reviewed-on: https://chromium-review.googlesource.com/926341 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#51398}
-
- 23 Jun, 2017 1 commit
-
-
jgruber authored
This piggy-backs on top of existing precise and best-effort coverage to expose block coverage through the inspector protocol. Coverage collection now implicitly reports block-granularity coverage when available. A new 'isBlockCoverage' property on Inspector's FunctionCoverage type specifies the granularity of reported coverage. For now, only count-based block coverage is supported, but binary block coverage should follow soon. Support is still gated behind the --block-coverage flag. Bug: v8:6000 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I9c4d64e1d2a098e66178b3a68dcee800de0081af Reviewed-on: https://chromium-review.googlesource.com/532975 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#46157}
-
- 28 Apr, 2017 1 commit
-
-
kozyatinskiy authored
This roll includes: - [inspector_protocol] added StringUtil::toDouble method as requirement [1] [1] https://codereview.chromium.org/2843223005/ BUG=chromium:712610 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2846673005 Cr-Commit-Position: refs/heads/master@{#44954}
-
- 24 Feb, 2017 2 commits
-
-
kozyatinskiy authored
We don't call any of v8::Debug methods in src/inspector codebase and should use debug-interface.h instead. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2710243002 Cr-Original-Commit-Position: refs/heads/master@{#43398} Committed: https://chromium.googlesource.com/v8/v8/+/838b1a8841aba0c421b413c01b0fbd3c024c2249 Review-Url: https://codereview.chromium.org/2710243002 Cr-Commit-Position: refs/heads/master@{#43420}
-
machenbach authored
Revert of [inspector] removed unused #include "include/v8-debug.h" (patchset #2 id:20001 of https://codereview.chromium.org/2710243002/ ) Reason for revert: breaks presubmit on CI which runs checkdeps Original issue's description: > [inspector] removed unused #include "include/v8-debug.h" > > We don't call any of v8::Debug methods in src/inspector codebase and should use debug-interface.h instead. > > BUG=none > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2710243002 > Cr-Commit-Position: refs/heads/master@{#43398} > Committed: https://chromium.googlesource.com/v8/v8/+/838b1a8841aba0c421b413c01b0fbd3c024c2249 TBR=dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review-Url: https://codereview.chromium.org/2719433002 Cr-Commit-Position: refs/heads/master@{#43404}
-
- 23 Feb, 2017 2 commits
-
-
kozyatinskiy authored
We don't call any of v8::Debug methods in src/inspector codebase and should use debug-interface.h instead. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2710243002 Cr-Commit-Position: refs/heads/master@{#43398}
-
bradnelson authored
Adding a full run of checkdeps to tools/presubmit.py so that we keep checkdeps green. PRESUBMIT.py checks only incremental changes. Temporarily disabling a check rule that's broker in the inspector, pending owners fix. BUG= R=machenbach@chromium.org,dgozman@chromium.org,eholk@chromium.org Review-Url: https://codereview.chromium.org/2705333005 Cr-Commit-Position: refs/heads/master@{#43397}
-
- 24 Jan, 2017 1 commit
-
-
kozyatinskiy authored
V8 has internal mechanism to ignore steps and breaks inside internal scripts, in this CL it's reused for blackboxing implementation. Advantages: - much faster blackboxing implementation (before we at least wrap and collect current call stack for each step), - get rid of StepFrame action and potential pause in blackboxed code after N StepFrame steps, - simplification of debugger agent logic. Disadvtanges: - currently when user was paused in blackboxed code (e.g. on breakpoint) and then makes step action, debugger ignores blackboxed state of the script and allows to use step actions as usual - this behavior is regressed, we still able to support it on frontend side. Current state and proposed changes for blackboxing: https://docs.google.com/document/d/1hnzaXPAN8_QC5ENxIgxgMNDbXLraM_OXT73rAyijTF8/edit?usp=sharing BUG=v8:5842 R=yangguo@chromium.org,dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2633803002 Cr-Commit-Position: refs/heads/master@{#42614}
-
- 29 Nov, 2016 1 commit
-
-
kozyatinskiy authored
V8 internally uses conversions.h to convert number to string, we can use these methods too instead of slow std::stringstream with std::locale. BUG=chromium:661497,v8:5551 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2534013002 Cr-Commit-Position: refs/heads/master@{#41334}
-
- 18 Oct, 2016 1 commit
-
-
kozyatinskiy authored
debug-interface.h contains part of v8-debug.h that is used by src/inspector. BUG=v8:5510 R=dgozman@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/2423713003 Cr-Commit-Position: refs/heads/master@{#40404}
-
- 14 Oct, 2016 2 commits
-
-
alph authored
It will allow timeline to show JS profile on code evaluated from console. BUG=chromium:655430 Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172 Review-Url: https://codereview.chromium.org/2413943002 Cr-Original-Commit-Position: refs/heads/master@{#40289} Cr-Commit-Position: refs/heads/master@{#40323}
-
machenbach authored
Revert of [inspector] Record EvaluateScript trace event upon console evaluation (patchset #2 id:20001 of https://codereview.chromium.org/2413943002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10647 See also: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [inspector] Record EvaluateScript trace event upon console evaluation > > It will allow timeline to show JS profile on code evaluated from console. > > BUG=chromium:655430 > > Committed: https://crrev.com/6882c91ecd222f3ee2feb42ad73fbc796d5c8172 > Cr-Commit-Position: refs/heads/master@{#40289} TBR=caseq@chromium.org,paulirish@chromium.org,dgozman@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:655430 Review-Url: https://codereview.chromium.org/2416213002 Cr-Commit-Position: refs/heads/master@{#40299}
-
- 13 Oct, 2016 1 commit
-
-
alph authored
It will allow timeline to show JS profile on code evaluated from console. BUG=chromium:655430 Review-Url: https://codereview.chromium.org/2413943002 Cr-Commit-Position: refs/heads/master@{#40289}
-
- 15 Sep, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2340763003 Cr-Commit-Position: refs/heads/master@{#39453}
-
- 13 Sep, 2016 2 commits
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2336023002 Cr-Commit-Position: refs/heads/master@{#39363}
-
kozyatinskiy authored
Going forward we may relax this, but it is a conscious decision to be made. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2337523003 Cr-Commit-Position: refs/heads/master@{#39362}
-