1. 18 Jun, 2020 1 commit
  2. 04 Jun, 2020 1 commit
  3. 05 Sep, 2019 1 commit
  4. 15 Mar, 2019 1 commit
  5. 27 Dec, 2018 1 commit
  6. 15 Oct, 2018 1 commit
    • Clemens Hammacher's avatar
      [base] Sync Optional implementation to chromium · da339e60
      Clemens Hammacher authored
      There were a lot of tweaks and optimizations to chromium's
      {base::Optional} implementation. This CL brings us back in sync with
      that.
      Some changes were needed to make this compatible with C++11 and with
      GCC 4.8:
      1) Types like std::decay_t and std::enable_if_t were rewritten to
         use std::decay and std::enable_if.
      2) Some conditional no_except declarations were removed.
      3) std::is_trivially_copy_constructible and
         std::is_trivially_move_constructible are assumed to be false on
         gcc 4 because it's unimplemented there.
      
      R=neis@chromium.org
      
      Bug: v8:8238
      Change-Id: Ia0542c0d4d2fd43a2454f639ec5201ad8d8201cd
      Reviewed-on: https://chromium-review.googlesource.com/c/1275824
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
      Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56625}
      da339e60
  7. 14 Sep, 2018 1 commit
  8. 16 Aug, 2018 1 commit
  9. 02 Aug, 2018 1 commit
  10. 01 Aug, 2018 2 commits
  11. 31 Jan, 2018 1 commit
  12. 09 Jun, 2017 1 commit
    • Clemens Hammacher's avatar
      [base] Introduce base::Optional, cloned from chromium · 58ca2115
      Clemens Hammacher authored
      base::Optional is a replacement for std::optional, until we switch to
      C++17 and can use std::optional directly.
      The implementation is copied from chromium's base::Optional, but put in
      the {v8::base} namespace instead of just {base}. Also, the
      specialization of std::hash for base::Optional is omitted, since it's
      disallowed in the style guide.
      
      A first use in the AsmJsParser is introduced, if that one sticks, I
      will refactor more uses of std::unique_ptr to use base::Optional
      instead, avoiding the heap allocation.
      
      R=mstarzinger@chromium.org
      BUG=v8:6474
      
      Change-Id: I019599d4bf9ff0105bf592dfb96d6050feba18ae
      Reviewed-on: https://chromium-review.googlesource.com/528884
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#45810}
      58ca2115