- 15 Mar, 2019 7 commits
-
-
Alexei Filippov authored
Introduces the setMaxCollectedScriptsSize Debugger protocol method. If the max size is set, the debugger will hold collected (not referenced by other v8 heap objects) scripts up to the specified total size of their sources. > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518556 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> BUG=v8:8988 TBR=dgozman@chromium.org Change-Id: I6f7da07c4c9ae35b5252aabddb98b693ec77b4e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524662Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#60255}
-
Ben Smith authored
Bug: v8:7226 Change-Id: Ia2ed97b193e77a016aa10e7abd50ce59ea38f7a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518558 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#60254}
-
Ben Smith authored
This CL only provides the implementation of memory.{init,copy,fill} and data.drop. Bug: v8:8965 Change-Id: I439f2520bfee8f147e4b0d1d31f954aaad2e14ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1510575 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60253}
-
Aseem Garg authored
R=binji@chromium.org,adamk@chromium.org Bug=v8:7742 Change-Id: I5b9a614dd0c8b028d756cbd401c803de4cb9437f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513159 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/dae979a..a2b5691 Editorial: Extract an "asynchronously instantiate a WebAssembly module" algorithm. (Daniel Ehrenberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/a2b5691 Editorial: Extract an "instantiate the core of a WebAssembly module" algorithm. (Daniel Ehrenberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/4ecc1b1 Editorial: Remove an unnecessary local variable in "create an instance object". (Daniel Ehrenberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/e4bea69 Editorial: Extract a "create an instance object" algorithm. (Daniel Ehrenberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/0555abc Editorial: Extract a "read the imports" algorithm. (Daniel Ehrenberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/e738239 Editorial: Stop breaking lists to insert a note. (Ms2ger) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/e692daa TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: If5d941a44b9c37d5ad2f2f76e3a726cefa9557fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525098Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60251}
-
Aseem Garg authored
This CL also changes the constructor for WasmTableObject so that the maximum_length is set to undefined instead of a default value if there's no maximum provided. R=binji@chromium.org,adamk@chromium.org Bug=v8:7742 Change-Id: I6310224e9997464bf69c198e2694a6cd76e01e8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513156 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2678ddc..77c810a Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/4457947..62f9eb0 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2afe880..f8e2315 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/40c1942..1c2fa0f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/8a36736..3dd606a TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: If25a10068d40afd68abab42534b8fbafc0834848 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1525097Reviewed-by:
-
- 14 Mar, 2019 23 commits
-
-
peterwmwong authored
Consolidates all the work into a single TFS builtin (CreateHTML) called by all these functions. Reduces the builtin size by about half. Change-Id: I92b2c7889f72db4c8c79d7ef0ce0e61036ab619e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1522727 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60248}
-
Matt Gardner authored
Bug: v8:8952 Change-Id: I099de2052941684d4ca714062a52c82ef0bb3850 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1516473 Commit-Queue: Matt Gardner <magardn@microsoft.com> Reviewed-by:
-
Caitlin Potter authored
Fix original imlpementation to support occurrence in eval(), and unskip tests. BUG=v8:8523 r=gsathya@chromium.org, mathias@chromium.org, littledan@chromium.org Change-Id: I80a3e8623357947c564a6cdf865eeff435b8e640 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1510792Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#60246}
-
Leszek Swirski authored
Since the new Objects were introduced, we can no longer cast integers to and Object pointer and call methods on them in gdb (due to how gdb's expression evaluator deals with temporaries). So, we add a new helper method to our gdbinit, "$job", which takes an address and returns an Object that is now exists in real (stack) memory. Bug: v8:8994 Change-Id: I760a007e7d2303e3a4b1fecb87e094fb9974e91e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523329 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#60245}
-
Sigurd Schneider authored
Change-Id: Ib9f423439f418be5ef15e2a65b9118f8f234cb5b Bug: v8:8834 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524201Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60244}
-
Ulan Degenbaev authored
This should have no effect unless the embedder uses an old version of the standard library with missing overloads of <math.h> functions, which causes such functions to perform implicit conversion to double. In such cases, the CL removes the implicit conversion. Change-Id: Ib90a461c81b1f354f7acdf32df88257bff20aca8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523549 Auto-Submit: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60243}
-
Clemens Hammacher authored
Compilation only stores whether an error has been found, but not the exact error or it's location. This is generated by running a validation pass once all wire bytes have been received. This unifies error messages by removing one more location where we generate compilation error messages, and makes it deterministic because a) we always report the error in the first failing function, and b) if names are present, the error message will always contain the function name. R=titzer@chromium.org Bug: chromium:926311, v8:8814 Change-Id: I79551b8bb73dcee503484de343a3ada60a6add4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1521112 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60242}
-
Maciej Goszczycki authored
Piggybacking of splitting heap setup, this change adds a shared read-only heap and a flag to enable it. Also makes CallOnce use std::function instead of a raw function pointer so the CL can use lambdas with CallOnce. Bug: v8:7464 Change-Id: I9a97fb1baa6badca39a7381de3fd9e01f5969340 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518180Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Cr-Commit-Position: refs/heads/master@{#60241}
-
Georg Neis authored
Main changes: - Rename ProcessedFeedback to ElementAccessFeedback and introduce a base class with the old name ProcessedFeedback. - Introduce another kind of ProcessedFeedback, namely GlobalAccessFeedback for the LoadGlobal/StoreGlobal IC. It's either a PropertyCell or a script context slot. - Produce such processed feedback in the serializer, when visiting LdaGlobal and similar bytecodes. - Consume it, and disallow heap access, in JSNativeContextSpecialization's ReduceJSLoadGlobal and ReduceJSStoreGlobal (for --concurrent-inlining). Minor changes: - Introduce a FeedbackSource class (pair of FeedbackVector and FeedbackSlot) that is used as the key of the processed feedback hash table. We already have two similar classes, FeedbackNexus and VectorSlotPair, but both are unsuitable for technical reasons (e.g. FeedbackNexus construction accesses the heap). Eventually we should remove VectorSlotPair. - Processed feedback is now returned as a pointer, which is nullptr if the original feedback wasn't interesting (e.g. megamorphic). The title says "partially" because the CL doesn't yet take into account named accesses where the receiver happens to be the global proxy. Bug: v8:7790 Change-Id: I4404d98636b91a8f2d5667115944bae4773a4770 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518184 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#60240}
-
Andreas Haas authored
R=mstarzinger@chromium.org Bug: v8:7581 Change-Id: Id8b9c3596eb6caf5ee7048a87a676a85dba0c5dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1520711 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This simplifies some code by removing unneeded checks and early returns. I just accidentally hit got one more instance of this, and I think we should get rid of the requirement of only decoding LEBs that start before the end pointer of the decoder. R=titzer@chromium.org Change-Id: I608c5c1c292088ac14fac20b7cb030f39c165bd7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523550Reviewed-by:
-
Michael Starzinger authored
This is a minimalistic script usable for creating packages of gcmole together with the corresponding Clang. Such packages are used on V8's infrastructure. R=machenbach@chromium.org BUG=v8:8813 Change-Id: Iee3594a3acdc7a4e5b5d5628e5557725d27d9ced Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523068 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
This reverts commit 57bc36aa. Reason for revert: Frame may not be allowed accesses to half size location. Reverting as a precautionary measure. Original change's description: > [ptr-compr] Correct size for tagged values in GetByteWidth > > Bug: v8:8477 > Change-Id: Id565bb8a4d420b715e3e89325786de699e30b22c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1517883 > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60197} TBR=mvstanton@chromium.org,solanes@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8477 Change-Id: Id0482074972194d8e8c531e0ea06da762e0262b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523347 Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#60236}
-
Leszek Swirski authored
It is a design decision of pointer compression to allow unaligned pointers, so disable this check in UBSan. Bug: v8:7703 Change-Id: I3fab34e77ad755cdef3cd385a3615e3d0e350c16 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523346 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Maya Lekova authored
Introduced a CHECK instead and details about the invariant it relies on. R=neis@chromium.org, rmcilroy@chromium.org Change-Id: I568fc6d737c6bf70bd7aabf47df22651e3fcf8fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1517882Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#60234}
-
Clemens Hammacher authored
We want to get rid of the atomicops library, hence switch all uses to std::atomic. R=mlippautz@chromium.org Bug: v8:8926, v8:8834 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Change-Id: I9b7cca83703775b1ddee4f16f51b7ad6535bb67c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1520717Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60233}
-
Leszek Swirski authored
Since StreamedSource takes ownership of the ExternalSourceStream passed into it, it should take it by unique_ptr rather than raw pointer to signal this transfer of ownership. The old constructor is now deprecated. Change-Id: I24681926c2f3141f7dd3664f72019a4c6deabfd7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1520713 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#60232}
-
Maya Lekova authored
This reverts commit 589d1a6b. Reason for revert: Breaking UBSan - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/5219 Original change's description: > [ptr-compr][x64] Temporarily enable pointer compression on x64 > > ... and make sure that the x64 ptr-compr bots proceed testing V8 without > pointer compression in order to keep testing the full pointer mode. > > Bug: v8:7703 > Change-Id: Iee725deda813425a6f0722948b54976154f50909 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1497139 > Reviewed-by: Michael Hablich <hablich@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60230} TBR=machenbach@chromium.org,hablich@chromium.org,ishell@chromium.org,verwaest@chromium.org Change-Id: I5a9f04acba1ef23ae944d97a029ea018808c7fcb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7703 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1522991Reviewed-by:
-
Igor Sheludko authored
... and make sure that the x64 ptr-compr bots proceed testing V8 without pointer compression in order to keep testing the full pointer mode. Bug: v8:7703 Change-Id: Iee725deda813425a6f0722948b54976154f50909 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1497139Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit 5a61630d. Reason for revert: Breaking gc stress bot - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/21477 Original change's description: > [inspector] Allow limiting the total size of collected scripts. > > Introduces the setMaxCollectedScriptsSize Debugger protocol method. > If the max size is set, the debugger will hold collected (not referenced by other v8 heap objects) > scripts up to the specified total size of their sources. > > BUG=v8:8988 > > Change-Id: I94d52866494102add91ca2d569a2044b08c9c593 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518556 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60227} TBR=dgozman@chromium.org,alph@chromium.org,kozyatinskiy@chromium.org Change-Id: I26de645e425f0f7d5aa8212eeefda76dad695b78 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8988 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1522988Reviewed-by:
-
Sergiy Belozorov authored
TBR=sergiyb@chromium.org Bug: chromium:934964 Change-Id: I4005a0422df68b357e6b34313d31f421c27cc95b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513612 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#60228}
-
Alexei Filippov authored
Introduces the setMaxCollectedScriptsSize Debugger protocol method. If the max size is set, the debugger will hold collected (not referenced by other v8 heap objects) scripts up to the specified total size of their sources. BUG=v8:8988 Change-Id: I94d52866494102add91ca2d569a2044b08c9c593 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518556 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#60227}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/96d6f98..2678ddc Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/794f2d1..4457947 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/967fadd..2afe880 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8b94108..40c1942 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/2fd941d..8c67416 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ff65c25..8a36736 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I5032fbb6066a8e4891caf0b1201090f1d56e6ac7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1522726Reviewed-by:
-
- 13 Mar, 2019 10 commits
-
-
Johannes Henkel authored
Change-Id: I270de4fa2970c9e33600453aaecc1c786701dcc3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1521326Reviewed-by:
-
Maciej Goszczycki authored
Splits heap setup to enable a single setup method on read-only heap. This simplifies shared read-only heap initialization code. Bug: v8:7464 Change-Id: If4f61e1fbc4780e19dcda2b2d50050b2c204b0e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1518179 Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Reviewed-by:
-
Junliang Yan authored
Change-Id: I9bd7c97dd0b36935bd1fb76cd2cbc83a1b28cdfb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1521223 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Auto-Submit: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#60223}
-
Maciej Goszczycki authored
This enables things like simple DCHECKs in functions that do not have access to isolate or heap. Change-Id: I7962c28f0c6a4928ee880f1373501f29e45ae1f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1517886Reviewed-by:
-
Simon Zünd authored
R=yangguo@chromium.org Bug: v8:8742 Change-Id: I307097021893617ed5178f1e967f9360a55cd929 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1520710 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:8977 Change-Id: I3bf6606d9db2369f5d82c71c5f58f6cf0c34bc0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1520712 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Z Duong Nguyen-Huu authored
JSArrayIterator, PreparseData Bug: v8:8952 Change-Id: I0a58402012f6fd5ded0eab92f7e28e3523342650 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1516474Reviewed-by:
-
Benedikt Meurer authored
The JSONTraceWriter didn't write the "flow_in", "flow_out" and "bind_id" fields, which are necessary to support TRACE_EVENT_WITH_FLOW and friends. This just mirrors the logic from trace_event_impl.cc in Chrome. Bug: v8:8991 Change-Id: I496db587fbb74d3c7205bbab4c23ec41c63fa715 Document: http://bit.ly/v8-tracing-signals Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1521108Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60218}
-
Maya Lekova authored
Bug: v8:8744 Change-Id: I2b4b7ace0dd7a0bcbb20ab0f41c30c25ce01cea2 R=machenbach@chromium.org,sergiyb@chromium.org No-Try: true Change-Id: I2b4b7ace0dd7a0bcbb20ab0f41c30c25ce01cea2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1521110 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Ujjwal Sharma authored
Add a CheckSmi call to the value of the position argument to String.prototype.startsWith(search, [position]). Bug: v8:8400, chromium:939746 Change-Id: I7462bebe0d3fde605a4c27a34c0d9bb3f0cc1c20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514198 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
