1. 25 Oct, 2017 1 commit
  2. 23 Oct, 2017 2 commits
    • Marja Hölttä's avatar
      Revert "[parser] Skipping inner funcs: Use less memory for variables." · 271e3b10
      Marja Hölttä authored
      This reverts commit 97ead433.
      
      Reason for revert: makes the PreParserScopeAnalysis test much slower.
      
      Original change's description:
      > [parser] Skipping inner funcs: Use less memory for variables.
      > 
      > - Make it possible to store quarter-bytes instead of full bytes.
      > 
      > - Don't store is_used; it can be recovered correctly based on the actual full
      >   parse (when a lazy function is eventually called) and
      >   has_forced_scope_allocation.
      > 
      > - With the is_used change, the old testing approach (which compared a scope for
      >   which we didn't do scope allocation to the baseline) no longer made
      >   sense. Replaced it with a new testing approach, which is also closer to the
      >   actual usage.
      > 
      > BUG=v8:5516
      > 
      > Change-Id: I02bac24e482126689dcdbabe8b3a04977be29b0c
      > Reviewed-on: https://chromium-review.googlesource.com/725422
      > Commit-Queue: Marja Hölttä <marja@chromium.org>
      > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#48828}
      
      TBR=marja@chromium.org,verwaest@chromium.org
      
      Change-Id: I8cb87bcd55462b1cef4444dabb5cbfa2ecb24c7c
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:5516
      Reviewed-on: https://chromium-review.googlesource.com/732878Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Commit-Queue: Marja Hölttä <marja@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48829}
      271e3b10
    • Marja Hölttä's avatar
      [parser] Skipping inner funcs: Use less memory for variables. · 97ead433
      Marja Hölttä authored
      - Make it possible to store quarter-bytes instead of full bytes.
      
      - Don't store is_used; it can be recovered correctly based on the actual full
        parse (when a lazy function is eventually called) and
        has_forced_scope_allocation.
      
      - With the is_used change, the old testing approach (which compared a scope for
        which we didn't do scope allocation to the baseline) no longer made
        sense. Replaced it with a new testing approach, which is also closer to the
        actual usage.
      
      BUG=v8:5516
      
      Change-Id: I02bac24e482126689dcdbabe8b3a04977be29b0c
      Reviewed-on: https://chromium-review.googlesource.com/725422
      Commit-Queue: Marja Hölttä <marja@chromium.org>
      Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48828}
      97ead433
  3. 30 Jun, 2017 1 commit
  4. 22 Jun, 2017 1 commit
  5. 17 May, 2017 1 commit
  6. 16 May, 2017 1 commit
  7. 07 Mar, 2017 1 commit
    • Marja Hölttä's avatar
      [parser] Skipping inner funcs: collect data needed for allocation, not the allocation result. · f489f7ab
      Marja Hölttä authored
      This pretty much rewrites the preparsed scope data collection. We used to store
      the allocation result, but it's faster to just store the raw data which is
      needed for deciding it later. (This way we don't need to run the allocation
      algorithm for just getting this data.)
      
      For each variable: is_used, maybe_assigned,
      has_forced_context_allocation, and for each scope:
      inner_scope_calls_eval_.
      
      In addition, this CL moves data handling out of Scope and into
      PreParsedScopeData where it belongs and simplifies the API for
      PreParsedScopeData.
      
      BUG=v8:5516
      R=vogelheim@chromium.org
      
      Change-Id: Ia5a4fa52f585cd4f483ce9a92f2dd7d9754f34ed
      Reviewed-on: https://chromium-review.googlesource.com/451273
      Commit-Queue: Marja Hölttä <marja@chromium.org>
      Reviewed-by: 's avatarDaniel Vogelheim <vogelheim@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#43641}
      f489f7ab
  8. 28 Feb, 2017 1 commit
  9. 24 Feb, 2017 1 commit
  10. 07 Feb, 2017 4 commits