- 07 Aug, 2019 2 commits
-
-
Michael Achenbach authored
Change-Id: I035d276004b21f167ede2ecd9bc59759f135bbd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741647Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#63107}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/38ae7d2..8400a89 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/698405a..1b12368 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/36756e4..aa2db56 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/cd2137f..3605577 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I08bb4364173d6a8765d07a7b6e9665f188306c9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1740967Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#63106}
-
- 06 Aug, 2019 22 commits
-
-
Deepti Gandluri authored
Change-Id: I0607978da6c346c5f8807b0c9a33e0245cd503e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1738470Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#63105}
-
Maggie Chen authored
The current V8HugeMaxOldGenerationSize feature increases the JS heap size for systems with larger than 16 GB physical memory. This cl adds support for 16 GB configuration. Because a small portion of memory is reserved by hardware, the physical memory calculation here is rounded up to GB so the actual installed memory is checked. Bug:chromium:958974 Change-Id: Idaf2e03a43ba6c3c40bb771296d06b87032c2725 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1734038 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#63104}
-
Jakob Gruber authored
The HandleScope lets objects allocated within the slow loop be collected prior to loop termination. Drive-by: Use the appropriate kMaxElementCount constant. Drive-by: Switch to less-or-equal comparison against it. Bug: chromium:948810 Change-Id: I2449408b87e7e82dead5ee76d8c92129fa3243fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1736749 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#63103}
-
Sami Kyostila authored
Use Perfetto's Start/StopBlocking() helpers instead of bespoke synchronization with semaphores. Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng Bug: v8:8339 Change-Id: If8266d5fa5e3ff6403b9b2e539ec985bc67fcc90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1728623 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#63102}
-
Peter Marshall authored
Ongoing cleanup to use the same term everywhere. Bug: chromium:913887 Change-Id: Ifc4d4de0c2dfd9f1150e61d64cf7f91cf923aa24 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1738865Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#63101}
-
Michael Achenbach authored
This reverts commit 11524453. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/27728 Original change's description: > [wasm] Test concurrent code emission > > This extends the jump table stress test. Currently, we generate > different thunks (on the main thread) and then concurrently update the > jump table to jump to one of these thunks. > With this CL, we also generate the thunks concurrently. So this also > tests whether there is proper synchronization between code generation > and executing it in another thread. > > R=ahaas@chromium.org, mstarzinger@chromium.org > > Bug: v8:9477 > Change-Id: I3598329e37482ebd27a13acc752581c714226184 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735319 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63097} TBR=mstarzinger@chromium.org,ahaas@chromium.org,clemensh@chromium.org Change-Id: I1c95cb43aa23340913de9cfad9988d0c583cc266 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9477 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1739368Reviewed-by:
-
Joshua Litt authored
This cl makes IsLockFree return true for 8 bytes on x64 platforms. The standard is unfortunately a bit vague on what exactly 'lock free' means. As a result, we err on the side of caution. We can revisit this, but first we need the specification to nail down exactly what 'lock free' in this context. Bug: v8:8100 Change-Id: I0a6099c6cb95a5581f3e71d0267857b88b4a2f0a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735592 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63099}
-
Tobias Tebbi authored
Bug: v8:7793 Change-Id: I5f5461e4e3d31c6d3c2c1fba4ce48a4eb5db5d8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1725625 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#63098}
-
Clemens Hammacher authored
This extends the jump table stress test. Currently, we generate different thunks (on the main thread) and then concurrently update the jump table to jump to one of these thunks. With this CL, we also generate the thunks concurrently. So this also tests whether there is proper synchronization between code generation and executing it in another thread. R=ahaas@chromium.org, mstarzinger@chromium.org Bug: v8:9477 Change-Id: I3598329e37482ebd27a13acc752581c714226184 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735319Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63097}
-
Santiago Aboy Solanes authored
There were some accesses that could be specialized to Pointer instead of Any. Also updated the WriteBarrierKind to match. Any -> full barrier, Pointer -> Pointer barrier, Signed -> no barrier. There were some accesses that were not used, and therefore got deleted. Bug: v8:9396 Change-Id: Ie249e6571080fa6e24d9022344775de679966144 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1733070Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#63096}
-
Andreas Haas authored
This CL removes the SEPERATOR from the FOREACH_WASM_FEATURE_FLAG macro, which was ugly, and fortunately also unnecessary. R=jkummerow@chromium.org Bug: v8:9396 Change-Id: I455589331f84a011a231d6897d03e8ab0b492b45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1738847Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Bug: v8:7783 Change-Id: I90226a16744388149993380399f1c6ee577b7c11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1738861Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=tmrts@chromium.org Change-Id: Id7148a5579d99928116a416bbd149d9ed7135fc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1738858Reviewed-by:
-
Sathya Gunasekaran authored
The is_public name is misleading now that we have private symbols. It's only used to know if the symbol is stored in the global symbol registry. This patch renames it to a more suitable name. Change-Id: I78f31cb5438416d07b78a9038c3526c9dfb96c6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1738849Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#63092}
-
Simon Zünd authored
This CL fixes an upcoming clang compiler warning (-Wparentheses). BuildAsciiCharFlags uses ternary operator '?' together with bitwise or '|'. Bitwise or '|' binds stronger than '?', so BuildAsciiCharsFlags is basically: return check1(c) ? E1 : (0 | check2(c)) ? E2 : (0 | check3(c)) ? E3 : 0; This CL fixes this. Change-Id: I794ef4aa19786e61b23d1f2b35eff486cf6d569a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1738850Reviewed-by:Leszek Swirski <leszeks@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#63091}
-
Darius Mercadier authored
Sorting the pages by least free bytes should reduce fragmentation: since map space is never compacted, it makes sense to first fill pages that are the most full already rather than to start with the most empty pages (which is what was more or less going on until this CL). Bug: v8:9329 Change-Id: I2157e3b4706c53da80220da5e4a26c00ee4c592f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735325Reviewed-by:
-
Clemens Hammacher authored
This is a reland of a3218aa7. Unmodified reland, thus TBR. Original change's description: > [wasm] Add support to allocate in a specific code region > > For multiple code spaces with multiple jump tables, we need to allocate > the space for the jump tables within specific regions (the new code > spaces) so they are within reachable distance. > This CL adds support for that, and uses it for the first jump table. > > R=mstarzinger@chromium.org > > Bug: v8:9477 > Change-Id: Ibdf05c9500c2dfdb2c5f5f920b4422339aaab810 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1733069 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63074} TBR=mstarzinger@chromium.org Bug: v8:9477 Change-Id: Ic110705fa13edeb103c06ad579a61cba78b6890c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1738848Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63089}
-
Clemens Hammacher authored
This is a reland of 779bdef3 Original change's description: > [wasm] Prepare for multiple jump tables > > This CL prepares {NativeModule} and {WasmCodeAllocator} for multiple > code spaces with separate jump tables. {WasmCodeAllocator} calls back > to the {NativeModule} for each code space it allocates, and > {NativeModule} stores data (especially the jump table) for each code > space. > A jump table is currently only created for the first code space added, > so nothing changes there yet. > > R=mstarzinger@chromium.org > > Bug: v8:9477 > Change-Id: I3ddeb8e251648b07ba8b7b4638abafe2364b47ff > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1730996 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63069} Bug: v8:9477 Change-Id: I9e25d59029cb6ce4869cf53a868afc59bc20b72f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735324Reviewed-by:
-
Dominik Inführ authored
Instead of inserting "deletion" entries into the store buffer, keep a list of invalidated objects to filter out invalid old-to-new slots. The first CL https://crrev.com/c/1704109 got reverted because both the sweeper and the main task were modifying the invalidated slots data structure concurrently. This CL changes this, such that the sweeper only modifies the invalidated slots during the final atomic pause when the main thread is not running. The sweeper does not need to clean this data structure after the pause, since the "update pointers" phase already removed all invalidated slots. Bug: v8:9454 Change-Id: Iffb5bf96de2c89eee1ee1231a3414a0f2a155cbc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1733081Reviewed-by:
-
Darius Mercadier authored
Sorting is done in order to make compaction more efficient: by sweeping pages with the most free bytes first, we make it more likely that when evacuating a page, already swept pages will have enough free bytes to hold the objects to move (and therefore, we won't need to wait for more pages to be swept in order to move those objects). Since maps don't move, there is no need to sort the pages from MAP_SPACE before sweeping them. Bug: v8:9093 Bug: v8:9329 Change-Id: I63964364d3cd0b64faf8570e87b5f75de6443902 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1736746 Commit-Queue: Darius Mercadier <dmercadier@google.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#63086}
-
Jakob Gruber authored
When serializing frame states into translations (later used by deopts), we pass certain values, depending on the frame kind, to be serialized as the frame height. This CL moves the calculation of this height value into the FrameStateDescriptor. In a follow-up, we may want to simplify the way these height values are passed and processed by deopts. The motivation behind this is to simplify calculation of unoptimized stack frame sizes during compilation. Bug: v8:9534 Change-Id: I20d2b57a42cea0c238b9c887dba0280f6aad76de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1728609 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d57f70e..38ae7d2 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/93ee550..698405a Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/921f6a1..36756e4 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ic6b12a6c3bfbbd27895110a29de92788360eaf3a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1737928Reviewed-by:
-
- 05 Aug, 2019 16 commits
-
-
Peter Marshall authored
Update the TracingCpuProfiler test to work properly with perfetto. Roll perfetto to get fixes for bugs encountered with starting/stopping tracing rapidly, which happens in the test for the tracing profiler. Add a check that the DataSource::Register call was successful to flush out any errors there (although they are fixed by the perfetto roll). Emit a fake trace event when stopping tracing in order to avoid losing the final trace event that the user provided. Remove the ad-hoc fake final trace events that the cctests for perfetto added. Add a test StartAndStopRepeated which flushes out the issues fixed by the perfetto roll. TBR=yangguo@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng Bug: v8:8339 Change-Id: I042d7385486bf42c86f1631406974693868a477f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1731006 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Mythri A authored
This is a reland of 159df248 Original change's description: > [ic] Don't transition to premonomorphic state > > We used to use premonomorphic state to delay initializing the ICs. > This optimization was to avoid the cost of setting up handlers if the > code executed only once. With lazy feedback allocation we no longer > need this. > > This cl also renames LoadIC_Uninitialized to LoadIC_Nofeedback and > StoreIC_Uninitialized to StoreIC_Nofeedback since we now miss to > runtime in the uninitialized state and use the builtin when there > is no feedback. > > > Change-Id: I1633e61ea74664da51348e362c34c47a017a264a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1683525 > Commit-Queue: Mythri Alle <mythria@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63020} Change-Id: Ica7eb65649615c2f8410d5b815a98b55cb1cfc4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1731000 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#63082}
-
Ulan Degenbaev authored
This reverts commit 5611f70b. Reason for revert: flaky tests: v8:9588, v8:9587 Original change's description: > "Reland x4 [arraybuffer] Rearchitect backing store ownership" > > This is a reland of bc33f5ae > > Contributed by titzer@chromium.org > > Original change's description: > > [arraybuffer] Rearchitect backing store ownership > > > > This CL completely rearchitects the ownership of array buffer backing stores, > > consolidating ownership into a {BackingStore} C++ object that is tracked > > throughout V8 using unique_ptr and shared_ptr where appropriate. > > > > Overall, lifetime management is simpler and more explicit. The numerous > > ways that array buffers were initialized have been streamlined to one > > Attach() method on JSArrayBuffer. The array buffer tracker in the > > GC implementation now manages std::shared_ptr<BackingStore> pointers, > > and the construction and destruction of the BackingStore object itself > > handles the underlying page or embedder-allocated memory. > > > > The embedder API remains unchanged for now. We use the > > v8::ArrayBuffer::Contents struct to hide an additional shared_ptr to > > keep the backing store alive properly, even in the case of aliases > > from live heap objects. Thus the embedder has a lower chance of making > > a mistake. Long-term, we should move the embedder to a model where they > > manage backing stores using shared_ptr to an opaque backing store object. > > TBR=yangguo@chromium.org > > BUG=v8:9380,v8:9221,chromium:986318 > > Change-Id: If671a4a9ca0476e8f084efae46e0d2bf99ed99ef > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1731005 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63041} TBR=ulan@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,clemensh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9380, v8:9221, chromium:986318 Change-Id: Ic7381239f4e90d0c437b7e47a5ac6e8bce60f882 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1736747Reviewed-by:
-
Milad Farazmand authored
Port ae60ea7e Original Commit Message: The mode without write barriers works only if incremental marking is disabled and the single generation mode is enabled. R=wangrong089@gmail.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: If2eb047bed41b92a0366c1401d0acf069257b650 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1733730Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
-
Tobias Tebbi authored
Now that we can short-circuit control flow in the optimizing compiler, there is no more need for BranchIf... macros in CSA/Torque. Thus removing support for them in Torque and rewriting Torque macros to use bool return values instead. Bug: v8:7793 Change-Id: Ie4b7522aa5558be038fe821d8b5d02859d522ed1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1724211 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL changes the signature of AccessorPair::GetComponent to take an additional parameter {native_context}. The current native_context does not always match the native context of the holder, resulting in JSFunctions that have the wrong native context for lazy instantiated AccessorPairs. Bug: chromium:989909, v8:6495 Change-Id: I45bfcb27ac367858dd6788736eba1a2e1302e802 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735311Reviewed-by: -
Peter Marshall authored
Bug: chromium:913887 Change-Id: I3b3040acc919990fa39f54add989c5caf325864a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735316Reviewed-by:
-
Leszek Swirski authored
This reverts commit 779bdef3. Reason for revert: Speculative revert for win breakage (https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8905967677942963904/+/steps/Check/0/logs/Fixed/0) Original change's description: > [wasm] Prepare for multiple jump tables > > This CL prepares {NativeModule} and {WasmCodeAllocator} for multiple > code spaces with separate jump tables. {WasmCodeAllocator} calls back > to the {NativeModule} for each code space it allocates, and > {NativeModule} stores data (especially the jump table) for each code > space. > A jump table is currently only created for the first code space added, > so nothing changes there yet. > > R=mstarzinger@chromium.org > > Bug: v8:9477 > Change-Id: I3ddeb8e251648b07ba8b7b4638abafe2364b47ff > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1730996 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63069} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: I57af88872c1335d547f83e524c8f06938b5c817b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9477 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735320 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit a3218aa7. Reason for revert: Needed for another revert (https://chromium-review.googlesource.com/c/v8/v8/+/1735320) Original change's description: > [wasm] Add support to allocate in a specific code region > > For multiple code spaces with multiple jump tables, we need to allocate > the space for the jump tables within specific regions (the new code > spaces) so they are within reachable distance. > This CL adds support for that, and uses it for the first jump table. > > R=mstarzinger@chromium.org > > Bug: v8:9477 > Change-Id: Ibdf05c9500c2dfdb2c5f5f920b4422339aaab810 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1733069 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63074} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: I4b1d1e670d5b25fa40205754d9572b2b809c93ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9477 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735321Reviewed-by:
-
Clemens Hammacher authored
For multiple code spaces with multiple jump tables, we need to allocate the space for the jump tables within specific regions (the new code spaces) so they are within reachable distance. This CL adds support for that, and uses it for the first jump table. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: Ibdf05c9500c2dfdb2c5f5f920b4422339aaab810 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1733069 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#63074}
-
Georg Neis authored
This reverts commit 9499ec0d. Reason for revert: Breaks lots of stuff, e.g. https://ci.chromium.org/p/v8/builders/ci/V8-Blink%20Linux%2064%20-%20future/9401 Original change's description: > [TurboFan] Brokerize remaining feedback vector slots > > This CL adds new ProcessedFeedback subclasses, corresponding to various IC > types: > > * ForIn > * Comparison ops > * Binary/Unary ops > * InstanceOf > * Calls > > The feedback is gathered at serialization time and used in several places, > namely: > > * Bytecode graph building, > * and its helper class JSTypeHintLowering (with its "early lowering") > * Native context specialization > * JSCallReducer > > Design doc: https://docs.google.com/document/d/1JLG0VFV8xmsAIJexU19xzlbNyP51ONqfo_Gf_2DcPC8/edit?usp=sharing > > Bug: v8:7790 > Change-Id: I53c3d7a17f844384f38c4ee0f0b082c114217a02 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710663 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63028} TBR=mvstanton@chromium.org,neis@chromium.org,mslekova@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7790 Change-Id: Id0c4d6651611fc3964010f7615d0ad0485169ebc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735315Reviewed-by:
-
Michael Achenbach authored
This is a reland of 3fc96631 The private method on_event in timeout proc is now renamed to be truly private. Original change's description: > [test] Print hanging tests on linux on test-runner termination > > This will print the list of processes still running before and after > joining workers during termination. This will help debugging hanging > tests during flake-bisect or with num-fuzzer, which both terminate > on total timeout and currently still sometimes hang without printing > processes. > > Bug: v8:8292 > Change-Id: I124b65fa35b8d7a6aa198fcf50f2c20df94dc51a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735312 > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63065} Bug: v8:8292 Change-Id: Ibad1172666d6f4d2c07884a54edfe9d6499b57fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735318Reviewed-by:
-
Simon Zünd authored
This CL changes the way AccessorPairs are collected for instantiation when debug break trampolines are installed. Instead of walking the heap and looking at AccessorPairs directly, we look at all JSObjects and collect AccessorPairs via each objects descriptor array. This way, we can associate the correct native context with each collected AccessorPair. The current native context is not always the correct context to instantiate the getter and setter JSFunctions for an AccessorPair. Bug: chromium:986063 Change-Id: I124a0802f4938b95f1ad75efc65eb05b66bcfc67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735310 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#63071}
-
Joshua Litt authored
When a fast path was added for Math.hypot, the algorithm was also simplified. This simplification turns out to be incorrect in some rare edge cases. This cl reverts back to the original algorithm and converts it to torque. Original cl: https://chromium-review.googlesource.com/c/v8/v8/+/1684178 Bug: v8:9546 Change-Id: If4e21504732f46081a8de823f50f499917f1a20c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1725200 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This CL prepares {NativeModule} and {WasmCodeAllocator} for multiple code spaces with separate jump tables. {WasmCodeAllocator} calls back to the {NativeModule} for each code space it allocates, and {NativeModule} stores data (especially the jump table) for each code space. A jump table is currently only created for the first code space added, so nothing changes there yet. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: I3ddeb8e251648b07ba8b7b4638abafe2364b47ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1730996 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
Instead of exposing a {kNext} constant to be used to construct the next bitfield, expose a templatized {Next} type alias. This ensures that the storage type is the same for all bitfields created this way. It's also shorter. Apart from the expected changes in the code base, the AST node classes are changed to expose a {NextBitField} templated type alias instead of a {kNextBitFieldIndex} constant. They thus follow the same pattern as {BitField} itself. R=jkummerow@chromium.org, mstarzinger@chromium.org, verwaest@chromium.org Bug: v8:9396 Change-Id: I70a1b0bd71cde694ec53444de0ca55e4cf0a3836 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1728615Reviewed-by:
-
