1. 14 May, 2020 1 commit
  2. 25 Mar, 2020 1 commit
  3. 20 Mar, 2020 1 commit
  4. 09 Jan, 2020 1 commit
  5. 05 Nov, 2019 1 commit
  6. 10 Sep, 2019 1 commit
  7. 18 Jan, 2019 1 commit
    • Andrey Lushnikov's avatar
      Revert "inspector: teach v8Inspector to return default context" · 8665bac1
      Andrey Lushnikov authored
      This reverts commit 22cb8d45.
      
      Reason for revert: it is fundamentally wrong to fetch default
      frame context using contextGroupId: contextGroupId is per page rather
      then per frame.
      
      Original change's description:
      > inspector: teach v8Inspector to return default context
      >
      > This is a follow-up to https://chromium-review.googlesource.com/c/v8/v8/+/1173718
      >
      > R=​kozy, pfeldman
      > TBR=pfeldman
      >
      > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      > Change-Id: I48b4ca5589505d03773477623654fa54703f0714
      > Reviewed-on: https://chromium-review.googlesource.com/1175061
      > Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
      > Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#55133}
      
      TBR=lushnikov@chromium.org,pfeldman@chromium.org,kozyatinskiy@chromium.org
      NOTRY=true
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Change-Id: Ide4246bfe75ccc8a4fb1f0c5dbc44ae4236cac5c
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      Reviewed-on: https://chromium-review.googlesource.com/c/1419082
      Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
      Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58906}
      8665bac1
  8. 30 Nov, 2018 1 commit
    • Yang Guo's avatar
      Make termination exception more consistent. · 7e5cac2c
      Yang Guo authored
      Termination exceptions tear down V8 to the bottom-most V8 call. If there is a
      v8::TryCatch scope around that call, it returns true for HasTerminated() and
      HasCaught(). However, Isolate::IsExecutionTerminating() returns false and we
      can call into V8 from still inside the v8::TryCatch scope.
      
      Changes that this patch introduces:
       - You need to leave the v8::TryCatch scope around the bottom-most call to
         reset the termination state, in order to resume.
       - Explicitly check for termination exception and reporting it through the
         DevTools protocol after Runtime.evaluate and Debugger.evaluateOnCallFrame.
      
      Bug: v8:8455
      Change-Id: I1f36f7a365985469813c2619bf16f18ee69aa4b8
      Reviewed-on: https://chromium-review.googlesource.com/c/1337582Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57963}
      7e5cac2c
  9. 06 Nov, 2018 1 commit
  10. 12 Oct, 2018 1 commit
  11. 18 Sep, 2018 2 commits
  12. 14 Aug, 2018 2 commits
  13. 01 Jun, 2018 2 commits
    • Alexey Kozyatinskiy's avatar
      Reland "[inspector] added Runtime.installBinding method" · 5cb11a17
      Alexey Kozyatinskiy authored
      This is a reland of 49c4ac77
      
      Original change's description:
      > [inspector] added Runtime.installBinding method
      >
      > A lot of different clients use console.debug as a message channel from
      > page to protocol client. console.debug is a little slow and not
      > designed for this use case.
      >
      > This CL introduces new method: Runtime.installBinding. This method
      > installs binding function by given name on global object on each
      > inspected context including any context created later.
      > Binding function takes exactly one string argument. Each time when
      > binding function is called, Runtime.bindingCalled notification is
      > triggered and includes passed payload.
      >
      > Binding function survives page reload and reinstalled right after
      > console object is setup. So installed binding can be used inside
      > script added by Page.addScriptToEvaluateOnNewDocument so client may do
      > something like:
      > Runtime.installBinding({name: 'send'});
      > Page.addScriptToEvaluateOnNewDocument({source: 'console.debug = send'});
      > .. navigate page ..
      >
      > In microbenchmark this function is ~4.6 times faster then
      > console.debug.
      >
      > R=lushnikov@chromium.org,pfeldman@chromium.org
      >
      > Bug: none
      > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      > Change-Id: I3e0e231dde9d45116709d248f6e9e7ec7037e8e3
      > Reviewed-on: https://chromium-review.googlesource.com/1077662
      > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#53462}
      
      TBR=dgozman@chromium.org
      
      Bug: none
      Change-Id: I58d053581a86f15338dea621498058b7b75c7c85
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      Reviewed-on: https://chromium-review.googlesource.com/1081833Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53479}
      5cb11a17
    • Sergiy Byelozyorov's avatar
      Revert "[inspector] added Runtime.installBinding method" · 7bd8b1c0
      Sergiy Byelozyorov authored
      This reverts commit 49c4ac77.
      
      Reason for revert: breaks linux_chromium_rel_ng when rolling into Chromium: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/107377
      
      Original change's description:
      > [inspector] added Runtime.installBinding method
      > 
      > A lot of different clients use console.debug as a message channel from
      > page to protocol client. console.debug is a little slow and not
      > designed for this use case.
      > 
      > This CL introduces new method: Runtime.installBinding. This method
      > installs binding function by given name on global object on each
      > inspected context including any context created later.
      > Binding function takes exactly one string argument. Each time when
      > binding function is called, Runtime.bindingCalled notification is
      > triggered and includes passed payload.
      > 
      > Binding function survives page reload and reinstalled right after
      > console object is setup. So installed binding can be used inside
      > script added by Page.addScriptToEvaluateOnNewDocument so client may do
      > something like:
      > Runtime.installBinding({name: 'send'});
      > Page.addScriptToEvaluateOnNewDocument({source: 'console.debug = send'});
      > .. navigate page ..
      > 
      > In microbenchmark this function is ~4.6 times faster then
      > console.debug.
      > 
      > R=​lushnikov@chromium.org,pfeldman@chromium.org
      > 
      > Bug: none
      > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      > Change-Id: I3e0e231dde9d45116709d248f6e9e7ec7037e8e3
      > Reviewed-on: https://chromium-review.googlesource.com/1077662
      > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#53462}
      
      TBR=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org,kozyatinskiy@chromium.org
      
      Change-Id: I1ebafd42db01d8a6435d58386f2c667b92db12f1
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: none
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      Reviewed-on: https://chromium-review.googlesource.com/1082311Reviewed-by: 's avatarSergiy Byelozyorov <sergiyb@chromium.org>
      Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53470}
      7bd8b1c0
  14. 31 May, 2018 1 commit
    • Alexey Kozyatinskiy's avatar
      [inspector] added Runtime.installBinding method · 49c4ac77
      Alexey Kozyatinskiy authored
      A lot of different clients use console.debug as a message channel from
      page to protocol client. console.debug is a little slow and not
      designed for this use case.
      
      This CL introduces new method: Runtime.installBinding. This method
      installs binding function by given name on global object on each
      inspected context including any context created later.
      Binding function takes exactly one string argument. Each time when
      binding function is called, Runtime.bindingCalled notification is
      triggered and includes passed payload.
      
      Binding function survives page reload and reinstalled right after
      console object is setup. So installed binding can be used inside
      script added by Page.addScriptToEvaluateOnNewDocument so client may do
      something like:
      Runtime.installBinding({name: 'send'});
      Page.addScriptToEvaluateOnNewDocument({source: 'console.debug = send'});
      .. navigate page ..
      
      In microbenchmark this function is ~4.6 times faster then
      console.debug.
      
      R=lushnikov@chromium.org,pfeldman@chromium.org
      
      Bug: none
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: I3e0e231dde9d45116709d248f6e9e7ec7037e8e3
      Reviewed-on: https://chromium-review.googlesource.com/1077662
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53462}
      49c4ac77
  15. 08 May, 2018 1 commit
  16. 30 Apr, 2018 1 commit
  17. 26 Apr, 2018 2 commits
  18. 25 Apr, 2018 1 commit
  19. 14 Apr, 2018 1 commit
  20. 13 Apr, 2018 2 commits
  21. 29 Mar, 2018 1 commit
  22. 19 Mar, 2018 1 commit
    • Alexey Kozyatinskiy's avatar
      Reland "[inspector] added Runtime.terminateExecution" · 97fc20f3
      Alexey Kozyatinskiy authored
      This is a reland of 14824520
      
      Original change's description:
      > [inspector] added Runtime.terminateExecution
      >
      > Runtime.terminateExecution terminates current or next JavaScript
      > call. Termination flag is automatically reset as soon as v8 call
      > or microtasks are completed.
      >
      > R=pfeldman@chromium.org
      >
      > Bug: chromium:820640
      > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      > Change-Id: Ie21c123be3a61fe25cf6e04c38a8b6c664622ed7
      > Reviewed-on: https://chromium-review.googlesource.com/957386
      > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#51912}
      
      Bug: chromium:820640
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: I6dd30f65c06c2b7eefd1e7beb9a3cf50ea5bf8cd
      Reviewed-on: https://chromium-review.googlesource.com/967323
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52004}
      97fc20f3
  23. 07 Mar, 2018 1 commit
  24. 22 Nov, 2017 3 commits
    • Alexey Kozyatinskiy's avatar
      Reland [inspector] introduced stackTraceId and externalAsyncTask API · 885a5669
      Alexey Kozyatinskiy authored
      Sometimes we need to capture stack trace on one debugger and use it
      later as a parent stack on another debugger (e.g. worker.postMessage).
      
      This CL includes following addition to our protocol and v8-inspector.h:
        - added Runtime.StackTraceId, this id represents stack trace captured
          on debugger with given id,
        - protocol client can fetch Runtime.StackTrace by
          Runtime.StacKTraceId using Debugger.getStackTrace method,
        - externalParent field is added to Debugger.paused event, it may
          contain external parent stack trace,
        - V8Inspector::storeCurrentStackTrace captures current stack trace
          and returns V8StackTraceId for embedder this id can be used as
          argument for V8Inspector::externalAsyncTaskStarted and
          V8Inspector::externalAsyncTaskFinished method. Any async stack
          trace captured between these calls will get passed external stack
          trace as external parent. These methods are designed to be called
          on different debuggers. If async task is scheduled and started on
          one debugger user should continue to use asyncTask* API,
        - Debugger.enable methods returns unique debuggerId.
      
      TBR=dgozman@chromium.org,jgruber@chromium.org
      
      Bug: chromium:778796
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I2c1a2b2e30ed69ccb61d10f08686f4edb09f50e4
      Reviewed-on: https://chromium-review.googlesource.com/786274
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49591}
      885a5669
    • Clemens Hammacher's avatar
      Revert "[inspector] introduced stackTraceId and externalAsyncTask API" · 4379533c
      Clemens Hammacher authored
      This reverts commit 3a41b697.
      
      Reason for revert: Break msvc: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20msvc/builds/250
      
      Original change's description:
      > [inspector] introduced stackTraceId and externalAsyncTask API
      > 
      > Sometimes we need to capture stack trace on one debugger and use it
      > later as a parent stack on another debugger (e.g. worker.postMessage).
      > 
      > This CL includes following addition to our protocol and v8-inspector.h:
      >   - added Runtime.StackTraceId, this id represents stack trace captured
      >     on debugger with given id,
      >   - protocol client can fetch Runtime.StackTrace by
      >     Runtime.StacKTraceId using Debugger.getStackTrace method,
      >   - externalParent field is added to Debugger.paused event, it may
      >     contain external parent stack trace,
      >   - V8Inspector::storeCurrentStackTrace captures current stack trace
      >     and returns V8StackTraceId for embedder this id can be used as
      >     argument for V8Inspector::externalAsyncTaskStarted and
      >     V8Inspector::externalAsyncTaskFinished method. Any async stack
      >     trace captured between these calls will get passed external stack
      >     trace as external parent. These methods are designed to be called
      >     on different debuggers. If async task is scheduled and started on
      >     one debugger user should continue to use asyncTask* API,
      >   - Debugger.enable methods returns unique debuggerId.
      > 
      > Bug: chromium:778796
      > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      > Change-Id: I16aba0d04bfcea90f3e187e635a0588c92354539
      > Reviewed-on: https://chromium-review.googlesource.com/754183
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
      > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#49582}
      
      TBR=dgozman@chromium.org,pfeldman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,jgruber@chromium.org
      
      Change-Id: I9b52354fa0841e5148596cf594317f2e5fe508ea
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:778796
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/786152Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49584}
      4379533c
    • Alexey Kozyatinskiy's avatar
      [inspector] introduced stackTraceId and externalAsyncTask API · 3a41b697
      Alexey Kozyatinskiy authored
      Sometimes we need to capture stack trace on one debugger and use it
      later as a parent stack on another debugger (e.g. worker.postMessage).
      
      This CL includes following addition to our protocol and v8-inspector.h:
        - added Runtime.StackTraceId, this id represents stack trace captured
          on debugger with given id,
        - protocol client can fetch Runtime.StackTrace by
          Runtime.StacKTraceId using Debugger.getStackTrace method,
        - externalParent field is added to Debugger.paused event, it may
          contain external parent stack trace,
        - V8Inspector::storeCurrentStackTrace captures current stack trace
          and returns V8StackTraceId for embedder this id can be used as
          argument for V8Inspector::externalAsyncTaskStarted and
          V8Inspector::externalAsyncTaskFinished method. Any async stack
          trace captured between these calls will get passed external stack
          trace as external parent. These methods are designed to be called
          on different debuggers. If async task is scheduled and started on
          one debugger user should continue to use asyncTask* API,
        - Debugger.enable methods returns unique debuggerId.
      
      Bug: chromium:778796
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I16aba0d04bfcea90f3e187e635a0588c92354539
      Reviewed-on: https://chromium-review.googlesource.com/754183Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49582}
      3a41b697
  25. 03 Oct, 2017 1 commit
  26. 02 Aug, 2017 1 commit
    • Alexey Kozyatinskiy's avatar
      [inspector] move breakpoint management to native · cd9e86a5
      Alexey Kozyatinskiy authored
      My goal was to move breakpoint API to native with minimal changes around, so on inspector side we use v8::debug::BreakpointId instead of String16, on v8::internal::Debug we use i::BreakPoint object instead of break point object created inside of debug.js.
      
      There are a lot of opportunities how we can improve breakpoints (at least we can avoid some of linear lookups to speedup implementation) but I think that as first step we need to remove mirrors/debug.js APIs.
      
      Drive by: debugger-script.js and usage of debugger context in inspector code base.
      
      R=yangguo@chromium.org,jgruber@chromium.org,clemensh@chromium.org
      
      Bug: v8:5510,chromium:652939
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I0b17972c39053dd4989bbe26db2bb0b88ca378f7
      Reviewed-on: https://chromium-review.googlesource.com/593156Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47091}
      cd9e86a5
  27. 01 Aug, 2017 1 commit
  28. 25 Jul, 2017 1 commit
    • Michael Hablich's avatar
      Revert "[inspector] support for cases when embedder doesn't call contextDestroyed" · 4f2e6e9d
      Michael Hablich authored
      This reverts commit 87aae715.
      
      Reason for revert: Speculative revert because of ASAN leaks in https://chromium-review.googlesource.com/584488
      
      Original change's description:
      > [inspector] support for cases when embedder doesn't call contextDestroyed
      > 
      > Node.js doesn't have good place to call contextDestroyed.
      > We need to cleanup everything on our side to allow clients to not call
      > contextDestroyed method.
      > 
      > R=​dgozman@chromium.org,eostroukhov@google.com
      > 
      > Bug: none
      > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      > Change-Id: I6bfd4d6039f53eb994a2d20ecbca650744564e29
      > Reviewed-on: https://chromium-review.googlesource.com/575519
      > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
      > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#46849}
      
      TBR=dgozman@chromium.org,kozyatinskiy@chromium.org,eostroukhov@google.com,eostroukhov@chromium.org
      
      Change-Id: Ic3c2764159f809536670f73ab0cd5ea37317d400
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: none
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/584767Reviewed-by: 's avatarMichael Hablich <hablich@chromium.org>
      Commit-Queue: Michael Hablich <hablich@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46865}
      4f2e6e9d
  29. 24 Jul, 2017 1 commit
  30. 01 Jun, 2017 1 commit
    • dgozman's avatar
      [inspector] Support multiple sessions per context group · 375bea1c
      dgozman authored
      This patch adds ability to connect multiple sessions to a single context group. This is an experimental feature, which is already supported in test harness.
      
      So far covered runtime domain with tests (and found a bug thanks to the test). More tests to follow in next patches, probably with code adjustments as well.
      
      BUG=chromium:590878
      
      Review-Url: https://codereview.chromium.org/2906153002
      Cr-Commit-Position: refs/heads/master@{#45667}
      375bea1c
  31. 31 May, 2017 1 commit
  32. 18 Apr, 2017 1 commit
  33. 06 Apr, 2017 1 commit