1. 30 Aug, 2017 1 commit
    • Adam Klein's avatar
      [ast] Make CaseClause a plain ZoneObject, not an Expression · de046f5f
      Adam Klein authored
      CaseClause never made sense as an Expression; this CL allows us to
      remove several UNREACHABLEs and slim down the representation of
      CaseClause by removing its source position (which was only used
      in prettyprinting).
      
      The only real fallout of this change is that SourceRangeMap now
      stores its keys as ZoneObject*, rather than AstNode*, but since
      there's already compile time typechecking for inserting items
      into the map this shouldn't cause any ill effects.
      
      While modifying CaseClause, also removed the dead body_target()
      accessor (and related member variable). Thus this CL overall
      reduces the memory needed for each CaseClause by two words.
      
      Bug: v8:6092
      Change-Id: I0021c0590a69e29305c41ec6105c8824ae0cc25b
      Reviewed-on: https://chromium-review.googlesource.com/639316Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
      Commit-Queue: Adam Klein <adamk@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47722}
      de046f5f
  2. 13 Jul, 2017 1 commit
  3. 12 Jul, 2017 1 commit
  4. 19 Jun, 2017 1 commit
    • jgruber's avatar
      [coverage] Add continuation counters · 95882f0e
      jgruber authored
      Track execution counts of the continuations of block structures (e.g.
      IfStatements) to capture cases in which execution does not continue after a
      block. For example:
      
      for (;;) {
        return;
      }
      // Never reached, tracked by continuation counter.
      
      A continuation counter only has a start position; it's range is implicitly
      until the next sibling range or the end of the parent range.
      
      Bug: v8:6000
      Change-Id: I8e8f1f5b140b64c86754b916e626eb50f0707d70
      Reviewed-on: https://chromium-review.googlesource.com/530846
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46006}
      95882f0e