- 10 Oct, 2016 6 commits
-
-
zhengxing.li authored
The CL #39795 (https://codereview.chromium.org/2345593003 ) added MultiReturnSelect_f32/MultiReturnSelect_f64 tests. Because those tests need 2 float point return registers and x87 only has 1 FP return register, Those tests failed at x87 port. This CL skips MultiReturnSelect_f32/MultiReturnSelect_f64 tests for x87. BUG= Review-Url: https://codereview.chromium.org/2405743002 Cr-Commit-Position: refs/heads/master@{#40113}
-
marja authored
If an inner function only declares a variable but doesn't use it, Parser and PreParser produced different unresolved variables, and that confused the pessimistic context allocation. This is continuation to https://codereview.chromium.org/2388183003/ This CL fixes more complicated declarations (which are not just one identifier). For this, PreParser needs to accumulate identifiers used in expressions. In addition, this CL manifests FLAG_lazy_inner_functions in tests, so that we get clusterfuzz coverage for it. BUG=chromium:650969, v8:5501 Review-Url: https://codereview.chromium.org/2400613003 Cr-Commit-Position: refs/heads/master@{#40112}
-
jochen authored
BUG=v8:5412 R=jgruber@chromium.org,machenbach@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe Review-Url: https://codereview.chromium.org/2372983003 Cr-Commit-Position: refs/heads/master@{#40111}
-
petermarshall authored
BUG=v8:5364 Review-Url: https://codereview.chromium.org/2399423003 Cr-Commit-Position: refs/heads/master@{#40110}
-
bmeurer authored
There were once plans to generate cross-context code with TurboFan, however that doesn't fit into the model anymore, and so all of this is essentially dead untested code (and thus most likely already broken in subtle ways). With this mode still in place it would also be a lot harder to make inlining based on SharedFunctionInfo work. BUG=v8:2206,v8:5499 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2406803002 Cr-Commit-Position: refs/heads/master@{#40109}
-
mtrofin authored
Updated the deserialization API to avoid copying uncompiled bytes. BUG= Review-Url: https://codereview.chromium.org/2404673002 Cr-Commit-Position: refs/heads/master@{#40108}
-
- 09 Oct, 2016 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/472d19e..17093d4 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2401273002 Cr-Commit-Position: refs/heads/master@{#40107}
-
- 08 Oct, 2016 3 commits
-
-
mvstanton authored
And not by pointer address. BUG= Review-Url: https://codereview.chromium.org/2390823011 Cr-Commit-Position: refs/heads/master@{#40106}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#40105}
-
v8-autoroll authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/e0fa02a..b403fa6 Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/792a87c..472d19e Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clan/+log/30c5a8b..36879c7 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2405683002 Cr-Commit-Position: refs/heads/master@{#40104}
-
- 07 Oct, 2016 30 commits
-
-
adamk authored
These tests were marked as NO_VARIANTS under debug, but they were timing out under turbofan_opt as well on the CFI bot (see, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds/6765). R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2400463003 Cr-Commit-Position: refs/heads/master@{#40103}
-
adamk authored
This allows us to stop using a Symbol, set as the name of the Module's SharedFunctionInfo, as our storage for a hash. As part of this, centralize the code for generating a random, non-zero hash code in one place (there were previously two copies of this code, and I needed to call it from a third file). BUG=v8:5483 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2395233003 Cr-Commit-Position: refs/heads/master@{#40102}
-
kozyatinskiy authored
This problem was detected only on linux64_gyp bot. It's safe to convert length string into int from size_t. R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2402583004 Cr-Commit-Position: refs/heads/master@{#40101}
-
hablich authored
Revert of Pool implementation for zone segments (patchset #13 id:520001 of https://codereview.chromium.org/2335343007/ ) Reason for revert: blocks roll: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/294283/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > Pool implementation for zone segments > > BUG=v8:5409 > > Committed: https://crrev.com/37c688a24578e787d3d8941093563ed049c3497e > Committed: https://crrev.com/316669f62ea3834395bf4caab7bc3d7c32f6bbc6 > Cr-Original-Commit-Position: refs/heads/master@{#39631} > Cr-Commit-Position: refs/heads/master@{#40044} TBR=jochen@chromium.org,jkummerow@chromium.org,verwaest@chromium.org,yangguo@chromium.org,heimbuef@google.com NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true BUG=v8:5409 Review-Url: https://codereview.chromium.org/2400343002 Cr-Commit-Position: refs/heads/master@{#40100}
-
hablich authored
Revert of Replaced different means of zone pooling/reusing by one zone segment pool (patchset #5 id:160001 of https://codereview.chromium.org/2348303002/ ) Reason for revert: related to roll blocker: https://codereview.chromium.org/2400343002/ Original issue's description: > Replaced different means of zone pooling/reusing by one zone segment pool > > BUG=v8:5409 > > Committed: https://crrev.com/a124feb0760896c8be61de08004a08c3bc9b4b3f > Committed: https://crrev.com/fc840361e357a571c709e0239ae82cc089800b3f > Cr-Original-Commit-Position: refs/heads/master@{#39633} > Cr-Commit-Position: refs/heads/master@{#40048} TBR=mstarzinger@chromium.org,verwaest@chromium.org,heimbuef@google.com NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true BUG=v8:5409 Review-Url: https://codereview.chromium.org/2401163002 Cr-Commit-Position: refs/heads/master@{#40099}
-
kozyatinskiy authored
String16 is not public part of src/inspector. All usage are replaced with vector of char/unit16_t to avoid potential linker problems. BUG=chromium:635948 R=dgozman@chromium.org,machenbach@chromium.org Review-Url: https://codereview.chromium.org/2403493002 Cr-Commit-Position: refs/heads/master@{#40098}
-
hablich authored
Revert of [parser] Deprecate ParseInfo constructor taking closure. (patchset #2 id:20001 of https://codereview.chromium.org/2396963003/ ) Reason for revert: Needed to revert https://codereview.chromium.org/2400343002/ Original issue's description: > [parser] Deprecate ParseInfo constructor taking closure. > > This removes the {ParseInfo} constructor consuming a closure, replacing > all uses to pass only the shared function info. The goal is to make the > fact that parsing is independent of a concrete closure explicit. > > R=jochen@chromium.org > BUG=v8:2206 > > Committed: https://crrev.com/3de42b3f224217ec88e4c609d3cf23fe06806dca > Cr-Commit-Position: refs/heads/master@{#40083} TBR=jochen@chromium.org,bmeurer@chromium.org,marja@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:2206 Review-Url: https://codereview.chromium.org/2406623002 Cr-Commit-Position: refs/heads/master@{#40097}
-
neis authored
This implements namespace imports (import * as foo from "bar"), except for the @@iterator property on namespace objects (to be done later). R=adamk@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2388153003 Cr-Commit-Position: refs/heads/master@{#40096}
-
adamk authored
Both bits of code were pointed out by our test coverage tools. R=gsathya@chromium.org Review-Url: https://codereview.chromium.org/2394403002 Cr-Commit-Position: refs/heads/master@{#40095}
-
jbroman authored
Found with libfuzzer. The length is automatically converted to int (thus large sizes could become negative, even though they are legal "array sizes"). Besides that, the length is coerced to a SMI (which is an even tighter constraint on 32-bit systems, where it limits the legal sizes to 2^30 - 1). Add checks that the length of a dense array is below that threshold, and also fail fast if a length that is provided obviously could not be the correct dense length (because there isn't enough data left in the buffer to populate such an array). BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2399873002 Cr-Commit-Position: refs/heads/master@{#40094}
-
petermarshall authored
BUG=v8:5364 Review-Url: https://codereview.chromium.org/2350963004 Cr-Commit-Position: refs/heads/master@{#40093}
-
bjaideep authored
Port ec132e05 Original commit message: (GcStress failure was unrelated.) At one time, we hoped to generate the same code for different native contexts. But in truth, much performance comes from optimizing on the native context. Now we abandon this pathway. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2401043002 Cr-Commit-Position: refs/heads/master@{#40092}
-
machenbach authored
BUG=v8:5451,v8:5496 TBR=mtrofin@chromium.org, titzer@chromium.org, ahaas@chromium.org NOTRY=true NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2399343003 Cr-Commit-Position: refs/heads/master@{#40091}
-
rmcilroy authored
A wide jump can be patched with a non-wide jump target operand, so the DCHECK added in r39637 was wrong. BUG=chromium:652430 Review-Url: https://codereview.chromium.org/2400203002 Cr-Commit-Position: refs/heads/master@{#40090}
-
mstarzinger authored
This removes the restriction of only allowing lazy compilation for top-level eval code with a context. We can by now compile such code without a concrete closure. R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2400973002 Cr-Commit-Position: refs/heads/master@{#40089}
-
jbroman authored
Previously this would result in applying trying to find a size modulo zero, which causes SIGFPE. This approach was preferred over adding a default case to preserve the ability of the compiler to detect unhandled switch cases (within the valid range of the enum). BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2395073003 Cr-Commit-Position: refs/heads/master@{#40088}
-
jgruber authored
BUG= Committed: https://crrev.com/7db0ecdec3cf330766575cb7973b983f3f1e3020 Review-Url: https://codereview.chromium.org/2381843002 Cr-Original-Commit-Position: refs/heads/master@{#40080} Cr-Commit-Position: refs/heads/master@{#40087}
-
Mike Stanton authored
(GcStress failure was unrelated.) At one time, we hoped to generate the same code for different native contexts. But in truth, much performance comes from optimizing on the native context. Now we abandon this pathway. BUG= TBR=bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/2402663002 . Cr-Commit-Position: refs/heads/master@{#40086}
-
danno authored
In the process, also fix a merge hiccup that clobbered https://codereview.chromium.org/2003663002/ back in May. BUG=chromium:608675 LOG=N Review-Url: https://codereview.chromium.org/2397223002 Cr-Commit-Position: refs/heads/master@{#40085}
-
machenbach authored
The create.js file is loaded unconditionally in run.js, therefore we need to add it to resources, otherwise it fails on Android. TBR=caitp@igalia.com NOTRY=true Review-Url: https://codereview.chromium.org/2401883002 Cr-Commit-Position: refs/heads/master@{#40084}
-
mstarzinger authored
This removes the {ParseInfo} constructor consuming a closure, replacing all uses to pass only the shared function info. The goal is to make the fact that parsing is independent of a concrete closure explicit. R=jochen@chromium.org BUG=v8:2206 Review-Url: https://codereview.chromium.org/2396963003 Cr-Commit-Position: refs/heads/master@{#40083}
-
jgruber authored
This reverts commit 7db0ecde. Manual revert since automatic revert is too large for the web interface. BUG= TBR=bmeurer@chromium.org,mstarzinger@chromium.org,yangguo@chromium.org,ahaas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2396353002 Cr-Commit-Position: refs/heads/master@{#40082}
-
mvstanton authored
Revert of [turbofan] Discard the shared code entry in the optimized code map. (patchset #3 id:40001 of https://codereview.chromium.org/2401653002/ ) Reason for revert: Possible GCSTRESS failure, investigating. Original issue's description: > [turbofan] Discard the shared code entry in the optimized code map. > > At one time, we hoped to generate the same code for different > native contexts. But in truth, much performance comes from optimizing > on the native context. Now we abandon this pathway. > > BUG= > > Committed: https://crrev.com/55af3c44c99a6e4cd6d53df775023d760ad2b2c3 > Cr-Commit-Position: refs/heads/master@{#40079} TBR=mstarzinger@chromium.org,ishell@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2403453002 Cr-Commit-Position: refs/heads/master@{#40081}
-
jgruber authored
BUG= Review-Url: https://codereview.chromium.org/2381843002 Cr-Commit-Position: refs/heads/master@{#40080}
-
mvstanton authored
At one time, we hoped to generate the same code for different native contexts. But in truth, much performance comes from optimizing on the native context. Now we abandon this pathway. BUG= Review-Url: https://codereview.chromium.org/2401653002 Cr-Commit-Position: refs/heads/master@{#40079}
-
neis authored
The _ParseException function in testcfg.py made incorrect assumptions about how exceptions are printed (I believe it expected a trace like that produced by Error). R=littledan@chromium.org BUG=v8:5136 Review-Url: https://codereview.chromium.org/2386103010 Cr-Commit-Position: refs/heads/master@{#40078}
-
clemensh authored
In CreateModuleObjectFromBytes, pointers to the raw bytes will be stored inside the decoded WasmModule, and still used after allocating V8 stuff in WasmModule::CompileFunctions. We thus cannot pass a raw pointer to the V8 heap. Fix this by copying the bytes before decoding. R=mtrofin@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2402633002 Cr-Commit-Position: refs/heads/master@{#40077}
-
titzer authored
R=mtrofin@chromium.org,gdeepti@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2392943006 Cr-Commit-Position: refs/heads/master@{#40076}
-
hpayer authored
BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2397373002 Cr-Commit-Position: refs/heads/master@{#40075}
-
jochen authored
For now keep the logic in compiler.cc and add a DCHECK that the scopes and compiler.cc agree. Use this knowledge to only created ScopeInfos for literals we'll actually compile. BUG=v8:5394,v8:5422 R=marja@chromium.org,verwaest@chromium.org Review-Url: https://codereview.chromium.org/2399833002 Cr-Commit-Position: refs/heads/master@{#40074}
-