- 23 May, 2019 17 commits
-
-
Georg Neis authored
We were sometimes printing the data pointer, and sometimes the handle location. This CL always uses the existing operator<< overload to print ObjectRefs, which currently means printing the data pointer. Bug: v8:7790 Change-Id: Ic5e2dad075678d2250bc0bcb170046d055680572 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1625989Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#61777}
-
Clemens Hammacher authored
R=leszeks@chromium.org No-Try: true Bug: v8:9183 Change-Id: I9372bdc5d3789a1bbc50ef2737577c4f60173bce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627342Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61776}
-
Frederik Gossen authored
The python script allows to read the custom section "compilationHints" from a Wasm module. It prints all hints to standard out. Bug: v8:9003 Change-Id: Ife8173e3267557d8adf4b6739f45060d386f25dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619764 Commit-Queue: Frederik Gossen <frgossen@google.com> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61775}
-
Clemens Hammacher authored
This fixes compile errors after https://crrev.com/c/1624788. TBR=jkummerow@chromium.org No-Try: true Bug: v8:9183, v8:3770 Change-Id: I982e77e86389163f1549bbb02621b17972bbc158 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627336Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61774}
-
Peter Marshall authored
This is only used by ElementsKindToString(!). Implement ElementsKindToString with a big 'ol switch. The compiler will give us an error if we forget an ElementsKind. Bug: v8:9183 Change-Id: I1ed73ecac33aa7318a97f31794473d9afa16961c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624802 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#61773}
-
Benedikt Meurer authored
The tests need to properly hold on to the original fast-mode map, otherwise the GC might clear that, and so the NormalizedMapCache lookup would fail due to that. Bug: chromium:963411, v8:9114, v8:9183, v8:9267 Change-Id: Ic41ed363959a5c182c74097767dc14c366076e17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627333Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#61772}
-
Benedikt Meurer authored
The `FunctionTemplate::SetHiddenPrototype()` API was deprecated beginning of the year and all uses in Node.js and Chrome have been removed appropriately. This removes the implementation of the method and the bit in the `FunctionTemplateInfo`, but retains the bit in the Map for now. That will be cleaned up as a second step later. Bug: v8:9183, v8:9267 Change-Id: I9aa2fc484b3321f4f42a29a0a38d72a6d30054a7 Cq-Include-Trybots: luci.chromium.try:linux-rel,win7-rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627329 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61771}
-
Benedikt Meurer authored
There's a `Map::IsDictionaryMap()` method in addition to the `Map::is_dictionary_map()`, which apparently do very different things: The former checks whether the instance type of the Map is in a certain range (FIRST_DICTIONARY_TYPE to LAST_DICTIONARY_TYPE), while the latter checks the `is_dictionary_map` bit (which means that the backing store for the properties of a JSObject is in slow mode). To make matters worse there's also `CodeStubAssembler::IsDictionaryMap()`, which does the bit check similar to `Map::is_dictionary_map()`. And to make matters even worse the FIRST_DICTIONARY_TYPE to LAST_DICTIONARY_TYPE range also contains instance types for classes that aren't subclass of `Dictionary` (despite a comment stating the opposite). So in conclusion it's best to remove the confusing `Map::IsDictionaryMap()` method, which is anyways wrong, and just test explicitly for `NameDictionary`, `NumberDictionary` or `GlobalDictionary` in the appropriate places. Bug: v8:9183 Change-Id: If35f73261e3cc96938ebf499bf32be3ec725288b Cq-Include-Trybots: luci.chromium.try:linux-rel,win7-rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627330 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61770}
-
Yang Guo authored
TBR=bmeurer@chromium.org,leszeks@chromium.org Bug: v8:9247 Change-Id: I8d14d0192ea8c705f8274e8e61a162531826edb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624220Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#61769}
-
Clemens Hammacher authored
For consistency, {Object} members should only be accessed via ".". CL https://crrev.com/c/1624209 cleaned up the code base already. This CL removes the now dead operator. R=jkummerow@chromium.org Bug: v8:9183, v8:3770 Change-Id: I599dcd49d79bfc68f970fe872b64b3b2680cddd5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624788 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#61768}
-
Yang Guo authored
R=szuend@chromium.org Change-Id: I7d8eb6f26dd0cecd749a66cd2b240ff27cbba985 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621927 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#61767}
-
Yang Guo authored
Bug: v8:9247 Change-Id: Iaed837e146603c37b0ad64605405c442154cf1b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624222 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#61766}
-
Sigurd Schneider authored
The type of the argument makes it clear what we're internalizing, and this allows us to choose either one based on a template parameter. Change-Id: I6d7865e7fdef364f6cf10ff9267034df182d7539 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624212 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61765}
-
Clemens Hammacher authored
This CL was generated by an automatic clang AST rewriter using this matcher expression: callExpr( callee( cxxMethodDecl( hasName("operator->"), ofClass(isSameOrDerivedFrom("v8::internal::Object")) ) ), argumentCountIs(1) ) The "->" at the expression location was then rewritten to ".". R=jkummerow@chromium.org TBR=mstarzinger@chromium.org,verwaest@chromium.org,yangguo@chromium.org Bug: v8:9183, v8:3770 No-Try: true No-Tree-Checks: true Change-Id: I0a7ecabdeafe51d0cf427f5280af0c7cab96869e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624209Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61764}
-
Jun Lim authored
In fast mode, this CL try to avoid calling substring in @@match. For an ATOM type regexp, hold the literal string to search for before the loop and reuse the string instead of calling substring in the loop. Change-Id: Ice314ebf146261cf206c21cb1530a2a44d3c42ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1618435Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#61763}
-
Yang Guo authored
Bug: v8:9247 Change-Id: I0023200c54fa6499ae4e2cf5e4c89407cc35f187 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624218Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61762}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0742a14..97564df Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/9ea486b..6884242 Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+log/9b96c3d..5938e05 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/535dc1d..4d346fb Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c7e440c..181e44c Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2db48c7..9d46446 Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/1b65f4e..779c4f0 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I7b2824622066da423b7f7584338a42e06902701d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627110Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#61761}
-
- 22 May, 2019 23 commits
-
-
Mathias Bynens authored
https://github.com/tc39/ecma262/issues/1530 https://github.com/tc39/test262/pull/2161 Bug: v8:7834, v8:9131 Change-Id: I9c5efe9d6eec6c5dabc120d1b1089341ed5b1088 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1625992 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#61760}
-
Frank Tang authored
Adds "calendar" and "numberingSystem" options for Intl.DateTimeForamt and "numberingSystem" for Intl.NumberFormat. Plan to flip to ship in early June (after m76 branch) for chrome m77. Spec: https://github.com/tc39/ecma402/pull/175 I2I: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!searchin/v8-dev/ftang%7Csort:date/v8-dev/7sk-rEHuCY4/n7kH0WzyAwAJ Tests: test262/intl402/NumberFormat/numbering-system-options test262/intl402/DateTimeFormat/numbering-system-calendar-options intl/number-format/check-numbering-system intl/date-format/check-numbering-system intl/date-format/check-calendar Bug: v8:9154 Change-Id: I80020b9af6bf9c87f5a1efc7aac3080e723eea34 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622728Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#61759}
-
Toon Verwaest authored
Change-Id: Ibb3f6d5a0f2f24ff5359ca280f058a20c8215ac1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624801 Auto-Submit: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#61758}
-
Paolo Severini authored
Function win64_unwindinfo::RegisterNonABICompliantCodeRange() calls LoadNtdllUnwindingFunctions() to dynamically load from ntdll a couple of functions that are not available on Windows 7. Unfortunately there is a race condition in LoadNtdllUnwindingFunctions() that can cause a crash when multiple isolates are initialized concurrently. This can be fixed using base::CallOnce(). Bug: v8:9204 Change-Id: I5c57708ab5f16e9ef9f897efce1ccdf591e2f828 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1623592Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Paolo Severini <paolosev@microsoft.com> Cr-Commit-Position: refs/heads/master@{#61757}
-
Z Duong Nguyen-Huu authored
Bug: v8:8996 Change-Id: Icb454f8ff5f0964b019f360e71119158341307de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622743 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#61756}
-
Clemens Hammacher authored
This is a reland of 2ce5da9a Original change's description: > [wasm] Compile big functions first > > Add a special queue to {CompilationUnitQueues} to handle big functions > specially. They are organized in a priority queue (ordered by their > body size), and all threads check this queue first, before executing > the tasks from their own queue. In some benchmarks, this shortens > overall compilation time by 10-20 percent. > > R=ahaas@chromium.org > > Bug: v8:8916, chromium:950493 > Change-Id: I45f36a05304e2f1c4f3ce6b8821ddd4bd08fbba3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622122 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61746} Bug: v8:8916, chromium:950493 No-Presubmit: true Change-Id: I26c949ce6a0f5efee684561dc0b4eba44921cddf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624799 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#61755}
-
Clemens Hammacher authored
This reverts commit a03ed626. Reason for revert: Fails on win32: https://ci.chromium.org/p/v8/builders/ci/V8%20Win32/21252 Original change's description: > [tracing] Add a configurable output stream for perfetto tracing > > Add the ability to provide perfetto with an output stream for the JSON > consumer rather than hardcode it. D8 will use this interface exclusively > once the old trace controller is removed. > > Also add a test for scope-managed trace events and their duration - this > was leftover from a previous CL. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng > Bug: v8:8339 > Change-Id: I1c45e17e528b549a4cfdaecabd33c7ac4ab4af77 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1611801 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61753} TBR=ulan@chromium.org,yangguo@chromium.org,jgruber@chromium.org,petermarshall@chromium.org Change-Id: Ie7dbe4fc5f9e496fafc8e3ad2b05011b88c9e2c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8339 Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1625465Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61754}
-
Peter Marshall authored
Add the ability to provide perfetto with an output stream for the JSON consumer rather than hardcode it. D8 will use this interface exclusively once the old trace controller is removed. Also add a test for scope-managed trace events and their duration - this was leftover from a previous CL. Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng Bug: v8:8339 Change-Id: I1c45e17e528b549a4cfdaecabd33c7ac4ab4af77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1611801Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#61753}
-
Andreas Haas authored
Up until now, we cached export wrappers per export index. With the anyref proposal potentially many more functions will need export wrappers, e.g. any function that is stored in a table, and any function accessed by the new ref.func instruction. With this CL, we change the caching scheme an do the caching per signature. Thereby we can guarantee that any export wrapper which potentially exists can be stored in the cache. For cctests which use wasm-run-utils, we don't know the size of the cache anymore ahead of time. However, we assume that no more than 5 signatures will be used in any cctest. If this assumption is not true, we can just adjust the number. The cache is now accessed in all code paths where we need an export wrapper. Bug: chromium:962850 Change-Id: I32df60dfa7801d1e71f7d837da091f388198af1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1615247 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61752}
-
Andreas Haas authored
The core spec tests need to be generated manually for now, because our bots don't have an ocaml installation. This CL was created automatically by running ./tools/wasm/update-wasm-spec-tests.sh. R=adamk@chromium.org Change-Id: I4c6199b51f30b29f150914a9bffe6009452c8c47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624794Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#61751}
-
Clemens Hammacher authored
{Object::operator->} will be removed soon. R=tebbi@chromium.org Bug: v8:9183, v8:3770 Change-Id: Ifb7754c16055aec41dd30a92e81521a830de4f26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624210Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61750}
-
Clemens Hammacher authored
This reverts commit 2ce5da9a. Reason for revert: Fails on several bots, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/26607 Original change's description: > [wasm] Compile big functions first > > Add a special queue to {CompilationUnitQueues} to handle big functions > specially. They are organized in a priority queue (ordered by their > body size), and all threads check this queue first, before executing > the tasks from their own queue. In some benchmarks, this shortens > overall compilation time by 10-20 percent. > > R=ahaas@chromium.org > > Bug: v8:8916, chromium:950493 > Change-Id: I45f36a05304e2f1c4f3ce6b8821ddd4bd08fbba3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622122 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61746} TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: Ib47b23ff878d4a561df1993d532e5eeafea64ff6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8916, chromium:950493 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624797Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61749}
-
Jakob Gruber authored
Refactor-only: move the more involved EmbeddedFileWriter methods into the .cc file. Bug: v8:9103 Change-Id: I546c23544a0425a32cbd04cecc759f9b553b7071 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624207 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#61748}
-
Georg Neis authored
Use JSObject::FastPropertyAt instead. Also, to avoid adding an immutable-flag to PropertyAccessInfo, use DataConstant (instead of DataField) for properties that are immutable according to their attributes. This is in preparation for serializing the property value for concurrent inlining. Bug: v8:7790 Change-Id: Ib40059bde2e5eb14b26400bcab72d6ea6bb57666 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624790Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#61747}
-
Clemens Hammacher authored
Add a special queue to {CompilationUnitQueues} to handle big functions specially. They are organized in a priority queue (ordered by their body size), and all threads check this queue first, before executing the tasks from their own queue. In some benchmarks, this shortens overall compilation time by 10-20 percent. R=ahaas@chromium.org Bug: v8:8916, chromium:950493 Change-Id: I45f36a05304e2f1c4f3ce6b8821ddd4bd08fbba3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622122Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61746}
-
Jakob Gruber authored
This is in preparation for better cross-compile support in mksnapshot. Specifically, this CL series will introduce runtime switches to select the target platform for generated embedded.S assembly. Each platform writer will derive from the abstract base class PlatformEmbeddedFileWriterBase. Currently, the code remains functionally unmodified and was just moved to PlatformEmbeddedFileWriterGeneric. This will be split up in future CLs. Bug: v8:9103 Change-Id: Ie7e29bb60ba5a8ff6c0c1edec676943b80a1781b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1622854 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#61745}
-
Ross McIlroy authored
Change-Id: I68e716ee664ae2295089ee4d6af6a0ea6dbf1c1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624789 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#61744}
-
Mythri A authored
KeyedStoreIC computes the expected transition to the map based on the incoming receiver map, the index and the value that is being stored. Since we already store the element into the object, the runtime would have already computed these transitions and it is possible to use the new map of the object instead of recomputing the map. Though we would need additional checks to see the newly transitioned map is indeed a more generic elements transition and not an unexpected transition. Bug: v8:8394 Change-Id: If6819895e5d20dd76bb062c6064593bf3a920778 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621937 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#61743}
-
Simon Zünd authored
This CL also removes the AdaptorWithExitFrame builtin and simplifies respective use-sites. Bug: v8:9183 Change-Id: I97c4e35aa551f586faedcb09cc0b2b837e5307f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624215Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#61742}
-
Mythri A authored
FindElementsKindTransitionedMap checks if we could transition from the source map to one of the target maps without requiring any instance rewriting. It does this by replaying all the property transitions of the source map on each elements kind map and seeing if it needs a instance rewrite. Since we already know the elements kind of the target maps, we can avoid doing this for element kinds that are not in target map. Change-Id: Ief9ba89992a411535a0335c3b67221666647f55e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624208Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#61741}
-
Igor Sheludko authored
This reverts commit 2d710200. Reason for revert: It's not ready for shipping in M76. > Reland "[ptr-compr][x64] Temporarily enable pointer compression on x64" > > This is a reland of d61a9347 > > 6th attempt. Relanding after fixing TSan/UBSan issues. > > Original change's description: > > [ptr-compr][x64] Temporarily enable pointer compression on x64 > > > > ... and make sure that the x64 ptr-compr bots proceed testing V8 without > > pointer compression in order to keep testing the full pointer mode. > > > > Bug: v8:7703 > > Change-Id: Ib1498609603cb03be2464043658131d5a2f1e012 > > Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel > > Cq-Include-Trybots: luci.chromium.try:fuchsia_x64,linux-rel,mac-rel > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559850 > > Commit-Queue: Igor Sheludko <ishell@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#61416} > > Bug: v8:7703 > Change-Id: I1fa0989aef9ea08e54fd6dfd32d6989367332ce3 > Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel > Cq-Include-Trybots: luci.v8.try:v8_linux64_cfi_rel_ng > Cq-Include-Trybots: luci.chromium.try:fuchsia_x64,linux-rel,mac-rel > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1607654 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61559} Tbr: machenbach@chromium.org Bug: v8:7703 Change-Id: Ic73b57203bbcb637e33b3577ce8142d43c364796 Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel Cq-Include-Trybots: luci.v8.try:v8_linux64_cfi_rel_ng Cq-Include-Trybots: luci.chromium.try:fuchsia_x64,linux-rel,mac-rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621942 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61740}
-
Jakob Gruber authored
The mksnapshot-specific runtime flag --target-arch, together with --target-os, specifies the target platform for the generated embedded.S file. Bug: v8:9103 Change-Id: Icb03a381101e7ab0db4a5fbbf3be8e23ed0b1a1c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624165 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#61739}
-
Santiago Aboy Solanes authored
Decompressions before TypedStateValues can be safely skipped since TypedStateValues always decompresses values. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: Ic3d43c21183c0decda123cb377706ee5c3c12f87 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617939 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#61738}
-