- 21 Jan, 2019 1 commit
-
-
Tamer Tas authored
Moving to a lazy test loading approach makes counting the total number of tests non-trivial. For CI runs, we output the total number of tests after the run. For users, progress indicator signals the status of the run. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8174 Change-Id: I0731964515aac60a3629acee6c7243433a2b4e04 Reviewed-on: https://chromium-review.googlesource.com/c/1420677 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58944}
-
- 19 Jan, 2019 1 commit
-
-
Sergiy Belozorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:922125 Change-Id: I58e6e2f3525293df0a6513611e16cd21b65e3985 Reviewed-on: https://chromium-review.googlesource.com/c/1418191 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58942}
-
- 18 Jan, 2019 3 commits
-
-
Tamer Tas authored
testrunner has tests asserting about the implementation details, assertions about the behavior of the testrunner (already in-place) provides robust coverage already. This cl remove the brittle assertions. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8174 Change-Id: I6583c971b7cf7eb2eb7dfa2b6737d6aa67957feb Reviewed-on: https://chromium-review.googlesource.com/c/1421359 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58928}
-
Georg Neis authored
Change-Id: I807581b0c058c304769d4ba1b4f9bc8a9739536f No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1417633Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58920}
-
Michael Achenbach authored
The tests were skipped due to problems with the previous test setup. Now the setup is the same as in Chromium and those tests should pass. NOTRY=true Bug: chromium:828847 Change-Id: Ibfbb931031176add90a340ca79c71e89f05e3045 Reviewed-on: https://chromium-review.googlesource.com/c/1421318Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58918}
-
- 17 Jan, 2019 1 commit
-
-
Ulan Degenbaev authored
This is a reland of fd49c8bb Original change's description: > [heap] Optimize MemoryChunk::FromAnyPointerAddress > > Currently this function requires the caller to hold a mutex for the > large page chunk hashtable and performs a hashtable lookup. > > This patch adds a header sentinel field in each MemoryChunk. The field > is then used to distinguish large object slots from ordinary slots. > > Bug: chromium:915233 > Change-Id: I9fbeeb4f07f49573d0a21f9a2cc934370e417d68 > Reviewed-on: https://chromium-review.googlesource.com/c/1391752 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58732} Bug: chromium:915233 Change-Id: I10d23a928328169a2dc6bab78d2b7d2c5d00ebb6 Reviewed-on: https://chromium-review.googlesource.com/c/1406672 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#58876}
-
- 16 Jan, 2019 3 commits
-
-
Sergiy Belozorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:616879 Change-Id: I301af0a07f29c32c1ade23a7858455aa2632a847 Reviewed-on: https://chromium-review.googlesource.com/c/1407083 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58864}
-
Daniel Clifford authored
With the changes in this patch, it is now possible to add methods to both Torque's class and struct types. As a special case, "constructor" methods are used to initialize the values of classes and structs when they are constructed. The functionality in this patch includes: - The refactoring of class- and struct-handling code to share field and method declaration code between both. - Addition of the "%Allocate" intrinsic that allocates raw bytes to be allocated from the V8 GC's NewSpace heap as the basis for freshly created, initialized class objects. - An implementation of a CallMethodExpression AST node that enables calling methods and constructors, including special handling of passing through the "this" pointer for method calls on structs by reference. The syntax for struct construction using "{}" remains as before, but now calls the struct's matching constructor rather than implicitly initializing the struct fields with the initialization arguments. A new syntax for allocation classes is introduced: "new ClassName{constructor_param1, constructor_param1, ...}", which de-sugars to an %Allocate call followed by a call to the matching constructor. - class constructors can use the "super" keyword to initialize their super class. - If classes and struct do not have a constructor, Torque creates a default constructor for them based on their field declarations, where each field's initial value is assigned to a same-typed parameter to the the default constructor. The default constructor's parameters are in field-declaration order, and for derived classes, the default constructor automatically uses a "super" initialization call to initialize inherited fields. - Class field declarations now automatically create ".field" and ".field=" operators that create CSA-compatible object accessors. - Addition of a no-argument constructor for JSArrays that creates an empty, PACKED_SMI_ELEMENTS JSArray using the machinery added elsewhere in this patch. Bug: v8:7793 Change-Id: I31ce5f4b444656ab999555d780aeeba605666bfa Reviewed-on: https://chromium-review.googlesource.com/c/1392192 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#58860}
-
Sergiy Belozorov authored
R=machenbach@chromium.org, tmrts@chromium.org No-Try: true Bug: chromium:616879 Change-Id: I1dbef7ca4ac69df2d3de654b381ab163d5be4214 Reviewed-on: https://chromium-review.googlesource.com/c/1409200 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58845}
-
- 15 Jan, 2019 5 commits
-
-
Leszek Swirski authored
This is more idiomatic than using a Promise. Change-Id: I61443e90ef1c0c589284851ea9be410153919eb5 Reviewed-on: https://chromium-review.googlesource.com/c/456278Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#58828}
-
Tamer Tas authored
V8 testrunner is loading every test it has to run into memory greedily in order to sort by slowness of the test case. The memory and CPU overhead for loading the test-suites are non-trivial. This CL restructures it by changing the sorting method. R=machenbach@chromium.org CC=sergiyb@chromium.org,yangguo@chromium.org Bug: v8:8174 Change-Id: I08331182147b92cf4ac54823eea0e2b472f51e84 Reviewed-on: https://chromium-review.googlesource.com/c/1406684 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58821}
-
Sigurd Schneider authored
Notry: true Bug: v8:7327 Change-Id: I9cdea29db2b409d773a16e3d6c29ef4325257162 Reviewed-on: https://chromium-review.googlesource.com/c/1409437 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58815}
-
Sigurd Schneider authored
This allows to reset the layout to the the inital layout of the graph, which only contains the control nodes. Change-Id: I7ab9fb1615057df99983369cd0fcdd42a68e1924 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1409436 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58814}
-
Sigurd Schneider authored
This enables per-phase toolbox items, which makes the toolbar easier to understand and use. Change-Id: I1b44d28595c118f0ba55dd64eea54415b51b93aa Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1409435Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58813}
-
- 14 Jan, 2019 9 commits
-
-
Sigurd Schneider authored
The URL must not have a leading slash, and the file needs to be included in the deployment script. TBR=neis@chromium.org Change-Id: Idd3fc25c052cb720d4956f630a8ddca7e5d36a1a Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1409432Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58799}
-
Sigurd Schneider authored
This is a first step towards support for opening more than one turbolizer json file at once. Change-Id: Id51ce47c59492ba63de03eceb0163fa1701ea500 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1407057 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58790}
-
Sigurd Schneider authored
..as mentioned in the info tab. Change-Id: I9ddbe1ad7eb3242ad7839650aecc7305a902fb0d Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1407056 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58789}
-
Sigurd Schneider authored
..instead of wrongly keeping the location from the previous view if the selection became empty after attaching it. Change-Id: I606010ad86034c2ec06e00c82143a22ca2d88274 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1407055 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58788}
-
Sigurd Schneider authored
..and display them in the extended node title (on hover). Notry: true Bug: v8:7327 Change-Id: Ic9cd6207269686edb42ecf1bee8f7ef7b6caa035 Reviewed-on: https://chromium-review.googlesource.com/c/1407054 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58783}
-
Sigurd Schneider authored
Drive-by: Make label of checkboxes in disassembly view clickable. Notry: true Bug: v8:7327 Change-Id: I29478c5cb2bd4152df7943f9dfbba487f3b8bddb Reviewed-on: https://chromium-review.googlesource.com/c/1407053 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58782}
-
Sigurd Schneider authored
Notry: true Bug: v8:7327 Change-Id: I440578b6b790f7f5f4cb41147572f32459fb59e5 Reviewed-on: https://chromium-review.googlesource.com/c/1407052 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58781}
-
Sigurd Schneider authored
Notry: true Bug: v8:7327 Change-Id: I2592d921905ad361f09ff6d99c0b0d64617543c4 Reviewed-on: https://chromium-review.googlesource.com/c/1407051 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58780}
-
Tom Tan authored
.rdata is the default section which hosts read-only data for COFF. Use this default section name avoids creating a new .rodata section with explicit read-only property. Bug: chromium:919180 Change-Id: I7325cbcfdb142b3ee15de93b7881f755c365d6e6 Reviewed-on: https://chromium-review.googlesource.com/c/1407240 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58764}
-
- 12 Jan, 2019 3 commits
-
-
Sigurd Schneider authored
- 'let' instead of 'var', and prefer 'const' - Prefer for-of over indexed interation - Variable names should be 'camel-case' or all-caps snake-case. - Only one variable declaration per line Change-Id: I645dd2333d6d9a993f24c29121f5f156249f1b71 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1405320 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58761}
-
Sigurd Schneider authored
Change-Id: I8e147bcb5d1e0b8e16874f0593a8ce4338dfc201 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1405319 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58760}
-
Sigurd Schneider authored
- Ban T[] array syntax - Format arrow function arguments consistently Bug: v8:7327 Notry: true Change-Id: I072a352ec9009948392a6bb5dd4381d4993af7be Reviewed-on: https://chromium-review.googlesource.com/c/1405317 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58759}
-
- 11 Jan, 2019 8 commits
-
-
Sergiy Belozorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:920561 Change-Id: Ice88e78100d8c87d11e30c8c5fa42c54206c2967 Reviewed-on: https://chromium-review.googlesource.com/c/1363132 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58757}
-
Sergiy Belozorov authored
R=machenbach@chromium.org No-Try: true Bug: chromium:920561 Change-Id: Iaf80de577ba2c6b2d22938240aba6b9e432b7427 Reviewed-on: https://chromium-review.googlesource.com/c/1404441Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58756}
-
Camillo Bruni authored
Drive-by-fix: - Add several iterator instance types to user objects - Add JSProxy instance type to user objects - Rename *PRE_PARSED_SCOPE* to *PREPARSE_DATA* Change-Id: Ia1304871c91bb4e7e46ae0aef6084ded985b9a9f Reviewed-on: https://chromium-review.googlesource.com/c/1405040Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#58745}
-
Tamer Tas authored
TestSuite has a static method LoadTestSuite that should properly configure the TestSuite instance (i.e. loaded status files and tests), however the method leaves some configuration logic to the caller. The leaky abstraction causes the caller to do a bunch of loading operations (see the removed methods in base_runner.py). This CL isolates the TestSuite loading logic to the static method only. This is a refactoring only change without any intended logical changes. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8174 Change-Id: I105059c9c9e050f03bb584174e2bd7ceeae2b228 Reviewed-on: https://chromium-review.googlesource.com/c/1396417 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58744}
-
Michael Achenbach authored
This reverts commit fd49c8bb. Reason for revert: Speculative revert for: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/24672 Original change's description: > [heap] Optimize MemoryChunk::FromAnyPointerAddress > > Currently this function requires the caller to hold a mutex for the > large page chunk hashtable and performs a hashtable lookup. > > This patch adds a header sentinel field in each MemoryChunk. The field > is then used to distinguish large object slots from ordinary slots. > > Bug: chromium:915233 > Change-Id: I9fbeeb4f07f49573d0a21f9a2cc934370e417d68 > Reviewed-on: https://chromium-review.googlesource.com/c/1391752 > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58732} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: I232729fdfd55baef7de99ea2fd14fbc0a2f71d27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:915233 Reviewed-on: https://chromium-review.googlesource.com/c/1406671Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58738}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org Bug: v8:8174, v8:8457 Change-Id: Ie87eddcc6986e1c724040b11b036b502e399dd05 Reviewed-on: https://chromium-review.googlesource.com/c/1404437Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58735}
-
Jakob Kummerow authored
Dynamically process the arguments instead of hardcoding them, which is brittle when they change. Change-Id: I08f603dc6df6e3ed34518326b67da15f6a6d6102 Reviewed-on: https://chromium-review.googlesource.com/c/1405312 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58733}
-
Ulan Degenbaev authored
Currently this function requires the caller to hold a mutex for the large page chunk hashtable and performs a hashtable lookup. This patch adds a header sentinel field in each MemoryChunk. The field is then used to distinguish large object slots from ordinary slots. Bug: chromium:915233 Change-Id: I9fbeeb4f07f49573d0a21f9a2cc934370e417d68 Reviewed-on: https://chromium-review.googlesource.com/c/1391752 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#58732}
-
- 10 Jan, 2019 3 commits
-
-
Daniel Clifford authored
Class declarations support structured heap data that is a subtype of HeapObject. Only fields of Object subtypes (both strong and weak) are currently supported (no scalar fields yet). With this CL, both the field list macro used with the C++ DEFINE_FIELD_OFFSET_CONSTANTS macro (to make field offset constants) as well as the Torque "operator '.field'" macros are generated for the classes declared in Torque. This is a first step to removing the substantial amount of duplication and boilerplate code needed to declare heap object classes. As a proof of concept, and handful of class field definitions, including those for non trivial classes like JSFunction, have been moved to Torque. Bug: v8:7793 Change-Id: I2fa0b53db65fa6f5fe078fb94e1db3418f908753 Reviewed-on: https://chromium-review.googlesource.com/c/1373971 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#58704}
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: I59d73ef672e64fd722317c84afc6bc5cb387f5b1 Reviewed-on: https://chromium-review.googlesource.com/c/1404448Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58702}
-
Jakob Gruber authored
This CL disables RX (read and execute) permissions for Code memory when in jitless mode. All memory that was previously allocated RX is now read-only. Bug: v8:7777 Cq-Include-Trybots: luci.v8.try:v8_linux_arm_lite_rel_ng Change-Id: I52d6ed785d244ec33168a02293c5506d26f36fe8 Reviewed-on: https://chromium-review.googlesource.com/c/1390122 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#58692}
-
- 09 Jan, 2019 3 commits
-
-
Sigurd Schneider authored
Change-Id: Iffd68156515948254e4ce38021c511596acc5788 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1400849 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58681}
-
Tamer Tas authored
R=sergiyb@chromium.org No-Try: true Change-Id: I94937b6852c8e7e8aece3b67eb1c2a79dbf71c25 Reviewed-on: https://chromium-review.googlesource.com/c/1392193 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58671}
-
Tom Tan authored
.rodata usually hosts read only data. MSVC link.exe complains mismatch when merging this read/write .rodata from embedded.S with .rodata from other object file. Bug: chromium:919180 Change-Id: I7789e42afe116cc4bf772e2cbb312d19e4ce7fe5 Reviewed-on: https://chromium-review.googlesource.com/c/1396361 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58653}
-