- 26 Aug, 2015 2 commits
-
-
conradw authored
When encountering a "=" token in ParseAssignmentExpression, the default parameter case is not locally distinguishable from the destructuring case. BUG= Review URL: https://codereview.chromium.org/1317843002 Cr-Commit-Position: refs/heads/master@{#30386}
-
littledan authored
The lack of marking this dependency led to a ClusterFuzz crash when sloppy-function was on but not sloppy. This case does not make sense. R=adamk LOG=N BUG=chromium:520891 Review URL: https://codereview.chromium.org/1316773004 Cr-Commit-Position: refs/heads/master@{#30364}
-
- 25 Aug, 2015 3 commits
-
-
hpayer authored
BUG=524425 LOG=n Review URL: https://codereview.chromium.org/1314903002 Cr-Commit-Position: refs/heads/master@{#30359}
-
mtrofin authored
This change encompasses what is necessary to enable stack checks in loops without suffering large regressions. Primarily, it consists of a new mechanism for dealing with deferred blocks by "splintering", rather than splitting, inside deferred blocks. My initial change was splitting along deferred block boundaries, but the regression introduced by stackchecks wasn't resolved conclusively. After investigation, it appears that just splitting ranges along cold block boundaries leads to a greater opportunity for moves on the hot path, hence the suboptimal outcome. The alternative "splinters" ranges rather than splitting them. While splitting creates 2 ranges and links them (parent-child), in contrast, splintering creates a new independent range with no parent-child relation to the original. The original range appears as if it has a liveness hole in the place of the splintered one. All thus obtained ranges are then register allocated with no change to the register allocator. The splinters (cold blocks) do not conflict with the hot path ranges, by construction. The hot path ones have less pressure to split, because we remove a source of conflicts. After allocation, we merge the splinters back to their original ranges and continue the pipeline. We leverage the previous changes made for deferred blocks (determining where to spill, for example). Review URL: https://codereview.chromium.org/1305393003 Cr-Commit-Position: refs/heads/master@{#30357}
-
rossberg authored
...in canary. This reverts commit c75af232. R=hablich@chromium.org BUG= Review URL: https://codereview.chromium.org/1319443002 Cr-Commit-Position: refs/heads/master@{#30346}
-
- 24 Aug, 2015 2 commits
-
-
domenic authored
Intent to ship: https://groups.google.com/d/msg/v8-users/-a8_8cb6FRI/trjyB5bACQAJ BUG=v8:3575 R=adamk@chromium.org, rossberg@chromium.org LOG=Y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1295543003 Cr-Commit-Position: refs/heads/master@{#30339}
-
rossberg authored
...until the hotfix has baked. R=hablich@chromium.org BUG=v8:4211 LOG=Y Review URL: https://codereview.chromium.org/1310243002 Cr-Commit-Position: refs/heads/master@{#30332}
-
- 21 Aug, 2015 1 commit
-
-
mlippautz authored
BUG= Review URL: https://codereview.chromium.org/1301963002 Cr-Commit-Position: refs/heads/master@{#30303}
-
- 20 Aug, 2015 1 commit
-
-
domenic authored
Embedders would use these for features which must be able to be turned off at runtime, despite being compiled into V8. They can be turned on and off by the embedder using the --experimental_extras flag, e.g. via v8::SetFlagsFromString. R=yangguo@chromium.org, mlippautz@chromium.org, hpayer@chromium.org BUG=chromium:507137 LOG=Y Review URL: https://codereview.chromium.org/1284413002 Cr-Commit-Position: refs/heads/master@{#30260}
-
- 18 Aug, 2015 2 commits
-
-
bradnelson authored
Place a copy of the v8-native-prototype in third_party/wasm. GYP_DEFINES='v8_wasm=1' gclient runhooks BUG=None TEST=None R=titzer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1294543006 Cr-Commit-Position: refs/heads/master@{#30225}
-
oth authored
Bytecode generator for local assignment and basic binary operations. Command-line flag for printing bytecodes. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1294543002 Cr-Commit-Position: refs/heads/master@{#30221}
-
- 17 Aug, 2015 1 commit
-
-
rossberg authored
Based on caitp's https://codereview.chromium.org/1127063003/ R=adamk@chromium.org, littledan@chromium.org BUG=v8:2160 LOG=N Review URL: https://codereview.chromium.org/1287063004 Cr-Commit-Position: refs/heads/master@{#30192}
-
- 14 Aug, 2015 1 commit
-
-
ofrobots authored
Restricts linux perf-event code range reporting to functions only (i.e. on stubs.) While this makes the gathered ticks less accurate, it reduces the growth of the /tmp/perf-${pid}.map file. BUG=v8:3453 R=hablich@chromium.org,danno@chromium.org LOG=N Review URL: https://codereview.chromium.org/1292743002 Cr-Commit-Position: refs/heads/master@{#30179}
-
- 12 Aug, 2015 2 commits
-
-
littledan authored
This patch puts --harmony-sloppy into staging. Now that let, lexically-scoped functions and ES2015 sloppy mode const semantics have been split off into separate flags, the change only enables classes in sloppy mode. BUG=v8:3305 R=adamk LOG=Y Review URL: https://codereview.chromium.org/1288153003 Cr-Commit-Position: refs/heads/master@{#30141}
-
littledan authored
In an initial attempt to implement sloppy mode lexical bindings, functions were made lexically scoped in sloppy mode. However, the ES2015 spec says that they need an additional hoisted var binding, and further, it's not clear when we'll implement that behavior or whether it's web-compatible. This patch splits off function block scoping into a new, separate flag called --harmony_sloppy_function. This change will enable the possibility of testing and shipping this feature separately from other block scoping-related features which don't have the same risks. BUG=v8:4285 R=adamk LOG=N Review URL: https://codereview.chromium.org/1282093002 Cr-Commit-Position: refs/heads/master@{#30122}
-
- 11 Aug, 2015 1 commit
-
-
domenic authored
BUG=v8:3575 R=adamk@chromium.org, rossberg@chromium.org LOG=Y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1283963002 Cr-Commit-Position: refs/heads/master@{#30121}
-
- 10 Aug, 2015 2 commits
-
-
yangguo authored
R=jkummerow@chromium.org BUG=chromium:517778 LOG=Y Review URL: https://codereview.chromium.org/1278353002 Cr-Commit-Position: refs/heads/master@{#30084}
-
mlippautz authored
BUG= Review URL: https://codereview.chromium.org/1281923002 Cr-Commit-Position: refs/heads/master@{#30083}
-
- 05 Aug, 2015 3 commits
-
-
adamk authored
It was shipped in V8 4.4. Review URL: https://codereview.chromium.org/1273543002 Cr-Commit-Position: refs/heads/master@{#30038}
-
adamk authored
It was shipped in V8 4.4. Review URL: https://codereview.chromium.org/1271073002 Cr-Commit-Position: refs/heads/master@{#30035}
-
mlippautz authored
With the recent changes to the incremental marking API we can now kick off incremental marking while respecting callback flags. Performance neutral for smoothness.image_decoding_cases on N9 (read: does not crash) as long as we synchronously process phantom callbacks (kGCCallbackFlagForced). OORT single run: "marksweep": { "count": 5, "pause_min": 7.5, "pause_max": 158.8, "pause_avg": 97.52000000000001, "pause_gt_10ms": 4 } --- vs --- "marksweep": { "count": 5, "pause_min": 16.2, "pause_max": 22.1, "pause_avg": 19.32, "pause_gt_10ms": 5 } The number of actual full GCs varies. The improvement manifests in reduced maximum and average pauses. BUG=chromium:515795 LOG=N Review URL: https://codereview.chromium.org/1271253002 Cr-Commit-Position: refs/heads/master@{#30028}
-
- 04 Aug, 2015 3 commits
-
-
adamk authored
To avoid tanking context startup performance, only the actual installation of the JS-exposed API is flag-guarded. The remainder of the implementation still resides in the snapshot. Review URL: https://codereview.chromium.org/1257063003 Cr-Commit-Position: refs/heads/master@{#30017}
-
adamk authored
BUG=v8:3887 LOG=y Review URL: https://codereview.chromium.org/1267773009 Cr-Commit-Position: refs/heads/master@{#30013}
-
mtrofin authored
Setting up the stage for heuristics that preprocess live ranges before register allocation, and are independent of register allocation - e.g. the deferred blocks heuristic, or the split at call sites heuristic. Added a separate flag for this, since we intend to enable it for the linear allocator as well. Currently, the option is "on" for greedy, as a point in time to enable its testing (through the greedy allocator bots). BUG= Review URL: https://codereview.chromium.org/1256313003 Cr-Commit-Position: refs/heads/master@{#30005}
-
- 30 Jul, 2015 1 commit
-
-
Benedikt Meurer authored
Reland^3 "Enable loads and stores to global vars through property cell shortcuts installed into par… (patchset #1 id:1 of https://codereview.chromium.org/1254723004/)" This reverts commit 2c16d81b. R=hablich@chromium.org Review URL: https://codereview.chromium.org/1261533004 . Cr-Commit-Position: refs/heads/master@{#29915}
-
- 29 Jul, 2015 1 commit
-
-
jkummerow authored
Revert^3 "Enable loads and stores to global vars through property cell shortcuts installed into par… (patchset #1 id:1 of https://codereview.chromium.org/1254723004/) Reason for revert: Suspected to cause Canary crashes Original issue's description: > Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into parent script context". > > This reverts commit 362b3785. > > R=ishell@chromium.org > > Committed: https://crrev.com/440ae014e56924b52337c3747221b79283f07b81 > Cr-Commit-Position: refs/heads/master@{#29849} TBR=ishell@chromium.org,v8-mips-ports@googlegroups.com,plind44@gmail.com,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/1260423002 Cr-Commit-Position: refs/heads/master@{#29905}
-
- 28 Jul, 2015 1 commit
-
-
hpayer authored
Revert of Activate preserving of optimized code map accross GCs. (patchset #1 id:1 of https://codereview.chromium.org/1217863006/) Reason for revert: This CL may be the reason for the spike on memory corruption. Tentatively reverting this CL. BUG=chromium:512780 LOG=n Original issue's description: > Activate preserving of optimized code map accross GCs. > > This enables --noflush-optimized-code-cache which allows preserving > entries in the optimized code map accross GCs. This only applies to > values being reachable through other paths. > > R=hpayer@chromium.org,hablich@chromium.org > > Committed: https://crrev.com/1a8776db25b63c4ce718423772d1fd13f58eeab5 > Cr-Commit-Position: refs/heads/master@{#29755} TBR=hablich@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1255043003 Cr-Commit-Position: refs/heads/master@{#29888}
-
- 25 Jul, 2015 1 commit
-
-
littledan authored
--harmony_sloppy includes behavior to turn on sloppy mode lexical bindings. Before this patch, it also included a way to parse let which is likely web-incompatible (let is disallowed as an identifier). This patch splits off the let parsing from the more general block scoping code, so that block scoping can be developed independently. R=adamk LOG=N BUG=v8:3305 Review URL: https://codereview.chromium.org/1255013002 Cr-Commit-Position: refs/heads/master@{#29855}
-
- 24 Jul, 2015 2 commits
-
-
bmeurer authored
Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into parent script context". This reverts commit 362b3785. R=ishell@chromium.org Review URL: https://codereview.chromium.org/1254723004 Cr-Commit-Position: refs/heads/master@{#29849}
-
ulan authored
This function will be used later instead of HasLowAllocationRate to decide how many pages to compact. BUG=chromium:502247 LOG=NO Review URL: https://codereview.chromium.org/1254603002 Cr-Commit-Position: refs/heads/master@{#29841}
-
- 23 Jul, 2015 2 commits
-
-
rmcilroy authored
Adds basic support for generation of interpreter bytecode handler code snippets. The InterpreterAssembler class exposes a set of low level, interpreter specific operations which can be used to build a Turbofan graph. The Interpreter class generates a bytecode handler snippet for each bytecode by assembling operations using an InterpreterAssembler. Currently only two simple bytecodes are supported: LoadLiteral0 and Return. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1239793002 Cr-Commit-Position: refs/heads/master@{#29814}
-
yangguo authored
The code is unmaintained and full of errors... but this CL wipes them all away. Nobody seems to use it anyways. R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1243213004 Cr-Commit-Position: refs/heads/master@{#29801}
-
- 22 Jul, 2015 1 commit
-
-
mstarzinger authored
This preserves the context-independent entry in an optimized code map across GCs when the code is considered young (i.e. less than 3 ages). Note that any context-dependent entry for the same code will still be flushed immediately when the respective context dies, hence context lifetime is not increased. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1252463002 Cr-Commit-Position: refs/heads/master@{#29790}
-
- 20 Jul, 2015 1 commit
-
-
mstarzinger authored
This enables --noflush-optimized-code-cache which allows preserving entries in the optimized code map accross GCs. This only applies to values being reachable through other paths. R=hpayer@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1217863006 Cr-Commit-Position: refs/heads/master@{#29755}
-
- 17 Jul, 2015 1 commit
-
-
ishell authored
Revert of Reland "Enable loads and stores to global vars through property cell shortcuts installed into paren… (patchset #1 id:1 of https://codereview.chromium.org/1237043006/) Reason for revert: chromium:510738, chromium:510911 Original issue's description: > Reland "Enable loads and stores to global vars through property cell shortcuts installed into parent script context." > > Committed: https://crrev.com/48584df5ed97e2cdec1b4900f783c47adc3a3d32 > Cr-Commit-Position: refs/heads/master@{#29670} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1238163002 Cr-Commit-Position: refs/heads/master@{#29729}
-
- 16 Jul, 2015 4 commits
-
-
adamk authored
BUG=v8:3887 LOG=y Review URL: https://codereview.chromium.org/1238693004 Cr-Commit-Position: refs/heads/master@{#29714}
-
adamk authored
The issue with spread arrays which caused us to turn it off was fixed in https://chromium.googlesource.com/v8/v8/+/24e98281 BUG=v8:3018 LOG=y Review URL: https://codereview.chromium.org/1239873002 Cr-Commit-Position: refs/heads/master@{#29713}
-
bbudge authored
This CL exposes the constructor function, defines type related information, and implements value type semantics. It also refactors test/mjsunit/samevalue.js to test SameValue and SameValueZero. TEST=test/mjsunit/harmony/simd.js, test/cctest/test-simd.cc LOG=Y BUG=v8:4124 Committed: https://crrev.com/e5ed3bee99807c502fa7d7a367ec401e16d3f773 Cr-Commit-Position: refs/heads/master@{#29689} Review URL: https://codereview.chromium.org/1219943002 Cr-Commit-Position: refs/heads/master@{#29712}
-
hablich authored
Revert of Expose SIMD.Float32x4 type to Javascript. (patchset #14 id:450001 of https://codereview.chromium.org/1219943002/) Reason for revert: Seems to brake the latest roll into Chromium: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/59796/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > Expose SIMD.Float32x4 type to Javascript. > This CL exposes the constructor function, defines type related > information, and implements value type semantics. > It also refactors test/mjsunit/samevalue.js to test SameValue and SameValueZero. > > TEST=test/mjsunit/harmony/simd.js, test/cctest/test-simd.cc > > LOG=Y > BUG=v8:4124 > > Committed: https://crrev.com/e5ed3bee99807c502fa7d7a367ec401e16d3f773 > Cr-Commit-Position: refs/heads/master@{#29689} TBR=rossberg@chromium.org,littledan@chromium.org,martyn.capewell@arm.com,bbudge@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Review URL: https://codereview.chromium.org/1241533004 Cr-Commit-Position: refs/heads/master@{#29701}
-
- 15 Jul, 2015 1 commit
-
-
bbudge authored
This CL exposes the constructor function, defines type related information, and implements value type semantics. It also refactors test/mjsunit/samevalue.js to test SameValue and SameValueZero. TEST=test/mjsunit/harmony/simd.js, test/cctest/test-simd.cc LOG=Y BUG=v8:4124 Review URL: https://codereview.chromium.org/1219943002 Cr-Commit-Position: refs/heads/master@{#29689}
-