- 22 Jun, 2018 7 commits
-
-
Sigurd Schneider authored
This CL adds the BUILTIN kind specific flag is_off_heap_trampoline to Code objects. Code objects hence know whether they are off-heap trampolines, and can decide whether they need to return the off-heap instruction start or not without looking at the builtin index and/or considering the existence of an embedded blob. Bug: v8:6666 Change-Id: I0fbc540a2624ed5fa8256b807299e2fe4b907dda Reviewed-on: https://chromium-review.googlesource.com/1109691 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#53956}
-
Georg Neis authored
This partially reverts commit bffe040e, which bypassed the cache globally. Now we bypass it only in Turbofan. R=jarin@chromium.org Bug: v8:7790, chromium:854976 Change-Id: I62a9904c06915f6f6e4a6b628dc3dcba5151bb87 Reviewed-on: https://chromium-review.googlesource.com/1109969Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53955}
-
Clemens Hammacher authored
This prologue is not needed any more now that we have the jump table. If optimized code exists, we will not even enter the Liftoff code any more, but instead jump to the optimized code right away. This also allows to remove the {WASM_CODE_TABLE_ENTRY} relocation info kind. R=mstarzinger@chromium.org Bug: v8:7758 Change-Id: I0449693d7434088fb264104fe59365d7ca2b74c6 Reviewed-on: https://chromium-review.googlesource.com/1110222Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53954}
-
Georg Neis authored
The dependency is unnecessary. Also add a DCHECK that effectively ensures that the instance size can't change. NOPRESUBMIT=true Bug: v8:7790 Change-Id: Ib68ed044f2f87a0b8b83f4110756f3d3ad96c530 Reviewed-on: https://chromium-review.googlesource.com/1110121 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#53953}
-
Yang Guo authored
TBR=machenbach@chromium.org Bug: v8:7877 Change-Id: Id890681e70cea8beef89ea2df2578255906fb7f6 Reviewed-on: https://chromium-review.googlesource.com/1110136 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53952}
-
Yang Guo authored
TBR=clemensh@chromium.org Bug: v8:7879 Change-Id: Ib8c394fc7696d1eaf831cbfd31e5aada26aa3a9b Reviewed-on: https://chromium-review.googlesource.com/1111698 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Yang Guo authored
TBR=binji@chromium.org Bug: v8:7876 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I95b1a674cb9852f9840e502ceffabbd6fcb689b7 Reviewed-on: https://chromium-review.googlesource.com/1111697Reviewed-by:
-
- 21 Jun, 2018 33 commits
-
-
Eric Holk authored
This change adds an addition 2GiB of guard region in front of guarded WebAssembly memories. This provides defense in depth against code generation errors, such as accidental sign extension of a 32-bit value. As we consider supporting 4GiB WebAssembly memories, this is an important line of defense. Change-Id: Ica643c01ef28b5d2a01fbbd46273442545d8448e Reviewed-on: https://chromium-review.googlesource.com/1108503 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53949}
-
Junliang Yan authored
Port 0f5a0719 Original Commit Message: This CL reverts commit 38bec2ea and implements the same functionality via Assembler::RecordRelocInfo. R=sigurds@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I5a6d65bb2cc7cdaf1b982b3fb05cbb01b2099db2 Reviewed-on: https://chromium-review.googlesource.com/1110154Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#53948}
-
Bill Budge authored
- Handles zip, unzip, and transpose shuffles/swizzles. - Adds punpck* instructions to assembler. Bug: v8:6020 Change-Id: If124b7a7462ffd0470347b54ce4a93c01667e384 Reviewed-on: https://chromium-review.googlesource.com/1084069Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#53947}
-
Clemens Hammacher authored
This CL adds a builtin which receives an int32 argument and returns the int32 result. Internally, it checks whether the argument is in the valid smi range, then calls the runtime function with the smi argument and converts the return value back from smi to int32. This saves a lot of code in the wasm TF builder and in Liftoff. R=mstarzinger@chromium.org Bug: v8:6600 Change-Id: Icddcb020eae74c767a75090feb4939275432c007 Reviewed-on: https://chromium-review.googlesource.com/1107711 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Dan Elphick authored
Pass Isolate directly into CallHandlerInfo methods so that calls to GetHeap can be removed. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: If28fbbd65530b01b69786c3e743754cff3b1ba3a Reviewed-on: https://chromium-review.googlesource.com/1107926Reviewed-by:
-
Leszek Swirski authored
Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic00953a5375f60b61a093234c03ce0df41dbe228 Reviewed-on: https://chromium-review.googlesource.com/1110125Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#53944}
-
Tobias Tebbi authored
This removes error messages about missing _True labels, and instead tries find overloads for the branch protocol and a normal function call at the same time. The branch protocol is only considered if there are _True and _False in the context and the overload returns never. In addition, it prints all macro names of operator overloads if none was matching. Bug: v8:7793 Change-Id: Id81712f5b7f2af6765e23bb1f37438f141a79316 Reviewed-on: https://chromium-review.googlesource.com/1109839Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53943}
-
Yang Guo authored
TBR=binji@chromium.org Bug: v8:7876 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ic98cb9a8f54980e563b765356adfd2653965ff9a Reviewed-on: https://chromium-review.googlesource.com/1110135Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Ib8725fb5d7cd6909c522e3dca015e192a3dc6b01 Reviewed-on: https://chromium-review.googlesource.com/1110124Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#53941}
-
Yang Guo authored
TBR=clemensh@chromium.org Bug: v8:7872 Change-Id: I1f61e1ec7ffd86c7e8f74821fa0c4cd59bef57b2 Reviewed-on: https://chromium-review.googlesource.com/1110134Reviewed-by:
-
Georg Neis authored
Also add a DCHECK to a branch that can only be taken for the null prototype. R=sigurds@chromium.org Change-Id: Ib94fe8f25ecfd1a4baa576915e6edfa60bcd771b Reviewed-on: https://chromium-review.googlesource.com/1109961 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: Ica0f7417a0d695900fa0578cd1248499ffa55f08 Reviewed-on: https://chromium-review.googlesource.com/1109965 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
-
Yang Guo authored
This reverts commit 18d0d7f6. Reason for revert: Tentative revert. This has somehow broken the custom snapshot build https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/19822 Original change's description: > Ship Symbol.prototype.description > > Intent to ship: > https://groups.google.com/forum/#!msg/v8-users/9U2kEQw8pb8/Sn91yUx5BQAJ > > Bug: v8:7807 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Ia9e73495b08b432371dfb0ccc571af969ae4d59f > Reviewed-on: https://chromium-review.googlesource.com/1107210 > Commit-Queue: Joyee Cheung <joyee@igalia.com> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53933} TBR=kozyatinskiy@chromium.org,gsathya@chromium.org,luoe@chromium.org,joyee@igalia.com Change-Id: I28835d35d594ed8e14d824627e6aadb0360618f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7807 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1110237Reviewed-by:
-
Alexey Kozyatinskiy authored
After this CL all liveedit tests call the same LiveEdit::PatchScript method. This method will be updated later. As well some new liveedit cctests added, unfortunately part of them do not work with current implementation. R=dgozman@chromium.org,yangguo@chromium.org Bug: v8:7862 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3521af12b0f95b39d13aaafb1d1cf60f3f642a97 Reviewed-on: https://chromium-review.googlesource.com/1108382 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#53936}
-
Georg Neis authored
R=sigurds@chromium.org Change-Id: I0478c38641cfba6ccbe5ffd0ba6e50d1040e6e58 Reviewed-on: https://chromium-review.googlesource.com/1109836Reviewed-by:
-
Mathias Bynens authored
Bug: v8:6890, v8:7825, v8:7834, v8:7874 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Idc5e532977e2309de55a27ea6513301389b3a525 Reviewed-on: https://chromium-review.googlesource.com/1110120Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#53934}
-
Joyee Cheung authored
Intent to ship: https://groups.google.com/forum/#!msg/v8-users/9U2kEQw8pb8/Sn91yUx5BQAJ Bug: v8:7807 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia9e73495b08b432371dfb0ccc571af969ae4d59f Reviewed-on: https://chromium-review.googlesource.com/1107210 Commit-Queue: Joyee Cheung <joyee@igalia.com> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#53933}
-
Dan Elphick authored
Pipe through Isolate into several elements.cc functions, to avoid using HeapObject::GetIsolate. In some cases, uses ReadOnlyObject::GetIsolate which is allowed. (Autogenerated using Leszek's clang-bubble-getisolate) Bug: v8:7786 Change-Id: Idcbfaadf95c3c2b96d03b606da5594774bac2f7e Reviewed-on: https://chromium-review.googlesource.com/1107706Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: If9cf209b26978ad11dc2cf9c01b92c40bcba1a49 Reviewed-on: https://chromium-review.googlesource.com/1109826 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Peter Marshall authored
Each local ABT is logically for one page. We passed the space in to the constructor, but this is wrong because the space a page is in can change, e.g. for compaction pages. Instead, pass the page to the local ABT constructor and always get the space from this. To do this we need to push the AllocateLocalTracker() helper and friends down to Page, rather than its superclass MemoryChunk. Unfortunately, we need to keep ReleaseLocalTracker() on MemoryChunk even though only Pages can have local trackers, because we can't do virtual dispatch on MemoryChunk::ReleaseAllocatedMemory() which would allow us to clean up the tracker memory nicely for pages only. We also have to make sure we update external bytes accounting properly when swapping spaces, as in SemiSpace::Swap(). Change-Id: Iff02e41dd12a6b04a57fcc32f9e2b4f049fcbc24 Reviewed-on: https://chromium-review.googlesource.com/1107635 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The name {CallerOwnedBuffer} does not make sense in all situations, especially if such an object is returned instead of being passed as argument. I am working on moving the wasm wire bytes off the JS heap, and hence will return unowned references via the API. To prepare this change, I deprecate the existing {CallerOwnedBuffer} and introduce a new {BufferReference} struct with proper field names. R=titzer@chromium.org, adamk@chromium.org Bug: v8:7868 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic8953951447038a831b15a336a52a199bfbeafd5 Reviewed-on: https://chromium-review.googlesource.com/1108207Reviewed-by: -
Toon Verwaest authored
Change-Id: I142735622cb741fa8d84ec1036febb720a467363 Reviewed-on: https://chromium-review.googlesource.com/1109918Reviewed-by:
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754 Change-Id: I6f86d8d835009d864ba059055ee5bade4a52ab2e Reviewed-on: https://chromium-review.googlesource.com/1109917Reviewed-by:
-
Clemens Hammacher authored
Other fuzzers already have this ability. This CL adds it to the fuzzer. The input has to be valid bytes, otherwise we cannot generate the text representation. R=titzer@chromium.org CC=gdeepti@chromium.org Change-Id: If1ba8accc707bee3b042e93f4201949f0233c90e Reviewed-on: https://chromium-review.googlesource.com/1109794 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
This completes the transition to Assembler::Options, which reduces the assemblers's dependency on isolates, and there is now only one way to create an Assembler, which is to use the options. Note that some operations on assemblers still need an isolate, such as GetCode(), and in these cases, the isolate is an additional argument to the method. R=jgruber@chromium.org CC=mstarzinger@chromium.org Change-Id: I413209d816c63a7c3640f1c226764693dcad1e7f Reviewed-on: https://chromium-review.googlesource.com/1106169 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Toon Verwaest authored
[unibrow] -1 used by kNoPreviousCharacter and kEndOfInput isn't a valid Lead/Trail char. Drop superfluous check. Change-Id: Ie6b8e61230e25ab0321d0672d71f64fd593714bf Reviewed-on: https://chromium-review.googlesource.com/1109829 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#53924}
-
Peter Marshall authored
For bounds accesses, we definitely want to see these dchecks fire in all configurations. Change-Id: I54516794e32aaf0b00a2b1d88ffaf449f5a20b7b Reviewed-on: https://chromium-review.googlesource.com/1109835 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
For consistency with the existing Validate/Complete methodology. Drive-by: Use it in {PrintRawWasmCode}. R=titzer@chromium.org Bug: v8:7754 Change-Id: I6f08ad7456ded2bdb9b06bb9f288e2609d4010e7 Reviewed-on: https://chromium-review.googlesource.com/1109793Reviewed-by: -
Peter Marshall authored
Change-Id: If133fe47a086ed273446ee7e8f8af85bf9fc8389 Reviewed-on: https://chromium-review.googlesource.com/1108203 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I98ac4de406630c14280927240e9471049af3e790 Reviewed-on: https://chromium-review.googlesource.com/1108118Reviewed-by:
-
Clemens Hammacher authored
This is a reland of c2f1090d, fixing jumbo builds. Original change's description: > [wasm] Move serialization tests to own file > > Move out all serialization related tests to > {test-wasm-serialization.cc}, to reduce the size of > {test-run-wasm-module.cc}. > > R=titzer@chromium.org > > Bug: v8:7754 > Change-Id: I0b2133baf69e2557df27d1733cc267d1d4cf7452 > Reviewed-on: https://chromium-review.googlesource.com/1107980 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53909} TBR=titzer@chromium.org Bug: v8:7754 Change-Id: Ic0bb02b1b782676c6100daa2d588adce8b54c388 Reviewed-on: https://chromium-review.googlesource.com/1109838Reviewed-by:
-
Rodrigo Bruno authored
Bug: chromium:852748 Change-Id: Iac1c52d45e84af190415aeae5df167ab501b4bc4 Reviewed-on: https://chromium-review.googlesource.com/1109821Reviewed-by:
-
Simon Zünd authored
All other sorting benchmarks use arrays of roughly the same length. This CL adds a set of benchmarks that sort arrays of various lengths. Two data configurations are used for each length: Completely random and already sorted. R=jgruber@chromium.org Bug: v8:7382 Change-Id: Ib80a3421a68029c8e4f823605bab7b2d7fe1ae34 Reviewed-on: https://chromium-review.googlesource.com/1109509 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
