- 22 Mar, 2019 1 commit
-
-
Nico Weber authored
Remove a special case on mac hosts that was needed when is_clang wasn't the default on Win, but is unnecessary now and gets in the way. Bug: chromium:801780,chromium:495204 Change-Id: I8d6783c73e0c240704830a46304482e3ce94418b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1534634Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60415}
-
- 24 Oct, 2018 1 commit
-
-
Tom Tan authored
This is a reland of fcbb023b Original change's description: > Add Windows ARM64 ABI support to V8 > > This change added Windows ARM64 ABI support, major things are: > 1. Excluding x18 register from any usage because it is reserved as > platform register. Preserve alignment after the change. > 2. Fix the assumption of LP64 in arm64 backend. Windows ARM64 is > still LLP64. > 3. Stack guard page probe for large allocation on stack. > > Reference: > Windows ARM64 ABI: > https://docs.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=vs-2017 > > Bug: chromium:893460 > Change-Id: I325884ac8dab719154a0047141e18a9fcb8dff7e > Reviewed-on: https://chromium-review.googlesource.com/c/1285129 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56881} CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_arm64_dbg_recipe TBR=mlippautz@chromium.org Bug: chromium:893460 Change-Id: Icc45fd091c33f7df805842a70236b79b14756f52 Reviewed-on: https://chromium-review.googlesource.com/c/1297300 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56965}
-
- 23 Oct, 2018 2 commits
-
-
Michael Hablich authored
This reverts commit fcbb023b. Reason for revert: blocks roll https://chromium-review.googlesource.com/c/chromium/src/+/1296315 Original change's description: > Add Windows ARM64 ABI support to V8 > > This change added Windows ARM64 ABI support, major things are: > 1. Excluding x18 register from any usage because it is reserved as > platform register. Preserve alignment after the change. > 2. Fix the assumption of LP64 in arm64 backend. Windows ARM64 is > still LLP64. > 3. Stack guard page probe for large allocation on stack. > > Reference: > Windows ARM64 ABI: > https://docs.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=vs-2017 > > Bug: chromium:893460 > Change-Id: I325884ac8dab719154a0047141e18a9fcb8dff7e > Reviewed-on: https://chromium-review.googlesource.com/c/1285129 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56881} TBR=bbudge@chromium.org,ulan@chromium.org,machenbach@chromium.org,hpayer@chromium.org,brucedawson@chromium.org,mlippautz@chromium.org,ahaas@chromium.org,bmeurer@chromium.org,Tom.Tan@microsoft.com Change-Id: I0b804af6dfca9409a655194fa6e5407f209be2dc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:893460 Reviewed-on: https://chromium-review.googlesource.com/c/1296460Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#56912}
-
Tom Tan authored
This change added Windows ARM64 ABI support, major things are: 1. Excluding x18 register from any usage because it is reserved as platform register. Preserve alignment after the change. 2. Fix the assumption of LP64 in arm64 backend. Windows ARM64 is still LLP64. 3. Stack guard page probe for large allocation on stack. Reference: Windows ARM64 ABI: https://docs.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=vs-2017 Bug: chromium:893460 Change-Id: I325884ac8dab719154a0047141e18a9fcb8dff7e Reviewed-on: https://chromium-review.googlesource.com/c/1285129 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#56881}
-
- 24 Nov, 2017 1 commit
-
-
Ivica Bogosavljevic authored
It is not possible to simulate big-endian systems on X64/X86, so snapshots must be generated natively or using an emulator such as qemu. Bug: Change-Id: Ib7ea6fe27ea5da19f270251f18fbc5f1c43413ce Reviewed-on: https://chromium-review.googlesource.com/771673 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#49621}
-
- 02 Jun, 2017 1 commit
-
-
sreten.kovacevic authored
Chromium_BUG=616017 R=machenbach@chromium.org, dpranke@chromium.org, ivica.bogosavljevic@imgtec.com Review-Url: https://codereview.chromium.org/2913353004 Cr-Commit-Position: refs/heads/master@{#45691}
-
- 23 Aug, 2016 1 commit
-
-
slan authored
Non-CrOS builds should use clang for snapshot_toolchain, even on builds which use gcc for the target device. Change the default value for snapshot_toolchain to always use clang, except on ChromeOS gcc builds. In practice, every platform except ChromeOS always uses clang, so this should not affect any platform except non-CrOS gcc builds (like Cast) BUG= internal b/30873074 Review-Url: https://codereview.chromium.org/2265983002 Cr-Commit-Position: refs/heads/master@{#38825}
-
- 25 Jul, 2016 1 commit
-
-
dpranke authored
The third attempt never landed :). This attempt completely reworks the logic to attempt to be clearer and more obviously correct. This attempt also actually had unit tests written for it (see bug 625353). R=machenbach@chromium.org BUG=625353, 629825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_compile_x86_dbg,android_compile_mips_dbg,android_arm64_dbg_recipe Review-Url: https://codereview.chromium.org/2173343002 Cr-Commit-Position: refs/heads/master@{#37999}
-
- 22 Jul, 2016 2 commits
-
-
vogelheim authored
Revert of Re-land "Fix double-building of v8 in GN builds" (patchset #2 id:20001 of https://codereview.chromium.org/2171083003/ ) Reason for revert: Reverted, because it breaks some funky android build. Can reproduce breakage locally, w/ args.gn as follows: disable_brotli_filter = true disable_file_support = true disable_ftp_support = true enable_websockets = false ffmpeg_branding = "Chrome" is_component_build = false is_debug = true proprietary_codecs = true symbol_level = 1 target_cpu = "x86" target_os = "android" use_goma = true use_platform_icu_alternatives = true This ends up building the mkpeephole tool w/ an architecture that won't run on the build machine. Original issue's description: > Re-land "Fix double-building of v8 in GN builds" > > This re-lands r37926 w/ the needed fix for cross-compiles; we > can only re-use the default toolchain when the host can actually > run it. > > R=machenbach@chromium.org > BUG=629825 > > Committed: https://crrev.com/5b762044b53f988fa9a534fe1a84f9938b3abd75 > Cr-Commit-Position: refs/heads/master@{#37970} TBR=machenbach@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=629825 Review-Url: https://codereview.chromium.org/2175693003 Cr-Commit-Position: refs/heads/master@{#37984}
-
dpranke authored
This re-lands r37926 w/ the needed fix for cross-compiles; we can only re-use the default toolchain when the host can actually run it. R=machenbach@chromium.org BUG=629825 Review-Url: https://codereview.chromium.org/2171083003 Cr-Commit-Position: refs/heads/master@{#37970}
-
- 21 Jul, 2016 3 commits
-
-
dpranke authored
I had written "mipsel64", not "mips64el". R=machenbach@chromium.org, milko.leporis@imgtec.com BUG=629057 Review-Url: https://codereview.chromium.org/2167873002 Cr-Commit-Position: refs/heads/master@{#37951}
-
machenbach authored
Revert of Fix double-building of v8 in GN builds when setting just v8_target_cpu. (patchset #1 id:1 of https://codereview.chromium.org/2166173002/ ) Reason for revert: Breaks: https://build.chromium.org/p/client.v8.fyi/builders/V8%20Android%20GN%20%28dbg%29/builds/4590 And also the trybot: https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/99806 Original issue's description: > Fix double-building of v8 in GN builds when setting just v8_target_cpu. > > Because of the somewhat strange way default toolchains and custom > toolchains and user-specified arguments work in GN, if you did a v8 > build that just set v8_target_cpu, you could end up building two > identical copies of v8 (see the comments in the change for more). > > This CL identifies that case and fixes it. > > R=machenbach@chromium.org > BUG=629825 > > Committed: https://crrev.com/3536db45c9409c9aadc4eee6004cf337c0588cdb > Cr-Commit-Position: refs/heads/master@{#37926} TBR=dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=629825 Review-Url: https://codereview.chromium.org/2167113002 Cr-Commit-Position: refs/heads/master@{#37936}
-
dpranke authored
Because of the somewhat strange way default toolchains and custom toolchains and user-specified arguments work in GN, if you did a v8 build that just set v8_target_cpu, you could end up building two identical copies of v8 (see the comments in the change for more). This CL identifies that case and fixes it. R=machenbach@chromium.org BUG=629825 Review-Url: https://codereview.chromium.org/2166173002 Cr-Commit-Position: refs/heads/master@{#37926}
-
- 15 Jul, 2016 1 commit
-
-
dpranke authored
This change makes the architecture that we target generated v8 code for a property of the current toolchain, rather than a global setting that applies to every toolchain. This will allow us to properly build two snapshots for two different architectures in a single build, which is needed for android webview/monochrome builds. R=brettw@chromium.org, jochen@chromium.org, michaelbai@chromium.org BUG=625383 Review-Url: https://codereview.chromium.org/2116913002 Cr-Commit-Position: refs/heads/master@{#37805}
-
- 20 May, 2016 1 commit
-
-
dpranke authored
This patch re-lands #36341 with another fix to make the amd64-generic build work as well. R=machenbach@chromium.org, hablich@chromium.org, adamk@chromium.org BUG=608596, 595653 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng,chromeos_amd64-generic_chromium_compile_only_ng,chromeos_x86-generic_chromium_compile_only_ng,linux_chromium_gn_chromeos_rel,linux_chromium_gn_chromeos_dbg Review-Url: https://codereview.chromium.org/1996513005 Cr-Commit-Position: refs/heads/master@{#36390}
-
- 19 May, 2016 2 commits
-
-
machenbach authored
Revert of Reland changes to v8_snapshot GN build arg. (patchset #2 id:20001 of https://codereview.chromium.org/1979883002/ ) Reason for revert: Blocks the roll again: https://codereview.chromium.org/1993163002/ https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/140169 Lets add chromeos_amd64-generic_chromium_compile_only_ng on a reland as well. Original issue's description: > Reland changes to v8_snapshot GN build arg. > > This patch re-lands #36193 with a couple of minor tweaks > including updating the BUILD.gn file to use the new > variable name and incorporating thakis' request to support > cross-compiling the win snapshot from a mac. > > R=thakis@chromium.org, jochen@chromium.org, machenbach@chromium.org > BUG=608596, 595653 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng > > Committed: https://crrev.com/b6168e1223d266dba1a357a921bc84ae97a1d803 > Cr-Commit-Position: refs/heads/master@{#36342} TBR=jochen@chromium.org,thakis@chromium.org,stevenjb@chromium.org,adamk@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608596, 595653 Review-Url: https://codereview.chromium.org/1996533002 Cr-Commit-Position: refs/heads/master@{#36347}
-
dpranke authored
This patch re-lands #36193 with a couple of minor tweaks including updating the BUILD.gn file to use the new variable name and incorporating thakis' request to support cross-compiling the win snapshot from a mac. R=thakis@chromium.org, jochen@chromium.org, machenbach@chromium.org BUG=608596, 595653 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:chromeos_daisy_chromium_compile_only_ng Review-Url: https://codereview.chromium.org/1979883002 Cr-Commit-Position: refs/heads/master@{#36342}
-
- 12 May, 2016 2 commits
-
-
machenbach authored
Revert of Change v8_snapshot_toolchain to be a GN build arg. (patchset #3 id:40001 of https://codereview.chromium.org/1969693002/ ) Reason for revert: Blocks the roll: https://codereview.chromium.org/1974733002/ Breaks: https://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/136166 Original issue's description: > Change v8_snapshot_toolchain to be a GN build arg. > > It is likely that CrOS and other distros will want to be > able to build the v8 snapshot with a custom toolchain. > > This CL makes snapshot_toolchain a declared build arg, and > renames it to v8_snapshot_toolchain to minimize the risk > of a name collision. > > R=machenbach@chromium.org, jochen@chromium.org > BUG=608596 > > Committed: https://crrev.com/2ae74af8f405f461d8e44d60b978f940673e46c8 > Cr-Commit-Position: refs/heads/master@{#36193} TBR=jochen@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=608596 Review-Url: https://codereview.chromium.org/1975713002 Cr-Commit-Position: refs/heads/master@{#36199}
-
dpranke authored
It is likely that CrOS and other distros will want to be able to build the v8 snapshot with a custom toolchain. This CL makes snapshot_toolchain a declared build arg, and renames it to v8_snapshot_toolchain to minimize the risk of a name collision. R=machenbach@chromium.org, jochen@chromium.org BUG=608596 Review-Url: https://codereview.chromium.org/1969693002 Cr-Commit-Position: refs/heads/master@{#36193}
-
- 11 Apr, 2016 1 commit
-
-
hablich authored
Revert of Use GCC for snapshot_toolchain when is_clang=false. (patchset #1 id:1 of https://codereview.chromium.org/1809643003/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/1874173002/ Original issue's description: > Use GCC for snapshot_toolchain when is_clang=false. > > Currently, snapshot_toolchain is hardcoded to use a clang host > toolchain. Use a GCC toolchain if is_clang is false. > > Revert this when this is root-caused (see crbug.com/601486) > > LOG=Y > BUG=601486 > > Committed: https://crrev.com/920370d1a910681bf464bd91aced316058ea2f6c > Cr-Commit-Position: refs/heads/master@{#35341} TBR=jochen@chromium.org,alokp@chromium.org,dpranke@chromium.org,slan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=601486 LOG=Y Review URL: https://codereview.chromium.org/1873113002 Cr-Commit-Position: refs/heads/master@{#35372}
-
- 07 Apr, 2016 1 commit
-
-
slan authored
Currently, snapshot_toolchain is hardcoded to use a clang host toolchain. Use a GCC toolchain if is_clang is false. Revert this when this is root-caused (see crbug.com/601486) LOG=Y BUG=601486 Review URL: https://codereview.chromium.org/1809643003 Cr-Commit-Position: refs/heads/master@{#35341}
-
- 16 Dec, 2015 1 commit
-
-
agrieve authored
BUG=chromium:568883 LOG=n Review URL: https://codereview.chromium.org/1517983002 Cr-Commit-Position: refs/heads/master@{#32907}
-
- 22 Sep, 2015 1 commit
-
-
dpranke authored
We need to build parts of v8 with a toolchain that might be different from both the default (target) toolchain and the regular host toolchain, because we need the snapshot to have the same bit-width as the target. V8's build defines a 'snapshot_toolchain' setting for this. It turns out that we need the value of this toolchain to be exposed to the Chromium build because some of the test targets (in browser_tests) depend on d8 and need to be able to built using the same toolchain. R=brett@chromium.org, jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1350223004 Cr-Commit-Position: refs/heads/master@{#30854}
-
- 31 Jul, 2015 1 commit
-
-
yangguo authored
R=cbruni@chromium.org Review URL: https://codereview.chromium.org/1265923002 Cr-Commit-Position: refs/heads/master@{#29951}
-
- 30 Jun, 2015 1 commit
-
-
hablich authored
R=machenbach@chromium.org BUG=v8:4135 NOTRY=true LOG=N Review URL: https://codereview.chromium.org/1217993002 Cr-Commit-Position: refs/heads/master@{#29375}
-
- 26 May, 2015 1 commit
-
-
hablich authored
BUG= NOTRY=true Review URL: https://codereview.chromium.org/1157993003 Cr-Commit-Position: refs/heads/master@{#28627}
-
- 07 Apr, 2015 1 commit
-
-
yangguo authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1060683003 Cr-Commit-Position: refs/heads/master@{#27629}
-
- 10 Oct, 2013 1 commit
-
-
jkummerow@chromium.org authored
See https://groups.google.com/d/msg/v8-users/jq8k9s4xEu8/N-es0or3uz4J BUG=none R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/26574009 Patch from Paweł Hajdan Jr. <phajdan.jr@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17134 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Aug, 2013 1 commit
-
-
mstarzinger@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/21771002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16022 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Aug, 2013 2 commits
-
-
jochen@chromium.org authored
It's now available via builtins. BUG=v8:2475 R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/21512002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16016 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/21511002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16013 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Jul, 2013 1 commit
-
-
jochen@chromium.org authored
BUG=v8:2745 R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18687003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15584 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Jun, 2013 1 commit
-
-
machenbach@chromium.org authored
Duration for each is between 14 s and 160 s. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18034017 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15374 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Jun, 2013 1 commit
-
-
machenbach@chromium.org authored
This initial CL contains the new test suite code and two tests for demonstration. Other tests will follow in a separate CL. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/17260002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15339 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Sep, 2012 1 commit
-
-
jkummerow@chromium.org authored
Review URL: https://codereview.chromium.org/10919265 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12583 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Oct, 2008 1 commit
-
-
sgjesse@chromium.org authored
report the exception when they happen in the try block and not as previously when re-thrown after execution of the finally block. There is no longer any message generated by re-throw. Added test cases for various combinations of try/catch/finally with throw in different places. Added a regression directory to the messages tests which is processed by the test runner. Added regression tests for the specific bugs fixed. Runs all the test suites. BUG=73 BUG=75 Review URL: http://codereview.chromium.org/8050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@565 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Sep, 2008 1 commit
-
-
christian.plesner.hansen@gmail.com authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@386 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Sep, 2008 1 commit
-
-
christian.plesner.hansen@gmail.com authored
Added presubmit step to check copyright. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Aug, 2008 1 commit
-
-
christian.plesner.hansen authored
In the shell sample don't print the result of executing a script, only evaluating expressions. Fixed issue when building samples on Windows using a shared V8 library. Added visibility option on Linux build which makes the generated library 18% smaller. Changed build system to accept multiple build modes in one build and generate seperate objects, libraries and executables for each mode. Removed deferred negation optimization (a * -b => -(a * b)) since this visibly changes operand conversion order. Improved parsing performance by introducing stack guard in preparsing. Without a stack guard preparsing always bails out with stack overflow. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jul, 2008 1 commit
-
-
christian.plesner.hansen authored
git-svn-id: http://v8.googlecode.com/svn/trunk@2 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-