1. 09 Mar, 2018 1 commit
  2. 06 Mar, 2018 1 commit
  3. 02 Feb, 2018 1 commit
  4. 06 Oct, 2017 1 commit
  5. 02 Aug, 2017 1 commit
    • Alexey Kozyatinskiy's avatar
      [inspector] move breakpoint management to native · cd9e86a5
      Alexey Kozyatinskiy authored
      My goal was to move breakpoint API to native with minimal changes around, so on inspector side we use v8::debug::BreakpointId instead of String16, on v8::internal::Debug we use i::BreakPoint object instead of break point object created inside of debug.js.
      
      There are a lot of opportunities how we can improve breakpoints (at least we can avoid some of linear lookups to speedup implementation) but I think that as first step we need to remove mirrors/debug.js APIs.
      
      Drive by: debugger-script.js and usage of debugger context in inspector code base.
      
      R=yangguo@chromium.org,jgruber@chromium.org,clemensh@chromium.org
      
      Bug: v8:5510,chromium:652939
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I0b17972c39053dd4989bbe26db2bb0b88ca378f7
      Reviewed-on: https://chromium-review.googlesource.com/593156Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47091}
      cd9e86a5
  6. 28 Jul, 2017 1 commit
    • Alexey Kozyatinskiy's avatar
      [inspector] move SetScriptSource call to native · 6b0bf165
      Alexey Kozyatinskiy authored
      To avoid using debugging context and debugger-script.js on inspector side we can move SetScriptSource call to v8::internal::Debug. Theoretically we can move live edit implementation to native completely but since it will be reimplemented it looks redundant.
      
      R=yangguo@chromium.org,jgruber@chromium.org
      
      Bug: chromium:652939
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: Id09492c2d2a93efbde429c9cc1bc181d5fdda19b
      Reviewed-on: https://chromium-review.googlesource.com/590736
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46985}
      6b0bf165
  7. 06 Mar, 2017 1 commit
  8. 28 Feb, 2017 1 commit
  9. 27 Feb, 2017 1 commit
  10. 03 Feb, 2017 1 commit
  11. 27 Jan, 2017 1 commit
    • clemensh's avatar
      [inspector] Expose GetPossibleBreakpoints for wasm · c6663ef1
      clemensh authored
      and add an inspector test for it. Also test that a breakpoint can be
      set on each reported position, and that it is also hit during
      execution.
      This CL also fixes two little things which were uncovered by the new
      test.
      
      R=yangguo@chromium.org, titzer@chromium.org, kozyatinskiy@chromium.org
      BUG=v8:5822
      
      Review-Url: https://codereview.chromium.org/2655653003
      Cr-Commit-Position: refs/heads/master@{#42722}
      c6663ef1
  12. 24 Jan, 2017 1 commit
    • kozyatinskiy's avatar
      [inspector] implemented blackboxing inside v8 · ac50c79a
      kozyatinskiy authored
      V8 has internal mechanism to ignore steps and breaks inside internal scripts, in this CL it's reused for blackboxing implementation.
      Advantages:
      - much faster blackboxing implementation (before we at least wrap and collect current call stack for each step),
      - get rid of StepFrame action and potential pause in blackboxed code after N StepFrame steps,
      - simplification of debugger agent logic.
      Disadvtanges:
      - currently when user was paused in blackboxed code (e.g. on breakpoint) and then makes step action, debugger ignores blackboxed state of the script and allows to use step actions as usual - this behavior is regressed, we still able to support it on frontend side.
      
      Current state and proposed changes for blackboxing: https://docs.google.com/document/d/1hnzaXPAN8_QC5ENxIgxgMNDbXLraM_OXT73rAyijTF8/edit?usp=sharing
      
      BUG=v8:5842
      R=yangguo@chromium.org,dgozman@chromium.org,alph@chromium.org
      
      Review-Url: https://codereview.chromium.org/2633803002
      Cr-Commit-Position: refs/heads/master@{#42614}
      ac50c79a
  13. 12 Dec, 2016 1 commit
  14. 06 Dec, 2016 1 commit
    • clemensh's avatar
      [inspector] Split V8DebuggerScript implementation for wasm · a9017cb0
      clemensh authored
      Make some methods on V8DebuggerScript virtual and provide the
      implementations ActualScript for scripts which are backed by scripts on
      V8's side, and WasmVirtualScript for wasm scripts.
      
      The added test case ensures that we at least don't crash on the attempt
      to get breakable locations for wasm "scripts", which we did previously.
      Returning a reasonable result for wasm will be implemented in a
      follow-up commit.
      
      R=yangguo@chromium.org, jgruber@chromium.org
      BUG=chromium:667767,chromium:613110
      
      Review-Url: https://codereview.chromium.org/2532433003
      Cr-Commit-Position: refs/heads/master@{#41527}
      a9017cb0
  15. 05 Dec, 2016 2 commits
    • clemensh's avatar
      [debug] Remove DebugInterface class · e6bd3063
      clemensh authored
      It only contained type definitions and static functions, so we
      can also just make it a namespace.
      
      R=kozyatinskiy@chromium.org, yangguo@chromium.org
      
      Review-Url: https://codereview.chromium.org/2549133002
      Cr-Commit-Position: refs/heads/master@{#41501}
      e6bd3063
    • clemensh's avatar
      [inspector] Split off interface-types.h · f5fb2da6
      clemensh authored
      This CL adds a new header src/debug/interface-types.h, moves the
      definition of Location from the debug-interface.h to this new header,
      and adds a new definition for the WasmDisassembly types.
      This allows to use the types in other implementation files or headers
      without having to include the entire debug-interface.h, reducing build
      dependencies and compile time (especially for incremental builds).
      
      The WasmDisassembly type replaces the old
      std::pair<std::string, std::vector<std::tuple<...>>>, which was a bit
      hard to unravel.
      
      R=yangguo@chromium.org, kozyatinskiy@chromium.org, titzer@chromium.org
      
      Review-Url: https://codereview.chromium.org/2529383002
      Cr-Commit-Position: refs/heads/master@{#41488}
      f5fb2da6
  16. 16 Nov, 2016 1 commit
    • clemensh's avatar
      [inspector] Introduce translation of wasm frames · d4a42a5f
      clemensh authored
      This allows to show wasm source (disassembled wasm code) in DevTools.
      See design doc for details.
      
      More tests for the disassembly will have to follow. Also, the text
      format (generated by V8) will be changed.
      
      BUG=chromium:659715
      R=yangguo@chromium.org, kozyatinskiy@chromium.org, titzer@chromium.org, dgozman@chromium.org
      
      Review-Url: https://codereview.chromium.org/2493773003
      Cr-Commit-Position: refs/heads/master@{#41055}
      d4a42a5f
  17. 04 Nov, 2016 1 commit
  18. 29 Oct, 2016 1 commit
  19. 26 Sep, 2016 1 commit
  20. 21 Sep, 2016 2 commits
  21. 19 Sep, 2016 1 commit
  22. 06 Sep, 2016 1 commit
  23. 01 Sep, 2016 1 commit
  24. 31 Aug, 2016 2 commits