- 27 Jul, 2016 1 commit
-
-
fmeawad authored
V8 has had a trace event macro interface for while, but without a tracing controller a standalone V8 would be unable to collect traces. This CL introduces a complete Tracing Controller system for V8. It is fully function except that it does not yet store trace event args. This CL has a few components, The tracing controller itself, contributed by the author of this CL The Trace config (including the parser), contributed by lpy@ The Trace Object, Trace Writer, and Trace Buffer are all contributed by rksang@ BUG=v8:4561 LOG=N The original CL was failing the V8 Arm Builder: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20builder/builds/2456 and the V8 Mips Builder: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/2506 The failure is due to undefined behavior of CHECK_EQ of 2 const char* Fix in patch #1 Committed: https://crrev.com/3d598452679ce208ad9b2f48e0fb3fae352ce375 Cr-Commit-Position: refs/heads/master@{#38073} patch from issue 2137013006 at patchset 200001 (http://crrev.com/2137013006#ps200001) Review-Url: https://codereview.chromium.org/2183923004 Cr-Commit-Position: refs/heads/master@{#38104}
-
- 26 Jul, 2016 2 commits
-
-
lpy authored
Revert of [Tracing] V8 Tracing Controller (patchset #11 id:200001 of https://codereview.chromium.org/2137013006/ ) Reason for revert: Revert this CL due to V8 Arm Builder failure and V8 Mips Builder failure. https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20builder/builds/2456 https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/2506 Original issue's description: > [Tracing] V8 Tracing Controller > > V8 has had a trace event macro interface for while, but without a tracing > controller a standalone V8 would be unable to collect traces. > > This CL introduces a complete Tracing Controller system for V8. > It is fully function except that it does not yet store trace event args. > > This CL has a few components, > The tracing controller itself, contributed by the author of this CL > The Trace config (including the parser), contributed by lpy@ > The Trace Object, Trace Writer, and Trace Buffer are all contributed by rksang@ > > BUG=v8:4561 > LOG=N > > Committed: https://crrev.com/3d598452679ce208ad9b2f48e0fb3fae352ce375 > Cr-Commit-Position: refs/heads/master@{#38073} TBR=jochen@chromium.org,mattloring@google.com,rskang@google.com,yangguo@chromium.org,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4561 Review-Url: https://codereview.chromium.org/2183943002 Cr-Commit-Position: refs/heads/master@{#38074}
-
fmeawad authored
V8 has had a trace event macro interface for while, but without a tracing controller a standalone V8 would be unable to collect traces. This CL introduces a complete Tracing Controller system for V8. It is fully function except that it does not yet store trace event args. This CL has a few components, The tracing controller itself, contributed by the author of this CL The Trace config (including the parser), contributed by lpy@ The Trace Object, Trace Writer, and Trace Buffer are all contributed by rksang@ BUG=v8:4561 LOG=N Review-Url: https://codereview.chromium.org/2137013006 Cr-Commit-Position: refs/heads/master@{#38073}
-
- 17 Mar, 2016 1 commit
-
-
mlippautz authored
This reverts commit 4857110c. This change was flushing out another issue which is fixed in https://codereview.chromium.org/1783283003/ BUG=v8:2999 LOG=N Review URL: https://codereview.chromium.org/1785933003 Cr-Commit-Position: refs/heads/master@{#34874}
-
- 11 Mar, 2016 2 commits
-
-
mlippautz authored
Revert of [platform] Change default platform max thread pool size 4 -> 8 (patchset #1 id:1 of https://codereview.chromium.org/1782833006/ ) Reason for revert: Seems to trigger bugs, needs investigation. Original issue's description: > [platform] Change default platform max thread pool size 4 -> 8 > > BUG= > > Committed: https://crrev.com/ddc0f9982057e76dd4dc35b6ca80d2322adc9141 > Cr-Commit-Position: refs/heads/master@{#34711} TBR=hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1780353003 Cr-Commit-Position: refs/heads/master@{#34714}
-
mlippautz authored
BUG= Review URL: https://codereview.chromium.org/1782833006 Cr-Commit-Position: refs/heads/master@{#34711}
-
- 01 Mar, 2016 1 commit
-
-
fmeawad authored
This should land after the chromium CL that starts using the new AddTraceEvent lands (https://codereview.chromium.org/1742603004/) BUG=4565 LOG=N Review URL: https://codereview.chromium.org/1744733002 Cr-Commit-Position: refs/heads/master@{#34412}
-
- 26 Feb, 2016 1 commit
-
-
fmeawad authored
This patch adds the newly added support for contexts in V8 Tracing, as well as use it to mark all the entry points for a V8 Isolate. Update for reland: The current tracing interface needs to be updated (AddTraceEvent), but the embedders need to migrate to the new version before removing the old version. (Reland of: https://codereview.chromium.org/1686233002) The revert happened because the 2 signatures of the old and new AddTraceEvent where different so it threw an overload-virtual error on cross arm debug. This issue is temporary, and to solve it, I added an implementation of the old and new everywhere until the embedder implements the new. BUG=v8:4565 LOG=N R=jochen@chromium.org Review URL: https://codereview.chromium.org/1704253002 Cr-Commit-Position: refs/heads/master@{#34332}
-
- 17 Feb, 2016 2 commits
-
-
machenbach authored
Revert of Add Scoped Context Info (Isolate) to V8 Traces (patchset #5 id:80001 of https://codereview.chromium.org/1686233002/ ) Reason for revert: [Sheriff] Breaks arm cross-compile: https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/7825/ Original issue's description: > Add Scoped Context Info (Isolate) to V8 Traces > > This patch adds the newly added support for contexts in V8 Tracing, as well > as use it to mark all the entry points for a V8 Isolate. > > BUG=v8:4565 > LOG=N > > Committed: https://crrev.com/44823c3c6965966c63b7e2e2361d0f2a58d196ea > Cr-Commit-Position: refs/heads/master@{#34092} TBR=jochen@chromium.org,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4565 Review URL: https://codereview.chromium.org/1710573002 Cr-Commit-Position: refs/heads/master@{#34095}
-
fmeawad authored
This patch adds the newly added support for contexts in V8 Tracing, as well as use it to mark all the entry points for a V8 Isolate. BUG=v8:4565 LOG=N Review URL: https://codereview.chromium.org/1686233002 Cr-Commit-Position: refs/heads/master@{#34092}
-
- 05 Feb, 2016 1 commit
-
-
mlippautz authored
The call can be used by the embedder to provide information on the workers executing background tasks. BUG=chromium:524425 LOG=N Review URL: https://codereview.chromium.org/1664203004 Cr-Commit-Position: refs/heads/master@{#33788}
-
- 17 Dec, 2015 1 commit
-
-
fmeawad authored
This is based on the Skia Implementation. More on the project can be found here: https://docs.google.com/a/chromium.org/document/d/1_4LAnInOB8tM_DLjptWiszRwa4qwiSsDzMkO4tU-Qes/edit#heading=h.p97rw6yt8o2j The V8 Tracing platform will replace the isolate->event_logger(). But since the current embedders (namely chromium) currently use the isolate->event_logger, I made the default implementation (event-tracer) call into isolate->event_logger if an event_logger was set. Once the embedders properly implement the interface (for example in chromium it would look like this: https://codereview.chromium.org/707273005/), the default implementation will be doing nothing. Once the embedders side is fixed, we will change how V8 uses the tracing framework beyond the call from Logger:CallEventLogger. (which would also include a d8 implementation) BUG=v8:4560 LOG=N Review URL: https://codereview.chromium.org/988893003 Cr-Commit-Position: refs/heads/master@{#32959}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 15 Jul, 2015 1 commit
-
-
ulan authored
BUG=chromium:490559 LOG=NO Review URL: https://codereview.chromium.org/1225713003 Cr-Commit-Position: refs/heads/master@{#29676}
-
- 02 Jul, 2015 2 commits
-
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/1222203003 Cr-Commit-Position: refs/heads/master@{#29458}
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/1221083004 Cr-Commit-Position: refs/heads/master@{#29446}
-
- 17 Jun, 2015 1 commit
-
-
ulan authored
Delayed tasks can be used to perform non-urgent clean up work. BUG=chromium:490559 LOG=NO Review URL: https://codereview.chromium.org/1179153002 Cr-Commit-Position: refs/heads/master@{#29084}
-
- 06 Oct, 2014 1 commit
-
-
rmcilroy@chromium.org authored
Adds a MonotonicallyIncreasingTime() function to the Platform API to enable the embedder to provide a time API to V8 which will be used for IdleNotification deadlines. BUG=417668 LOG=Y R=jochen@chromium.org Review URL: https://codereview.chromium.org/632663002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24411 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
Also fix several inconsistencies/bugs on the way. TEST=base-unittests R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/510693003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23435 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jul, 2014 2 commits
-
-
jochen@chromium.org authored
BUG=none LOG=n R=marja@chromium.org Review URL: https://codereview.chromium.org/363303002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
Also remove the "use default platform" compile flag. Instead, the embedder has to provide the platform. Change all binaries to use the default platfrom from libplatform. Unless --job-based-sweeping is passed, nothing uses the platform yet, so nothing will break for embedders (yet). BUG=none R=jkummerow@chromium.org LOG=y Review URL: https://codereview.chromium.org/345903004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22180 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Jul, 2014 1 commit
-
-
jochen@chromium.org authored
BUG=none R=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/336313017 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22107 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
Also split v8-core independent methods from checks.h to base/logging.h and merge v8checks with the rest of checks. The CPU::FlushICache method is moved to CpuFeatures::FlushICache RoundUp and related methods are moved to base/macros.h Remove all layering violations from src/libplatform BUG=none R=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/358363002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Jun, 2014 1 commit
-
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/333013002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21894 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 May, 2014 1 commit
-
-
jochen@chromium.org authored
It's really more an OS-level information, and this way the default platform doesn't depend on CPU-level details BUG=none R=yangguo@chromium.org LOG=n Review URL: https://codereview.chromium.org/300713002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21501 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Apr, 2014 3 commits
-
-
jochen@chromium.org authored
Don't use OS::MemCopy in BitCast. It's crucial that the compiler can optimize the memcpy away. > Platform includes utils.h for the definition of Vector<>, so utils.h > can't include platform.h and has to use memcpy instead of OS::MemCopy. > > We split out Vector<> into its own header to break this cycle > dependency. > > BUG=none > R=mstarzinger@chromium.org > LOG=n > > Review URL: https://codereview.chromium.org/251753002 TBR=jkummerow@chromium.org LOG=n BUG=none Review URL: https://codereview.chromium.org/252683004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20983 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
> Platform includes utils.h for the definition of Vector<>, so utils.h > can't include platform.h and has to use memcpy instead of OS::MemCopy. > > We split out Vector<> into its own header to break this cycle > dependency. > > BUG=none > R=mstarzinger@chromium.org > LOG=n > > Review URL: https://codereview.chromium.org/251753002 BUG=none LOG=n TBR=danno@chromium.org Review URL: https://codereview.chromium.org/254823002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20976 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
Platform includes utils.h for the definition of Vector<>, so utils.h can't include platform.h and has to use memcpy instead of OS::MemCopy. We split out Vector<> into its own header to break this cycle dependency. BUG=none R=mstarzinger@chromium.org LOG=n Review URL: https://codereview.chromium.org/251753002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20962 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Dec, 2013 3 commits
-
-
jochen@chromium.org authored
BUG=none LOG=n TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/107503005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18382 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
R=hpayer@chromium.org BUG=none LOG=n Review URL: https://codereview.chromium.org/98123004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18381 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
We don't use the worker pool yet, however, there are tests. Yay. The next step is to use the worker pool for parallel sweeping. I've also started to move the platform related files into a sub directory. The goal is to eventually build all the platform stuff as a separate library which is used by d8 and cctest (and other embedders that wish to use the default implementation) but not by chromium. BUG=v8:3015 R=hpayer@chromium.org, svenpanne@chromium.org LOG=n Review URL: https://codereview.chromium.org/104583003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18380 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Nov, 2013 1 commit
-
-
jochen@chromium.org authored
Over the initial commit, this CL moves the lifetime management of the default platform to v8.cc from api.cc R=bmeurer@chromium.org, svenpanne@chromium.org BUG=v8:3015 LOG=n Review URL: https://codereview.chromium.org/78453003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17970 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Oct, 2013 1 commit
-
-
danno@chromium.org authored
- Detect unreachable basic blocks of code either following an unconditional deopt or after a provably untaken branch of HBranch or HCompareObjectEqAndBranch instructions. - Emit dummy uses in unreachable blocks during Hydrogen -> Lithium translation. BUG=chromium:258519 R=jkummerow@chromium.org, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/22876009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17073 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Jul, 2013 1 commit
-
-
bmeurer@chromium.org authored
R=dslomov@chromium.org Review URL: https://codereview.chromium.org/18758003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15613 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Jul, 2013 1 commit
-
-
bmeurer@chromium.org authored
R=hpayer@chromium.org Review URL: https://codereview.chromium.org/18816002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15531 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 May, 2010 2 commits
-
-
floitschV8@gmail.com authored
Review URL: http://codereview.chromium.org/1956005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4596 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
floitschV8@gmail.com authored
Review URL: http://codereview.chromium.org/1968003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4592 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-