- 20 Jul, 2022 3 commits
-
-
Dominik Inführ authored
This CL re-structures the write barrier slow path in order to prepare for adding the shared write barrier. Behavior remains the same in this CL, only code structure changes a bit (e.g. the branch for when marking is off, got moved up to the IsMarking() check). Bug: v8:13018 Change-Id: I991f896abb88e0c85de3123fa67d8f47282f632d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3771840 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81836}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6e435d6..7aa2227 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I52abe292ba0ce456bb3603aa6a371e95a88bfe5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773882 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81835}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1240e97..0c6b8d6 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8168f76..9585c93 Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220713.3.1..version:9.20220719.2.1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Id79d384ce729cbd281e3ae0cebff6d2a141038e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773881 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81834}
-
- 19 Jul, 2022 37 commits
-
-
Michael Lippautz authored
We will provide a replacement for raw pointers in future which should only be used by backing stores. Any other callsite must go through Trace(BasicMember<>). Bug: v8:13089 Change-Id: Ibdae439b44ad94bd7af2532855be941c5334db99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3772328 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#81833}
-
Milad Fa authored
This CL fixes macro-asm to take in scratch registers as arguments. Change-Id: Ib6070c9a9df050ce201d36027a0be44c77a54ba3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773875 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#81832}
-
Michael Achenbach authored
This ports: https://crrev.com/c/3773795 Bug: chromium:1344570, chromium:1345621 Change-Id: Ie3f8019a259f66900ea6dda878040edec20d4f38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773777Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#81831}
-
Shu-yu Guo authored
Bug: v8:11460 Change-Id: Iec0b913e5b6dbe27eae3ee0ae207d8339336961d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3774094Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#81830}
-
Jakob Kummerow authored
This adds support for reading modules in hex or decimal "array literal" syntax, e.g. what --full-hexdump produces, or the result of printing JS arrays using `console.log(JSON.stringify(bytes))` or similar. Bonus feature: support reading input from stdin, e.g. for piping. Change-Id: Ic268f266a243f843b6fbf1e3f090e1b06487f5d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3767743 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#81829}
-
Leszek Swirski authored
The used_or_unused_instance_size_in_words field already determines whether the used fields are in- or out-of-object, so we can use it's value for a fast HasOutOfObjectProperties check rather than using NumberOfFields (which includes an iteration over the descriptor array). Change-Id: I6c5b4f3f793b8df7832def7465106f2af7306759 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1718152 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#81828}
-
Andreas Haas authored
R=cbruni@chromium.org Bug: chromium:1338150 Change-Id: I5e5f8ede942dd37112766812a3c84a356f0b6ca9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714355Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#81827}
-
Jakob Kummerow authored
Bug: v8:12917 Change-Id: I8942664831c591f9b5566ee5b1609f68948601e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749208Reviewed-by:
Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/main@{#81826}
-
Danylo Boiko authored
Bug: v8:7327 Change-Id: Iddce3c08ebd5969f47d4996fa6bcaa64908226c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3764352Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Danylo Boiko <danielboyko02@gmail.com> Cr-Commit-Position: refs/heads/main@{#81825}
-
Danylo Boiko authored
Bug: v8:7327 Change-Id: I45085b4b2dcb76948e39e79fcf15711deb531541 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3764441 Commit-Queue: Danylo Boiko <danielboyko02@gmail.com> Reviewed-by:
-
Michael Achenbach authored
This is a reland of commit c66a8017 The reland suppresses the deprecation warning on windows for google_benchmark. Original change's description: > Update V8 DEPS > > Rolling both trusted-versions and trusted-origins and an additional patch coming from https://crrev.com/c/3706887. > > Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx/+log/b126981..88bf407 > > Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/49191c5..955e2ff > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8168f76..f05fcf7 > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/679de1e..6e435d6 > > Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/5cee6a2..a4506d5 > > > > R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com > > Bug: chromium:1345621 > Change-Id: I0659a5f98c83bbc6f061259e798a4b85a7cd7c63 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3766889 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Liviu Rau <liviurau@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81815} Bug: chromium:1345621 Change-Id: I2975ca6ae04c99a9e53f3bbd6872b7d114febb7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773775 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Danylo Boiko authored
Bug: v8:7327 Change-Id: I76317cd206d95584e77b6ece9860a551107154b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3760456Reviewed-by:
-
Matthias Liedtke authored
Bug: v8:7748 Change-Id: Iec95162ec86a0d96fdd64764864604fc3e26cc39 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3771902Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Matthias Liedtke <mliedtke@google.com> Commit-Queue: Matthias Liedtke <mliedtke@google.com> Cr-Commit-Position: refs/heads/main@{#81821}
-
Danylo Boiko authored
Refactored views: - code-view - disassembly-view Bug: v8:7327 Change-Id: I2020e288ace5b2706546b825620c147686dd310c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3757899Reviewed-by:
-
Liviu Rau authored
This reverts commit c66a8017. Reason for revert: Broke windows builders Original change's description: > Update V8 DEPS > > Rolling both trusted-versions and trusted-origins and an additional patch coming from https://crrev.com/c/3706887. > > Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx/+log/b126981..88bf407 > > Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/49191c5..955e2ff > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8168f76..f05fcf7 > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/679de1e..6e435d6 > > Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/5cee6a2..a4506d5 > > > > R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com > > Bug: chromium:1345621 > Change-Id: I0659a5f98c83bbc6f061259e798a4b85a7cd7c63 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3766889 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Liviu Rau <liviurau@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81815} Bug: chromium:1345621 Change-Id: Idfcc6eaac648fcb64818caa50603634ca32f8612 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773774 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#81819}
-
Thibaud Michaud authored
The suspender is only needed by the wrapper, do not forward it to the JS import. R=ahaas@chromium.org Bug: v8:12191 Change-Id: Id8e9a820491588b40fffb5dfd8706e85a16b8b23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3768410Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#81818}
-
Danylo Boiko authored
Implemented: - Remember nodes/blocks selection for Turboshaft layout - Test version of adapting nodes positions while changing op properties visibility - Turboshaft blocks collapsing Refactored: - text-view.ts - resizer.ts Solved previous comments: - https://chromium-review.googlesource.com/c/v8/v8/+/3706603/comments/62ffc361_7827e282 - https://chromium-review.googlesource.com/c/v8/v8/+/3700078/comments/d29ea456_f3c197d6 Bug: v8:7327 Change-Id: I9e141eb882ab0e22bd079b067e2229f5baa69433 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3752805 Commit-Queue: Danylo Boiko <danielboyko02@gmail.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#81817}
-
Michael Lippautz authored
Thread through compressed pointer into write barrier to allow to delay compression after checking whether a write barrier is actually needed. Change-Id: If7e6cbb69a57cc9aeeb551c11f685bace4e56c4c Bug: chromium:1325007 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769826 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling both trusted-versions and trusted-origins and an additional patch coming from https://crrev.com/c/3706887. Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx/+log/b126981..88bf407 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/49191c5..955e2ff Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/8168f76..f05fcf7 Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/679de1e..6e435d6 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/5cee6a2..a4506d5 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Bug: chromium:1345621 Change-Id: I0659a5f98c83bbc6f061259e798a4b85a7cd7c63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3766889Reviewed-by:
-
ishell@chromium.org authored
... when external code space is enabled. Currently this mode is guarded by V8_REMOVE_BUILTINS_CODE_OBJECTS flag which is set to false until Code-less builtins are supported. Drive-by: * remove unnecessary methods from AbstractCode, * avoid CodeDataContainer <-> Code roundtrips when accessing writable state of Code objects via CodeT. Bug: v8:11880 Change-Id: Iae3ff3b2feae68d875cbe9f82a6bb076460dd2f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769832 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Pierre Langlois authored
We already generate BTI instructions with `BaselineAssembler::JumpTarget()` on `VisitSingleBytecode()`, so we shouldn't need to do it when binding a label. Bug: v8:13082 Change-Id: Ie4d645a2379c3feb4909be524b42ebd85a8d35af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3771861Reviewed-by:
-
Darius M authored
When pointer compression is disabled, and sizeof(Tagged_t) is 8 (eg, arm64 without pointer compression), the function extract_first_nonzero_index is never used, which was causing a warning. Bug: v8:13048 Change-Id: I5a0fba4da4201e3be147632d891d0d9e20cb46eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769694Reviewed-by:
-
ishell@chromium.org authored
The Code::constant_pool() segfaulted on configurations with disabled external code space when it was called on mallocced copy of a Code object. Bug: v8:11880 Change-Id: I86919002ef080486f1e4532c3a2d3352f4526508 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3772004 Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#81811}
-
Danylo Boiko authored
- accelerated nodes selection for the old IR layout; - implemented turboshaft blocks layout building (blocks coordinates and edges); - extended interaction with user (selecting/hovering) for such things like: blocks/nodes/edges. Bug: v8:7327 Change-Id: I0b01679e9dde0bb7d94ba80dd0ee744f334e1968 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747871Reviewed-by:
-
Philip Pfaffe authored
Thic CL adds a CDP API skeleton that will be used to disassemble WASM modules using V8's new disassembler. Bug: v8:12917, chromium:1325626 Change-Id: I4ca81aca923e9716653cd90367e5fad319483aae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721381Reviewed-by:
-
Jakob Kummerow authored
This includes several changes: - avoid a very-unlikely-but-theoretically-possible OOB write - avoid a somewhat-likely memory leak - grow the buffer less aggressively for medium-length strings Change-Id: I877f43d7e2e7cd4778ba8c7c7525ba988301f750 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3771900Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:13006 Change-Id: Ia59bf5ca93403e055c65e4f28afc1b0f803bc531 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3771901Reviewed-by:
-
Manos Koukoutos authored
Notably: - As per convention, TrapIf/Unless should not return a control node. - Wasm-gc pipeline should not depend on FLAG_wasm_inlining. Change-Id: Ic593db1f979bec1cedfd9384b21487fc2763a35b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3771640Reviewed-by:
-
Samuel Groß authored
To work properly and securely, the sandbox requires cooperation from the Embedder, for example in the form of a custom ArrayBufferAllocator and later on custom type tags for external objects. As such, it likely does not make sense to enable the sandbox by default everywhere. Bug: v8:10391, v8:13058 Change-Id: Ief2720122f70b9a1bc3f2e6802e60b5b95b855d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3771841Reviewed-by:
-
Leszek Swirski authored
DropRegisterAtEnd is used to free a register, to make space for the result of a node. Normally this frees up an input that is dead at the end of the node's lifetime, but under high local variable pressure, we might not have a dead value to drop. In these cases we have to spill a register through the normal spilling mechanism. Additionally, allow freeing up a blocked free register (i.e. a temporary) if this is possible. Bug: v8:7700 Change-Id: I0099751918cf5cb65c2a09337a3f080eb2c4dd14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769833Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81804}
-
Nikolaos Papaspyrou authored
This CL fixes a bug in the units of the reported metrics for V8.GC.Cycle.MainThread.Full.Incremental.Mark (ms instead of us). It also reports incremental marking/sweeping metrics (both for the unified heap and the C++ managed heap) only when incremental marking/sweeping were used; otherwise, no zero values are reported. Bug: chromium:1154636 Bug: chromium:1343507 Change-Id: Ibc0103ea62fa0eeb5f7184280c8514e99a5c21a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3768502Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Reviewed-by:
-
Victor Gomes authored
Bug: v8:7700 Change-Id: Id108820c75d8a3a84b90b8bb498aaaa603dfb0e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3768412 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/48c2d1c..d4bc509 Fix SOVERSION of shared library (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/d4bc509 v1.6.2 bump (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/7a2024e R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I3aea0df8dc06edd78f3e4e8329ab17ed58a6ed6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3768773Reviewed-by:
-
Victor Gomes authored
Similarly to TF, we inline ToBoolean directly on Maglev generated code. Most of the code is run as deferred, it "returns" true after 6 simple checks. ToBoolean is separated in a different function to be used by other nodes later (e.g. ToBooleanLogicalNot). Bug: v8:7700 Change-Id: I75d77b60ebfb1bb124c9e98ad381f8aefa0ac665 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769688Reviewed-by:
-
Manos Koukoutos authored
Mostly test/fuzzer, test/inspector, test/unittests. Bug: v8:13006 Change-Id: I825efa5d72a224bb3cb9f86a9fac8763e9dbd1cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769696Reviewed-by:
-
Victor Gomes authored
Additionally, the CL creates a BranchIfRootConstant node and updates JumpIfTrue and JumpIfFalse. Bug: v8:7700 Change-Id: I7ee98f4b726ffef0f7969231b598d6216b09ccfc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769828Reviewed-by:
-
Leon Bettscheider authored
This CL is part of an effort to enable concurrent marking in MinorMC. For this purpose we plan to reuse the IncrementalMarking class which already implements a part of the concurrent marking code for MajorMC (and is currently coupled with MarkCompactCollector). We plan to parameterize IncrementalMarking with CollectorBase, which can be either MinorMarkCompactCollector or MarkCompactCollector, in a subsequent CL. Bug: v8:13012 Change-Id: I595bfdcb6e1abaa270d8037d889620433f26a416 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3749183 Commit-Queue: Leon Bettscheider <bettscheider@google.com> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#81797}
-
