- 02 Dec, 2015 1 commit
-
-
verwaest authored
This hackily disambiguates multiple calls for the iterator protocols in ForOf / Yield* by adding -2 / -1 to the pos. BUG=v8:3953 LOG=y Review URL: https://codereview.chromium.org/1491923003 Cr-Commit-Position: refs/heads/master@{#32527}
-
- 03 Nov, 2015 1 commit
-
-
yangguo authored
R=littledan@chromium.org BUG=v8:4003 LOG=N Review URL: https://codereview.chromium.org/1423993006 Cr-Commit-Position: refs/heads/master@{#31730}
-
- 23 Oct, 2015 1 commit
-
-
neis authored
R=rossberg BUG= Review URL: https://codereview.chromium.org/1415283003 Cr-Commit-Position: refs/heads/master@{#31507}
-
- 14 Oct, 2015 1 commit
-
-
franziska.hinkelmann authored
Section 8.10.5 9a specifies that a property descriptor cannot both have accessors and specify the writability of the property. The previous error message was misleading because it referred to writable rather than specifying the writability (which includes writable: false). BUG=v8:2536 LOG=N Review URL: https://codereview.chromium.org/1399693003 Cr-Commit-Position: refs/heads/master@{#31273}
-
- 09 Oct, 2015 1 commit
-
-
cbruni authored
strict mode. LOG=N BUG=chromium:423739 Review URL: https://codereview.chromium.org/1381083004 Cr-Commit-Position: refs/heads/master@{#31192}
-
- 25 Aug, 2015 1 commit
-
-
bmeurer authored
The previous hack with HInstanceOfKnownGlobal was not only slower, but also very brittle and required a lot of weird hacks to support it. And what's even more important it wasn't even correct (because a map check on the lhs is never enough for instanceof). The new implementation provides a sane runtime implementation for InstanceOf plus a fast case in the InstanceOfStub, combined with a proper specialization in the case of a known global in CrankShaft, which does only the prototype chain walk (coupled with a code dependency on the known global). As a drive-by-fix: Also fix the incorrect Object.prototype.isPrototypeOf implementation. BUG=v8:4376 LOG=y Review URL: https://codereview.chromium.org/1304633002 Cr-Commit-Position: refs/heads/master@{#30342}
-
- 15 Aug, 2015 1 commit
-
-
caitpotter88 authored
Second item in section 13.7.5.1 states that the error should be a SyntaxError, when previously CheckAndRewriteReferenceExpression would always emit a ReferenceError. BUG=v8:4373 R=adamk, rossberg LOG=N CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1292393002 Cr-Commit-Position: refs/heads/master@{#30184}
-
- 13 Aug, 2015 1 commit
-
-
adamk authored
This test enumerates properties on all the builtins and makes sure that they never change. In practice, this just generates busywork when trying to add new language features; I've never seen it catch an accidentally-exposed bit of API. Review URL: https://codereview.chromium.org/1275423006 Cr-Commit-Position: refs/heads/master@{#30160}
-
- 28 Jul, 2015 1 commit
-
-
machenbach authored
BUG= Review URL: https://codereview.chromium.org/1257583005 Cr-Commit-Position: refs/heads/master@{#29895}
-
- 14 Jul, 2015 1 commit
-
-
littledan authored
Duplicate parameters are banned both overall in strict mode and also in arrow functions. Our error message for both cases blamed strict mode, which is confusing. This patch fixes the message to point to arrow functions as a possible source as well. R=wingo, adamk LOG=N Review URL: https://codereview.chromium.org/1236863008 Cr-Commit-Position: refs/heads/master@{#29662}
-
- 10 Jul, 2015 1 commit
-
-
verwaest authored
For now it uses a pretty slow path for accessing strings by wrapping it into a new temporary wrapper. BUG=v8:4042, v8:3088 LOG=y Review URL: https://codereview.chromium.org/1221303019 Cr-Commit-Position: refs/heads/master@{#29576}
-
- 23 Jun, 2015 1 commit
-
-
littledan authored
Turning the --harmony-array flag on has been delayed behind unrelated test failures. Now that those tests are disabled, land the changes. This patch fixes WebKit tests based on the new change. R=adamk LOG=Y BUG=v8:3578 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1199113003 Cr-Commit-Position: refs/heads/master@{#29209}
-
- 22 Jun, 2015 3 commits
-
-
dslomov authored
Scoping for initializers is yet incorrect. Defaults are not supported. R=arv@chromium.org,rossberg@chromium.org BUG=v8:811 LOG=N Committed: https://crrev.com/42f30f4ded2b1ca0c4caa7639e6206e93c78ee70 Cr-Commit-Position: refs/heads/master@{#29184} Review URL: https://codereview.chromium.org/1189743003 Cr-Commit-Position: refs/heads/master@{#29192}
-
machenbach authored
Revert of [destructuring] Implement parameter pattern matching. (patchset #7 id:120001 of https://codereview.chromium.org/1189743003/) Reason for revert: [Sheriff] Breaks tsan: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/4392 Original issue's description: > [destructuring] Implement parameter pattern matching. > > Scoping for initializers is yet incorrect. Defaults are not supported. > > R=arv@chromium.org,rossberg@chromium.org > BUG=v8:811 > LOG=N > > Committed: https://crrev.com/42f30f4ded2b1ca0c4caa7639e6206e93c78ee70 > Cr-Commit-Position: refs/heads/master@{#29184} TBR=arv@chromium.org,rossberg@chromium.org,caitpotter88@gmail.com,wingo@igalia.com,dslomov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:811 Review URL: https://codereview.chromium.org/1195163007 Cr-Commit-Position: refs/heads/master@{#29188}
-
dslomov authored
Scoping for initializers is yet incorrect. Defaults are not supported. R=arv@chromium.org,rossberg@chromium.org BUG=v8:811 LOG=N Review URL: https://codereview.chromium.org/1189743003 Cr-Commit-Position: refs/heads/master@{#29184}
-
- 20 Jun, 2015 2 commits
-
-
machenbach authored
Revert of Ship Harmony Array/TypedArray methods (patchset #6 id:100001 of https://codereview.chromium.org/1187543003/) Reason for revert: [Sheriff] Breaks gcstress and mac asan: http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%203/builds/3896 http://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/1774 Original issue's description: > Ship Harmony Array/TypedArray methods > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > BUG=v8:3578 > LOG=Y > R=adamk > > Committed: https://crrev.com/7142b0d211b732e1c119fded80f43fbbd9cea0f8 > Cr-Commit-Position: refs/heads/master@{#29170} TBR=adamk@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3578 Review URL: https://codereview.chromium.org/1195163002 Cr-Commit-Position: refs/heads/master@{#29171}
-
littledan authored
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel BUG=v8:3578 LOG=Y R=adamk Review URL: https://codereview.chromium.org/1187543003 Cr-Commit-Position: refs/heads/master@{#29170}
-
- 19 Jun, 2015 1 commit
-
-
caitpotter88 authored
BUG=v8:4007 LOG=N R=rossberg@chromium.org, arv@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/12e194860a56d47a10d89ae34761a4af6b6166bb Cr-Commit-Position: refs/heads/master@{#29118} Review URL: https://codereview.chromium.org/1191003003 Cr-Commit-Position: refs/heads/master@{#29150}
-
- 18 Jun, 2015 2 commits
-
-
caitpotter88 authored
Revert of [es6] ship Object.assign (patchset #2 id:20001 of https://codereview.chromium.org/1191003003/) Reason for revert: Seems to break asan somehow Original issue's description: > [es6] ship Object.assign > > BUG=v8:4007 > LOG=N > R=rossberg@chromium.org, arv@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/12e194860a56d47a10d89ae34761a4af6b6166bb > Cr-Commit-Position: refs/heads/master@{#29118} TBR=arv@chromium.org,dslomov@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4007 Review URL: https://codereview.chromium.org/1191593005 Cr-Commit-Position: refs/heads/master@{#29124}
-
caitpotter88 authored
BUG=v8:4007 LOG=N R=rossberg@chromium.org, arv@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1191003003 Cr-Commit-Position: refs/heads/master@{#29118}
-
- 02 Jun, 2015 1 commit
-
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1153583006 Cr-Commit-Position: refs/heads/master@{#28757}
-
- 09 Apr, 2015 1 commit
-
-
caitpotter88 authored
BUG=v8:3946, v8:3982 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel LOG=N R=arv@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1027283004 Cr-Commit-Position: refs/heads/master@{#27729}
-
- 13 Mar, 2015 1 commit
-
-
arv authored
ES6 specs the function length property (it was not part of ES5) and it makes it configurable. BUG=v8:3045 LOG=N R=mstarzinger@chromium.org, adamk@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/993073002 Cr-Commit-Position: refs/heads/master@{#27190}
-
- 21 Jan, 2015 1 commit
-
-
verwaest authored
BUG=259443 LOG=y Review URL: https://codereview.chromium.org/861623002 Cr-Commit-Position: refs/heads/master@{#26189}
-
- 08 Jan, 2015 1 commit
-
-
dslomov authored
R=rossberg@chromium.org BUG=v8:3330 Review URL: https://codereview.chromium.org/836393003 Cr-Commit-Position: refs/heads/master@{#26000}
-
- 18 Dec, 2014 1 commit
-
-
arv authored
BUG=v8:3230 LOG=Y R=dslomov@chromium.org, caitpotter88@gmail.com Review URL: https://codereview.chromium.org/808413004 Cr-Commit-Position: refs/heads/master@{#25892}
-
- 15 Dec, 2014 1 commit
-
-
dslomov authored
R=arv@chromium.org BUG=v8:3330 LOG=Y Review URL: https://codereview.chromium.org/808433002 Cr-Commit-Position: refs/heads/master@{#25826}
-
- 27 Nov, 2014 1 commit
-
-
dslomov authored
R=rossberg@chromium.org, yangguo@chromium.org LOG=Y Review URL: https://codereview.chromium.org/761913002 Cr-Commit-Position: refs/heads/master@{#25536}
-
- 26 Nov, 2014 1 commit
-
-
dslomov authored
Per TC39 Nov 2014 decision. This patch also changes behavior for "legacy const": assignments to sloppy const in strict mode is now also a type error. This fixes v8:2243 and also brings us in compliance with other engines re assignment to function names (see updated webkit test), but might have bigger implications. That change can easily be reverted by changing Variable::IsSignallingAssignmentToConst. BUG=v8:3713,v8:2243 LOG=N Review URL: https://codereview.chromium.org/749633002 Cr-Commit-Position: refs/heads/master@{#25516}
-
- 17 Oct, 2014 1 commit
-
-
adamk@chromium.org authored
TBR=danno@chromium.org Review URL: https://codereview.chromium.org/664613004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24708 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Aug, 2014 1 commit
-
-
yangguo@chromium.org authored
R=arv@chromium.org, mathiasb@opera.com BUG=v8:3486 LOG=Y Review URL: https://codereview.chromium.org/465273002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23223 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Aug, 2014 2 commits
-
-
wingo@igalia.com authored
R=arv@chromium.org TBR=arv@chromium.org, rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/454463002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22982 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
wingo@igalia.com authored
R=arv@chromium.org TBR=rossberg@chromium.org Review URL: https://codereview.chromium.org/451703005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22981 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 Aug, 2014 2 commits
-
-
adamk@chromium.org authored
Follow up to: 438103002 BUG=None LOG=Y R=adamk@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/439153005 Patch from Erik Arvidsson <arv@chromium.org>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22949 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
TBR=rossberg@chromium.org Review URL: https://codereview.chromium.org/446883002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22941 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
adamk@chromium.org authored
TBR=dslomov@chromium.org Review URL: https://codereview.chromium.org/438103002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22833 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Jul, 2014 1 commit
-
-
verwaest@chromium.org authored
BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/408183002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22520 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Jul, 2014 1 commit
-
-
yangguo@chromium.org authored
R=rossberg@chromium.org BUG=v8:2938 LOG=Y Review URL: https://codereview.chromium.org/394833002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22434 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 May, 2014 1 commit
-
-
ulan@chromium.org authored
BUG= R=mstarzinger@chromium.org, mvstanton@chromium.org Review URL: https://codereview.chromium.org/279773002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21423 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 May, 2014 1 commit
-
-
rafaelw@chromium.org authored
TBR=verwaest Review URL: https://codereview.chromium.org/262823008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21125 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-