- 09 Nov, 2018 1 commit
-
-
Jaroslav Sevcik authored
Change-Id: Ia1f47083689abb7d37c91098465a107a71f4dbea Reviewed-on: https://chromium-review.googlesource.com/c/1225757 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#57375}
-
- 12 Oct, 2018 1 commit
-
-
Clemens Hammacher authored
LockGuard is mostly used with Mutex. Since both are defined outside the internal namespace, we often have to write {base::LockGuard<base::Mutex>}. This CL shortens this to {base::MutexGuard} across the code base R=mlippautz@chromium.org Bug: v8:8238 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I020d5933b73aafb98c4b72e3bb2dfd07c979ba73 Reviewed-on: https://chromium-review.googlesource.com/c/1278796Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56612}
-
- 04 Apr, 2018 1 commit
-
-
Ross McIlroy authored
With the Ignition + Turbofan pipeline there is very little overlap between the data needed for unoptimized compilation and optimized compilation. As a result, it is cleaner to split up the CompilationInfo into UnoptimizedCompilationInfo and OptimizedCompilationInfo. Doing so also necessitate splitting up CompilationJob into UnoptimizedCompilationJob and OptimizedCompilationJob - again there is not much overlap so this seems cleaner. Change-Id: I1056ad520937b7f8582e4fc3ca8f4910742de30a Reviewed-on: https://chromium-review.googlesource.com/995895 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#52369}
-
- 20 Feb, 2018 1 commit
-
-
Sigurd Schneider authored
This ensures that breaking on inlined builtins works, even when compiling concurrently. This CL also introduces the member Isolate::AbortConcurrentOptimization. R=sigurds@chromium.org Bug: v8:178 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ie6cbb48ebde18036888af2dd715862e7a14ddf9d Reviewed-on: https://chromium-review.googlesource.com/912468 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#51384}
-
- 25 Aug, 2017 1 commit
-
-
Peter Marshall authored
Bug: v8:6333 Change-Id: Iad2fdb7670dd01d19ed25c48a0091969cddb01c8 Reviewed-on: https://chromium-review.googlesource.com/632257Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#47592}
-
- 30 May, 2017 1 commit
-
-
ulan authored
This is consistent with C++ memory model and avoids confusion with GC write barrier. BUG= Review-Url: https://codereview.chromium.org/2912773002 Cr-Commit-Position: refs/heads/master@{#45584}
-
- 30 Jan, 2017 2 commits
-
-
jochen authored
R=mtrofin@chromium.org,verwaest@chromium.org BUG= Review-Url: https://codereview.chromium.org/2662883003 Cr-Commit-Position: refs/heads/master@{#42787}
-
jochen authored
We shouldn't block during GC for arbitrarily long intervals. BUG=chromium:686153,chromium:642532 R=verwaest@chromium.org,hpayer@chromium.org Review-Url: https://codereview.chromium.org/2658313002 Cr-Commit-Position: refs/heads/master@{#42761}
-
- 20 Jul, 2016 1 commit
-
-
jochen authored
BUG=v8:5215 R=marja@chromium.org Review-Url: https://codereview.chromium.org/2161033003 Cr-Commit-Position: refs/heads/master@{#37906}
-
- 27 Apr, 2016 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/1925743002 Cr-Commit-Position: refs/heads/master@{#35832}
-
- 08 Mar, 2016 1 commit
-
-
mstarzinger authored
R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1773593002 Cr-Commit-Position: refs/heads/master@{#34572}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 15 Apr, 2015 1 commit
-
-
jochen authored
The embedder can control how many threads it wants to use via the v8::Platform implementation. V8 internally doesn't spin up threads anymore. If the embedder doesn't want to use any threads at all, it's v8::Platform implementation must either run the background jobs on the foreground thread, or the embedder should specify --predictable BUG=none R=yangguo@chromium.org LOG=y Review URL: https://codereview.chromium.org/1064723005 Cr-Commit-Position: refs/heads/master@{#27833}
-
- 14 Apr, 2015 3 commits
-
-
jochen authored
Original issue's description: > Remove support for thread-based recompilation > > BUG=v8:3608 > R=yangguo@chromium.org > LOG=y > > Committed: https://crrev.com/ed5db223a19dfe126af01 > Cr-Commit-Position: refs/heads/master@{#27619} BUG=v8:3608 R=yangguo@chromium.org LOG=y Review URL: https://codereview.chromium.org/1087763003 Cr-Commit-Position: refs/heads/master@{#27821}
-
jochen authored
Revert of Reland "Remove support for thread-based recompilation" (patchset #1 id:1 of https://codereview.chromium.org/1059853004/) Reason for revert: still times out Original issue's description: > Reland "Remove support for thread-based recompilation" > > Original issue's description: > > Remove support for thread-based recompilation > > > > BUG=v8:3608 > > R=yangguo@chromium.org > > LOG=y > > > > Committed: https://crrev.com/ed5db223a19dfe126af012e894582251aa3635d7 > > Cr-Commit-Position: refs/heads/master@{#27619} > > BUG=v8:3608 > R=yangguo@chromium.org > LOG=y > > Committed: https://crrev.com/f1ceccb8b8b352a91e6366e3e3103f1db0df6afb > Cr-Commit-Position: refs/heads/master@{#27813} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3608 Review URL: https://codereview.chromium.org/1082183003 Cr-Commit-Position: refs/heads/master@{#27816}
-
jochen authored
Original issue's description: > Remove support for thread-based recompilation > > BUG=v8:3608 > R=yangguo@chromium.org > LOG=y > > Committed: https://crrev.com/ed5db223a19dfe126af012e894582251aa3635d7 > Cr-Commit-Position: refs/heads/master@{#27619} BUG=v8:3608 R=yangguo@chromium.org LOG=y Review URL: https://codereview.chromium.org/1059853004 Cr-Commit-Position: refs/heads/master@{#27813}
-
- 08 Apr, 2015 1 commit
-
-
yangguo authored
Revert of Remove support for thread-based recompilation (patchset #1 id:1 of https://codereview.chromium.org/966653002/) Reason for revert: speculative revert due to gc-stress timeouts. Original issue's description: > Remove support for thread-based recompilation > > BUG=v8:3608 > R=yangguo@chromium.org > LOG=y > > Committed: https://crrev.com/ed5db223a19dfe126af012e894582251aa3635d7 > Cr-Commit-Position: refs/heads/master@{#27619} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true BUG=v8:3608 LOG=N Review URL: https://codereview.chromium.org/1063383004 Cr-Commit-Position: refs/heads/master@{#27654}
-
- 07 Apr, 2015 1 commit
-
-
Jochen Eisinger authored
BUG=v8:3608 R=yangguo@chromium.org LOG=y Review URL: https://codereview.chromium.org/966653002 Cr-Commit-Position: refs/heads/master@{#27619}
-
- 24 Feb, 2015 2 commits
-
-
jochen authored
Instead of semaphore and atomics BUG=v8:3608 R=yangguo@chromium.org LOG=n Review URL: https://codereview.chromium.org/950323002 Cr-Commit-Position: refs/heads/master@{#26823}
-
jochen authored
For flushing the input queue, use the input queue lock. Introduce an explicit refcount to make sure we don't delete the thread object before all jobs are finished. BUG=v8:3608 R=yangguo@chromium.org LOG=n Review URL: https://codereview.chromium.org/948863002 Cr-Commit-Position: refs/heads/master@{#26812}
-
- 22 Dec, 2014 1 commit
-
-
jochen authored
BUG=v8:3608 R=bmeurer@chromium.org LOG=n Review URL: https://codereview.chromium.org/816363003 Cr-Commit-Position: refs/heads/master@{#25925}
-
- 09 Oct, 2014 1 commit
-
-
jochen@chromium.org authored
BUG=none R=yangguo@chromium.org LOG=n Review URL: https://codereview.chromium.org/639353002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24483 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Oct, 2014 1 commit
-
-
jochen@chromium.org authored
The implementation is not yet complete, it doesn't support blocking yet, and doesn't collect statistics. This things will be fixed in follow-up CLs. BUG=v8:3608 R=yangguo@chromium.org LOG=n Review URL: https://codereview.chromium.org/620093003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24425 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Aug, 2014 1 commit
-
-
mstarzinger@chromium.org authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/462033002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23081 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
Also split v8-core independent methods from checks.h to base/logging.h and merge v8checks with the rest of checks. The CPU::FlushICache method is moved to CpuFeatures::FlushICache RoundUp and related methods are moved to base/macros.h Remove all layering violations from src/libplatform BUG=none R=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/358363002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
BUG=none R=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/316133002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21693 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Dec, 2013 1 commit
-
-
yangguo@chromium.org authored
Goals: - easier to read, more suitable identifiers. - better distinction between compiling optimized/unoptimized code - compiler does not install code on the function. - easier to add features (e.g. caching optimized code for osr). - remove unnecessary code. R=titzer@chromium.org Review URL: https://codereview.chromium.org/110203002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18409 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Nov, 2013 1 commit
-
-
yangguo@chromium.org authored
R=svenpanne@chromium.org BUG=v8:2991 LOG=Y Review URL: https://codereview.chromium.org/68203029 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17866 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Oct, 2013 2 commits
-
-
yangguo@chromium.org authored
R=mvstanton@chromium.org BUG= Review URL: https://codereview.chromium.org/27473006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17247 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
Specifically, this includes: - Encapsulating data structure for osr buffer into CyclicBuffer - Use the new CyclicQueue instead of UnboundedQueue to queue new jobs. We can enqueue and dequeue a CyclicQueue on both ends in O(1). This allows us to add OSR jobs to the front for lower compile latency. - Dispose osr buffer by one stale job per GC to avoid leak R=titzer@chromium.org BUG= Review URL: https://codereview.chromium.org/25505002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17244 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Oct, 2013 1 commit
-
-
yangguo@chromium.org authored
Instead, we block concurrent recompilation until unblocked. This makes affected tests more predictable and run shorter. R=jkummerow@chromium.org BUG= Review URL: https://codereview.chromium.org/26758003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17199 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Sep, 2013 1 commit
-
-
yangguo@chromium.org authored
The heap leak has since been solved. R=mstarzinger@chromium.org BUG=291236 Review URL: https://codereview.chromium.org/25237003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17002 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Sep, 2013 2 commits
-
-
yangguo@chromium.org authored
R=mvstanton@chromium.org BUG= Review URL: https://codereview.chromium.org/24543002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16939 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
Changes include: - completed concurrent OSR tasks trigger a stack check interrupt. - polling for completion is now guarded by a stack check. - circular buffer for completed OSR tasks instead of list. R=titzer@chromium.org BUG= Review URL: https://codereview.chromium.org/24237009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16934 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Sep, 2013 1 commit
-
-
yangguo@chromium.org authored
Also small refactorings. R=mstarzinger@chromium.org BUG=291236 Review URL: https://codereview.chromium.org/23902033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16740 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Sep, 2013 1 commit
-
-
yangguo@chromium.org authored
Instead of overwriting the code entry of the function, we trigger an interrupt to install the code on the main thread. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/23542029 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16681 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Sep, 2013 1 commit
-
-
yangguo@chromium.org authored
R=titzer@chromium.org BUG= Review URL: https://codereview.chromium.org/23842004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16649 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-