- 02 Mar, 2021 1 commit
-
-
Camillo Bruni authored
- Fix diff coloring when a baseline is selected - Cleanup UI and use dark-mode by default - Reuse CSS from the system-analyzer - Support loading mutliple files by default everywhere - Use hideable panels from system-analyzer Change-Id: Iafe271d2f86fbbd10a940b3ac99874dd51f45442 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2721763 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#73128}
-
- 03 Feb, 2021 1 commit
-
-
Leszek Swirski authored
Fix some trailing whitespace issues in files in the tools directory. Change-Id: If9e9b1dab1d6f521e20619a2a1d093749f0528d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2671660 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#72498}
-
- 20 Jan, 2021 1 commit
-
-
Camillo Bruni authored
Doing a function call into the logger to decide whether logging is enabled or not is more costly than necessary. This CL changes logging to take FLAG_log as main signal whether logging could be active. If FLAG_log == false, logging cannot be active. In that case we always call into the logger and perform detailed checks there. This CL changes flag-definitions to set FLAG_log if they need logging. Change-Id: Ia51ed9fb7128451bf1dcf345fab257547aab4a47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2602461Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#72186}
-
- 12 Jan, 2021 1 commit
-
-
Camillo Bruni authored
Drive-by-fix: - fix load spinner z-index Change-Id: I4a8f9b768ec858da4d91780ae0998a685f4438bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2624609Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#72044}
-
- 08 Jan, 2021 1 commit
-
-
Camillo Bruni authored
Change the background of source position markers based on the events they link to. Bug: v8:10644 Change-Id: I108d9f5670acdaf5835905c2b44648c0eaf6dbd0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2604708 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71970}
-
- 07 Jan, 2021 1 commit
-
-
Camillo Bruni authored
Prepare the system analyzer to be able to select events related to a a single code log entry. - Rename source-panel to script-script panel - Update main index.css to support selects in the panel selection header Bug: v8:10644 Change-Id: Ie8dd1839294687cb9e25995bcb7ef246a7d7f48d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2604707Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71948}
-
- 21 Dec, 2020 1 commit
-
-
Camillo Bruni authored
- Fix landing page - Introduce and use SelectRelatedEvent for centralising the logic of finding and showing related LogEntries. It also clears the selection of all list panels if there are no related entries. - Add "select related" button to the script-panel to show events only from the currently selected script - Add selection type tabs for the map-panel - Fix transition colors for map-transitions view - Introduce separate map-transition view for the currently selected Map Bug: v8:10644 Change-Id: I4199a8332bab2518d98078712ed5ce9a8f1dc19e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599555 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71849}
-
- 14 Dec, 2020 3 commits
-
-
Camillo Bruni authored
- Allow hiding individual timeline-tracks to clear up screen space. - Auto-hide timeline-tracks when there are no entries Bug: v8:10644 Change-Id: Ibde37242fa1fcb827ca176ee7576a23715c45bda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584954Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71739}
-
Camillo Bruni authored
Associate DeoptLogEntry with both, the function's source position and the deopt location's source position. Also fixes the list-panel click handler to support all clickable entry types. Bug: v8:10644, v8:10754 Change-Id: If10272a926d5dad10b29322e237610900715b9dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584955 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71732}
-
Camillo Bruni authored
- Show selection tab-bar - Hide panels on empty timeline - Fix legend position in ic list-panel Bug: v8:10644 Change-Id: I4ef09627ed4de8682adb60f88be38867bc91640d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584953Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71731}
-
- 09 Dec, 2020 1 commit
-
-
Camillo Bruni authored
- Display the source code in the code-panel - Add selection dropdown to code-panel - Add more filter propertyNames to CodeLogEntry - Rename list panel titles to "XXX List" - Add +10, +100 buttons for LazyTables - Add Color.darken Change-Id: Ia41c41c1d6cc949dfe766397ba6b72edc29797aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2578945Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71674}
-
- 08 Dec, 2020 1 commit
-
-
Camillo Bruni authored
Bug: v8:10644 Change-Id: I83801396fe683173349d14a7590828ec86587eac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2575122Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71655}
-
- 05 Dec, 2020 1 commit
-
-
Camillo Bruni authored
- Clean up entry selection code - Add source positions for code and deopt events - Fix log entry selection from script - Improve log parsing speed Bug: v8:10644 Change-Id: Ie466679132b8ce24506ecf75223118b32275f931 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2569756 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71624}
-
- 02 Dec, 2020 3 commits
-
-
Camillo Bruni authored
- Don't print normalize transition for cached maps - Avoid printing two transitions in Map::CopyReplaceDescriptor - Harden processor.mjs existing existing broken logs by skipping double entries and avoiding mutliple edges to the same target map Bug: v8:10644 Change-Id: I561a0f888c8835a40a289baa50d65ff69e368bad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565123Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71565}
-
Camillo Bruni authored
Bug: v8:10644 Change-Id: I727f844f3796f37e92c8855e02d519abeee73dc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2566760 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71558}
-
Camillo Bruni authored
- Add FLAG_log_code_disassemble - Add code-disassamble log entries for Code and BytecodeArray - Add basic code-panel to system-analyzer Bug: v8:10644 Change-Id: I1abb339a42b55df01265d63d0f0d8c1ac2e041dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565517Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71556}
-
- 01 Dec, 2020 2 commits
-
-
Camillo Bruni authored
This CL extends the existing optimization markers: - "~" for interpreted code - "-" for native context independent code (new) - "+" for turboprop code (new) - "*" for turbofan code Bug: v8:10644 Change-Id: If8940a8c3f32c6f347f61a901be101078df66331 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567693 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#71541}
-
Sathya Gunasekaran authored
Bug: v8:10644 Change-Id: I8c81e1f9d6f1f766af07905928ea7b437771e1ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2567201Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71540}
-
- 30 Nov, 2020 10 commits
-
-
Camillo Bruni authored
Bug: v8:10644 Change-Id: I24229cbbf6a3ffea0fd4c3b96ef6eaf1e780b6e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565136 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71505}
-
Camillo Bruni authored
- Timeline.selection is now a Timeline as well - Allow remove the current timeline-track selection by double-clicking outside-the selection - Update the timeline-track stats based on the current selection - Simplify DOM element creation methods - Add separate SelectionHandler class for timeline-track Bug: v8:10644 Change-Id: I4f15d6ab4f5ec6b7330e22769472ca3074b00edd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565130 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71497}
-
Sathya Gunasekaran authored
Bug: v8:10644 Change-Id: I299e95f5a8505205a4942a5a5b04cde36f1e5320 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565355Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71493}
-
Sathya Gunasekaran authored
Bug: v8:10644 Change-Id: I8aaaf7337a92ef4962848a550ad1b80a65e3bc23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565350Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71491}
-
Sathya Gunasekaran authored
Bug: v8:10644 Change-Id: I98a557782cabadec3a85ca04cd3fc6c391e239d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565352Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71490}
-
Sathya Gunasekaran authored
Bug: v8:10644 Change-Id: I934795e6ef8c42c3bc801c84dfb5f9770acd46fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565057Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71486}
-
Camillo Bruni authored
Attach SourcePositionInfo objects to existing code entries if we find code-source-info log entries. This improves fixes finding scripts for anonymous functions. Bug: v8:10644 Change-Id: I6fc1e029b17107cacce89dc74a67d4d448d9a979 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562672 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71482}
-
Camillo Bruni authored
Drive-by-fix: - better handle tooltip text Bug: v8:10644 Change-Id: Ibe20a1e0a0ebd298855afcbdc6f28e6fa4d1e64e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563660 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71479}
-
Sathya Gunasekaran authored
Bug: v8:10644 Change-Id: I14bbe3afcef09b0d2a785c61d603974c3c393d72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565121Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71478}
-
Camillo Bruni authored
- Fix transition view selection and opening of subtrees - Fix transition colors by storing an index on the uniqueType map in the timeline - Do not reset the current list in the transition view when clicking on a map - Support changing source positions in the source panel - Highlight the current source position with a pulsing marker - Fix kColors usage in timeline-track Bug: v8:10644 Change-Id: I5130f18d9076cb37f9c3c8d585c9e47038ca411b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562386Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71477}
-
- 27 Nov, 2020 1 commit
-
-
Camillo Bruni authored
Make Timeline.selectTimeRange run in O(log(n)) instead of O(n) comparisons. Drive-by-fix: - Use *Index for variable names in Timeline Bug: v8:10644 Change-Id: I65f3be9f259e6bebcec489526a54712daffd4d15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507714 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#71461}
-
- 26 Nov, 2020 2 commits
-
-
Camillo Bruni authored
Properly indent wrapper source lines so the source line numbers are easily visible. Change-Id: I25095ca3e15a8e953c6e826eb8594289a10aa41b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2551105 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#71439}
-
Camillo Bruni authored
- Add ToolTip helper that tracks scrolling target elements - Auto hide if the target scrolls out of view - ToolTip position depends on target position - Add basic tooltips for maps in the transition view, entries in timeline tracks and the source panel Drive-by-fix: - Move events.mjs to view/ folder - Add basic toString methods on various log entries - Add requestAnimationFrame update support for V8CustomElement Bug: v8:10644 Change-Id: I1059733cd094a986b715547b3d5747eefbc54bc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2551103 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#71434}
-
- 18 Nov, 2020 1 commit
-
-
Camillo Bruni authored
- introduce view specific helper.mjs module - clean up some imports Bug: v8:10644 Change-Id: I0497c1a962c90f61f2beca667aca4a3f53a11e59 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2545705Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71269}
-
- 16 Nov, 2020 1 commit
-
-
Camillo Bruni authored
- Reuse DOM nodes if possible - Delay slow DOM node removal to not block the UI - Fix global time range syncing when adding timelines to the state - Use a Proxy to cache CSS colors instead of querying CSS properties on every access - Set className on newly create DOM nodes instead of adding to the classList - Use bound functions for event handlers that are added multiple times - Speed up Chunk.getBreackdown - Use CSS gradient for timeline-track chunk backgrounds, which is an order of magnitude faster than the serialised canvas approach Bug: v8:10644 Change-Id: Ie2d6d5b404f18e920c10c0a6460669fd4d0b20e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2539947 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71207}
-
- 10 Nov, 2020 2 commits
-
-
Camillo Bruni authored
Drive-by-fix: - Remove duplicated LazyTable - Introduce more pseudo private _* fields - Remove MapPanel.mapDetails getter - Rename MapDetails.setSelectedMap to .map Bug: v8:10644 Change-Id: I0f976ab86f24de2677e024e386e7d4169c9abbb3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2523192 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71093}
-
Camillo Bruni authored
This is mostly an auto-conversion done by several tools. - use let / const - use arrow functions - use template strings There are some additional manual rewrite required to modernize the code further. Change-Id: I63a7a43b05b14b33ad9941350d3d5f26aab10ba0 Bug: v8:10667 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519564Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71080}
-
- 03 Nov, 2020 1 commit
-
-
Sathya Gunasekaran authored
This is a reland of 1ec8f1da Original change's description: > [presubmit] Add JS formatting for tools/system-analyzer > > Bug: v8:10670 > Change-Id: Ifb653ada003719faff261b6e5b2169db37cffdaf > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282522 > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68909} Bug: v8:10670 Change-Id: I4903b3eb8ff39a76594324076f0840b06290044e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307229 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70938}
-
- 02 Nov, 2020 1 commit
-
-
Camillo Bruni authored
- Move all createElement helpers onto a separate DOM class - Make ICPanel.update async - Show number of selected IC events in the ICPanel header - Use shared bound functions for event listeners in the ICPanel groups - Use triangle to mark opened and closed ICPanel groups - Use global --border-color CSS variable Bug: v8:10644 Change-Id: Ib35d94db1019d5cdcee057f0f047472f478ab3be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507718Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70919}
-
- 30 Oct, 2020 1 commit
-
-
Camillo Bruni authored
- Introduce LazyTable that only shows the first 100 entries and can lazily expand - Make StatsPanel.update method async to not block the UI - Show "Total" entry as last item in StatsPanel tables - Fix StatsPanel table entries text alignment - Remove unused getters from StatsPanel class Drive-by-fix: - MapPanel._displayedMapsInTree is undefined when expanding to a sub-transition tree Bug: v8:10644 Change-Id: I5ce7c8b1ee825515cf790a3e52534c3069d8be89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507716 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#70903}
-
- 29 Oct, 2020 1 commit
-
-
Camillo Bruni authored
- Use initial color for TimelineTrack chunks - Use async functions for TimelineTrack setChunkBackgrounds - Introduce timeSelection setter on TimelinePanel - Propagate time selection down to the TimelinePanel - Avoid layout recalculation in TimelineTrack updateSelection drive-by-cleanups: - Add common event listeners only to top-level document - Use console.warn instead of console.error for better debugging in DevTools Bug: v8:10644 Change-Id: Ie4f80f1c6c3f4fa193f8ac01225e0fb76981551d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2497175 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#70886}
-
- 27 Oct, 2020 1 commit
-
-
Camillo Bruni authored
Add simple log file test with processor.mjs, mostly focusing on parsing the log file correctly. Change-Id: Ie8db569b65ecd526ef4474a64d4019f00707d159 Bug: v8:10668 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2484515 Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#70806}
-