1. 26 Jun, 2018 2 commits
  2. 25 Jun, 2018 1 commit
    • Camillo Bruni's avatar
      Reland "[parser][log] Log script id during background compilation" · e7f5c5cc
      Camillo Bruni authored
      This reverts commit a800e050.
      
      Original change's description:
      > Revert "[parser][log] Log script id during background compilation"
      >
      > This reverts commit aafd5c52.
      >
      > Reason for revert: Tentative revert for
      >
      > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825
      > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242
      >
      > Original change's description:
      > > [parser][log] Log script id during background compilation
      > >
      > > - Add separate script-create, script-reserve-id and script-details log events
      > > - Add log events for CompilationCache hits and puts
      > > - Simplify function event logging by only pass along the script id
      > > - Explicitly create Scripts in parse-processor.js on script events only
      > > - Create a temporary script id in the ParseInfo for use during background
      > >   parsing and compilation
      > > - Clean up ParseInfo initialization to centralize creation and use of
      > >   script ids
      > > - Allow creating Scripts with predefined script ids
      > >
      > > Bug: chromium:757467, chromium:850038
      > > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe
      > > Reviewed-on: https://chromium-review.googlesource.com/1097131
      > > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
      > > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
      > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#53978}
      >
      > TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
      >
      > Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2
      > No-Presubmit: true
      > No-Tree-Checks: true
      > No-Try: true
      > Bug: chromium:757467, chromium:850038
      > Reviewed-on: https://chromium-review.googlesource.com/1112538
      > Reviewed-by: Yang Guo <yangguo@chromium.org>
      > Commit-Queue: Yang Guo <yangguo@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#53984}
      
      TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: chromium:757467, chromium:850038
      Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad
      Reviewed-on: https://chromium-review.googlesource.com/1112539Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53994}
      e7f5c5cc
  3. 22 Jun, 2018 2 commits
  4. 18 Jun, 2018 1 commit
  5. 11 Jun, 2018 1 commit
    • Matheus Marchini's avatar
      [log] fix ExistingCodeLogger behavior on edge case · b20faffb
      Matheus Marchini authored
      ExistingCodeLogger was behaving incorrectly when the CodeEventHandler
      API was used in combination with --interpreted-frames-native-stack.
      Instead of collecting copied trampolines as InterpretedFunction:functionName,
      they were being collected as Builtin:IntepreterEntryTrampolines.
      This patch adds special handling for copied trampolines when
      using ExistingCodeLogger.
      
      R=yangguo@google.com
      
      Change-Id: I3ee4be03800122d28d53b51b20c60dcf6263e4c1
      Reviewed-on: https://chromium-review.googlesource.com/1087813Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53624}
      b20faffb
  6. 28 May, 2018 1 commit
  7. 18 Apr, 2018 1 commit
  8. 17 Apr, 2018 2 commits
  9. 14 Apr, 2018 1 commit
    • Jakob Kummerow's avatar
      [ubsan] Change Address typedef to uintptr_t · 2459046c
      Jakob Kummerow authored
      The "Address" type is V8's general-purpose type for manipulating memory
      addresses. Per the C++ spec, pointer arithmetic and pointer comparisons
      are undefined behavior except within the same array; since we generally
      don't operate within a C++ array, our general-purpose type shouldn't be
      a pointer type.
      
      Bug: v8:3770
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: Ib96016c24a0f18bcdba916dabd83e3f24a1b5779
      Reviewed-on: https://chromium-review.googlesource.com/988657
      Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52601}
      2459046c
  10. 10 Apr, 2018 1 commit
    • Matheus Marchini's avatar
      interpreter: make interpreted frames distinguishable in the native stack · ada64b58
      Matheus Marchini authored
      Before Turbofan/Ignition it was possible to use external profilers to
      sample running V8/Node.js processes and generate reports/FlameGraphs
      from that. It's still possible to do so, but non-optimized JavaScript
      functions appear in the stack as InterpreterEntryTrampoline. This commit
      adds a runtime flag which makes interpreted frames visible on the
      process' native stack as distinguishable functions, making the sampled
      data gathered by external profilers such as Linux perf and DTrace more
      useful.
      
      R=bmeurer@google.com, franzih@google.com, jarin@google.com, yangguo@google.com
      
      Bug: v8:7155
      Change-Id: I3dc8876aa3cd9f1b9766624842a7cc354ccca415
      Reviewed-on: https://chromium-review.googlesource.com/959081
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52533}
      ada64b58
  11. 22 Mar, 2018 1 commit
  12. 09 Mar, 2018 1 commit
  13. 20 Feb, 2018 1 commit
  14. 05 Feb, 2018 1 commit
  15. 19 Dec, 2017 1 commit
  16. 30 Nov, 2017 1 commit
  17. 29 Nov, 2017 1 commit
  18. 17 Nov, 2017 2 commits
  19. 14 Nov, 2017 1 commit
  20. 30 Oct, 2017 2 commits
  21. 27 Oct, 2017 1 commit
  22. 20 Oct, 2017 2 commits
    • Camillo Bruni's avatar
      [log] Consistently escape log entries · d06cb586
      Camillo Bruni authored
      Implicitly escape all output that is passed to Log::MessageBuilder.
      We escape non-printable characters and the log field separator ','
      using the \x00 and \u0000 escape sequences.
      
      Example:
      Before: event-foo,"space: ","comma: ,","double quotes: """
      After:  event-foo,space: ,comma: \x2C,double quotes: "
      
      This might slightly impact human readability of the log files in
      extreme cases. However, most strings do not contain any escaped
      characters.
      
      Bug: 
      Change-Id: Ic78f6d9932367d02f9f3c3f70b41b5c283bdf880
      Reviewed-on: https://chromium-review.googlesource.com/728332
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48805}
      d06cb586
    • Camillo Bruni's avatar
      Reland "[logging] Use OFStream for log events" · 761b4719
      Camillo Bruni authored
      This is a reland of 06ff9e97
      Original change's description:
      > [logging] Use OFStream for log events
      > 
      > This simplifies a few operations and removes the size limitations
      > implied by the message buffer used.
      > 
      > Change-Id: I8b873a0ffa399a037ff5c2501ba4b68158810968
      > Reviewed-on: https://chromium-review.googlesource.com/724285
      > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      > Reviewed-by: Adam Klein <adamk@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#48766}
      
      Change-Id: Iafda1c88d9180d188d6b8bd7d03d6d27100538d8
      Reviewed-on: https://chromium-review.googlesource.com/731107
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48804}
      761b4719
  23. 18 Oct, 2017 1 commit
  24. 13 Oct, 2017 2 commits
  25. 28 Aug, 2017 1 commit
  26. 28 Jul, 2017 1 commit
  27. 22 Mar, 2017 1 commit
  28. 09 Jan, 2017 1 commit
  29. 07 Sep, 2016 1 commit
  30. 01 Sep, 2016 1 commit
  31. 31 May, 2016 2 commits
  32. 24 May, 2016 1 commit