- 07 Oct, 2021 1 commit
-
-
Frank Tang authored
This is a reland of a1e6efd8 Fix Android issue by checking the resources is not filtering out. Original change's description: > [intl] Fix consistency in Intl API > > Fix several edge cases consistency issues with ICU discovered by test262 test by > using Intl Enumeration API > 1. Work around ICU short coming of always fallback in currency display > name so when the fallback is "none" in DisplayNames, the force fallback > code will produce the correct undefined from the of(currency_code) method. > 2. Always check numbering system is not algorithm based numbering system > to fix DateTimeFormat/RelativeTimeFormat/NumberFormat > resolvedOptions().numberingSystem when the reqested numberingSystem is one > of the numbering systems that we filter out the resources and not supported. > 3. Generalize the iso8601 bit solution in DateTimeFormat and rename it to > alt_calendar bit to also fix DateTimeFormat resolvedOptions report > calendar as "islamic" while requesting "islamic-rgsa". > 4. Work around reporting inconsistency of currency code and display name > in ICU. > > Bug: v8:12209 > Change-Id: Ibd349ee55426fad7d6f20a5e93fb35ff7438e111 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3153576 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77242} Bug: v8:12209 Change-Id: I96e1ba33e97f6a4abbe20e23a8fdff6cdf8bc131 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3207380Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#77290}
-
- 06 Oct, 2021 2 commits
-
-
Frank Tang authored
This reverts commit a1e6efd8. Reason for revert: Break Arm64 Original change's description: > [intl] Fix consistency in Intl API > > Fix several edge cases consistency issues with ICU discovered by test262 test by > using Intl Enumeration API > 1. Work around ICU short coming of always fallback in currency display > name so when the fallback is "none" in DisplayNames, the force fallback > code will produce the correct undefined from the of(currency_code) method. > 2. Always check numbering system is not algorithm based numbering system > to fix DateTimeFormat/RelativeTimeFormat/NumberFormat > resolvedOptions().numberingSystem when the reqested numberingSystem is one > of the numbering systems that we filter out the resources and not supported. > 3. Generalize the iso8601 bit solution in DateTimeFormat and rename it to > alt_calendar bit to also fix DateTimeFormat resolvedOptions report > calendar as "islamic" while requesting "islamic-rgsa". > 4. Work around reporting inconsistency of currency code and display name > in ICU. > > Bug: v8:12209 > Change-Id: Ibd349ee55426fad7d6f20a5e93fb35ff7438e111 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3153576 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77242} Bug: v8:12209 Change-Id: I6b8ac7dc89eda158e29c9d653825cb20a89341aa No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3207379Reviewed-by: Frank Tang <ftang@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77246}
-
Frank Tang authored
Fix several edge cases consistency issues with ICU discovered by test262 test by using Intl Enumeration API 1. Work around ICU short coming of always fallback in currency display name so when the fallback is "none" in DisplayNames, the force fallback code will produce the correct undefined from the of(currency_code) method. 2. Always check numbering system is not algorithm based numbering system to fix DateTimeFormat/RelativeTimeFormat/NumberFormat resolvedOptions().numberingSystem when the reqested numberingSystem is one of the numbering systems that we filter out the resources and not supported. 3. Generalize the iso8601 bit solution in DateTimeFormat and rename it to alt_calendar bit to also fix DateTimeFormat resolvedOptions report calendar as "islamic" while requesting "islamic-rgsa". 4. Work around reporting inconsistency of currency code and display name in ICU. Bug: v8:12209 Change-Id: Ibd349ee55426fad7d6f20a5e93fb35ff7438e111 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3153576 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#77242}
-
- 21 Jul, 2021 1 commit
-
-
Seth Brenith authored
Since most Torque-defined extern classes use @generateCppClass, it makes more sense to instead annotate the small number that don't. This is part of the cleanup work that Nico recommended in [1]. Classes that still have to opt out: - Those that can be converted by https://crrev.com/c/3015666 - HeapObject: sort of special since it's the root of the inheritance hierarchy. Generated code would include two declarations that don't compile until HeapObject is defined: bool IsHeapObject_NonInline(HeapObject o); explicit TorqueGeneratedHeapObject( Address ptr, HeapObject::AllowInlineSmiStorage allow_smi); - SmallOrdered*: these classes use templates on the C++ side, which is not currently representable in Torque. - SwissNameDictionary: according to a comment, the Torque generation for this class is incorrect. I haven't investigated further. Drive-by fix: make the Torque formatter keep LF on Windows rather than writing CRLF. [1] https://docs.google.com/document/d/1q_gZLnXd4bGnCx3IUfbln46K3bSs9UHBGasy9McQtHI/edit# Bug: v8:8952 Change-Id: I1fbb5290f0c645842b84c53816c09bb3398206a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3028721Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#75841}
-
- 12 Jan, 2021 1 commit
-
-
Frank Tang authored
Use a bit to work around the issue of ICU getType() bug. Bug: v8:11295 Change-Id: I15d65bd44c489031d789e7638ea8abab90128124 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2614216 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#72028}
-
- 28 Oct, 2020 1 commit
-
-
Tobias Tebbi authored
This CL splits the class definitions per .tq file, to realize the following relationship: A class defined in src/objects/foo.tq has a C++ definition in src/objects/foo.h. Torque then generates: - torque-generated/src/objects/foo-tq.inc An include file (no proper header) to be included in src/objects/foo.h containing the Torque-generated C++ class definition. - torque-generated/src/objects/foo-tq-inl.inc An include file (no proper header) to be included in src/objects/foo-inl.h containing inline function definitions. - torque-generated/src/objects/foo-tq.cc A source file including src/objects/foo-inl.h that contains non-inline function definitions. Advantages of this approach: - Avoid big monolithic headers and preserve the work that went into splitting objects.h - Moving a definition to Torque keeps everything in the same place from a C++ viewpoint, including a fully Torque-generated C++ class definition. - The Torque-generated include files do not need to be independent headers, necessary includes or forward declarations can just be added to the headers that include them. Drive-by changes: A bunch of definitions and files had to be moved or created to realize a consistent 1:1 relationship between .tq files and C++ headers. Bug: v8:7793 TBR: hpayer@chromium.org Change-Id: I239a89a16d0bc856a8669d7c92aeafe24a7c7663 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2470571 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#70853}
-