1. 07 Oct, 2021 1 commit
    • Frank Tang's avatar
      Reland "[intl] Fix consistency in Intl API" · fed33f90
      Frank Tang authored
      This is a reland of a1e6efd8
      
      Fix Android issue by checking the resources is not filtering out.
      
      Original change's description:
      > [intl] Fix consistency in Intl API
      >
      > Fix several edge cases consistency issues with ICU discovered by test262 test by
      > using Intl Enumeration API
      > 1. Work around ICU short coming of always fallback in currency display
      >  name so when the fallback is "none" in DisplayNames, the force fallback
      > code will produce the correct undefined from the of(currency_code) method.
      > 2. Always check numbering system is not algorithm based numbering system
      > to fix DateTimeFormat/RelativeTimeFormat/NumberFormat
      > resolvedOptions().numberingSystem when the reqested numberingSystem is one
      > of the numbering systems that we filter out the resources and not supported.
      > 3. Generalize the iso8601 bit solution in DateTimeFormat and rename it to
      > alt_calendar bit to also fix DateTimeFormat resolvedOptions report
      > calendar as "islamic" while requesting "islamic-rgsa".
      > 4. Work around reporting inconsistency of currency code and display name
      > in ICU.
      >
      > Bug: v8:12209
      > Change-Id: Ibd349ee55426fad7d6f20a5e93fb35ff7438e111
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3153576
      > Commit-Queue: Frank Tang <ftang@chromium.org>
      > Reviewed-by: Shu-yu Guo <syg@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#77242}
      
      Bug: v8:12209
      Change-Id: I96e1ba33e97f6a4abbe20e23a8fdff6cdf8bc131
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3207380Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
      Commit-Queue: Frank Tang <ftang@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#77290}
      fed33f90
  2. 06 Oct, 2021 2 commits
    • Frank Tang's avatar
      Revert "[intl] Fix consistency in Intl API" · 34f278b8
      Frank Tang authored
      This reverts commit a1e6efd8.
      
      Reason for revert: Break Arm64
      
      Original change's description:
      > [intl] Fix consistency in Intl API
      >
      > Fix several edge cases consistency issues with ICU discovered by test262 test by
      > using Intl Enumeration API
      > 1. Work around ICU short coming of always fallback in currency display
      >  name so when the fallback is "none" in DisplayNames, the force fallback
      > code will produce the correct undefined from the of(currency_code) method.
      > 2. Always check numbering system is not algorithm based numbering system
      > to fix DateTimeFormat/RelativeTimeFormat/NumberFormat
      > resolvedOptions().numberingSystem when the reqested numberingSystem is one
      > of the numbering systems that we filter out the resources and not supported.
      > 3. Generalize the iso8601 bit solution in DateTimeFormat and rename it to
      > alt_calendar bit to also fix DateTimeFormat resolvedOptions report
      > calendar as "islamic" while requesting "islamic-rgsa".
      > 4. Work around reporting inconsistency of currency code and display name
      > in ICU.
      >
      > Bug: v8:12209
      > Change-Id: Ibd349ee55426fad7d6f20a5e93fb35ff7438e111
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3153576
      > Commit-Queue: Frank Tang <ftang@chromium.org>
      > Reviewed-by: Shu-yu Guo <syg@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#77242}
      
      Bug: v8:12209
      Change-Id: I6b8ac7dc89eda158e29c9d653825cb20a89341aa
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3207379Reviewed-by: 's avatarFrank Tang <ftang@chromium.org>
      Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/main@{#77246}
      34f278b8
    • Frank Tang's avatar
      [intl] Fix consistency in Intl API · a1e6efd8
      Frank Tang authored
      Fix several edge cases consistency issues with ICU discovered by test262 test by
      using Intl Enumeration API
      1. Work around ICU short coming of always fallback in currency display
       name so when the fallback is "none" in DisplayNames, the force fallback
      code will produce the correct undefined from the of(currency_code) method.
      2. Always check numbering system is not algorithm based numbering system
      to fix DateTimeFormat/RelativeTimeFormat/NumberFormat
      resolvedOptions().numberingSystem when the reqested numberingSystem is one
      of the numbering systems that we filter out the resources and not supported.
      3. Generalize the iso8601 bit solution in DateTimeFormat and rename it to
      alt_calendar bit to also fix DateTimeFormat resolvedOptions report
      calendar as "islamic" while requesting "islamic-rgsa".
      4. Work around reporting inconsistency of currency code and display name
      in ICU.
      
      Bug: v8:12209
      Change-Id: Ibd349ee55426fad7d6f20a5e93fb35ff7438e111
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3153576
      Commit-Queue: Frank Tang <ftang@chromium.org>
      Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#77242}
      a1e6efd8
  3. 21 Jul, 2021 1 commit
  4. 12 Jan, 2021 1 commit
  5. 28 Oct, 2020 1 commit
    • Tobias Tebbi's avatar
      [torque] generate C++ class definitions per Torque file · 03f60296
      Tobias Tebbi authored
      This CL splits the class definitions per .tq file, to realize the
      following relationship:
      A class defined in src/objects/foo.tq has a C++ definition in
      src/objects/foo.h. Torque then generates:
      
      - torque-generated/src/objects/foo-tq.inc
        An include file (no proper header) to be included in src/objects/foo.h
        containing the Torque-generated C++ class definition.
      
      - torque-generated/src/objects/foo-tq-inl.inc
        An include file (no proper header) to be included in
        src/objects/foo-inl.h containing inline function definitions.
      
      - torque-generated/src/objects/foo-tq.cc
        A source file including src/objects/foo-inl.h that contains non-inline
        function definitions.
      
      Advantages of this approach:
      - Avoid big monolithic headers and preserve the work that went into
        splitting objects.h
      - Moving a definition to Torque keeps everything in the same place
        from a C++ viewpoint, including a fully Torque-generated C++ class
        definition.
      - The Torque-generated include files do not need to be independent
        headers, necessary includes or forward declarations can just be added
        to the headers that include them.
      
      Drive-by changes:
      A bunch of definitions and files had to be moved or created to realize
      a consistent 1:1 relationship between .tq files and C++ headers.
      
      
      Bug: v8:7793
      TBR: hpayer@chromium.org
      Change-Id: I239a89a16d0bc856a8669d7c92aeafe24a7c7663
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2470571
      Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
      Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
      Reviewed-by: 's avatarSeth Brenith <seth.brenith@microsoft.com>
      Cr-Commit-Position: refs/heads/master@{#70853}
      03f60296